Re: [PATCH 2/2] ARM: dts: Sort nodes within Peach-pit/Peach-pi dts files

2014-06-21 Thread Kukjin Kim

On 06/21/14 05:09, Doug Anderson wrote:

Tushar / Kukjin,

On Fri, Jun 20, 2014 at 1:20 AM, Tushar Beheratusha...@samsung.com  wrote:

Peach-pit and Peach-pi boards are almost similar, hence the DTS file
is also very similar. Sorting nodes in both these files will allow
us to figure out the difference easily.

All the node aliases are sorted in alphabetically increasing order.
There is no functional change with this patch.

Signed-off-by: Tushar Beheratusha...@samsung.com
---
  arch/arm/boot/dts/exynos5420-peach-pit.dts |  236 ++--
  arch/arm/boot/dts/exynos5800-peach-pi.dts  |  225 +-
  2 files changed, 233 insertions(+), 228 deletions(-)


Thanks, this looks much better.  I tried against next-20140620 and it
applied cleanly, gave a good diff between pit and pi, and looked sane.

This is gonna be a pain in the butt if Kukjin doesn't apply it ASAP.
It will conflict with every single other dts patch to pi.


So I've applied both in my tree just now ;-)


Reviewed-by: Doug Andersondiand...@chromium.org


Thanks for your review.

- Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 2/2] ARM: dts: Sort nodes within Peach-pit/Peach-pi dts files

2014-06-20 Thread Tushar Behera
Peach-pit and Peach-pi boards are almost similar, hence the DTS file
is also very similar. Sorting nodes in both these files will allow
us to figure out the difference easily.

All the node aliases are sorted in alphabetically increasing order.
There is no functional change with this patch.

Signed-off-by: Tushar Behera tusha...@samsung.com
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |  236 ++--
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |  225 +-
 2 files changed, 233 insertions(+), 228 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts 
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 1c5b8f9..7649982 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -25,8 +25,13 @@
google,pit, google,peach,samsung,exynos5420,
samsung,exynos5;
 
-   memory {
-   reg = 0x2000 0x8000;
+   backlight {
+   compatible = pwm-backlight;
+   pwms = pwm 0 100 0;
+   brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
+   default-brightness-level = 7;
+   pinctrl-0 = pwm0_out;
+   pinctrl-names = default;
};
 
fixed-rate-clocks {
@@ -50,13 +55,8 @@
};
};
 
-   backlight {
-   compatible = pwm-backlight;
-   pwms = pwm 0 100 0;
-   brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
-   default-brightness-level = 7;
-   pinctrl-0 = pwm0_out;
-   pinctrl-names = default;
+   memory {
+   reg = 0x2000 0x8000;
};
 
sound {
@@ -89,64 +89,83 @@
};
 };
 
-pinctrl_0 {
-   max98090_irq: max98090-irq {
-   samsung,pins = gpx0-2;
-   samsung,pin-function = 0;
-   samsung,pin-pud = 0;
-   samsung,pin-drv = 0;
-   };
+dp {
+   status = okay;
+   pinctrl-names = default;
+   pinctrl-0 = dp_hpd_gpio;
+   samsung,color-space = 0;
+   samsung,dynamic-range = 0;
+   samsung,ycbcr-coeff = 0;
+   samsung,color-depth = 1;
+   samsung,link-rate = 0x06;
+   samsung,lane-count = 2;
+   samsung,hpd-gpio = gpx2 6 0;
 
-   tpm_irq: tpm-irq {
-   samsung,pins = gpx1-0;
-   samsung,pin-function = 0;
-   samsung,pin-pud = 0;
-   samsung,pin-drv = 0;
-   };
+   display-timings {
+   native-mode = timing1;
 
-   power_key_irq: power-key-irq {
-   samsung,pins = gpx1-2;
-   samsung,pin-function = 0;
-   samsung,pin-pud = 0;
-   samsung,pin-drv = 0;
+   timing1: timing@1 {
+   clock-frequency = 70589280;
+   hactive = 1366;
+   vactive = 768;
+   hfront-porch = 40;
+   hback-porch = 40;
+   hsync-len = 32;
+   vback-porch = 10;
+   vfront-porch = 12;
+   vsync-len = 6;
+   };
};
+};
 
-   hdmi_hpd_irq: hdmi-hpd-irq {
-   samsung,pins = gpx3-7;
-   samsung,pin-function = 0;
-   samsung,pin-pud = 1;
-   samsung,pin-drv = 0;
-   };
+fimd {
+   status = okay;
+   samsung,invert-vclk;
+};
 
-   dp_hpd_gpio: dp_hpd_gpio {
-   samsung,pins = gpx2-6;
-   samsung,pin-function = 0;
-   samsung,pin-pud = 3;
-   samsung,pin-drv = 0;
-   };
+hdmi {
+   status = okay;
+   hpd-gpio = gpx3 7 GPIO_ACTIVE_HIGH;
+   pinctrl-names = default;
+   pinctrl-0 = hdmi_hpd_irq;
+   ddc = i2c_2;
 };
 
-pinctrl_3 {
-   usb300_vbus_en: usb300-vbus-en {
-   samsung,pins = gph0-0;
-   samsung,pin-function = 1;
-   samsung,pin-pud = 0;
-   samsung,pin-drv = 0;
+hsi2c_7 {
+   status = okay;
+
+   max98090: codec@10 {
+   compatible = maxim,max98090;
+   reg = 0x10;
+   interrupts = 2 0;
+   interrupt-parent = gpx0;
+   pinctrl-names = default;
+   pinctrl-0 = max98090_irq;
};
+};
 
-   usb301_vbus_en: usb301-vbus-en {
-   samsung,pins = gph0-1;
-   samsung,pin-function = 1;
-   samsung,pin-pud = 0;
-   samsung,pin-drv = 0;
+hsi2c_9 {
+   status = okay;
+   clock-frequency = 40;
+
+   tpm@20 {
+   compatible = infineon,slb9645tt;
+   reg = 0x20;
+
+   /* Unused irq; but still need to configure the pins */
+   pinctrl-names = default;
+   pinctrl-0 = tpm_irq;
};
 };
 
-rtc {
+i2c_2 {
status = okay;
+   

Re: [PATCH 2/2] ARM: dts: Sort nodes within Peach-pit/Peach-pi dts files

2014-06-20 Thread Doug Anderson
Tushar / Kukjin,

On Fri, Jun 20, 2014 at 1:20 AM, Tushar Behera tusha...@samsung.com wrote:
 Peach-pit and Peach-pi boards are almost similar, hence the DTS file
 is also very similar. Sorting nodes in both these files will allow
 us to figure out the difference easily.

 All the node aliases are sorted in alphabetically increasing order.
 There is no functional change with this patch.

 Signed-off-by: Tushar Behera tusha...@samsung.com
 ---
  arch/arm/boot/dts/exynos5420-peach-pit.dts |  236 
 ++--
  arch/arm/boot/dts/exynos5800-peach-pi.dts  |  225 +-
  2 files changed, 233 insertions(+), 228 deletions(-)

Thanks, this looks much better.  I tried against next-20140620 and it
applied cleanly, gave a good diff between pit and pi, and looked sane.

This is gonna be a pain in the butt if Kukjin doesn't apply it ASAP.
It will conflict with every single other dts patch to pi.

Reviewed-by: Doug Anderson diand...@chromium.org

-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html