RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-12-02 Thread Seungwon Jeon
Maya Erez wrote: Maya Erez wrote: On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: @@ -980,12 +988,67 @@ static int mmc_blk_err_check(struct mmc_card *card,        if (!brq-data.bytes_xfered)                return MMC_BLK_RETRY; +  

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-12-01 Thread merez
Maya Erez wrote: On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: @@ -980,12 +988,67 @@ static int mmc_blk_err_check(struct mmc_card *card,        if (!brq-data.bytes_xfered)                return MMC_BLK_RETRY; +       if (mq_mrq-packed_cmd

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-28 Thread Seungwon Jeon
Maya Erez wrote: On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: @@ -943,7 +950,8 @@ static int mmc_blk_err_check(struct mmc_card *card,         * kind.  If it was a write, we may have transitioned to       * program mode, which we have to wait for it to

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-27 Thread merez
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: @@ -943,7 +950,8 @@ static int mmc_blk_err_check(struct mmc_card *card,         * kind.  If it was a write, we may have transitioned to         * program mode, which we have to wait for it to complete.         */

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-17 Thread merez
Maya Erez wrote: +               phys_segments +=  next-nr_phys_segments; +               if (phys_segments max_phys_segs) { +                       blk_requeue_request(q, next); +                       break; +               } I mentioned this before - if the

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-16 Thread Seungwon Jeon
Maya Erez wrote: +               phys_segments +=  next-nr_phys_segments; +               if (phys_segments max_phys_segs) { +                       blk_requeue_request(q, next); +                       break; +               } I mentioned this before - if the

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-15 Thread merez
+       if (rqc) +               reqs = mmc_blk_chk_packable(mq, rqc); It would be best to keep all the calls to blk_fetch_request in the same location. Therefore, I suggest to move the call to mmc_blk_chk_packable to mmc/card/queue.c after the first request is fetched.

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-15 Thread merez
+               phys_segments +=  next-nr_phys_segments; +               if (phys_segments max_phys_segs) { +                       blk_requeue_request(q, next); +                       break; +               } I mentioned this before - if the next request is not

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-14 Thread Seungwon Jeon
S, Venkatraman svenk...@ti.com wrote: On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote: Maya Erez wrote: On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote:

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-14 Thread Seungwon Jeon
Maya Erez wrote: On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote: Maya Erez wrote: On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: +static u8

Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-13 Thread merez
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote: Maya Erez wrote: On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: +static u8 mmc_blk_chk_packable(struct

Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-11 Thread S, Venkatraman
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote: Maya Erez wrote: On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: +static u8 mmc_blk_chk_packable(struct

Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-11 Thread merez
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote: Maya Erez wrote: On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: +static u8 mmc_blk_chk_packable(struct

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-10 Thread merez
On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: +static u8 mmc_blk_chk_packable(struct mmc_queue *mq, struct request *req) The function prepares the checkable list and not only checks if

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-10 Thread Seungwon Jeon
Maya Erez wrote: On Thu, Nov 10, 2011 Maya Erez wrote: S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: +static u8 mmc_blk_chk_packable(struct mmc_queue *mq, struct request *req) The function prepares the checkable list

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-06 Thread Seungwon Jeon
S, Venkatraman svenk...@ti.com wrote: On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: S, Venkatraman svenk...@ti.com wrote: On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: This patch supports packed command of eMMC4.5 device. Several

Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-04 Thread S, Venkatraman
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote: S, Venkatraman svenk...@ti.com wrote: On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: This patch supports packed command of eMMC4.5 device. Several reads(or writes) can be grouped in packed

Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-02 Thread Girish K S
On 2 November 2011 04:03, Seungwon Jeon tgih@samsung.com wrote: This patch supports packed command of eMMC4.5 device. Several reads(or writes) can be grouped in packed command and all data of the individual commands can be sent in a single transfer on the bus. Signed-off-by: Seungwon

Re: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-02 Thread S, Venkatraman
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: This patch supports packed command of eMMC4.5 device. Several reads(or writes) can be grouped in packed command and all data of the individual commands can be sent in a single transfer on the bus. Signed-off-by:

RE: [PATCH 2/2] mmc: core: Support packed command for eMMC4.5 device

2011-11-02 Thread Seungwon Jeon
S, Venkatraman svenk...@ti.com wrote: On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote: This patch supports packed command of eMMC4.5 device. Several reads(or writes) can be grouped in packed command and all data of the individual commands can be sent in a single