Re: [PATCH 23/25] thermal: exynos: fix error return code

2014-01-01 Thread Zhang Rui
On Sun, 2013-12-29 at 23:47 +0100, Julia Lawall wrote: > From: Julia Lawall > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if@p1 (\

Re: [PATCH 23/25] thermal: exynos: fix error return code

2013-12-29 Thread Jingoo Han
On Monday, December 30, 2013 7:48 AM, Julia Lawall wrote: > > From: Julia Lawall > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if

[PATCH 23/25] thermal: exynos: fix error return code

2013-12-29 Thread Julia Lawall
From: Julia Lawall Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret =