Re: [PATCH 4/9] tests/exynos: clean struct connector

2015-06-12 Thread Emil Velikov 
On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote:
 Remove all unused struct members.

Mentioning if they were used at some point in the past will be great.

Thanks
Emil

 Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de
 ---
  tests/exynos/exynos_fimg2d_test.c | 10 --
  1 file changed, 10 deletions(-)

 diff --git a/tests/exynos/exynos_fimg2d_test.c 
 b/tests/exynos/exynos_fimg2d_test.c
 index 64dacfa..6af9277 100644
 --- a/tests/exynos/exynos_fimg2d_test.c
 +++ b/tests/exynos/exynos_fimg2d_test.c
 @@ -65,17 +65,9 @@ struct fimg2d_test_case {
  struct connector {
 uint32_t id;
 char mode_str[64];
 -   char format_str[5];
 -   unsigned int fourcc;
 drmModeModeInfo *mode;
 drmModeEncoder *encoder;
 int crtc;
 -   int pipe;
 -   int plane_zpos;
 -   unsigned int fb_id[2], current_fb_id;
 -   struct timeval start;
 -
 -   int swap_count;
  };

  static void connector_find_mode(int fd, struct connector *c,
 @@ -750,8 +742,6 @@ int main(int argc, char **argv)
 if (ret  0)
 goto err_destroy_buffer;

 -   con.plane_zpos = -1;
 -
 memset(bo-vaddr, 0xff, screen_width * screen_height * 4);

 ret = drm_set_crtc(dev, con, fb_id);
 --
 2.0.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/9] tests/exynos: clean struct connector

2015-06-12 Thread Tobias Jakobi 
Hello Emil,

Emil Velikov wrote:
 On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote:
 Remove all unused struct members.

 Mentioning if they were used at some point in the past will be great.
OK, I'll take a look at git history but AFAIK it is not.


With best wishes,
Tobias


 
 Thanks
 Emil
 
 Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de
 ---
  tests/exynos/exynos_fimg2d_test.c | 10 --
  1 file changed, 10 deletions(-)

 diff --git a/tests/exynos/exynos_fimg2d_test.c 
 b/tests/exynos/exynos_fimg2d_test.c
 index 64dacfa..6af9277 100644
 --- a/tests/exynos/exynos_fimg2d_test.c
 +++ b/tests/exynos/exynos_fimg2d_test.c
 @@ -65,17 +65,9 @@ struct fimg2d_test_case {
  struct connector {
 uint32_t id;
 char mode_str[64];
 -   char format_str[5];
 -   unsigned int fourcc;
 drmModeModeInfo *mode;
 drmModeEncoder *encoder;
 int crtc;
 -   int pipe;
 -   int plane_zpos;
 -   unsigned int fb_id[2], current_fb_id;
 -   struct timeval start;
 -
 -   int swap_count;
  };

  static void connector_find_mode(int fd, struct connector *c,
 @@ -750,8 +742,6 @@ int main(int argc, char **argv)
 if (ret  0)
 goto err_destroy_buffer;

 -   con.plane_zpos = -1;
 -
 memset(bo-vaddr, 0xff, screen_width * screen_height * 4);

 ret = drm_set_crtc(dev, con, fb_id);
 --
 2.0.5


--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/9] tests/exynos: clean struct connector

2015-06-10 Thread Tobias Jakobi 
Remove all unused struct members.

Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de
---
 tests/exynos/exynos_fimg2d_test.c | 10 --
 1 file changed, 10 deletions(-)

diff --git a/tests/exynos/exynos_fimg2d_test.c 
b/tests/exynos/exynos_fimg2d_test.c
index 64dacfa..6af9277 100644
--- a/tests/exynos/exynos_fimg2d_test.c
+++ b/tests/exynos/exynos_fimg2d_test.c
@@ -65,17 +65,9 @@ struct fimg2d_test_case {
 struct connector {
uint32_t id;
char mode_str[64];
-   char format_str[5];
-   unsigned int fourcc;
drmModeModeInfo *mode;
drmModeEncoder *encoder;
int crtc;
-   int pipe;
-   int plane_zpos;
-   unsigned int fb_id[2], current_fb_id;
-   struct timeval start;
-
-   int swap_count;
 };
 
 static void connector_find_mode(int fd, struct connector *c,
@@ -750,8 +742,6 @@ int main(int argc, char **argv)
if (ret  0)
goto err_destroy_buffer;
 
-   con.plane_zpos = -1;
-
memset(bo-vaddr, 0xff, screen_width * screen_height * 4);
 
ret = drm_set_crtc(dev, con, fb_id);
-- 
2.0.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html