RE: [PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250

2012-02-09 Thread Kukjin Kim 
Will Deacon wrote:
 
 On Wed, Feb 01, 2012 at 08:50:23AM +, Olof Johansson wrote:
  On Tue, Jan 31, 2012 at 8:20 PM, Kyungmin Park kmp...@infradead.org
 wrote:
   As I remember only DT based board file is acceptable for mainline?
 
  For a new SoC family like 5250 it would be much preferred to only add
  device-tree enabled boards.
 
As I commented, I'd like to support both dt and non-dt for EXYNOS5250 and
I'm saying EXYNOS5250 DT patches will be submitted next time again.

 As I mentioned in an earlier thread, it would also solve the problem of
 enumerating the CPU topology on A15 (without resorting to flaky hacks in
 core code).
 
Will, yes I know that. But I think, seems A15 SMP (not MP) can be supported?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250

2012-02-09 Thread Arnd Bergmann 
On Thursday 09 February 2012, Kukjin Kim wrote:
 Will Deacon wrote:
  
  On Wed, Feb 01, 2012 at 08:50:23AM +, Olof Johansson wrote:
   On Tue, Jan 31, 2012 at 8:20 PM, Kyungmin Park kmp...@infradead.org
  wrote:
As I remember only DT based board file is acceptable for mainline?
  
   For a new SoC family like 5250 it would be much preferred to only add
   device-tree enabled boards.
  
 As I commented, I'd like to support both dt and non-dt for EXYNOS5250 and
 I'm saying EXYNOS5250 DT patches will be submitted next time again.

I think it would be much better to start with just the DT based platform
for exynos5 and leave out the atag based platform.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250

2012-02-01 Thread Olof Johansson 
Hi,

On Tue, Jan 31, 2012 at 8:20 PM, Kyungmin Park kmp...@infradead.org wrote:
 As I remember only DT based board file is acceptable for mainline?

For a new SoC family like 5250 it would be much preferred to only add
device-tree enabled boards.


-Olof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250

2012-02-01 Thread Will Deacon 
On Wed, Feb 01, 2012 at 08:50:23AM +, Olof Johansson wrote:
 On Tue, Jan 31, 2012 at 8:20 PM, Kyungmin Park kmp...@infradead.org wrote:
  As I remember only DT based board file is acceptable for mainline?
 
 For a new SoC family like 5250 it would be much preferred to only add
 device-tree enabled boards.

As I mentioned in an earlier thread, it would also solve the problem of
enumerating the CPU topology on A15 (without resorting to flaky hacks in
core code).

Will
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250

2012-01-31 Thread Kukjin Kim 
Signed-off-by: Kukjin Kim kgene@samsung.com
---
 arch/arm/mach-exynos/Kconfig |   11 
 arch/arm/mach-exynos/Makefile|2 +
 arch/arm/mach-exynos/mach-smdk5250.c |   94 ++
 3 files changed, 107 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos/mach-smdk5250.c

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 60905d5..89b8e17 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -364,6 +364,17 @@ config MACH_SMDK4412
  Machine support for Samsung SMDK4412
 endif
 
+if ARCH_EXYNOS5
+
+comment EXYNOS5250 Boards
+
+config MACH_SMDK5250
+   bool SMDK5250
+   select SOC_EXYNOS5250
+   help
+ Machine support for Samsung SMDK4412
+endif
+
 comment Flattened Device Tree based board for Exynos4 based SoC
 
 config MACH_EXYNOS4_DT
diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
index 33d27d4..1b12345 100644
--- a/arch/arm/mach-exynos/Makefile
+++ b/arch/arm/mach-exynos/Makefile
@@ -43,6 +43,8 @@ obj-$(CONFIG_MACH_SMDK4412)   += mach-smdk4x12.o
 
 obj-$(CONFIG_MACH_EXYNOS4_DT)  += mach-exynos4-dt.o
 
+obj-$(CONFIG_MACH_SMDK5250)+= mach-smdk5250.o
+
 # device support
 
 obj-$(CONFIG_ARCH_EXYNOS4) += dev-audio.o
diff --git a/arch/arm/mach-exynos/mach-smdk5250.c 
b/arch/arm/mach-exynos/mach-smdk5250.c
new file mode 100644
index 000..0fe4a0b
--- /dev/null
+++ b/arch/arm/mach-exynos/mach-smdk5250.c
@@ -0,0 +1,94 @@
+/*
+ * linux/arch/arm/mach-exynos/mach-smdk5250.c
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include linux/platform_device.h
+#include linux/serial_core.h
+
+#include asm/mach/arch.h
+#include asm/hardware/gic.h
+#include asm/mach-types.h
+
+#include plat/clock.h
+#include plat/cpu.h
+#include plat/regs-serial.h
+
+#include mach/map.h
+
+#include common.h
+
+/* Following are default values for UCON, ULCON and UFCON UART registers */
+#define SMDK5250_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |\
+S3C2410_UCON_RXILEVEL |\
+S3C2410_UCON_TXIRQMODE |   \
+S3C2410_UCON_RXIRQMODE |   \
+S3C2410_UCON_RXFIFO_TOI |  \
+S3C2443_UCON_RXERR_IRQEN)
+
+#define SMDK5250_ULCON_DEFAULT S3C2410_LCON_CS8
+
+#define SMDK5250_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |   \
+S5PV210_UFCON_TXTRIG4 |\
+S5PV210_UFCON_RXTRIG4)
+
+static struct s3c2410_uartcfg smdk5250_uartcfgs[] __initdata = {
+   [0] = {
+   .hwport = 0,
+   .flags  = 0,
+   .ucon   = SMDK5250_UCON_DEFAULT,
+   .ulcon  = SMDK5250_ULCON_DEFAULT,
+   .ufcon  = SMDK5250_UFCON_DEFAULT,
+   },
+   [1] = {
+   .hwport = 1,
+   .flags  = 0,
+   .ucon   = SMDK5250_UCON_DEFAULT,
+   .ulcon  = SMDK5250_ULCON_DEFAULT,
+   .ufcon  = SMDK5250_UFCON_DEFAULT,
+   },
+   [2] = {
+   .hwport = 2,
+   .flags  = 0,
+   .ucon   = SMDK5250_UCON_DEFAULT,
+   .ulcon  = SMDK5250_ULCON_DEFAULT,
+   .ufcon  = SMDK5250_UFCON_DEFAULT,
+   },
+   [3] = {
+   .hwport = 3,
+   .flags  = 0,
+   .ucon   = SMDK5250_UCON_DEFAULT,
+   .ulcon  = SMDK5250_ULCON_DEFAULT,
+   .ufcon  = SMDK5250_UFCON_DEFAULT,
+   },
+};
+
+static void __init smdk5250_map_io(void)
+{
+   clk_xusbxti.rate = 2400;
+
+   exynos_init_io(NULL, 0);
+   s3c24xx_init_clocks(clk_xusbxti.rate);
+   s3c24xx_init_uarts(smdk5250_uartcfgs, ARRAY_SIZE(smdk5250_uartcfgs));
+}
+
+static void __init smdk5250_machine_init(void)
+{
+   /* nothing here yet */
+}
+
+MACHINE_START(SMDK5250, SMDK5250)
+   .atag_offset= 0x100,
+   .init_irq   = exynos5_init_irq,
+   .map_io = smdk5250_map_io,
+   .handle_irq = gic_handle_irq,
+   .init_machine   = smdk5250_machine_init,
+   .timer  = exynos4_timer,
+   .restart= exynos5_restart,
+MACHINE_END
-- 
1.7.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/9] ARM: EXYNOS: add board file for SMDK5250

2012-01-31 Thread Kyungmin Park 
As I remember only DT based board file is acceptable for mainline?

On 2/1/12, Kukjin Kim kgene@samsung.com wrote:
 Signed-off-by: Kukjin Kim kgene@samsung.com
 ---
  arch/arm/mach-exynos/Kconfig |   11 
  arch/arm/mach-exynos/Makefile|2 +
  arch/arm/mach-exynos/mach-smdk5250.c |   94
 ++
  3 files changed, 107 insertions(+), 0 deletions(-)
  create mode 100644 arch/arm/mach-exynos/mach-smdk5250.c

 diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
 index 60905d5..89b8e17 100644
 --- a/arch/arm/mach-exynos/Kconfig
 +++ b/arch/arm/mach-exynos/Kconfig
 @@ -364,6 +364,17 @@ config MACH_SMDK4412
 Machine support for Samsung SMDK4412
  endif

 +if ARCH_EXYNOS5
 +
 +comment EXYNOS5250 Boards
 +
 +config MACH_SMDK5250
 + bool SMDK5250
 + select SOC_EXYNOS5250
 + help
 +   Machine support for Samsung SMDK4412
 +endif
 +
  comment Flattened Device Tree based board for Exynos4 based SoC

  config MACH_EXYNOS4_DT
 diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile
 index 33d27d4..1b12345 100644
 --- a/arch/arm/mach-exynos/Makefile
 +++ b/arch/arm/mach-exynos/Makefile
 @@ -43,6 +43,8 @@ obj-$(CONFIG_MACH_SMDK4412) += mach-smdk4x12.o

  obj-$(CONFIG_MACH_EXYNOS4_DT)+= mach-exynos4-dt.o

 +obj-$(CONFIG_MACH_SMDK5250)  += mach-smdk5250.o
 +
  # device support

  obj-$(CONFIG_ARCH_EXYNOS4)   += dev-audio.o
 diff --git a/arch/arm/mach-exynos/mach-smdk5250.c
 b/arch/arm/mach-exynos/mach-smdk5250.c
 new file mode 100644
 index 000..0fe4a0b
 --- /dev/null
 +++ b/arch/arm/mach-exynos/mach-smdk5250.c
 @@ -0,0 +1,94 @@
 +/*
 + * linux/arch/arm/mach-exynos/mach-smdk5250.c
 + *
 + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
 + *   http://www.samsung.com
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 as
 + * published by the Free Software Foundation.
 +*/
 +
 +#include linux/platform_device.h
 +#include linux/serial_core.h
 +
 +#include asm/mach/arch.h
 +#include asm/hardware/gic.h
 +#include asm/mach-types.h
 +
 +#include plat/clock.h
 +#include plat/cpu.h
 +#include plat/regs-serial.h
 +
 +#include mach/map.h
 +
 +#include common.h
 +
 +/* Following are default values for UCON, ULCON and UFCON UART registers */
 +#define SMDK5250_UCON_DEFAULT(S3C2410_UCON_TXILEVEL |\
 +  S3C2410_UCON_RXILEVEL |\
 +  S3C2410_UCON_TXIRQMODE |   \
 +  S3C2410_UCON_RXIRQMODE |   \
 +  S3C2410_UCON_RXFIFO_TOI |  \
 +  S3C2443_UCON_RXERR_IRQEN)
 +
 +#define SMDK5250_ULCON_DEFAULT   S3C2410_LCON_CS8
 +
 +#define SMDK5250_UFCON_DEFAULT   (S3C2410_UFCON_FIFOMODE |   \
 +  S5PV210_UFCON_TXTRIG4 |\
 +  S5PV210_UFCON_RXTRIG4)
 +
 +static struct s3c2410_uartcfg smdk5250_uartcfgs[] __initdata = {
 + [0] = {
 + .hwport = 0,
 + .flags  = 0,
 + .ucon   = SMDK5250_UCON_DEFAULT,
 + .ulcon  = SMDK5250_ULCON_DEFAULT,
 + .ufcon  = SMDK5250_UFCON_DEFAULT,
 + },
 + [1] = {
 + .hwport = 1,
 + .flags  = 0,
 + .ucon   = SMDK5250_UCON_DEFAULT,
 + .ulcon  = SMDK5250_ULCON_DEFAULT,
 + .ufcon  = SMDK5250_UFCON_DEFAULT,
 + },
 + [2] = {
 + .hwport = 2,
 + .flags  = 0,
 + .ucon   = SMDK5250_UCON_DEFAULT,
 + .ulcon  = SMDK5250_ULCON_DEFAULT,
 + .ufcon  = SMDK5250_UFCON_DEFAULT,
 + },
 + [3] = {
 + .hwport = 3,
 + .flags  = 0,
 + .ucon   = SMDK5250_UCON_DEFAULT,
 + .ulcon  = SMDK5250_ULCON_DEFAULT,
 + .ufcon  = SMDK5250_UFCON_DEFAULT,
 + },
 +};
 +
 +static void __init smdk5250_map_io(void)
 +{
 + clk_xusbxti.rate = 2400;
 +
 + exynos_init_io(NULL, 0);
 + s3c24xx_init_clocks(clk_xusbxti.rate);
 + s3c24xx_init_uarts(smdk5250_uartcfgs, ARRAY_SIZE(smdk5250_uartcfgs));
 +}
 +
 +static void __init smdk5250_machine_init(void)
 +{
 + /* nothing here yet */
 +}
 +
 +MACHINE_START(SMDK5250, SMDK5250)
 + .atag_offset= 0x100,
 + .init_irq   = exynos5_init_irq,
 + .map_io = smdk5250_map_io,
 + .handle_irq = gic_handle_irq,
 + .init_machine   = smdk5250_machine_init,
 + .timer  = exynos4_timer,
 + .restart= exynos5_restart,
 +MACHINE_END
 --
 1.7.4.4

 --
 To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
 in
 the body of