Re: [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow

2015-01-14 Thread Javier Martinez Canillas
Hello Kukjin, On 01/14/2015 04:17 PM, Kukjin Kim wrote: pinctrl_0 { +power_key_irq: power-key-irq { +samsung,pins = gpx1-3; +samsung,pin-function = 0xf; I think, this setting should be same with exynos5250-spring but different. from:

Re: [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow

2015-01-14 Thread Kukjin Kim
On 01/03/15 00:24, Javier Martinez Canillas wrote: The Exynos5250 Snow Chromebook has GPIO keys for power and lid so the SoC I/O pins have to be configured in external interrupt mode. Currently, this is working without setting the pinctrl lines but is better to set it explicitly instead of

[PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow

2015-01-02 Thread Javier Martinez Canillas
The Exynos5250 Snow Chromebook has GPIO keys for power and lid so the SoC I/O pins have to be configured in external interrupt mode. Currently, this is working without setting the pinctrl lines but is better to set it explicitly instead of relying on the previous state of the I/O pins. The DTS