Re: [PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

2014-01-19 Thread Leela Krishna Amudala
On 12/7/13, Guenter Roeck li...@roeck-us.net wrote:
 On Fri, Dec 06, 2013 at 11:17:48AM +0530, Leela Krishna Amudala wrote:
 In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
 watchdog timer which is not the case with s3c series SoCs so, there is a
 need to have different compatible names for watchdog to handle these pmu
 registers access.

 Hence this patch removes watchdog node from Exynos5.dtsi common file and
 make it separate by updating existing node in Exynos5250 and adding new
 node
 to Exynos5420. This patch also makes the watchdog node enabled by default

 Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
 Reviewed-by: Tomasz Figa t.f...@samsung.com
 Reviewed-by: Doug Anderson diand...@chromium.org
 Tested-by: Doug Anderson diand...@chromium.org

 Acked-by: Guenter Roeck li...@roeck-us.net

Hi Kgene,

Driver changes has been merged to Wim's tree, so can you please pick
this patch into your tree.

Best Wishes,
Leela krishna.

 --
 To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
 in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

2013-12-06 Thread Guenter Roeck
On Fri, Dec 06, 2013 at 11:17:48AM +0530, Leela Krishna Amudala wrote:
 In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
 watchdog timer which is not the case with s3c series SoCs so, there is a
 need to have different compatible names for watchdog to handle these pmu
 registers access.
 
 Hence this patch removes watchdog node from Exynos5.dtsi common file and
 make it separate by updating existing node in Exynos5250 and adding new node
 to Exynos5420. This patch also makes the watchdog node enabled by default
 
 Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
 Reviewed-by: Tomasz Figa t.f...@samsung.com
 Reviewed-by: Doug Anderson diand...@chromium.org
 Tested-by: Doug Anderson diand...@chromium.org

Acked-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420

2013-12-05 Thread Leela Krishna Amudala
In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask
watchdog timer which is not the case with s3c series SoCs so, there is a
need to have different compatible names for watchdog to handle these pmu
registers access.

Hence this patch removes watchdog node from Exynos5.dtsi common file and
make it separate by updating existing node in Exynos5250 and adding new node
to Exynos5420. This patch also makes the watchdog node enabled by default

Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
Reviewed-by: Tomasz Figa t.f...@samsung.com
Reviewed-by: Doug Anderson diand...@chromium.org
Tested-by: Doug Anderson diand...@chromium.org
---
 arch/arm/boot/dts/exynos5.dtsi|7 ---
 arch/arm/boot/dts/exynos5250.dtsi |6 +-
 arch/arm/boot/dts/exynos5420.dtsi |9 +
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index e52b038..f1fea28 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -81,13 +81,6 @@
status = disabled;
};
 
-   watchdog {
-   compatible = samsung,s3c2410-wdt;
-   reg = 0x101D 0x100;
-   interrupts = 0 42 0;
-   status = disabled;
-   };
-
fimd@1440 {
compatible = samsung,exynos5250-fimd;
interrupt-parent = combiner;
diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
b/arch/arm/boot/dts/exynos5250.dtsi
index 62f9e36..d440a9a 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -168,9 +168,13 @@
reg = 0x1004 0x5000;
};
 
-   watchdog {
+   watchdog@101D {
+   compatible = samsung,exynos5250-wdt;
+   reg = 0x101D 0x100;
+   interrupts = 0 42 0;
clocks = clock 336;
clock-names = watchdog;
+   samsung,syscon-phandle = pmu_system_controller;
};
 
g2d@1085 {
diff --git a/arch/arm/boot/dts/exynos5420.dtsi 
b/arch/arm/boot/dts/exynos5420.dtsi
index cd47db0..167480c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -407,4 +407,13 @@
compatible = samsung,exynos5420-pmu, syscon;
reg = 0x1004 0x5000;
};
+
+watchdog@101D {
+   compatible = samsung,exynos5420-wdt;
+   reg = 0x101D 0x100;
+   interrupts = 0 42 0;
+   clocks = clock 316;
+   clock-names = watchdog;
+   samsung,syscon-phandle = pmu_system_controller;
+};
 };
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html