Re: [PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
On Fri, Aug 23, 2013 at 4:36 AM, Tomasz Figa tomasz.f...@gmail.com wrote:
On Thursday 22 of August 2013 12:24:58 Yuvaraj Kumar wrote:
On Wed, Aug 21, 2013 at 4:00 PM, Tomasz Figa t.f...@samsung.com wrote:
Hi Yuvaraj,
On Wednesday 21 of August 2013 12:13:53 Yuvaraj Kumar C D wrote:
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
What are the difference between both versions? Is there a patch adding
the new compatible to the driver somewhere?
Exynos5250 has DWMMC controller of IP version 2.41a
Exynos5420 has DWMMC controller of IP version 2.50a
In addition Exynos5420 has Security Management Unit for eMMC.
OK. What about my second question?
Below is the link.
http://permalink.gmane.org/gmane.linux.kernel.mmc/21060
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Ahh, so you fixed this already in this version, thanks. Haven't
noticed
this patch at first and commented on previous one. Sorry for the
noise.
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 ++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 38
arch/arm/boot/dts/exynos5420.dtsi
| 36 +++ 3 files changed, 76 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt index
6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung
Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung
Exynos5420 + specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card
interface unit (ciu) clock. This property is applicable only for
Exynos5 SoC's and diff --git
a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..6e65278
100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,44 @@
};
};
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
You don't have to specify this property if there is only one slot.
Also are you sure that this is a board specific property?
Yes,If num-slots property is not defined dw_mmc driver assumes 1 slot
is available.
I think yes,its a board specific property as number of card slots is
board dependent.
+ broken-cd;
+ bypass-smu;
This property doesn't seem to be documented nor used anywhere.
Sorry. I missed to add in binding document.Will add in next version.
Is there a patch adding support for this property to the driver?
Yes.You can find here http://permalink.gmane.org/gmane.linux.kernel.mmc/21060
+ supports-highspeed;
Is it a board specific property?
+ fifo-depth = 0x80;
Ditto.
Ideally this can be move to SOC specific dts.But I am just following
,already merged smdk5250 board
dts convensions.
This means that Exynos5250 board dts files need to be fixed as well.
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
Are the above three properties really board-specific?
Hmm?
I am not sure about this. But Doug Anderson has pointed out these as
board specific properties.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
Hi Yuvaraj,
On 08/23/2013 03:16 PM, Yuvaraj Cd wrote:
On Fri, Aug 23, 2013 at 4:36 AM, Tomasz Figa tomasz.f...@gmail.com wrote:
On Thursday 22 of August 2013 12:24:58 Yuvaraj Kumar wrote:
On Wed, Aug 21, 2013 at 4:00 PM, Tomasz Figa t.f...@samsung.com wrote:
Hi Yuvaraj,
On Wednesday 21 of August 2013 12:13:53 Yuvaraj Kumar C D wrote:
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
What are the difference between both versions? Is there a patch adding
the new compatible to the driver somewhere?
Exynos5250 has DWMMC controller of IP version 2.41a
Exynos5420 has DWMMC controller of IP version 2.50a
In addition Exynos5420 has Security Management Unit for eMMC.
OK. What about my second question?
Below is the link.
http://permalink.gmane.org/gmane.linux.kernel.mmc/21060
If you will send the next version,
Could you add the comment about patch has dependency?
Best Regards,
Jaehoon Chung
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Ahh, so you fixed this already in this version, thanks. Haven't
noticed
this patch at first and commented on previous one. Sorry for the
noise.
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 ++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 38
arch/arm/boot/dts/exynos5420.dtsi
| 36 +++ 3 files changed, 76 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt index
6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung
Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung
Exynos5420 + specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card
interface unit (ciu) clock. This property is applicable only for
Exynos5 SoC's and diff --git
a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..6e65278
100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,44 @@
};
};
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
You don't have to specify this property if there is only one slot.
Also are you sure that this is a board specific property?
Yes,If num-slots property is not defined dw_mmc driver assumes 1 slot
is available.
I think yes,its a board specific property as number of card slots is
board dependent.
+ broken-cd;
+ bypass-smu;
This property doesn't seem to be documented nor used anywhere.
Sorry. I missed to add in binding document.Will add in next version.
Is there a patch adding support for this property to the driver?
Yes.You can find here http://permalink.gmane.org/gmane.linux.kernel.mmc/21060
+ supports-highspeed;
Is it a board specific property?
+ fifo-depth = 0x80;
Ditto.
Ideally this can be move to SOC specific dts.But I am just following
,already merged smdk5250 board
dts convensions.
This means that Exynos5250 board dts files need to be fixed as well.
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
Are the above three properties really board-specific?
Hmm?
I am not sure about this. But Doug Anderson has pointed out these as
board specific properties.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
On Wed, Aug 21, 2013 at 4:00 PM, Tomasz Figa t.f...@samsung.com wrote:
Hi Yuvaraj,
On Wednesday 21 of August 2013 12:13:53 Yuvaraj Kumar C D wrote:
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
What are the difference between both versions? Is there a patch adding the
new compatible to the driver somewhere?
Exynos5250 has DWMMC controller of IP version 2.41a
Exynos5420 has DWMMC controller of IP version 2.50a
In addition Exynos5420 has Security Management Unit for eMMC.
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Ahh, so you fixed this already in this version, thanks. Haven't noticed
this patch at first and commented on previous one. Sorry for the noise.
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 ++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 38
arch/arm/boot/dts/exynos5420.dtsi
| 36 +++ 3 files changed, 76 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt index
6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung Exynos5420
+ specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card
interface unit (ciu) clock. This property is applicable only for Exynos5
SoC's and diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..6e65278
100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,44 @@
};
};
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
You don't have to specify this property if there is only one slot. Also are
you sure that this is a board specific property?
Yes,If num-slots property is not defined dw_mmc driver assumes 1 slot
is available.
I think yes,its a board specific property as number of card slots is
board dependent.
+ broken-cd;
+ bypass-smu;
This property doesn't seem to be documented nor used anywhere.
Sorry. I missed to add in binding document.Will add in next version.
+ supports-highspeed;
Is it a board specific property?
+ fifo-depth = 0x80;
Ditto.
Ideally this can be move to SOC specific dts.But I am just following
,already merged smdk5250 board
dts convensions.
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
Are the above three properties really board-specific?
Same for remaining nodes.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
On Thursday 22 of August 2013 12:24:58 Yuvaraj Kumar wrote:
On Wed, Aug 21, 2013 at 4:00 PM, Tomasz Figa t.f...@samsung.com wrote:
Hi Yuvaraj,
On Wednesday 21 of August 2013 12:13:53 Yuvaraj Kumar C D wrote:
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
What are the difference between both versions? Is there a patch adding
the new compatible to the driver somewhere?
Exynos5250 has DWMMC controller of IP version 2.41a
Exynos5420 has DWMMC controller of IP version 2.50a
In addition Exynos5420 has Security Management Unit for eMMC.
OK. What about my second question?
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Ahh, so you fixed this already in this version, thanks. Haven't
noticed
this patch at first and commented on previous one. Sorry for the
noise.
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 ++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 38
arch/arm/boot/dts/exynos5420.dtsi
| 36 +++ 3 files changed, 76 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt index
6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung
Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung
Exynos5420 + specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card
interface unit (ciu) clock. This property is applicable only for
Exynos5 SoC's and diff --git
a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..6e65278
100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,44 @@
};
};
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
You don't have to specify this property if there is only one slot.
Also are you sure that this is a board specific property?
Yes,If num-slots property is not defined dw_mmc driver assumes 1 slot
is available.
I think yes,its a board specific property as number of card slots is
board dependent.
+ broken-cd;
+ bypass-smu;
This property doesn't seem to be documented nor used anywhere.
Sorry. I missed to add in binding document.Will add in next version.
Is there a patch adding support for this property to the driver?
+ supports-highspeed;
Is it a board specific property?
+ fifo-depth = 0x80;
Ditto.
Ideally this can be move to SOC specific dts.But I am just following
,already merged smdk5250 board
dts convensions.
This means that Exynos5250 board dts files need to be fixed as well.
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
Are the above three properties really board-specific?
Hmm?
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 +
arch/arm/boot/dts/exynos5420-smdk5420.dts | 39
arch/arm/boot/dts/exynos5420.dtsi | 36 ++
3 files changed, 77 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
index 6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung Exynos5420
+ specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card interface
unit (ciu) clock. This property is applicable only for Exynos5 SoC's and
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 08607df..0b2e464 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -30,4 +30,43 @@
clock-frequency = 2400;
};
};
+
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
+ broken-cd;
+ bypass-smu;
+ supports-highspeed;
+ fifo-depth = 0x80;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
+ pinctrl-names = default;
+ pinctrl-0 = sd0_clk sd0_cmd sd0_bus4 sd0_bus8;
+
+ slot@0 {
+ reg = 0;
+ bus-width = 8;
+ };
+ };
+
+ dwmmc2@1222 {
+ status = okay;
+ num-slots = 1;
+ supports-highspeed;
+ fifo-depth = 0x80;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ pinctrl-names = default;
+ pinctrl-0 = sd2_clk sd2_cmd sd2_cd sd2_bus4;
+
+ slot@0 {
+ reg = 0;
+ bus-width = 4;
+ };
+ };
+
};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi
b/arch/arm/boot/dts/exynos5420.dtsi
index 9e90d1e..d9220c3 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -19,6 +19,9 @@
compatible = samsung,exynos5420;
aliases {
+ mshc0 = dwmmc_0;
+ mshc1 = dwmmc_1;
+ mshc2 = dwmmc_2;
pinctrl0 = pinctrl_0;
pinctrl1 = pinctrl_1;
pinctrl2 = pinctrl_2;
@@ -65,6 +68,39 @@
#clock-cells = 1;
};
+ dwmmc_0: dwmmc0@1220 {
+ compatible = samsung,exynos5420-dw-mshc;
+ interrupts = 0 75 0;
+ #address-cells = 1;
+ #size-cells = 0;
+ reg = 0x1220 0x2000;
+ clocks = clock 351, clock 132;
+ clock-names = biu, ciu;
+ status = disabled;
+ };
+
+ dwmmc_1: dwmmc1@1221 {
+ compatible = samsung,exynos5420-dw-mshc;
+ interrupts = 0 76 0;
+ #address-cells = 1;
+ #size-cells = 0;
+ reg = 0x1221 0x2000;
+ clocks = clock 352, clock 133;
+ clock-names = biu, ciu;
+ status = disabled;
+ };
+
+ dwmmc_2: dwmmc2@1222 {
+ compatible = samsung,exynos5420-dw-mshc;
+ interrupts = 0 77 0;
+ #address-cells = 1;
+ #size-cells = 0;
+ reg = 0x1222 0x2000;
+ clocks = clock 353, clock 134;
+ clock-names = biu, ciu;
+ status = disabled;
+ };
+
mct@101C {
compatible = samsung,exynos4210-mct;
reg = 0x101C 0x800;
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 ++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 38
arch/arm/boot/dts/exynos5420.dtsi | 36 +++
3 files changed, 76 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
index 6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung Exynos5420
+ specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card interface
unit (ciu) clock. This property is applicable only for Exynos5 SoC's and
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index bafba25..6e65278 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,44 @@
};
};
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
+ broken-cd;
+ bypass-smu;
+ supports-highspeed;
+ fifo-depth = 0x80;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
+ pinctrl-names = default;
+ pinctrl-0 = sd0_clk sd0_cmd sd0_bus4 sd0_bus8;
+
+ slot@0 {
+ reg = 0;
+ bus-width = 8;
+ };
+ };
+
+ dwmmc2@1222 {
+ status = okay;
+ num-slots = 1;
+ supports-highspeed;
+ fifo-depth = 0x80;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ pinctrl-names = default;
+ pinctrl-0 = sd2_clk sd2_cmd sd2_cd sd2_bus4;
+
+ slot@0 {
+ reg = 0;
+ bus-width = 4;
+ };
+ };
+
dp-controller@145B {
pinctrl-names = default;
pinctrl-0 = dp_hpd;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi
b/arch/arm/boot/dts/exynos5420.dtsi
index 5353e32..694e7f1 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -22,6 +22,9 @@
compatible = samsung,exynos5420;
aliases {
+ mshc0 = dwmmc_0;
+ mshc1 = dwmmc_1;
+ mshc2 = dwmmc_2;
pinctrl0 = pinctrl_0;
pinctrl1 = pinctrl_1;
pinctrl2 = pinctrl_2;
@@ -84,6 +87,39 @@
clock-names = mfc;
};
+ dwmmc_0: dwmmc0@1220 {
+ compatible = samsung,exynos5420-dw-mshc;
+ interrupts = 0 75 0;
+ #address-cells = 1;
+ #size-cells = 0;
+ reg = 0x1220 0x2000;
+ clocks = clock 351, clock 132;
+ clock-names = biu, ciu;
+ status = disabled;
+ };
+
+ dwmmc_1: dwmmc1@1221 {
+ compatible = samsung,exynos5420-dw-mshc;
+ interrupts = 0 76 0;
+ #address-cells = 1;
+ #size-cells = 0;
+ reg = 0x1221 0x2000;
+ clocks = clock 352, clock 133;
+ clock-names = biu, ciu;
+ status = disabled;
+ };
+
+ dwmmc_2: dwmmc2@1222 {
+ compatible = samsung,exynos5420-dw-mshc;
+ interrupts = 0 77 0;
+ #address-cells = 1;
+ #size-cells = 0;
+ reg = 0x1222 0x2000;
+ clocks = clock 353, clock 134;
+ clock-names = biu, ciu;
+ status = disabled;
+ };
+
mct@101C {
compatible = samsung,exynos4210-mct;
reg = 0x101C 0x800;
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add dwmmc DT nodes for exynos5420 SOC
Hi Yuvaraj,
On Wednesday 21 of August 2013 12:13:53 Yuvaraj Kumar C D wrote:
This patch adds the device tree node entries for exynos5420 SOC.
Exynos5420 has a different version of DWMMC controller,so a new
compatible string is used to distinguish it from the prior SOC's.
What are the difference between both versions? Is there a patch adding the
new compatible to the driver somewhere?
changes since V1:
1.disable node by status = disabled in SOC file
2.enable node by status = okay in board specific file
Ahh, so you fixed this already in this version, thanks. Haven't noticed
this patch at first and commented on previous one. Sorry for the noise.
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |2 ++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 38
arch/arm/boot/dts/exynos5420.dtsi
| 36 +++ 3 files changed, 76 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt index
6d1c098..84cd56f 100644
--- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
+++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
@@ -16,6 +16,8 @@ Required Properties:
specific extensions.
- samsung,exynos5250-dw-mshc: for controllers with Samsung Exynos5250
specific extensions.
+ - samsung,exynos5420-dw-mshc: for controllers with Samsung Exynos5420
+ specific extensions.
* samsung,dw-mshc-ciu-div: Specifies the divider value for the card
interface unit (ciu) clock. This property is applicable only for Exynos5
SoC's and diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts index bafba25..6e65278
100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,44 @@
};
};
+ dwmmc0@1220 {
+ status = okay;
+ num-slots = 1;
You don't have to specify this property if there is only one slot. Also are
you sure that this is a board specific property?
+ broken-cd;
+ bypass-smu;
This property doesn't seem to be documented nor used anywhere.
+ supports-highspeed;
Is it a board specific property?
+ fifo-depth = 0x80;
Ditto.
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 0 4;
+ samsung,dw-mshc-ddr-timing = 0 2;
Are the above three properties really board-specific?
Same for remaining nodes.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
