Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory
On Monday 06 of May 2013 23:05:06 Zhang Rui wrote: On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: This movement of files is done for easy maintenance and adding more new sensor's support for exynos platform easily . This will also help in bifurcating exynos common, sensor driver and sensor data related parts. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/Kconfig| 13 + drivers/thermal/Makefile |2 +- drivers/thermal/samsung/Kconfig|9 + drivers/thermal/samsung/Makefile |4 drivers/thermal/{ = samsung}/exynos_thermal.c |0 5 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 drivers/thermal/samsung/Kconfig create mode 100644 drivers/thermal/samsung/Makefile rename drivers/thermal/{ = samsung}/exynos_thermal.c (100%) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5e3c025..081ddc5 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL Support for the Kirkwood thermal sensor driver into the Linux thermal framework. Only kirkwood 88F6282 and 88F6283 have this sensor. -config EXYNOS_THERMAL - tristate Temperature sensor on Samsung EXYNOS - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) - depends on CPU_THERMAL - help - If you say yes here you get support for TMU (Thermal Management - Unit) on SAMSUNG EXYNOS series of SoC. - config DOVE_THERMAL tristate Temperature sensor on Marvell Dove SoCs depends on ARCH_DOVE @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP enforce idle time which results in more package C-state residency. The user interface is exposed via generic thermal framework. +menu Exynos thermal drivers would it be more proper to use Samsung thermal drivers or Samsung Exynos thermal drivers instead? +1 Still, I wonder if it really makes sense to create a separate directory and submenu for this. +depends on PLAT_SAMSUNG +source drivers/thermal/samsung/Kconfig +endmenu + sorry I know few about arm, could you tell me the difference between CONFIG_ARCH_EXYNOS4/CONFIG_ARCH_EXYNOS5 and CONFIG_PLAT_SAMSUNG please, I do not see the dependency between these in Kconfig file? If those files were kept at thermal/, there would be no need for this check. Just particular drivers would depend on platform they are for. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Kernel and System Framework endif diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index c054d41..b3063a9 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -17,7 +17,7 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o obj-$(CONFIG_SPEAR_THERMAL)+= spear_thermal.o obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o obj-$(CONFIG_KIRKWOOD_THERMAL) += kirkwood_thermal.o -obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o +obj-y += samsung/ obj-$(CONFIG_DOVE_THERMAL) += dove_thermal.o obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig new file mode 100644 index 000..2d3d9dc --- /dev/null +++ b/drivers/thermal/samsung/Kconfig @@ -0,0 +1,9 @@ +config EXYNOS_THERMAL + tristate Temperature sensor on Samsung EXYNOS + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) + depends on CPU_THERMAL + help + If you say yes here you get support for TMU (Thermal Management + Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering + the exynos thermal driver with the core thermal layer and cpu + cooling API's. diff --git a/drivers/thermal/samsung/Makefile b/drivers/thermal/samsung/Makefile new file mode 100644 index 000..1fe6d93 --- /dev/null +++ b/drivers/thermal/samsung/Makefile @@ -0,0 +1,4 @@ +# +# Samsung thermal specific Makefile +# +obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/samsung/exynos_thermal.c similarity index 100% rename from drivers/thermal/exynos_thermal.c rename to drivers/thermal/samsung/exynos_thermal.c -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory
Hi Rui, On Mon, May 6, 2013 at 8:35 PM, Zhang Rui rui.zh...@intel.com wrote: On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: This movement of files is done for easy maintenance and adding more new sensor's support for exynos platform easily . This will also help in bifurcating exynos common, sensor driver and sensor data related parts. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/Kconfig| 13 + drivers/thermal/Makefile |2 +- drivers/thermal/samsung/Kconfig|9 + drivers/thermal/samsung/Makefile |4 drivers/thermal/{ = samsung}/exynos_thermal.c |0 5 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 drivers/thermal/samsung/Kconfig create mode 100644 drivers/thermal/samsung/Makefile rename drivers/thermal/{ = samsung}/exynos_thermal.c (100%) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5e3c025..081ddc5 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL Support for the Kirkwood thermal sensor driver into the Linux thermal framework. Only kirkwood 88F6282 and 88F6283 have this sensor. -config EXYNOS_THERMAL - tristate Temperature sensor on Samsung EXYNOS - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) - depends on CPU_THERMAL - help - If you say yes here you get support for TMU (Thermal Management - Unit) on SAMSUNG EXYNOS series of SoC. - config DOVE_THERMAL tristate Temperature sensor on Marvell Dove SoCs depends on ARCH_DOVE @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP enforce idle time which results in more package C-state residency. The user interface is exposed via generic thermal framework. +menu Exynos thermal drivers would it be more proper to use Samsung thermal drivers or Samsung Exynos thermal drivers instead? Yes Samsung thermal drivers will look fine. Submitted with this change. +depends on PLAT_SAMSUNG +source drivers/thermal/samsung/Kconfig +endmenu + sorry I know few about arm, could you tell me the difference between CONFIG_ARCH_EXYNOS4/CONFIG_ARCH_EXYNOS5 and CONFIG_PLAT_SAMSUNG please, I do not see the dependency between these in Kconfig file? PLAT_SAMSUNG is the superset of ARCH_EXYNOS4/5 so I used this dependency but currently only exynos based soc's have TMU driver. Also it matches with the folder name. Thanks, Amit Daniel thanks, rui endif diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index c054d41..b3063a9 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -17,7 +17,7 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o obj-$(CONFIG_KIRKWOOD_THERMAL) += kirkwood_thermal.o -obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o +obj-y+= samsung/ obj-$(CONFIG_DOVE_THERMAL) += dove_thermal.o obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig new file mode 100644 index 000..2d3d9dc --- /dev/null +++ b/drivers/thermal/samsung/Kconfig @@ -0,0 +1,9 @@ +config EXYNOS_THERMAL + tristate Temperature sensor on Samsung EXYNOS + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) + depends on CPU_THERMAL + help + If you say yes here you get support for TMU (Thermal Management + Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering + the exynos thermal driver with the core thermal layer and cpu + cooling API's. diff --git a/drivers/thermal/samsung/Makefile b/drivers/thermal/samsung/Makefile new file mode 100644 index 000..1fe6d93 --- /dev/null +++ b/drivers/thermal/samsung/Makefile @@ -0,0 +1,4 @@ +# +# Samsung thermal specific Makefile +# +obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/samsung/exynos_thermal.c similarity index 100% rename from drivers/thermal/exynos_thermal.c rename to drivers/thermal/samsung/exynos_thermal.c -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory
On Tuesday 07 of May 2013 18:48:46 amit daniel kachhap wrote: Hi Tomasz Figa, On Tue, May 7, 2013 at 3:51 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 06 of May 2013 23:05:06 Zhang Rui wrote: On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: This movement of files is done for easy maintenance and adding more new sensor's support for exynos platform easily . This will also help in bifurcating exynos common, sensor driver and sensor data related parts. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/Kconfig| 13 + drivers/thermal/Makefile |2 +- drivers/thermal/samsung/Kconfig|9 + drivers/thermal/samsung/Makefile |4 drivers/thermal/{ = samsung}/exynos_thermal.c |0 5 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 drivers/thermal/samsung/Kconfig create mode 100644 drivers/thermal/samsung/Makefile rename drivers/thermal/{ = samsung}/exynos_thermal.c (100%) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5e3c025..081ddc5 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL Support for the Kirkwood thermal sensor driver into the Linux thermal framework. Only kirkwood 88F6282 and 88F6283 have this sensor. -config EXYNOS_THERMAL - tristate Temperature sensor on Samsung EXYNOS - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) - depends on CPU_THERMAL - help - If you say yes here you get support for TMU (Thermal Management - Unit) on SAMSUNG EXYNOS series of SoC. - config DOVE_THERMAL tristate Temperature sensor on Marvell Dove SoCs depends on ARCH_DOVE @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP enforce idle time which results in more package C-state residency. The user interface is exposed via generic thermal framework. +menu Exynos thermal drivers would it be more proper to use Samsung thermal drivers or Samsung Exynos thermal drivers instead? +1 Still, I wonder if it really makes sense to create a separate directory and submenu for this. Yes separate directory was needed as the current TMU drivers supports many exynos SOC's with some differences in the controller itself. This has made it unmanageable and unclean and configuration data need to be separated from driver. With all these re-structuring, tmu support for exynos5440 is added very cleanly. Also many changes in this patchset are for making the driver multi-stance which is needed for 5440. I fully understand the need to restructure this driver. I'm just thinking if there is really a reason to have a separate directory with its own Makefile and Kconfig just for six source files, which could be placed in drivers/thermal/ directly as well. I guess it's just a matter of preference, though. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Kernel and System Framework -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: This movement of files is done for easy maintenance and adding more new sensor's support for exynos platform easily . This will also help in bifurcating exynos common, sensor driver and sensor data related parts. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/Kconfig| 13 + drivers/thermal/Makefile |2 +- drivers/thermal/samsung/Kconfig|9 + drivers/thermal/samsung/Makefile |4 drivers/thermal/{ = samsung}/exynos_thermal.c |0 5 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 drivers/thermal/samsung/Kconfig create mode 100644 drivers/thermal/samsung/Makefile rename drivers/thermal/{ = samsung}/exynos_thermal.c (100%) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5e3c025..081ddc5 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL Support for the Kirkwood thermal sensor driver into the Linux thermal framework. Only kirkwood 88F6282 and 88F6283 have this sensor. -config EXYNOS_THERMAL - tristate Temperature sensor on Samsung EXYNOS - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) - depends on CPU_THERMAL - help - If you say yes here you get support for TMU (Thermal Management - Unit) on SAMSUNG EXYNOS series of SoC. - config DOVE_THERMAL tristate Temperature sensor on Marvell Dove SoCs depends on ARCH_DOVE @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP enforce idle time which results in more package C-state residency. The user interface is exposed via generic thermal framework. +menu Exynos thermal drivers would it be more proper to use Samsung thermal drivers or Samsung Exynos thermal drivers instead? +depends on PLAT_SAMSUNG +source drivers/thermal/samsung/Kconfig +endmenu + sorry I know few about arm, could you tell me the difference between CONFIG_ARCH_EXYNOS4/CONFIG_ARCH_EXYNOS5 and CONFIG_PLAT_SAMSUNG please, I do not see the dependency between these in Kconfig file? thanks, rui endif diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index c054d41..b3063a9 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -17,7 +17,7 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o obj-$(CONFIG_KIRKWOOD_THERMAL) += kirkwood_thermal.o -obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o +obj-y+= samsung/ obj-$(CONFIG_DOVE_THERMAL) += dove_thermal.o obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig new file mode 100644 index 000..2d3d9dc --- /dev/null +++ b/drivers/thermal/samsung/Kconfig @@ -0,0 +1,9 @@ +config EXYNOS_THERMAL + tristate Temperature sensor on Samsung EXYNOS + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) + depends on CPU_THERMAL + help + If you say yes here you get support for TMU (Thermal Management + Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering + the exynos thermal driver with the core thermal layer and cpu + cooling API's. diff --git a/drivers/thermal/samsung/Makefile b/drivers/thermal/samsung/Makefile new file mode 100644 index 000..1fe6d93 --- /dev/null +++ b/drivers/thermal/samsung/Makefile @@ -0,0 +1,4 @@ +# +# Samsung thermal specific Makefile +# +obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/samsung/exynos_thermal.c similarity index 100% rename from drivers/thermal/exynos_thermal.c rename to drivers/thermal/samsung/exynos_thermal.c -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory
This movement of files is done for easy maintenance and adding more new sensor's support for exynos platform easily . This will also help in bifurcating exynos common, sensor driver and sensor data related parts. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/thermal/Kconfig| 13 + drivers/thermal/Makefile |2 +- drivers/thermal/samsung/Kconfig|9 + drivers/thermal/samsung/Makefile |4 drivers/thermal/{ = samsung}/exynos_thermal.c |0 5 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 drivers/thermal/samsung/Kconfig create mode 100644 drivers/thermal/samsung/Makefile rename drivers/thermal/{ = samsung}/exynos_thermal.c (100%) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5e3c025..081ddc5 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL Support for the Kirkwood thermal sensor driver into the Linux thermal framework. Only kirkwood 88F6282 and 88F6283 have this sensor. -config EXYNOS_THERMAL - tristate Temperature sensor on Samsung EXYNOS - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) - depends on CPU_THERMAL - help - If you say yes here you get support for TMU (Thermal Management - Unit) on SAMSUNG EXYNOS series of SoC. - config DOVE_THERMAL tristate Temperature sensor on Marvell Dove SoCs depends on ARCH_DOVE @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP enforce idle time which results in more package C-state residency. The user interface is exposed via generic thermal framework. +menu Exynos thermal drivers +depends on PLAT_SAMSUNG +source drivers/thermal/samsung/Kconfig +endmenu + endif diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index c054d41..b3063a9 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -17,7 +17,7 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o obj-$(CONFIG_SPEAR_THERMAL)+= spear_thermal.o obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o obj-$(CONFIG_KIRKWOOD_THERMAL) += kirkwood_thermal.o -obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o +obj-y += samsung/ obj-$(CONFIG_DOVE_THERMAL) += dove_thermal.o obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig new file mode 100644 index 000..2d3d9dc --- /dev/null +++ b/drivers/thermal/samsung/Kconfig @@ -0,0 +1,9 @@ +config EXYNOS_THERMAL + tristate Temperature sensor on Samsung EXYNOS + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) + depends on CPU_THERMAL + help + If you say yes here you get support for TMU (Thermal Management + Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering + the exynos thermal driver with the core thermal layer and cpu + cooling API's. diff --git a/drivers/thermal/samsung/Makefile b/drivers/thermal/samsung/Makefile new file mode 100644 index 000..1fe6d93 --- /dev/null +++ b/drivers/thermal/samsung/Makefile @@ -0,0 +1,4 @@ +# +# Samsung thermal specific Makefile +# +obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/samsung/exynos_thermal.c similarity index 100% rename from drivers/thermal/exynos_thermal.c rename to drivers/thermal/samsung/exynos_thermal.c -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html