Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-29 Thread Rob Clark
On Mon, Apr 28, 2014 at 9:08 AM, Ajay kumar ajayn...@gmail.com wrote: Daniel, On Sun, Apr 27, 2014 at 6:25 PM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar ajayn...@gmail.com wrote: We can call panel_enable/disable at the right point. Even the bridge chips

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-28 Thread Ajay kumar
Daniel, On Sun, Apr 27, 2014 at 6:25 PM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar ajayn...@gmail.com wrote: We can call panel_enable/disable at the right point. Even the bridge chips expect the same. So, I am not ok with combining the bridge and panel

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-27 Thread Daniel Vetter
On Fri, Apr 25, 2014 at 8:17 AM, Ajay kumar ajayn...@gmail.com wrote: We can call panel_enable/disable at the right point. Even the bridge chips expect the same. So, I am not ok with combining the bridge and panel and calling the fxn pointers from crtc_helpers. So, either we leave it the way

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-25 Thread Ajay kumar
On Thu, Apr 24, 2014 at 11:08 PM, Ajay kumar ajayn...@gmail.com wrote: On Thu, Apr 24, 2014 at 10:55 PM, Rob Clark robdcl...@gmail.com wrote: On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar ajayn...@gmail.com wrote: Rob, On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark robdcl...@gmail.com wrote: On

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-25 Thread Ajay kumar
Sorry for the previous reply. Here goes the full explaination. On Fri, Apr 25, 2014 at 11:40 AM, Ajay kumar ajayn...@gmail.com wrote: On Thu, Apr 24, 2014 at 11:08 PM, Ajay kumar ajayn...@gmail.com wrote: On Thu, Apr 24, 2014 at 10:55 PM, Rob Clark robdcl...@gmail.com wrote: On Thu, Apr 24,

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Rob Clark
On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar ajayn...@gmail.com wrote: Sorry for the previous reply, Here goes the full explaination: Rob, On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark robdcl...@gmail.com wrote: So what about, rather than adding drm_panel support to each bridge individually,

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Ajay kumar
Rob, On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark robdcl...@gmail.com wrote: On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar ajayn...@gmail.com wrote: Sorry for the previous reply, Here goes the full explaination: Rob, On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark robdcl...@gmail.com wrote: So

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Rob Clark
On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar ajayn...@gmail.com wrote: Rob, On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark robdcl...@gmail.com wrote: On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar ajayn...@gmail.com wrote: Sorry for the previous reply, Here goes the full explaination: Rob, On

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-24 Thread Ajay kumar
On Thu, Apr 24, 2014 at 10:55 PM, Rob Clark robdcl...@gmail.com wrote: On Thu, Apr 24, 2014 at 12:55 PM, Ajay kumar ajayn...@gmail.com wrote: Rob, On Thu, Apr 24, 2014 at 9:41 PM, Rob Clark robdcl...@gmail.com wrote: On Wed, Apr 23, 2014 at 3:02 PM, Ajay kumar ajayn...@gmail.com wrote: Sorry

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-23 Thread Ajay kumar
Rob, On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark robdcl...@gmail.com wrote: So what about, rather than adding drm_panel support to each bridge individually, we introduce a drm_panel_bridge (with a form of chaining).. ie: struct drm_panel_bridge { struct drm_bridge base; struct

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-23 Thread Ajay kumar
Sorry for the previous reply, Here goes the full explaination: Rob, On Tue, Apr 22, 2014 at 5:04 PM, Rob Clark robdcl...@gmail.com wrote: So what about, rather than adding drm_panel support to each bridge individually, we introduce a drm_panel_bridge (with a form of chaining).. ie:

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Rob Clark
So what about, rather than adding drm_panel support to each bridge individually, we introduce a drm_panel_bridge (with a form of chaining).. ie: struct drm_panel_bridge { struct drm_bridge base; struct drm_panel *panel; struct drm_bridge *bridge; /* optional */ }; static void

Re: [PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-22 Thread Daniel Vetter
On Tue, Apr 22, 2014 at 07:34:03AM -0400, Rob Clark wrote: So what about, rather than adding drm_panel support to each bridge individually, we introduce a drm_panel_bridge (with a form of chaining).. ie: struct drm_panel_bridge { struct drm_bridge base; struct drm_panel *panel;

[PATCH V2 7/9] drm/bridge: ptn3460: add drm_panel controls

2014-04-21 Thread Ajay Kumar
attach ptn3460 connector to drm_panel and support drm_panel routines, if a valid drm_panel object is passed to ptn3460_init. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- Changes since V1: Address few coding style comments from Jingoo Han drivers/gpu/drm/bridge/Kconfig