Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Sylwester, Thanks for the review. Will update with your suggestion in the next version, Thanks, Amit D On Thu, Mar 7, 2013 at 8:58 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: +/* Register definations */ s/definations/definitions

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Russell, On Thu, Mar 7, 2013 at 9:07 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 07, 2013 at 04:28:00PM +0100, Sylwester Nawrocki wrote: On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: + dvfs_info-cpu_clk = devm_clk_get(dvfs_info-dev, armclk); + if

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Viresh, On Sat, Mar 9, 2013 at 4:17 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 7 March 2013 12:13, Amit Daniel Kachhap amit.dan...@samsung.com wrote: diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c +struct exynos_dvfs_data { + void

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-09 Thread Viresh Kumar
On 7 March 2013 12:13, Amit Daniel Kachhap amit.dan...@samsung.com wrote: diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c +struct exynos_dvfs_data { + void __iomem *base; + struct resource *mem; + int irq; + struct clk

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-07 Thread Sylwester Nawrocki
On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: +/* Register definations */ s/definations/definitions +#define XMU_DVFS_CTRL0x0060 +#define XMU_PMU_P0_7 0x0064 +#define XMU_C0_3_PSTATE 0x0090 +#define XMU_P_LIMIT 0x00A0 +#define XMU_P_STATUS

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-07 Thread Russell King - ARM Linux
On Thu, Mar 07, 2013 at 04:28:00PM +0100, Sylwester Nawrocki wrote: On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: + dvfs_info-cpu_clk = devm_clk_get(dvfs_info-dev, armclk); + if (IS_ERR_OR_NULL(dvfs_info-cpu_clk)) { devm_clk_get() return value needs to be checked with IS_ERR(),