[PATCH V3 5/7] ARM: dts: Add osc clock node on smdk5420.

2013-08-07 Thread Padmavathi Venna 
This patch adds 16MHz oscillator clock node required for audio
on smdk5420 and adds the phandle of the same in wm8994 clock info.

Signed-off-by: Padmavathi Venna padm...@samsung.com
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |   10 ++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index e86c1ae..3c56a91 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,13 @@
};
};
 
+   osc3_clk16mhz: clk16mhz {
+   compatible = osc3_clk16mhz;
+   #clock-cells = 0;
+   clock-frequency = 16934400;
+   clock-output-names = osc3_clk16mhz;
+   };
+
dwmmc0@1220 {
status = okay;
num-slots = 1;
@@ -123,6 +130,9 @@
DBVDD-supply = dbvdd;
SPKVDD1-supply = spkvdd;
SPKVDD2-supply = spkvdd;
+
+   clocks = osc3_clk16mhz;
+   clock-names = mclk1;
};
};
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 5/7] ARM: dts: Add osc clock node on smdk5420.

2013-08-07 Thread Tomasz Figa 
On Wednesday 07 of August 2013 14:40:14 Padmavathi Venna wrote:
 This patch adds 16MHz oscillator clock node required for audio
 on smdk5420 and adds the phandle of the same in wm8994 clock info.
 
 Signed-off-by: Padmavathi Venna padm...@samsung.com
 ---
  arch/arm/boot/dts/exynos5420-smdk5420.dts |   10 ++
  1 files changed, 10 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
 b/arch/arm/boot/dts/exynos5420-smdk5420.dts index e86c1ae..3c56a91
 100644
 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
 +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
 @@ -31,6 +31,13 @@
   };
   };
 
 + osc3_clk16mhz: clk16mhz {
 + compatible = osc3_clk16mhz;

Hmm?

What about the generic fixed rate clock binding[1]?

Also please name nodes being added with generic names, not platform-
specific ones. For example, fixed-rate-clock-0 or oscillator-0, just like 
it is done with fixed regulators.

Best regards,
Tomasz

[1] - Documentation/devicetree/bindings/clock/fixed-clock.txt

 + #clock-cells = 0;
 + clock-frequency = 16934400;
 + clock-output-names = osc3_clk16mhz;
 + };
 +
   dwmmc0@1220 {
   status = okay;
   num-slots = 1;
 @@ -123,6 +130,9 @@
   DBVDD-supply = dbvdd;
   SPKVDD1-supply = spkvdd;
   SPKVDD2-supply = spkvdd;
 +
 + clocks = osc3_clk16mhz;
 + clock-names = mclk1;
   };
   };
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html