Re: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
On 08/16/13 16:53, Tomasz Figa wrote: Hi Kukjin, [...] - compatible = samsung,i2s-v5; + compatible = samsung,s5pv210-i2s; Device tree reviewers, this is something to look out for in the future. Some samsung platforms/drivers use samsung,chip-ip, others samsung,ip-chip. I don't personally care much one way or another, but it really should be consistent. Hmm...I think, if samsung,ip name-ip version is possible, it would be nice. I remember there are no versions in datasheet for some IPs but something have like i2s and mfc. So samsung,ip-version is used for only i2s and mfc. But actually there are versions for Samsung IPs, no comments for that in datasheet. So I think, if Samsung can provide the specific version of Samsung IPs, we can use that like other platforms. I will prepare some table for that after meeting with Samsung hardware IP team so that samsung platform use one format samsung,ip-version. Sorry, I don't think this is a good idea, unless you can force the IP team to release a version table containing version of _every_ IP for _every_ released SoC, including those historical ones, like S3C24xx and S3C64xx. Of course such tables should be available publicly. It's different issue and I agree with Mark Brown's comments. In addition, there might be other funny things going on with IPs and their surroundings, that could make a need to create several separate compatible values for the same IP revision, but on different SoCs, because it was integrated in a slightly different way. I believe we have choses the samsung,chip-ip scheme to avoid being dependent upon data that is not always publicly available, which is more future- (and past-) proof and also solves the integration problem. Well, I don't think so, because Samsung is no more just SoC vendor. Actually Samsung is providing just IP to customers, I think, they don't like to use the name, exynos for their SoC or Chip, because exynos, s3c or s5p whatever is Samsung's SoC brand name. If so, I think, my suggestion is more reasonable. See the example of Synopsys and ARM primecell...that's why I will try to do it. But I know I need to get agreement from DT guys and maybe I need more time than I expect ;-) Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
Hi Olof,
On Thursday 15 of August 2013 21:48:32 Olof Johansson wrote:
On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna padm...@samsung.com
wrote:
This patch removes quirks from i2s node and change the i2s
compatible names.
Signed-off-by: Padmavathi Venna padm...@samsung.com
---
Changes since V4:
- Mark Brown reverted the below two patches due to below build
failure with
exynos_defconfig.
ARM: dts: exynos5250: move common i2s properties to
exynos5 dtsi
ARM: dts: Change i2s compatible string on exynos5250
build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node
or label pdma1 ERROR (phandle_references): Reference to
non-existent node or label pdma1 ERROR
(phandle_references): Reference to non-existent node or
label pdma0 ERROR (phandle_references): Reference to
non-existent node or label pdma0
But with out ARM: dts: Change i2s compatible string on exynos5250
will break the i2s driver.
So posting this patch now and will take care of posting other patch
later after dependent patches got merged.
arch/arm/boot/dts/exynos5250.dtsi |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
};
i2s0: i2s@0383 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s5pv210-i2s;
Device tree reviewers, this is something to look out for in the
future. Some samsung platforms/drivers use samsung,chip-ip,
others samsung,ip-chip. I don't personally care much one way or
another, but it really should be consistent.
Hmm, I just did a quick git grep over arch/arm/boot/dts and could not
really find the samsung,ip-chip pattern.
Except MFC (and without Padma's patch also I2S), which used samsung,ip-
ip version, all the compatible values I can see are based on
samsung,chip-ip pattern.
I believe we discussed this issue several times already and finally agreed
to use samsung,chip-ip for any new compatible values.
Best regards,
Tomasz
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
Hi Kukjin,
On Friday 16 of August 2013 14:43:17 Kukjin Kim wrote:
Olof Johansson wrote:
On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna
padm...@samsung.com
wrote:
This patch removes quirks from i2s node and change the i2s
compatible names.
Signed-off-by: Padmavathi Venna padm...@samsung.com
---
Changes since V4:
- Mark Brown reverted the below two patches due to below
build
failure with
exynos_defconfig.
ARM: dts: exynos5250: move common i2s properties to
exynos5
dtsi
ARM: dts: Change i2s compatible string on
exynos5250
build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node
or
label pdma1
ERROR (phandle_references): Reference to non-existent node
or
label pdma1
ERROR (phandle_references): Reference to non-existent node
or
label pdma0
ERROR (phandle_references): Reference to non-existent node
or
label pdma0
But with out ARM: dts: Change i2s compatible string on exynos5250
will
break the i2s
driver.
So posting this patch now and will take care of posting other patch
later after dependent
patches got merged.
arch/arm/boot/dts/exynos5250.dtsi |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
};
i2s0: i2s@0383 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s5pv210-i2s;
Device tree reviewers, this is something to look out for in the
future. Some samsung platforms/drivers use samsung,chip-ip,
others samsung,ip-chip. I don't personally care much one way or
another, but it really should be consistent.
Hmm...I think, if samsung,ip name-ip version is possible, it would
be nice. I remember there are no versions in datasheet for some IPs but
something have like i2s and mfc. So samsung,ip-version is used
for only i2s and mfc. But actually there are versions for Samsung IPs,
no comments for that in datasheet. So I think, if Samsung can provide
the specific version of Samsung IPs, we can use that like other
platforms. I will prepare some table for that after meeting with
Samsung hardware IP team so that samsung platform use one format
samsung,ip-version.
Sorry, I don't think this is a good idea, unless you can force the IP team
to release a version table containing version of _every_ IP for _every_
released SoC, including those historical ones, like S3C24xx and S3C64xx.
Of course such tables should be available publicly.
In addition, there might be other funny things going on with IPs and their
surroundings, that could make a need to create several separate compatible
values for the same IP revision, but on different SoCs, because it was
integrated in a slightly different way.
I believe we have choses the samsung,chip-ip scheme to avoid being
dependent upon data that is not always publicly available, which is more
future- (and past-) proof and also solves the integration problem.
Best regards,
Tomasz
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
On Fri, Aug 16, 2013 at 09:53:23AM +0200, Tomasz Figa wrote: Sorry, I don't think this is a good idea, unless you can force the IP team to release a version table containing version of _every_ IP for _every_ released SoC, including those historical ones, like S3C24xx and S3C64xx. Of course such tables should be available publicly. I don't think public availability is much of an issue here, the datasheets are all NDAed anyway. signature.asc Description: Digital signature
Re: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
On Fri, Aug 16, 2013 at 09:56:18AM +0530, Padmavathi Venna wrote: This patch removes quirks from i2s node and change the i2s compatible names. Applied, thanks. signature.asc Description: Digital signature
[PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
This patch removes quirks from i2s node and change the i2s
compatible names.
Signed-off-by: Padmavathi Venna padm...@samsung.com
---
Changes since V4:
- Mark Brown reverted the below two patches due to below build failure
with
exynos_defconfig.
ARM: dts: exynos5250: move common i2s properties to exynos5
dtsi
ARM: dts: Change i2s compatible string on exynos5250
build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node or label
pdma1
ERROR (phandle_references): Reference to non-existent node or label
pdma1
ERROR (phandle_references): Reference to non-existent node or label
pdma0
ERROR (phandle_references): Reference to non-existent node or label
pdma0
But with out ARM: dts: Change i2s compatible string on exynos5250 will break
the i2s
driver.
So posting this patch now and will take care of posting other patch later after
dependent
patches got merged.
arch/arm/boot/dts/exynos5250.dtsi |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
};
i2s0: i2s@0383 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s5pv210-i2s;
reg = 0x0383 0x100;
dmas = pdma0 10
pdma0 9
@@ -415,16 +415,13 @@
clock_audss EXYNOS_I2S_BUS,
clock_audss EXYNOS_SCLK_I2S;
clock-names = iis, i2s_opclk0, i2s_opclk1;
- samsung,supports-6ch;
- samsung,supports-rstclr;
- samsung,supports-secdai;
samsung,idma-addr = 0x0300;
pinctrl-names = default;
pinctrl-0 = i2s0_bus;
};
i2s1: i2s@12D6 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s3c6410-i2s;
reg = 0x12D6 0x100;
dmas = pdma1 12
pdma1 11;
@@ -436,7 +433,7 @@
};
i2s2: i2s@12D7 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s3c6410-i2s;
reg = 0x12D7 0x100;
dmas = pdma0 12
pdma0 11;
--
1.7.4.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna padm...@samsung.com wrote:
This patch removes quirks from i2s node and change the i2s
compatible names.
Signed-off-by: Padmavathi Venna padm...@samsung.com
---
Changes since V4:
- Mark Brown reverted the below two patches due to below build
failure with
exynos_defconfig.
ARM: dts: exynos5250: move common i2s properties to exynos5
dtsi
ARM: dts: Change i2s compatible string on exynos5250
build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node or label
pdma1
ERROR (phandle_references): Reference to non-existent node or label
pdma1
ERROR (phandle_references): Reference to non-existent node or label
pdma0
ERROR (phandle_references): Reference to non-existent node or label
pdma0
But with out ARM: dts: Change i2s compatible string on exynos5250 will
break the i2s
driver.
So posting this patch now and will take care of posting other patch later
after dependent
patches got merged.
arch/arm/boot/dts/exynos5250.dtsi |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
};
i2s0: i2s@0383 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s5pv210-i2s;
Device tree reviewers, this is something to look out for in the
future. Some samsung platforms/drivers use samsung,chip-ip,
others samsung,ip-chip. I don't personally care much one way or
another, but it really should be consistent.
-Olof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V5] ARM: dts: Change i2s compatible string on exynos5250
Olof Johansson wrote:
On Thu, Aug 15, 2013 at 9:26 PM, Padmavathi Venna padm...@samsung.com
wrote:
This patch removes quirks from i2s node and change the i2s
compatible names.
Signed-off-by: Padmavathi Venna padm...@samsung.com
---
Changes since V4:
- Mark Brown reverted the below two patches due to below build
failure with
exynos_defconfig.
ARM: dts: exynos5250: move common i2s properties to
exynos5
dtsi
ARM: dts: Change i2s compatible string on exynos5250
build error:
DTC arch/arm/boot/dts/exynos5420-smdk5420.dtb
ERROR (phandle_references): Reference to non-existent node or
label pdma1
ERROR (phandle_references): Reference to non-existent node or
label pdma1
ERROR (phandle_references): Reference to non-existent node or
label pdma0
ERROR (phandle_references): Reference to non-existent node or
label pdma0
But with out ARM: dts: Change i2s compatible string on exynos5250 will
break the i2s
driver.
So posting this patch now and will take care of posting other patch
later after dependent
patches got merged.
arch/arm/boot/dts/exynos5250.dtsi |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..376090f 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -405,7 +405,7 @@
};
i2s0: i2s@0383 {
- compatible = samsung,i2s-v5;
+ compatible = samsung,s5pv210-i2s;
Device tree reviewers, this is something to look out for in the
future. Some samsung platforms/drivers use samsung,chip-ip,
others samsung,ip-chip. I don't personally care much one way or
another, but it really should be consistent.
Hmm...I think, if samsung,ip name-ip version is possible, it would be
nice. I remember there are no versions in datasheet for some IPs but
something have like i2s and mfc. So samsung,ip-version is used for
only i2s and mfc. But actually there are versions for Samsung IPs, no
comments for that in datasheet. So I think, if Samsung can provide the
specific version of Samsung IPs, we can use that like other platforms. I
will prepare some table for that after meeting with Samsung hardware IP team
so that samsung platform use one format samsung,ip-version.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
