Re: [PATCH V5 0/3] Add watchdog DT nodes and use syscon regmap interfac to configure pmu registers

2013-10-30 Thread Sachin Kamat
Hi Leela,

On 31 October 2013 11:30, Leela Krishna Amudala  wrote:
> This patchset does the following things
> - Adds pmusysreg device node to exynos5.dtsi file
> - Adds watchdog DT nodes to Exynos5250 and 5420
> - Uses syscon regmap interface to configure pmu registers
>   to mask/unmask enable/disable of watchdog.
>
> This patch set is rebased on Kgene's for-next branch and tested on SMDK5420
>
> Changes since V4:
> - changed the node name from pmusysreg to syscon and node label from 
> pmu_sys_reg to pmu_syscon
> - changed the property name from samsung,pmusysreg to 
> samsung,syscon-phandle
> - used regmap_update_bits instead of remap_read/regmap_write
> - Addressed other comments given by Tomasz Figa 
>
> Changes since V3:
> - changed the compatible strings for watchdog node
> - splitted up adding pmusysreg node and made it separate patch
> - Addressed comments given by Sachin Kamat 
>
> Changes since V2:
> - used syscon regmap interface to configure pmu registers in WDT 
> driver
>   (suggested by Tomasz Figa )
>
> Changes since V1:
> - Added new compatible string for Exynos5 SoCs
> - Introduced quirk mechanism to program PMU registers
> - Addressed comments given by Tomasz Figa 
>
> Leela Krishna Amudala (3):
>   ARM: dts: Add pmu sysreg node to Exynos5 dtsi file
>   ARM: dts: add watchdog device nodes for Exynos5250 and Exynos5420
>   watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu
> register
>
>  .../devicetree/bindings/watchdog/samsung-wdt.txt   |   22 ++-
>  arch/arm/boot/dts/exynos5.dtsi |   12 +-
>  arch/arm/boot/dts/exynos5250.dtsi  |7 +-
>  arch/arm/boot/dts/exynos5420.dtsi  |   10 ++
>  drivers/watchdog/s3c2410_wdt.c |  150 
> +---
>  5 files changed, 175 insertions(+), 26 deletions(-)
>
> --
> 1.7.10.4
>

Series looks good. However, you would need to add select MFD_SYSCON option to
watchdog Kconfig for ARCH_EXYNOS5.

Tested this series on Origen (4210), Arndale (5250) and SMDK5420 boards.

Tested-by: Sachin Kamat 
Reviewed-by: Sachin Kamat 

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH V5 0/3] Add watchdog DT nodes and use syscon regmap interfac to configure pmu registers

2013-10-30 Thread Leela Krishna Amudala
This patchset does the following things
- Adds pmusysreg device node to exynos5.dtsi file
- Adds watchdog DT nodes to Exynos5250 and 5420
- Uses syscon regmap interface to configure pmu registers
  to mask/unmask enable/disable of watchdog.

This patch set is rebased on Kgene's for-next branch and tested on SMDK5420

Changes since V4:
- changed the node name from pmusysreg to syscon and node label from 
pmu_sys_reg to pmu_syscon
- changed the property name from samsung,pmusysreg to 
samsung,syscon-phandle
- used regmap_update_bits instead of remap_read/regmap_write
- Addressed other comments given by Tomasz Figa 

Changes since V3:
- changed the compatible strings for watchdog node
- splitted up adding pmusysreg node and made it separate patch
- Addressed comments given by Sachin Kamat 

Changes since V2:
- used syscon regmap interface to configure pmu registers in WDT driver
  (suggested by Tomasz Figa )

Changes since V1:
- Added new compatible string for Exynos5 SoCs
- Introduced quirk mechanism to program PMU registers
- Addressed comments given by Tomasz Figa 

Leela Krishna Amudala (3):
  ARM: dts: Add pmu sysreg node to Exynos5 dtsi file
  ARM: dts: add watchdog device nodes for Exynos5250 and Exynos5420
  watchdog: s3c2410_wdt: use syscon regmap interface to configure pmu
register

 .../devicetree/bindings/watchdog/samsung-wdt.txt   |   22 ++-
 arch/arm/boot/dts/exynos5.dtsi |   12 +-
 arch/arm/boot/dts/exynos5250.dtsi  |7 +-
 arch/arm/boot/dts/exynos5420.dtsi  |   10 ++
 drivers/watchdog/s3c2410_wdt.c |  150 +---
 5 files changed, 175 insertions(+), 26 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html