RE: [PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options

2011-11-02 Thread Kukjin Kim 
Rajeshwari Shinde wrote:
 
 This patch modifies the driver to stop depending on the clock names
 being passed from the platform and switch over to bus clock lookup
 using generic clock names.
 
 V6 Changes:
 Changed sprintf to snprintf as suggested by Chris Ball.
 
 Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com

Acked-by: Kukjin Kim kgene@samsung.com

Hi Chirs,

Could you please pick this up in your tree for this merge window?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

 ---
  drivers/mmc/host/sdhci-s3c.c |7 ++-
  1 files changed, 2 insertions(+), 5 deletions(-)
 
 diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
 index 82709b6..488223c 100644
 --- a/drivers/mmc/host/sdhci-s3c.c
 +++ b/drivers/mmc/host/sdhci-s3c.c
 @@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct
 platform_device *pdev)
 
   for (clks = 0, ptr = 0; ptr  MAX_BUS_CLK; ptr++) {
   struct clk *clk;
 - char *name = pdata-clocks[ptr];
 -
 - if (name == NULL)
 - continue;
 + char name[14];
 
 + snprintf(name, 14, mmc_busclk.%d, ptr);
   clk = clk_get(dev, name);
   if (IS_ERR(clk)) {
 - dev_err(dev, failed to get clock %s\n, name);
   continue;
   }
 
 --
 1.7.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options

2011-11-02 Thread Thomas Abraham 
On 31 October 2011 11:14, Rajeshwari Shinde rajeshwar...@samsung.com wrote:
 This patch modifies the driver to stop depending on the clock names
 being passed from the platform and switch over to bus clock lookup
 using generic clock names.

 V6 Changes:
 Changed sprintf to snprintf as suggested by Chris Ball.

The above two lines can be removed from the commit message.


 Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
 ---
  drivers/mmc/host/sdhci-s3c.c |    7 ++-
  1 files changed, 2 insertions(+), 5 deletions(-)

 diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
 index 82709b6..488223c 100644
 --- a/drivers/mmc/host/sdhci-s3c.c
 +++ b/drivers/mmc/host/sdhci-s3c.c
 @@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct 
 platform_device *pdev)

[...]
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options

2011-11-02 Thread Kukjin Kim 
Chris Ball wrote:
 
 Hi Kukjin,
 
 On Wed, Nov 02 2011, Kukjin Kim wrote:
  This patch modifies the driver to stop depending on the clock names
  being passed from the platform and switch over to bus clock lookup
  using generic clock names.
 
  V6 Changes:
  Changed sprintf to snprintf as suggested by Chris Ball.
 
  Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
 
  Acked-by: Kukjin Kim kgene@samsung.com
 
  Hi Chirs,
 
  Could you please pick this up in your tree for this merge window?
 
 Might be easier to have you send this, if you don't mind, since I'm
 still traveling and have already sent my main pull request.  Thanks!
 
 Acked-by: Chris Ball c...@laptop.org
 
Hi Chris,

OK, I picked this up in my tree.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options

2011-10-30 Thread Rajeshwari Shinde 
This patch modifies the driver to stop depending on the clock names
being passed from the platform and switch over to bus clock lookup
using generic clock names.

V6 Changes:
Changed sprintf to snprintf as suggested by Chris Ball.

Signed-off-by: Rajeshwari Shinde rajeshwar...@samsung.com
---
 drivers/mmc/host/sdhci-s3c.c |7 ++-
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
index 82709b6..488223c 100644
--- a/drivers/mmc/host/sdhci-s3c.c
+++ b/drivers/mmc/host/sdhci-s3c.c
@@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct 
platform_device *pdev)
 
for (clks = 0, ptr = 0; ptr  MAX_BUS_CLK; ptr++) {
struct clk *clk;
-   char *name = pdata-clocks[ptr];
-
-   if (name == NULL)
-   continue;
+   char name[14];
 
+   snprintf(name, 14, mmc_busclk.%d, ptr);
clk = clk_get(dev, name);
if (IS_ERR(clk)) {
-   dev_err(dev, failed to get clock %s\n, name);
continue;
}
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html