Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-16 Thread Padma Venkat
Hi, On Fri, Feb 15, 2013 at 5:31 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Feb 14, 2013 at 09:33:00PM +0100, Sylwester Nawrocki wrote: My apologies for the late review. It's already sixth version of this patch series... But I noticed it just now when applying it for

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-15 Thread Mark Brown
On Thu, Feb 14, 2013 at 09:33:00PM +0100, Sylwester Nawrocki wrote: My apologies for the late review. It's already sixth version of this patch series... But I noticed it just now when applying it for Exynos4. The GPIO part of the bindings is now incompatible with Exynos4 and the bindings will

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Sylwester Nawrocki
Hi, On 01/18/2013 12:47 PM, Padmavathi Venna wrote: Add support for device based discovery. Signed-off-by: Padmavathi Venna padm...@samsung.com --- .../devicetree/bindings/sound/samsung-i2s.txt | 63 ++ sound/soc/samsung/dma.c|3 +-

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Sylwester Nawrocki
On 01/18/2013 12:47 PM, Padmavathi Venna wrote: Add support for device based discovery. Signed-off-by: Padmavathi Venna padm...@samsung.com --- ... /* Lock for cross i/f checks */ @@ -997,19 +1006,76 @@ static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec)

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Tomasz Figa
Hi, On Thursday 14 of February 2013 11:48:59 Sylwester Nawrocki wrote: On 01/18/2013 12:47 PM, Padmavathi Venna wrote: Add support for device based discovery. Signed-off-by: Padmavathi Venna padm...@samsung.com --- ... /* Lock for cross i/f checks */ @@ -997,19 +1006,76 @@

Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-02-14 Thread Mark Brown
On Thu, Feb 14, 2013 at 11:48:59AM +0100, Sylwester Nawrocki wrote: NAK. Why we should leave with this temporary code when there is already pinctrl support for Exynos SoCs ? If the pinctrl driver for Exynos5 was updated you could instead just do

[PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s

2013-01-18 Thread Padmavathi Venna
Add support for device based discovery. Signed-off-by: Padmavathi Venna padm...@samsung.com --- .../devicetree/bindings/sound/samsung-i2s.txt | 63 ++ sound/soc/samsung/dma.c|3 +- sound/soc/samsung/dma.h|1 +