Re: [PATCH v2] pinctrl: Add pinctrl-s3c24xx driver

2013-04-11 Thread Tomasz Figa
Hi Heiko, As previously, generally looks good to me, but see my comments inline. On Thursday 11 of April 2013 01:16:41 Heiko Stübner wrote: The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore reuse the already introduced infrastructure. The s3c24xx SoCs

Re: [PATCH v2] pinctrl: Add pinctrl-s3c24xx driver

2013-04-11 Thread Heiko Stübner
Am Donnerstag, 11. April 2013, 10:54:45 schrieb Tomasz Figa: Hi Heiko, As previously, generally looks good to me, but see my comments inline. On Thursday 11 of April 2013 01:16:41 Heiko Stübner wrote: The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore

Re: [PATCH v2] pinctrl: Add pinctrl-s3c24xx driver

2013-04-11 Thread Tomasz Figa
On Thursday 11 of April 2013 11:32:03 Heiko Stübner wrote: Am Donnerstag, 11. April 2013, 10:54:45 schrieb Tomasz Figa: Hi Heiko, As previously, generally looks good to me, but see my comments inline. On Thursday 11 of April 2013 01:16:41 Heiko Stübner wrote: The s3c24xx pins

Re: [PATCH v2] pinctrl: Add pinctrl-s3c24xx driver

2013-04-11 Thread Heiko Stübner
Am Donnerstag, 11. April 2013, 11:43:19 schrieb Tomasz Figa: On Thursday 11 of April 2013 11:32:03 Heiko Stübner wrote: Am Donnerstag, 11. April 2013, 10:54:45 schrieb Tomasz Figa: Hi Heiko, As previously, generally looks good to me, but see my comments inline. On Thursday 11

[PATCH v2] pinctrl: Add pinctrl-s3c24xx driver

2013-04-10 Thread Heiko Stübner
The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore reuse the already introduced infrastructure. The s3c24xx SoCs have one design oddity in that the first 4 external interrupts do not reside in the eint pending register but in the main interrupt controller