Re: [PATCH v2 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-30 Thread Alim Akhtar
Hi Krzysztof, On 12/30/2015 10:17 AM, Krzysztof Kozlowski wrote: Before updating time and alarm the driver must set appropriate mask in UDR register. For that purpose the driver uses common register configuration and a lot of exceptions per device in the code. The exceptions are not obvious,

Re: [rtc-linux] Re: [PATCH v2 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-30 Thread Krzysztof Kozlowski
2015-12-30 19:14 GMT+09:00 Alim Akhtar : > > Hi Krzysztof, > > On 12/30/2015 10:17 AM, Krzysztof Kozlowski wrote: >> >> Before updating time and alarm the driver must set appropriate mask in >> UDR register. For that purpose the driver uses common register >> configuration

[PATCH v2 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-29 Thread Krzysztof Kozlowski
Before updating time and alarm the driver must set appropriate mask in UDR register. For that purpose the driver uses common register configuration and a lot of exceptions per device in the code. The exceptions are not obvious, for example except the change in the logic sometimes the fields are