Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-08 Thread Tomasz Figa
Hi Kgene, On Saturday 08 of September 2012 11:47:15 Kukjin Kim wrote: + memory { + reg = 0x4000 0x2000 + 0x6000 0x2000; + }; Why does this have to be split. Why not have a single entry with the size as

RE: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-07 Thread Kukjin Kim
Tomasz Figa wrote: Hi, Thanks for reviewing the patch. On Wednesday 05 of September 2012 09:35:49 Thomas Abraham wrote: + + memory { + reg = 0x4000 0x2000 + 0x6000 0x2000; + }; Why does this have to be

[PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-04 Thread Tomasz Figa
This commit adds basic device tree for Exynos4210-based Trats board. Currently it provides support for eMMC over sdhci and MAX8997 PMIC. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 237

Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-04 Thread Thomas Abraham
On 4 September 2012 14:20, Tomasz Figa t.f...@samsung.com wrote: This commit adds basic device tree for Exynos4210-based Trats board. Currently it provides support for eMMC over sdhci and MAX8997 PMIC. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-04 Thread Tomasz Figa
Hi, Thanks for reviewing the patch. On Wednesday 05 of September 2012 09:35:49 Thomas Abraham wrote: + + memory { + reg = 0x4000 0x2000 + 0x6000 0x2000; + }; Why does this have to be split. Why not have a single entry