Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-12 Thread Alim Akhtar
Hi Jaehoon, On Thu, Jan 8, 2015 at 7:06 AM, Jaehoon Chung wrote: > Hi, > > On 12/31/2014 03:43 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> ciu_div may not be common value for all speed mode. >> So, it needs to be attached to CLKSEL timing. >> This also introduce a new compatibale 'dw-msh

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-12 Thread Alim Akhtar
Hi Doug, On Tue, Jan 6, 2015 at 6:37 AM, Doug Anderson wrote: > Alim, > > On Sun, Jan 4, 2015 at 2:43 PM, Alim Akhtar wrote: >>> You are breaking backward compatibility here. If your change is >>> merged then all old boards will instantly break. Since the "dts" and >>> code changes will likely

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-07 Thread Jaehoon Chung
Hi, On 12/31/2014 03:43 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > ciu_div may not be common value for all speed mode. > So, it needs to be attached to CLKSEL timing. > This also introduce a new compatibale 'dw-mshc-hs200-timing' > for selecting hs200 timing value > > Signed-off-by: Seun

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-05 Thread Doug Anderson
Alim, On Sun, Jan 4, 2015 at 2:43 PM, Alim Akhtar wrote: >> You are breaking backward compatibility here. If your change is >> merged then all old boards will instantly break. Since the "dts" and >> code changes will likely be merged through different trees you'll end >> up with a bunch of brok

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-04 Thread Alim Akhtar
Hi Doug, Thanks for looking into this series. On Fri, Jan 2, 2015 at 10:28 PM, Doug Anderson wrote: > Alim, > > On Tue, Dec 30, 2014 at 10:43 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> ciu_div may not be common value for all speed mode. >> So, it needs to be attached to CLKSEL timing.

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-02 Thread Doug Anderson
Alim, On Tue, Dec 30, 2014 at 10:43 PM, Alim Akhtar wrote: > From: Seungwon Jeon > > ciu_div may not be common value for all speed mode. > So, it needs to be attached to CLKSEL timing. The more time I've spent looking at all of this stuff the less I like the exynos bindings. Personally I'd pre

Re: [PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2015-01-02 Thread Ulf Hansson
On 31 December 2014 at 07:43, Alim Akhtar wrote: > From: Seungwon Jeon > > ciu_div may not be common value for all speed mode. > So, it needs to be attached to CLKSEL timing. > This also introduce a new compatibale 'dw-mshc-hs200-timing' > for selecting hs200 timing value According to the patch

[PATCH v3 1/4] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2014-12-30 Thread Alim Akhtar
From: Seungwon Jeon ciu_div may not be common value for all speed mode. So, it needs to be attached to CLKSEL timing. This also introduce a new compatibale 'dw-mshc-hs200-timing' for selecting hs200 timing value Signed-off-by: Seungwon Jeon Signed-off-by: Alim Akhtar --- .../devicetree/bindin