Re: [PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-06-24 Thread Tomasz Figa
On 24.06.2014 13:28, Pankaj Dubey wrote: On Tuesday, June 17 2014, Tomasz Figa wrote: On 10.05.2014 08:56, Pankaj Dubey wrote: [snip] + + ret = platform_driver_register(exynos_pmu_driver); + if (ret 0) + goto out; + + exynos_pmu_pdev =

RE: [PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-06-24 Thread Pankaj Dubey
Hi, On Wednesday, June 25 2014 Tomasz Figa write: On 24.06.2014 13:28, Pankaj Dubey wrote: On Tuesday, June 17 2014, Tomasz Figa wrote: On 10.05.2014 08:56, Pankaj Dubey wrote: [snip] + + ret = platform_driver_register(exynos_pmu_driver); + if (ret 0) + goto out; +

Re: [PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-06-17 Thread Tomasz Figa
Hi Pankaj, [dropping Young-Gun Jang yg1004.j...@samsung.com, as my mailer denies to send to this address] Please see my comments inline. I have skipped comments for changed related to regmap, as according to our previous discussion they will be dropped in next version. On 10.05.2014 08:56,

[PATCH v4 10/11] ARM: EXYNOS: Add platform driver support for Exynos PMU.

2014-05-10 Thread Pankaj Dubey
This patch modifies Exynos Power Management Unit (PMU) initialization implementation in following way: - Added platform_device support by registering static platform device. - Added platform struct exynos_pmu_data to hold platform specific data. - For each SoC's PMU support now we can add