Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-02-02 Thread Javier Martinez Canillas
Hello, On 01/30/2015 01:51 PM, Javier Martinez Canillas wrote: On 01/29/2015 10:11 PM, Paul Bolle wrote: + help + If you say Y here, you get support for talking to the ChromeOS EC + over an LPC bus. This uses a simple byte-level protocol with a + checksum. This is used for

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-30 Thread Javier Martinez Canillas
Hello Paul, Thanks a lot for your feedback. On 01/29/2015 10:11 PM, Paul Bolle wrote: +config CROS_EC_LPC +tristate ChromeOS Embedded Controller (LPC) +depends on MFD_CROS_EC + Please drop this empty line. Ok. +help + If you say Y here, you get support for

[PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Javier Martinez Canillas
From: Bill Richardson wfric...@chromium.org Chromebooks have an Embedded Controller (EC) that is used to implement various functions such as keyboard, power and battery. The AP can communicate with the EC through different bus types such as I2C, SPI or LPC. The cros_ec mfd driver is then

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Varka Bhadram
On Thu, Jan 29, 2015 at 7:07 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: From: Bill Richardson wfric...@chromium.org Chromebooks have an Embedded Controller (EC) that is used to implement various functions such as keyboard, power and battery. The AP can communicate

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Paul Bolle
Javier, Trivial nits below. On Thu, 2015-01-29 at 14:37 +0100, Javier Martinez Canillas wrote: From: Bill Richardson wfric...@chromium.org Chromebooks have an Embedded Controller (EC) that is used to implement various functions such as keyboard, power and battery. The AP can communicate