Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
On 11 July 2012 19:01, Mark Brown wrote: > On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote: > >> Based on your comments to add the gpio request, only two patches 5/6 >> and 6/6 in this series have changed since. I have cc'ed you in the >> other 4 patches as well. If you do not have

[PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote: > Based on your comments to add the gpio request, only two patches 5/6 > and 6/6 in this series have changed since. I have cc'ed you in the > other 4 patches as well. If you do not have those patches, please let > me know, I will repo

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
On 11 July 2012 17:17, Mark Brown wrote: > On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since a

Re: [PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Mark Brown
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote: > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the sl

[PATCH v5 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-11 Thread Thomas Abraham
The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave select line, this callback can be removed from the controller data a