Re: [PATCHv6 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-08-25 Thread Pavel Machek
On Fri 2014-07-25 10:11:51, Jaehoon Chung wrote:
 dw-mmc controller can support multiple slots.
 But, there are no use-cases anywhere. So we don't need to support the
 slot-node for dw-mmc controller.
 And supports-highspeed property in dw-mmc is deprecated.
 supports-highspeed property can be replaced to cap-sd/mmc-highspeed.
 
 Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
 Reviewed-by: Tushar Behera trbli...@gmail.com
 Reviewed-by: Ulf Hansson ulf.hans...@linaro.org
 Acked-by: Seungwon Jeon tgih@samsung.com
 Acked-by: Dinh Nguyen dingu...@altera.com

So, controller supports it, and slot representation makes sense, but
we move to less logical representation that will break when someone
actually does two slots?

NAK, for what it is worth. 
Pavel

 ---
  arch/arm/boot/dts/socfpga_arria5.dtsi   |9 +++--
  arch/arm/boot/dts/socfpga_cyclone5.dtsi |9 +++--
  arch/arm/boot/dts/socfpga_vt.dts|9 +++--
  3 files changed, 9 insertions(+), 18 deletions(-)
 
 diff --git a/arch/arm/boot/dts/socfpga_arria5.dtsi 
 b/arch/arm/boot/dts/socfpga_arria5.dtsi
 index 12d1c2c..468fc4c 100644
 --- a/arch/arm/boot/dts/socfpga_arria5.dtsi
 +++ b/arch/arm/boot/dts/socfpga_arria5.dtsi
 @@ -29,13 +29,10 @@
  
   dwmmc0@ff704000 {
   num-slots = 1;
 - supports-highspeed;
   broken-cd;
 -
 - slot@0 {
 - reg = 0;
 - bus-width = 4;
 - };
 + bus-width = 4;
 + cap-mmc-highspeed;
 + cap-sd-highspeed;
   };
  
   sysmgr@ffd08000 {
 diff --git a/arch/arm/boot/dts/socfpga_cyclone5.dtsi 
 b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
 index bf51182..1ee03c4 100644
 --- a/arch/arm/boot/dts/socfpga_cyclone5.dtsi
 +++ b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
 @@ -30,13 +30,10 @@
  
   dwmmc0@ff704000 {
   num-slots = 1;
 - supports-highspeed;
   broken-cd;
 -
 - slot@0 {
 - reg = 0;
 - bus-width = 4;
 - };
 + bus-width = 4;
 + cap-mmc-highspeed;
 + cap-sd-highspeed;
   };
  
   ethernet@ff702000 {
 diff --git a/arch/arm/boot/dts/socfpga_vt.dts 
 b/arch/arm/boot/dts/socfpga_vt.dts
 index 09792b4..f9345e0 100644
 --- a/arch/arm/boot/dts/socfpga_vt.dts
 +++ b/arch/arm/boot/dts/socfpga_vt.dts
 @@ -43,13 +43,10 @@
  
   dwmmc0@ff704000 {
   num-slots = 1;
 - supports-highspeed;
   broken-cd;
 -
 - slot@0 {
 - reg = 0;
 - bus-width = 4;
 - };
 + bus-width = 4;
 + cap-mmc-highspeed;
 + cap-sd-highspeed;
   };
  
   ethernet@ff70 {

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCHv6 3/5] ARM: dts: socfpga: unuse the slot-node and deprecated the supports-highspeed for dw-mmc

2014-07-24 Thread Jaehoon Chung
dw-mmc controller can support multiple slots.
But, there are no use-cases anywhere. So we don't need to support the
slot-node for dw-mmc controller.
And supports-highspeed property in dw-mmc is deprecated.
supports-highspeed property can be replaced to cap-sd/mmc-highspeed.

Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Reviewed-by: Tushar Behera trbli...@gmail.com
Reviewed-by: Ulf Hansson ulf.hans...@linaro.org
Acked-by: Seungwon Jeon tgih@samsung.com
Acked-by: Dinh Nguyen dingu...@altera.com
---
 arch/arm/boot/dts/socfpga_arria5.dtsi   |9 +++--
 arch/arm/boot/dts/socfpga_cyclone5.dtsi |9 +++--
 arch/arm/boot/dts/socfpga_vt.dts|9 +++--
 3 files changed, 9 insertions(+), 18 deletions(-)

diff --git a/arch/arm/boot/dts/socfpga_arria5.dtsi 
b/arch/arm/boot/dts/socfpga_arria5.dtsi
index 12d1c2c..468fc4c 100644
--- a/arch/arm/boot/dts/socfpga_arria5.dtsi
+++ b/arch/arm/boot/dts/socfpga_arria5.dtsi
@@ -29,13 +29,10 @@
 
dwmmc0@ff704000 {
num-slots = 1;
-   supports-highspeed;
broken-cd;
-
-   slot@0 {
-   reg = 0;
-   bus-width = 4;
-   };
+   bus-width = 4;
+   cap-mmc-highspeed;
+   cap-sd-highspeed;
};
 
sysmgr@ffd08000 {
diff --git a/arch/arm/boot/dts/socfpga_cyclone5.dtsi 
b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
index bf51182..1ee03c4 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5.dtsi
+++ b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
@@ -30,13 +30,10 @@
 
dwmmc0@ff704000 {
num-slots = 1;
-   supports-highspeed;
broken-cd;
-
-   slot@0 {
-   reg = 0;
-   bus-width = 4;
-   };
+   bus-width = 4;
+   cap-mmc-highspeed;
+   cap-sd-highspeed;
};
 
ethernet@ff702000 {
diff --git a/arch/arm/boot/dts/socfpga_vt.dts b/arch/arm/boot/dts/socfpga_vt.dts
index 09792b4..f9345e0 100644
--- a/arch/arm/boot/dts/socfpga_vt.dts
+++ b/arch/arm/boot/dts/socfpga_vt.dts
@@ -43,13 +43,10 @@
 
dwmmc0@ff704000 {
num-slots = 1;
-   supports-highspeed;
broken-cd;
-
-   slot@0 {
-   reg = 0;
-   bus-width = 4;
-   };
+   bus-width = 4;
+   cap-mmc-highspeed;
+   cap-sd-highspeed;
};
 
ethernet@ff70 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html