RE: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Marek Szyprowski
Hello, On Wednesday, July 14, 2010 6:57 AM Kukjin Kim wrote: Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup

Re: [PATCH 2/3] ARM: S5PV210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Mark Brown
On Wed, Jul 14, 2010 at 10:16:55AM +0200, Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup functionality with external

RE: [PATCH 2/3] ARM: S5PV210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim
Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup functionality with external interrupt). Signed-off-by: Marek

RE: [PATCH 2/3] ARM: S5PV210: Aquila: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim
Mark Brown wrote: On Wed, Jul 14, 2010 at 10:16:55AM +0200, Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup

RE: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-13 Thread Kukjin Kim
Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup functionality with external interrupt). Signed-off-by: Marek

Re: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 08:07:45AM +0200, Marek Szyprowski wrote: +static struct regulator_consumer_supply aquila_ldo3_consumers[] = { + { .supply = VMIPI_1.1V, }, +}; +static struct regulator_consumer_supply aquila_ldo8_consumers[] = { + { .supply = VADC_3.3V, }, +};

Re: [PATCH 2/3] arm: s5pv210: Aquila: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 03:32:17PM +0200, Marek Szyprowski wrote: One more question - should I enable the regulators in the driver itself or in the platform callback (like a poweron() callback)? I don't understand what you mean by platform callback. Normally the driver would unconditionally