RE: [PATCH 3/3] ARM: S5PV210: GONI: add support for MAX8998 PMIC

2010-07-14 Thread Kukjin Kim
Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup functionality with external interrupt). Signed-off-by: Marek

RE: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-13 Thread Kukjin Kim
Marek Szyprowski wrote: This patch adds required platform definitions for MAX8998 PMIC driver. Power regulators for LDO and BUCK outputs has been defined as well as a simple gpio-keys button for power key (to enable wakeup functionality with external interrupt). Almost same with previous

Re: [PATCH 3/3] arm: s5pv210: GONI: add support for MAX8998 PMIC

2010-07-01 Thread Mark Brown
On Thu, Jul 01, 2010 at 08:07:46AM +0200, Marek Szyprowski wrote: +static struct regulator_consumer_supply goni_ldo3_consumers[] = { + { .supply = VMIPI_1.1V, }, +}; A similar issue to the previous patch applies here - you should be defining consumers using struct device based