RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen

2012-09-07 Thread Kukjin Kim
Kukjin Kim wrote:
> 
> Sachin Kamat wrote:
> >
> > Commit: f447ed8b31d (gpio: samsung: add flags specifier to
> > device-tree binding) adds a flag to represent active low state
> > for gpio line. Since gpio-keys on Origen board are active low,
> > using this flag to represent the same.
> >
> > Signed-off-by: Sachin Kamat 
> > Reviewed-by: Thomas Abraham 
> > ---
> >  arch/arm/boot/dts/exynos4210-origen.dts |   10 +-
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> > b/arch/arm/boot/dts/exynos4210-origen.dts
> > index 0c49caa..c37edf0 100644
> > --- a/arch/arm/boot/dts/exynos4210-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> > @@ -62,31 +62,31 @@
> >
> > up {
> > label = "Up";
> > -   gpios = <&gpx2 0 0 0 2>;
> > +   gpios = <&gpx2 0 0 0x1 2>;
> > linux,code = <103>;
> > };
> >
> > down {
> > label = "Down";
> > -   gpios = <&gpx2 1 0 0 2>;
> > +   gpios = <&gpx2 1 0 0x1 2>;
> > linux,code = <108>;
> > };
> >
> > back {
> > label = "Back";
> > -   gpios = <&gpx1 7 0 0 2>;
> > +   gpios = <&gpx1 7 0 0x1 2>;
> > linux,code = <158>;
> > };
> >
> > home {
> > label = "Home";
> > -   gpios = <&gpx1 6 0 0 2>;
> > +   gpios = <&gpx1 6 0 0x1 2>;
> > linux,code = <102>;
> > };
> >
> > menu {
> > label = "Menu";
> > -   gpios = <&gpx1 5 0 0 2>;
> > +   gpios = <&gpx1 5 0 0x1 2>;
> > linux,code = <139>;
> > };
> > };
> > --
> > 1.7.4.1
> 
> Applied, thanks.
> 
Note, since this is not a bug fix, queued this for v3.7.

If any problem, let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen

2012-09-07 Thread Kukjin Kim
Sachin Kamat wrote:
> 
> Commit: f447ed8b31d (gpio: samsung: add flags specifier to
> device-tree binding) adds a flag to represent active low state
> for gpio line. Since gpio-keys on Origen board are active low,
> using this flag to represent the same.
> 
> Signed-off-by: Sachin Kamat 
> Reviewed-by: Thomas Abraham 
> ---
>  arch/arm/boot/dts/exynos4210-origen.dts |   10 +-
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts
> index 0c49caa..c37edf0 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -62,31 +62,31 @@
> 
>   up {
>   label = "Up";
> - gpios = <&gpx2 0 0 0 2>;
> + gpios = <&gpx2 0 0 0x1 2>;
>   linux,code = <103>;
>   };
> 
>   down {
>   label = "Down";
> - gpios = <&gpx2 1 0 0 2>;
> + gpios = <&gpx2 1 0 0x1 2>;
>   linux,code = <108>;
>   };
> 
>   back {
>   label = "Back";
> - gpios = <&gpx1 7 0 0 2>;
> + gpios = <&gpx1 7 0 0x1 2>;
>   linux,code = <158>;
>   };
> 
>   home {
>   label = "Home";
> - gpios = <&gpx1 6 0 0 2>;
> + gpios = <&gpx1 6 0 0x1 2>;
>   linux,code = <102>;
>   };
> 
>   menu {
>   label = "Menu";
> - gpios = <&gpx1 5 0 0 2>;
> + gpios = <&gpx1 5 0 0x1 2>;
>   linux,code = <139>;
>   };
>   };
> --
> 1.7.4.1

Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim , Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html