RE: [PATCH v3] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support

2012-11-19 Thread Kukjin Kim
Kukjin Kim wrote:
 
 Taehun Kim wrote:
 
  - The gpio routines are changed to use the gpio_request() functions from
comments of Vasily and Sylwester.
  - The mistake of adding a character by my email client automatically is
  fixed.
 
  Please review this patch and apply it if do not have any problems.
 
 
 Taehun,
 
 Above area is for adding comments like 'This patch adds WIZnet W5300E01
 board' because it will be remained in its git log and nobody want to see
 your old request in there. If any comments which are not related to
 changes just put it after '---' around your sign. It doesn't hurt your
 patch.
 
 And you need to update this against on for-next of my tree because some
 S3C2410 gpio APIs have been gone.(See the Sylwester's comments) Please re-
 send this.
 
Any updates on this?

K-Gene kg...@kernel.org

 
 
  Signed-off-by: Taehun Kim kth3...@gmail.com
  ---
   arch/arm/mach-s3c24xx/Kconfig |5 +
   arch/arm/mach-s3c24xx/Makefile|1 +
   arch/arm/mach-s3c24xx/mach-w5300e01.c |  193
  +
   3 files changed, 199 insertions(+)
   create mode 100644 arch/arm/mach-s3c24xx/mach-w5300e01.c
 
 [snip]

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH v3] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support

2012-09-19 Thread Kukjin Kim
Taehun Kim wrote:
 
 - The gpio routines are changed to use the gpio_request() functions from
   comments of Vasily and Sylwester.
 - The mistake of adding a character by my email client automatically is
 fixed.
 
 Please review this patch and apply it if do not have any problems.
 

Taehun,

Above area is for adding comments like 'This patch adds WIZnet W5300E01 board' 
because it will be remained in its git log and nobody want to see your old 
request in there. If any comments which are not related to changes just put it 
after '---' around your sign. It doesn't hurt your patch.

And you need to update this against on for-next of my tree because some S3C2410 
gpio APIs have been gone.(See the Sylwester's comments) Please re-send this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


 Signed-off-by: Taehun Kim kth3...@gmail.com
 ---
  arch/arm/mach-s3c24xx/Kconfig |5 +
  arch/arm/mach-s3c24xx/Makefile|1 +
  arch/arm/mach-s3c24xx/mach-w5300e01.c |  193
 +
  3 files changed, 199 insertions(+)
  create mode 100644 arch/arm/mach-s3c24xx/mach-w5300e01.c
  
[snip]

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html