Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration
On 8 April 2013 21:38, Doug Anderson wrote: > Thomas, > > Since I commented on previous versions of this patch, I would have > loved to have been CCed on this new version. ;) Hi Doug, Sorry for missing out on CC'ing you in the v3 patch. It just slipped my mind. > > On Fri, Apr 5, 2013 at 6:53 AM, Thomas Abraham > wrote: >> With device core now able to setup the default pin configuration, >> the pin configuration code based on the deprecated Samsung specific >> gpio bindings is removed. >> >> Signed-off-by: Thomas Abraham >> --- >> Changes since v2: >> - Changed patch subject from "mmc: dwmmc: let..." to "mmc: dw_mmc: let..." >> - Rebased to Chris's latest mmc-next branch. >> >> drivers/mmc/host/dw_mmc-exynos.c | 38 >> -- >> drivers/mmc/host/dw_mmc.c| 12 ++-- >> drivers/mmc/host/dw_mmc.h|3 --- >> 3 files changed, 2 insertions(+), 51 deletions(-) > > This patch applies fine but fails to compile on linux-next > "next-20130408". You lost the race with: >f2f942c mmc: dw_mmc: Check return value of regulator_enable > > ...that patch adds a "goto err_setup_bus" and you've renamed that > label. I guess you get another fun rebase. > > NOTE: this patch is even more urgent than it was before. It looks > like pincontrol stuff has now landed in linux-next which means that > Exynos5 devices that need eMMC/SD will no longer boot until this patch > goes in. Ok. I have posted the v4 version of this patch taking care of this. Thanks for pointing this out. Regards, Thomas. > > -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration
On 8 April 2013 17:49, Seungwon Jeon wrote: > On Friday, April 05, 2013, Thomas Abraham wrote: >> With device core now able to setup the default pin configuration, >> the pin configuration code based on the deprecated Samsung specific >> gpio bindings is removed. >> >> Signed-off-by: Thomas Abraham > Acked-by: Seungwon Jeon > > I hope that your another patch is merged. > ARM: dts: add pinctrl nodes for Exynos5250 SoC > I didn't check whether it is applied. Hi Seungwon, Thanks for your Ack. Yes, the pinctrl nodes for Exynos5250 have been merged through kgene's tree. Regards, Thomas. > > Thanks, > Seungwon Jeon > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration
Thomas, Since I commented on previous versions of this patch, I would have loved to have been CCed on this new version. ;) On Fri, Apr 5, 2013 at 6:53 AM, Thomas Abraham wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham > --- > Changes since v2: > - Changed patch subject from "mmc: dwmmc: let..." to "mmc: dw_mmc: let..." > - Rebased to Chris's latest mmc-next branch. > > drivers/mmc/host/dw_mmc-exynos.c | 38 > -- > drivers/mmc/host/dw_mmc.c| 12 ++-- > drivers/mmc/host/dw_mmc.h|3 --- > 3 files changed, 2 insertions(+), 51 deletions(-) This patch applies fine but fails to compile on linux-next "next-20130408". You lost the race with: f2f942c mmc: dw_mmc: Check return value of regulator_enable ...that patch adds a "goto err_setup_bus" and you've renamed that label. I guess you get another fun rebase. NOTE: this patch is even more urgent than it was before. It looks like pincontrol stuff has now landed in linux-next which means that Exynos5 devices that need eMMC/SD will no longer boot until this patch goes in. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3] mmc: dw_mmc: let device core setup the default pin configuration
On Friday, April 05, 2013, Thomas Abraham wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham Acked-by: Seungwon Jeon I hope that your another patch is merged. ARM: dts: add pinctrl nodes for Exynos5250 SoC I didn't check whether it is applied. Thanks, Seungwon Jeon -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
