On Tue, Aug 21, 2012 at 10:48:43AM -0400, Chris Ball wrote:
Aside: the bindings do not match the code. The bindings document says
to use fsl,cd-internal, and imx51-babbage.dts does so -- but the code
doesn't check for fsl,cd-internal, it checks for fsl,cd-controller:
if
Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
(
if@p1 (\(ret 0\|ret != 0\))
{ ...
Mandeep Singh Baines wrote:
From 0cdf3aff, ARM: SAMSUNG: use spin_lock_irqsave() in
clk_{enable,disable}:
The clk_enable()and clk_disable() can be used process and ISR either.
And actually it is used for real product and other platforms use it
now. So spin_lock_irqsave() should be
Hi,
On Wed, Aug 22 2012, Shawn Guo wrote:
The following is what I have on my mind.
broken-cd cd-gpiosimplication
---
nono SDHCI CD
noyes GPIO CD
yes no NO CD / Broken
On 22 August 2012 15:47, Chris Ball c...@laptop.org wrote:
Hi,
On Wed, Aug 22 2012, Shawn Guo wrote:
The following is what I have on my mind.
broken-cd cd-gpiosimplication
---
nono SDHCI CD
noyes
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
This matches Mitch's last suggestion exactly -- I think we're all agreed
on these properties now. The only remaining question is how to handle
the pinctrl for CD in Thomas's case.
Hi Chris,
For sdhci-s3c driver, the 'broken-cd' and
On Wed, Aug 22, 2012 at 06:38:36PM +0900, Kukjin Kim wrote:
Julia Lawall wrote:
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Acked-by: Kukjin Kim kgene@samsung.com
(Cc'ed Mark Brown who is handling spi for a moment)
Please resend the patch to me so I can apply this.
From: Julia Lawall julia.law...@lip6.fr
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
(
if@p1 (\(ret 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when
On 22 August 2012 16:38, Chris Ball c...@laptop.org wrote:
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
This matches Mitch's last suggestion exactly -- I think we're all agreed
on these properties now. The only remaining question is how to handle
the pinctrl for CD in Thomas's
Hi Chris,
On Tue, Aug 21, 2012 at 10:48:43AM -0400, Chris Ball wrote:
Aside: the bindings do not match the code. The bindings document says
to use fsl,cd-internal, and imx51-babbage.dts does so -- but the code
doesn't check for fsl,cd-internal, it checks for fsl,cd-controller:
if
Hi Shawn,
On Wed, Aug 22 2012, Shawn Guo wrote:
mmc: sdhci: Always pass clock request value zero to set_clock host op
To allow the set_clock host op to disable the SDCLK source when not
needed, always call the host op when the requested clock speed is
zero. Do this even if
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
none - currently samsung,sdhci-cd-internal
broken-cd - currently samsung,sdhci-cd-none
cd-gpios - currently samsung,sdhci-cd-gpios
non-removable - currently samsung,sdhci-cd-permanent
cd-gpios + samsung,sdhci-cd-external
On 08/22/2012 04:17 AM, Chris Ball wrote:
Hi,
On Wed, Aug 22 2012, Shawn Guo wrote:
The following is what I have on my mind.
broken-cdcd-gpiosimplication
---
no no SDHCI CD
no yes GPIO CD
Hi Stephen,
On Wed, Aug 22 2012, Stephen Warren wrote:
On 08/22/2012 04:17 AM, Chris Ball wrote:
Hi,
On Wed, Aug 22 2012, Shawn Guo wrote:
The following is what I have on my mind.
broken-cd cd-gpiosimplication
---
no no
On 22 August 2012 20:24, Chris Ball c...@laptop.org wrote:
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
none - currently samsung,sdhci-cd-internal
broken-cd - currently samsung,sdhci-cd-none
cd-gpios - currently samsung,sdhci-cd-gpios
non-removable - currently
On Wed, Aug 22, 2012 at 01:42:47PM +0200, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Initialize return variable before exiting on an error path.
Applied, thanks.
signature.asc
Description: Digital signature
Hi Thomas,
On 8/22/2012 2:04 AM, Thomas Abraham wrote:
On 22 August 2012 16:38, Chris Ball c...@laptop.org wrote:
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
This matches Mitch's last suggestion exactly -- I think we're all agreed
on these properties now. The only remaining
Signed-off-by: Chris Ball c...@laptop.org
---
Documentation/devicetree/bindings/mmc/mmc.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt
b/Documentation/devicetree/bindings/mmc/mmc.txt
index 8a6811f..8e2e0ba 100644
---
Guenter Roeck wrote:
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause
subsequent
module unload attempts to fail. Drop the calls.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Kukjin Kim
19 matches
Mail list logo
