Re: [PATCH V4 2/2] video: drm: exynos: Add device tree support

2012-09-07 Thread Inki Dae
Hi 2012/9/7 Leela Krishna Amudala l.kris...@samsung.com: Hi, On Thu, Sep 6, 2012 at 4:35 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 09/06/2012 09:21 AM, InKi Dae wrote: +Required properties: + - compatible: Should be samsung,exynos5-fimd or samsung,exynos4-fb for

[PATCH] ARM: SAMSUNG: Use spin_lock_{irqsave,irqrestore} in clk_set_rate

2012-09-07 Thread Tushar Behera
The spinlock clocks_lock can be held during ISR, hence it is not safe to hold that lock with disabling interrupts. It fixes following potential deadlock. = [ INFO: possible irq lock inversion dependency detected ] 3.6.0-rc4+ #2 Not tainted

RE: [PATCH] ARM: SAMSUNG: Fix HDMI related warnings

2012-09-07 Thread Kukjin Kim
Sachin Kamat wrote: Silences the following warnings: arch/arm/plat-samsung/devs.c:765:31: warning: symbol 's5p_hdmi_def_platdata' was not declared. Should it be static? arch/arm/plat-samsung/devs.c:767:13: warning: symbol 's5p_hdmi_set_platdata' was not declared. Should it be static?

Re: [PATCH v5 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-09-07 Thread Thomas Abraham
Hi Jaehoon, Thanks for reviewing the patch. On 5 September 2012 14:00, Jaehoon Chung jh80.ch...@samsung.com wrote: On 09/05/2012 04:46 AM, Thomas Abraham wrote: Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock

[PATCH 0/2] DMA: PL330: Clock and runtime cleanup

2012-09-07 Thread Inderpal Singh
The controller clock is being managed at AMBA bus level probe/remove and pm_runtime/suspend functions. The existing driver does the clock enable/disable again in the same code paths, which unneccessarily increments the usage count of the clock for the same device. The following patches remove

[PATCH 1/2] DMA: PL330: Remove controller clock enable/disable

2012-09-07 Thread Inderpal Singh
The controller clock is being enabled/disabled in AMBA bus infrastructre in probe/remove functions. Hence, its not required at driver level probe/remove. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org --- drivers/dma/pl330.c | 12 1 file changed, 12 deletions(-) diff

[PATCH 2/2] DMA: PL330: Remove redundant runtime_suspend/resume functions

2012-09-07 Thread Inderpal Singh
The driver's runtime_suspend/resume functions just disable/enable the clock which is already being managed at AMBA bus level runtime_suspend/resume functions. Hence, remove the driver's runtime_suspend/resume functions. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org ---

Re: [PATCH V4 2/2] video: drm: exynos: Add device tree support

2012-09-07 Thread Inki Dae
2012/9/7 Inki Dae inki@samsung.com: Hi 2012/9/7 Leela Krishna Amudala l.kris...@samsung.com: Hi, On Thu, Sep 6, 2012 at 4:35 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 09/06/2012 09:21 AM, InKi Dae wrote: +Required properties: + - compatible: Should be

Re: [PATCH V5 0/2] video: drm: Add Device tree support to DRM-FIMD

2012-09-07 Thread Inki Dae
Applied. Thanks. Inki Dae 2012/9/7 Leela Krishna Amudala l.kris...@samsung.com: This patch set adds device tree support for DRM-FIMD for Samsung's Exynos5250. It includes parsing platform data from dts file. Also, adds the driver data for exynos4 and exynos5 devices. This patchset is based

Re: [PATCH v5 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-09-07 Thread Thomas Abraham
Hi Seungwon, Thanks for reviewing the patch. On 5 September 2012 16:13, Seungwon Jeon tgih@samsung.com wrote: On Wednesday, September 05, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: Version 6 is right? Samsung Exynos SoC's extend the dw-mshc controller for additional clock

[PATCH 1/2] ARM: samsung: clock: add clock_tree debugfs file

2012-09-07 Thread 최종환
From: Colin Cross ccr...@android.com Add a clock/clock_tree debugfs file that shows the entire clock hierarchy including usage counts and rates. Signed-off-by: Colin Cross ccr...@android.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- arch/arm/plat-samsung/clock.c | 65

[PATCH 2/2] ARM: samsung: call clk_get_rate for debugfs rate files

2012-09-07 Thread 최종환
From: Colin Cross ccr...@android.com c-rate is rarely set, call clk_get_rate on the clock to print the value in /d/clock/.../rate. Signed-off-by: Colin Cross ccr...@android.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- arch/arm/plat-samsung/clock.c | 10 +- 1 files

Re: [PATCH v2] gpio: samsung: add devicetree init for s3c24xx arches

2012-09-07 Thread Heiko Stübner
Am Freitag, 7. September 2012, 07:38:52 schrieb Kukjin Kim: Heiko Stübner wrote: Until now the Exynos-SoC was the only Samsung-SoC supporting the GPIOs via the device tree. This patch implements dt-support for the s3c24xx arches. The controllers contain only 3 cells, as the underlying

[PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen

2012-09-07 Thread Sachin Kamat
Commit: f447ed8b31d (gpio: samsung: add flags specifier to device-tree binding) adds a flag to represent active low state for gpio line. Since gpio-keys on Origen board are active low, using this flag to represent the same. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Reviewed-by: Thomas

[PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen

2012-09-07 Thread Sachin Kamat
Adds heartbeat gpio-leds support to Origen board. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos4210-origen.dts |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-origen.dts

[PATCH v5 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-09-07 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com Signed-off-by: Thomas

[PATCH v5 8/9] mmc: dw_mmc: add support for implementation specific callbacks

2012-09-07 Thread Thomas Abraham
The core dw-mshc controller driver can let platform specific implementations of the dw-mshc controller to control the hardware as required by such implementations. This is acheived by invoking implementation specific (optional) callbacks. Define the list of callbacks supported the add invocation

[PATCH v5 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-09-07 Thread Thomas Abraham
Samsung Exynos SoC's extend the dw-mshc controller for additional clock and bus control. Add support for these extensions and include provide device tree based discovery suppory as well. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Will Newton will.new...@imgtec.com ---

[PATCH v4 3/3] ARM: dts: Add nodes for dw_mmc controllers for Samsung Exynos5250 platforms

2012-09-07 Thread Thomas Abraham
Add device nodes for the four instances of dw_mmc controllers in Exynos5250 and enable instance 0 and 2 for the smdk5250 board. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 57 +

RE: [PATCH v5 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-09-07 Thread Seungwon Jeon
On Friday, September 07, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: Hi Seungwon, Thanks for reviewing the patch. On 5 September 2012 16:13, Seungwon Jeon tgih@samsung.com wrote: On Wednesday, September 05, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: Version 6

Re: [PATCH v5 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-09-07 Thread Thomas Abraham
On 7 September 2012 16:21, Seungwon Jeon tgih@samsung.com wrote: On Friday, September 07, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: Hi Seungwon, Thanks for reviewing the patch. On 5 September 2012 16:13, Seungwon Jeon tgih@samsung.com wrote: On Wednesday, September

Re: [PATCH 1/2] ARM: samsung: clock: add clock_tree debugfs file

2012-09-07 Thread Sylwester Nawrocki
Hi, On 09/07/2012 09:20 AM, 최종환 wrote: From: Colin Crossccr...@android.com Add a clock/clock_tree debugfs file that shows the entire clock hierarchy including usage counts and rates. Signed-off-by: Colin Crossccr...@android.com Signed-off-by: Jonghwan Choijhbird.c...@samsung.com Due to

RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen

2012-09-07 Thread Kukjin Kim
Sachin Kamat wrote: Commit: f447ed8b31d (gpio: samsung: add flags specifier to device-tree binding) adds a flag to represent active low state for gpio line. Since gpio-keys on Origen board are active low, using this flag to represent the same. Signed-off-by: Sachin Kamat

RE: [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen

2012-09-07 Thread Kukjin Kim
Sachin Kamat wrote: Adds heartbeat gpio-leds support to Origen board. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos4210-origen.dts |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-origen.dts

RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen

2012-09-07 Thread Kukjin Kim
Kukjin Kim wrote: Sachin Kamat wrote: Commit: f447ed8b31d (gpio: samsung: add flags specifier to device-tree binding) adds a flag to represent active low state for gpio line. Since gpio-keys on Origen board are active low, using this flag to represent the same. Signed-off-by:

RE: [PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-09-07 Thread Kukjin Kim
Tomasz Figa wrote: This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board. Well...I'm not sure about the status of Origen serial, but all of the serials are enabled on SMDKV310, is it right? Thanks. Best regards, Kgene. -- Kukjin Kim

RE: [PATCH v2 2/5] ARM: Exynos4: dts: Specify address and size cells for i2c controllers

2012-09-07 Thread Kukjin Kim
Thomas Abraham wrote: On 4 September 2012 14:20, Tomasz Figa t.f...@samsung.com wrote: Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 16 1 file changed, 16 insertions(+)

RE: [PATCH v2 3/5] ARM: Exynos4: Add OF compatibility lookups for Exynos4 i2c adapters

2012-09-07 Thread Kukjin Kim
Thomas Abraham wrote: On 4 September 2012 14:20, Tomasz Figa t.f...@samsung.com wrote: Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-exynos4-dt.c | 14 ++ 1 file changed, 14 insertions(+)

RE: [PATCH v2 4/5] ARM: EXYNOS: Increase maximum possible memory bank size to 512MiB

2012-09-07 Thread Kukjin Kim
Tomasz Figa wrote: Some boards have larger memory banks than 256MiB. This patch increses maximum bank size for Exynos-based boards to 512MiB. Well...the meaning of SECTION_SIZE_BITS is a little bit different you know. Please refer to following thread.

RE: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-07 Thread Kukjin Kim
Tomasz Figa wrote: Hi, Thanks for reviewing the patch. On Wednesday 05 of September 2012 09:35:49 Thomas Abraham wrote: + + memory { + reg = 0x4000 0x2000 + 0x6000 0x2000; + }; Why does this have to be

RE: [PATCH 0/3] ARM: dts: Exynos4 dts reorganization

2012-09-07 Thread Kukjin Kim
Thomas Abraham wrote: On 3 September 2012 18:04, Tomasz Figa t.f...@samsung.com wrote: This patch series prepares existing Exynos4210 DT infrastructure to be further extended for new SoCs from Exynos4 line and new boards. Tomasz Figa (3): ARM: dts: Move parts common to Exynos4 from