[PATCH 2/3] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-09-25 Thread Inderpal Singh
In probe, memory for multiple DMA descriptors were being allocated at once and then it was being split and added into DMA pool one by one. The address of this memory allocation is not being saved anywhere. To free this memory, the address is required. Initially the first node of the pool will be

[PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-25 Thread Inderpal Singh
Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org --- drivers/dma/pl330.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff

[PATCH 0/3] DMA: PL330: Fix mem leaks and balance probe/remove

2012-09-25 Thread Inderpal Singh
The first 2 patches of this series fix memory leaks because the memory allocated for peripheral channels and DMA descriptors were not getting freed. The third patch balances the module's remove function. This patchset is based on slave-dma tree's next branch merged with fixes branch and applied

[PATCH 1/3] DMA: PL330: Free memory allocated for peripheral channels

2012-09-25 Thread Inderpal Singh
The allocated memory for peripheral channels is not being freed upon failure in probe and in module's remove funtion. It will lead to memory leakage. Hence free the allocated memory. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org --- drivers/dma/pl330.c |5 - 1 file changed, 4

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-25 Thread Praveen Paneri
Hi Rob, On Mon, Sep 24, 2012 at 6:34 PM, Rob Herring robherri...@gmail.com wrote: On 09/17/2012 07:54 AM, Praveen Paneri wrote: This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable phy. Tested with smdk6410 and smdkv310.

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-25 Thread Marc Kleine-Budde
On 09/24/2012 11:38 AM, Praveen Paneri wrote: Hi Kishon, Felipe, Any further comments on these patches? Can they be merged now? One nitpick inline. Marc Thanks, Praveen On Mon, Sep 17, 2012 at 6:24 PM, Praveen Paneri p.pan...@samsung.com wrote: This driver uses usb_phy interface to

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-25 Thread Laurent Pinchart
On Monday 24 September 2012 21:35:46 Inki Dae wrote: 2012/9/22 Stephen Warren swar...@wwwdotorg.org: On 09/21/2012 01:22 AM, Inki Dae wrote: 2012/9/21 Stephen Warren swar...@wwwdotorg.org: On 09/21/2012 05:22 AM, Leela Krishna Amudala wrote: This patch adds device tree based discovery

Re: [PATCH 2/3] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: In probe, memory for multiple DMA descriptors were being allocated at once and then it was being split and added into DMA pool one by one. The address of this memory allocation is not being saved anywhere. To free

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org ---

Re: [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 25, 2012 at 5:48 PM, Rob Herring robherri...@gmail.com wrote: On 09/25/2012 06:23 AM, Praveen Paneri wrote: Hi Rob, On Mon, Sep 24, 2012 at 6:34 PM, Rob Herring robherri...@gmail.com wrote: On 09/17/2012 07:54 AM, Praveen Paneri wrote: This driver uses usb_phy interface to

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-25 Thread Inki Dae
2012/9/25 Laurent Pinchart laurent.pinch...@ideasonboard.com: On Monday 24 September 2012 21:35:46 Inki Dae wrote: 2012/9/22 Stephen Warren swar...@wwwdotorg.org: On 09/21/2012 01:22 AM, Inki Dae wrote: 2012/9/21 Stephen Warren swar...@wwwdotorg.org: On 09/21/2012 05:22 AM, Leela Krishna

Re: [PATCH 1/3] DMA: PL330: Free memory allocated for peripheral channels

2012-09-25 Thread Inderpal Singh
On 25 September 2012 18:17, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: The allocated memory for peripheral channels is not being freed upon failure in probe and in module's remove funtion. It will lead to memory

Re: [PATCH 2/3] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-09-25 Thread Inderpal Singh
On 25 September 2012 18:39, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: In probe, memory for multiple DMA descriptors were being allocated at once and then it was being split and added into DMA pool one by one. The

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-25 Thread Mark Brown
On Wed, Sep 26, 2012 at 12:03:44AM +0900, Inki Dae wrote: 2012/9/25 Laurent Pinchart laurent.pinch...@ideasonboard.com: Aren't DT bindings considered as an ABI, and required to be supported more or less forever ? If you merge this DT binding you'll have to keep supporting it. That's

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 03:37 AM, Tomasz Figa wrote: Hi Stephen, On Monday 24 of September 2012 17:14:38 Stephen Warren wrote: On 09/24/2012 03:31 PM, Tomasz Figa wrote: On Monday 24 of September 2012 11:42:15 Stephen Warren wrote: On 09/21/2012 01:54 PM, Tomasz Figa wrote: On Friday 21 of September

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 11:41 AM, Tomasz Figa wrote: On Tuesday 25 of September 2012 10:49:11 Stephen Warren wrote: On 09/25/2012 03:37 AM, Tomasz Figa wrote: Hi Stephen, On Monday 24 of September 2012 17:14:38 Stephen Warren wrote: On 09/24/2012 03:31 PM, Tomasz Figa wrote: On Monday 24 of September

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 12:35 PM, Tomasz Figa wrote: On Tuesday 25 of September 2012 12:22:03 Stephen Warren wrote: ... BTW, how does the driver know what register addresses to use; I can see the base for each pin controller bank is in samsung,pctl-offset, but what describes the offset for each of the

RE: [PATCH v4 0/3] ARM: Exynos: Add support for MSHC controller

2012-09-25 Thread Kukjin Kim
Thomas Abraham wrote: This patch series adds Exynos5250 platform support for MSHC controllers. Thomas Abraham (3): ARM: Samsung: Add support for MSHC controller clocks ARM: Exynos5: Add AUXDATA support for MSHC controllers ARM: dts: Add nodes for dw_mmc controllers for Samsung

RE: [PATCH v4] ARM: EXYNOS: Add MFC device tree support

2012-09-25 Thread Kukjin Kim
Karol Lewandowski wrote: On 09/22/2012 08:07 PM, Arun Kumar K wrote: This patch adds device tree entry for MFC v6 in the Exynos5 SoC. Makes the required changes in the clock files and adds MFC to the DT device list. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-25 Thread Inki Dae
2012/9/26 Mark Brown broo...@opensource.wolfsonmicro.com: On Wed, Sep 26, 2012 at 12:03:44AM +0900, Inki Dae wrote: 2012/9/25 Laurent Pinchart laurent.pinch...@ideasonboard.com: Aren't DT bindings considered as an ABI, and required to be supported more or less forever ? If you merge this