Re: [PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-10-18 Thread Venkatraman S
On Wednesday 17 October 2012 05:23 PM, Vinayak Holikatti wrote: This patch seggregates the PCI specific code in ufshcd.c to make it ready for splitting into core ufs driver and PCI glue driver. Also copyright header modification to remove extra warranty disclaim. Reviewed-by: Arnd Bergmann

Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-18 Thread Nicolas Ferre
On 10/17/2012 11:33 PM, Russell King - ARM Linux : On Wed, Oct 17, 2012 at 11:28:48PM +0300, Phil Carmody wrote: So, what to do? It can and has been used sensibly, so I don't think removing it is the best option. Well, the first thing that needs to be done is a full review of every user and

[PATCH] ARM: SAMSUNG: use devm_ functions for ADC driver

2012-10-18 Thread Eunki Kim
This patch uses devm_* functions for probe function in ADC driver. It reduces code size and simplifies the code. Signed-off-by: Eunki Kim eunki_...@samsung.com --- arch/arm/plat-samsung/adc.c | 48 +++--- 1 files changed, 13 insertions(+), 35 deletions(-)

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-10-18 Thread Heiko Stübner
Hi, Am Donnerstag, 18. Oktober 2012, 04:04:42 schrieb Jaehoon Chung: Sorry, i didn't check this patch with s3c2416. (i didn't have the s3c2416 board.) If you have a problem, i think good that revert this patch for fixing your problem. Also, i will check and share the result. After looking a

RE: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-10-18 Thread Seungwon Jeon
On Thursday, October 18, 2012, Heiko Stübner he...@sntech.de wrote: Hi, Am Donnerstag, 18. Oktober 2012, 04:04:42 schrieb Jaehoon Chung: Sorry, i didn't check this patch with s3c2416. (i didn't have the s3c2416 board.) If you have a problem, i think good that revert this patch for fixing

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-10-18 Thread Heiko Stübner
Am Donnerstag, 18. Oktober 2012, 11:36:03 schrieb Seungwon Jeon: On Thursday, October 18, 2012, Heiko Stübner he...@sntech.de wrote: Hi, Am Donnerstag, 18. Oktober 2012, 04:04:42 schrieb Jaehoon Chung: Sorry, i didn't check this patch with s3c2416. (i didn't have the s3c2416 board.)

Re: [PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-10-18 Thread vinayak holikatti
On Thu, Oct 18, 2012 at 12:13 PM, Venkatraman S svenk...@ti.com wrote: On Wednesday 17 October 2012 05:23 PM, Vinayak Holikatti wrote: This patch seggregates the PCI specific code in ufshcd.c to make it ready for splitting into core ufs driver and PCI glue driver. Also copyright header

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-18 Thread Sachin Kamat
On 17 October 2012 21:27, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 10/17/2012 05:35 PM, Sachin Kamat wrote: Most of the s5p-* drivers have already added support for clk_(un)prepare. Thus most of your changes in this patch are not needed. I seem to have only missed fimc-mdevice.c,