Re: [PATCH] spi: s3c64xx: Add fix for crash in spi suspend/resume

2012-11-07 Thread Mark Brown
On Wed, Nov 07, 2012 at 11:40:12AM +0530, Naveen Krishna Chatradhi wrote: From: Abhilash Kesavan a.kesa...@samsung.com The SPI driver makes a gpio_request during initialization. The requested gpios need to be populated as part of the s3c64xx_spi_driver_data so that they can be released

[PATCH 1/1] ARM: EXYNOS: Make combiner_of_init function static

2012-11-07 Thread Sachin Kamat
Silences the following warning: arch/arm/mach-exynos/common.c:576:12: warning: symbol 'combiner_of_init' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/common.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[PATCH 1/1] ARM: EXYNOS: Add missing static storage class specifiers in clock-exynos5.c

2012-11-07 Thread Sachin Kamat
Fixes the following warnings: arch/arm/mach-exynos/clock-exynos5.c:300:19: warning: symbol 'exynos5_clk_mout_mpll' was not declared. Should it be static? arch/arm/mach-exynos/clock-exynos5.c:475:12: warning: symbol 'exynos5_clkset_aclk_top_list' was not declared. Should it be static?

[PATCH] i2c: samsung: resume race fix

2012-11-07 Thread Naveen Krishna Chatradhi
Don't unmark the device as suspended until after it's been re-setup. The main race would be w.r.t. an i2c driver that gets resumed at the same time (asyncronously), that is allowed to do a transfer since suspended is set to 0 before reinit, but really should have seen the -EIO return instead.

Re: [PATCH] i2c: samsung: resume race fix

2012-11-07 Thread Jean Delvare
On Wed, 07 Nov 2012 15:58:26 +0530, Naveen Krishna Chatradhi wrote: Don't unmark the device as suspended until after it's been re-setup. The main race would be w.r.t. an i2c driver that gets resumed at the same time (asyncronously), that is allowed to do a transfer since suspended is set to

Re: [PATCH] ARM: Fix the WFI instruction opcode definition.

2012-11-07 Thread Catalin Marinas
On 6 November 2012 11:24, Kukjin Kim kgene@samsung.com wrote: BTW, if mach-exynos includes ARMv8 later?...ARMv8 platform codes will be put in the arch/arm/ or arch/arm/64/ if some platform codes share with ARMv7? Just wondering... If mach-exynos would support ARMv8 at some point, I would

[PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0

2012-11-07 Thread Tomasz Figa
This patch removes compatibility definitions added long time ago when clock ids were used instead of devnames that were needed for platforms with only one i2c controller with id -1 (some s3c24xx's). Because currently devname field is used for matching device instances to clocks and if no devname

[PATCH] ARM: EXYNOS: origen: Add missing USB regulators

2012-11-07 Thread Tomasz Figa
This patch adds missing USB OTG regulators needed for s3c-hsotg driver to work on Origen board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-origen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Vivek Gautam
Hi, On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Vivek Gautam
Hi, On Wed, Nov 7, 2012 at 5:10 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi, I have a few comments. Please see below... On 11/06/2012 04:36 PM, Vivek Gautam wrote: Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. exynso - exynos Sure, will

Re: [PATCH] ARM: EXYNOS: origen: Add missing USB regulators

2012-11-07 Thread Tomasz Figa
On Wednesday 07 of November 2012 14:01:19 Tomasz Figa wrote: This patch adds missing USB OTG regulators needed for s3c-hsotg driver to work on Origen board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH] ARM: dts: exynos4: Add support for Exynos4x12 SoCs

2012-11-07 Thread Tomasz Figa
Hi Kgene, On Wednesday 07 of November 2012 11:26:42 Kukjin Kim wrote: Kukjin Kim wrote: Tomasz Figa wrote: This patch adds device tree sources for Exynos4x12 SoC series (currently Exynos4212 and Exynos4412) and enables mach-exynos4-dt to support these SoCs. Signed-off-by:

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Felipe Balbi
Hi, On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: Hi, On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: Adding DWC3 device tree node for Exynos5250 along with the device address and clock

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Tomasz Figa
Hi Vivek, Felipe, On Wednesday 07 of November 2012 18:43:22 Felipe Balbi wrote: Hi, On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: Hi, On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote:

Re: [PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0

2012-11-07 Thread Sylwester Nawrocki
On 11/07/2012 02:00 PM, Tomasz Figa wrote: This patch removes compatibility definitions added long time ago when clock ids were used instead of devnames that were needed for platforms with only one i2c controller with id -1 (some s3c24xx's). Because currently devname field is used for matching

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Sylwester Nawrocki
On 11/07/2012 02:35 PM, Vivek Gautam wrote: @@ -180,10 +273,12 @@ enum samsung_cpu_type { /* * struct samsung_usbphy - transceiver driver state * @phy: transceiver structure + * @phy3: transceiver structure for USB 3.0 * @plat: platform data * @dev: The parent device supplied

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-07 Thread Sylwester Nawrocki
On 11/06/2012 10:34 PM, Andrey Gusakov wrote: Hi. Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Work! I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h It use significantly different init sequence. Some of settings described in Application note for ov9650,

[PATCH 1/2] ARM: S3C24XX: Add clkdev entry for camif-upll clock

2012-11-07 Thread Sylwester Nawrocki
The s3c-camif driver uses camera clock conn_id for the camif-upll (s3c244x) and camera (s3c64xx) platform clock. By adding this new clkdev entry the platform differences are isolated from the driver. Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com ---

[PATCH 2/2] ARM: S3C64XX: Statically define parent clock of the camera clock

2012-11-07 Thread Sylwester Nawrocki
The camera clock defined in arch/arm/mach-s3c64xx/clock.c has null clock source mux control register as it can have only one parent clock. In such cases there is a need to configure the parent clock statically, otherwise s3c_set_clksrc() bails out with an error message no parent clock specified

Re: [PATCH] ARM: SAMSUNG: Fix typo in definition of VIDCON1_VSTATUS_FRONTPORCH value

2012-11-07 Thread Jingoo Han
On Wednesday, November 07, 2012 9:31 PM Jingoo Han wrote The correct value for VIDCON1_VSTATUS_FRONTPORCH is 3, not 0. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com According to the datasheet, 3 is right value. Acked-by: Jingoo Han

[PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-07 Thread Amit Daniel Kachhap
This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly jump to the upper or lower cooling level instead of incremental increase or decrease. This is needed for temperature sensors which support rising/falling

[PATCH 0/4] thermal: Add support for interrupt based notification to thermal layer

2012-11-07 Thread Amit Daniel Kachhap
The patch submitted by Jonghwa Lee (https://patchwork.kernel.org/patch/1683441/) adds support for interrupt based notification to thermal layer. This is a good feature but the current thermal framework needs polling/regular notification for invoking suitable cooling action. So adding 2 new thermal

[PATCH 2/4] Thermal: exynos: Add support for temperature falling interrupt.

2012-11-07 Thread Amit Daniel Kachhap
From: Jonghwa Lee jonghwa3@samsung.com This patch introduces using temperature falling interrupt in exynos thermal driver. Former patch, it only use polling way to check whether if system themperature is fallen. However, exynos SOC also provides temperature falling interrupt way to do same

[PATCH 3/4] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

2012-11-07 Thread Amit Daniel Kachhap
Below fixes are done to support falling threshold interrupt, * Falling interrupt status macro corrected according to exynos5 data sheet. * The get trend function modified to calculate trip temperature correctly. * The clearing of interrupt status in the isr is now done after handling the the

RE: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC

2012-11-07 Thread Kukjin Kim
Bartlomiej Zolnierkiewicz wrote: Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address can fix the problem you commented on EXYNOS4210 Rev0 without others?... The problem is affecting only EXYNOS4210 Rev0 and the fix is applied only for case when soc_is_exynos4210()

RE: [PATCH] ARM: EXYNOS5: Remove wrongly placed usb2.0 PHY_CFG definition from PMU_REG

2012-11-07 Thread Kukjin Kim
Jingoo Han wrote: On Friday, October 05, 2012 10:27 PM Vivek Gautam wrote EXYNOS5_USB_CFG macro should actually point to USB20PHY_CFG system register (base addr + 0x230). It's wrongly placed in regs-pmu. Actual register at offset 0x230 in PMU is SEQ_TRANSITION4. Signed-off-by: Vivek

RE: [PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0

2012-11-07 Thread Kukjin Kim
Sylwester Nawrocki wrote: On 11/07/2012 02:00 PM, Tomasz Figa wrote: This patch removes compatibility definitions added long time ago when clock ids were used instead of devnames that were needed for platforms with only one i2c controller with id -1 (some s3c24xx's). Because currently

RE: [PATCH] ARM: dts: exynos4: Add support for Exynos4x12 SoCs

2012-11-07 Thread Kukjin Kim
Tomasz Figa wrote: [...] +/include/ exynos4x12-pinctrl.dtsi BTW, I think, above line should be added when exynos4x12-pinctrl patches applied. Yes, you are right. Seems like a rebase error on my side. Can you fix it or should I send a fixed version? I did, thanks ;-) Best

RE: [PATCH 1/1] ARM: EXYNOS: Make combiner_of_init function static

2012-11-07 Thread Kukjin Kim
Sachin Kamat wrote: Silences the following warning: arch/arm/mach-exynos/common.c:576:12: warning: symbol 'combiner_of_init' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/common.c |3 ++- 1 files changed, 2

RE: [PATCH 1/1] ARM: EXYNOS: Add missing static storage class specifiers in clock-exynos5.c

2012-11-07 Thread Kukjin Kim
Sachin Kamat wrote: Fixes the following warnings: arch/arm/mach-exynos/clock-exynos5.c:300:19: warning: symbol 'exynos5_clk_mout_mpll' was not declared. Should it be static? arch/arm/mach-exynos/clock-exynos5.c:475:12: warning: symbol 'exynos5_clkset_aclk_top_list' was not declared. Should

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-07 Thread Vivek Gautam
Hi, On Wed, Nov 7, 2012 at 10:48 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Felipe, On Wednesday 07 of November 2012 18:43:22 Felipe Balbi wrote: Hi, On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: Hi, On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi

RE: [PATCH 2/2] ARM: EXYNOS: change the name of USB ohci header

2012-11-07 Thread Kukjin Kim
Jingoo Han wrote: This patch changes the name of USB ohci header from 'usb-exynos.h' to 'usb-ohci-exynos.h'. This is because this header file has the platdata for only Exynos ohci. Signed-off-by: Jingoo Han jg1@samsung.com --- arch/arm/mach-exynos/dev-ohci.c|

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-07 Thread Zhang Rui
On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly jump to the upper or lower cooling level instead of incremental increase or decrease.

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-07 Thread Amit Kachhap
On 8 November 2012 11:31, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly jump to the upper or

[PATCH v2 0/2] Enable ehci and ohci devices for exynos5250

2012-11-07 Thread Vivek Gautam
Changes from v1: - Changed the device node names from 'ehci' and 'ohci' to 'usb@1211' and 'usb@1212' as per discussion for the change 'http://www.spinics.net/lists/linux-usb/msg73993.html' - Rebased on for-next branch of linux-samsung. Vivek Gautam (2): ARM: Exynos5250: Enabling

[PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-11-07 Thread Vivek Gautam
Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com --- .../devicetree/bindings/usb/exynos-usb.txt | 25