Re: [PATCH 09/16] iommu/tegra-smmu: Make use of domain_alloc and domain_free

2015-03-27 Thread Thierry Reding
On Thu, Mar 26, 2015 at 01:43:12PM +0100, Joerg Roedel wrote: From: Joerg Roedel jroe...@suse.de Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel jroe...@suse.de --- drivers/iommu/tegra-smmu.c | 41

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-27 Thread Thierry Reding
On Thu, Mar 26, 2015 at 01:43:03PM +0100, Joerg Roedel wrote: Changes v1-v2: * Rebased to v4.0-rc5 * Converted domain-types to a bit-field Hi, here is patch-set to replace the existing domain_init and domain_destroy iommu-ops with the new domain_alloc and domain_free

Re: [PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

2015-03-27 Thread Javier Martinez Canillas
Hello Inki, On Fri, Mar 27, 2015 at 2:47 AM, Inki Dae inki@samsung.com wrote: Right, this is not documented but if you have ever checked exynos drm driver tree, then I think you could know how we use the prefix. Of course, I don't like to force the use of this prefix but if you and other

Re: [PATCH v2] ARM: EXYNOS: Fix failed second suspend on Exynos4

2015-03-27 Thread Krzysztof Kozlowski
Dear Kukjin, How would you like to proceed? You did not respond to my email nor to Bartlomiej's questions. You questioned the soc_is_exynos(). I replied but there was no answer from you. My last reply: 2015-03-18 9:57 GMT+01:00 Krzysztof Kozlowski k.kozlow...@samsung.com: Probably

[RESEND PATCH 2/2] ARM: EXYNOS: Handle of_find_device_by_node and kstrdup failures

2015-03-27 Thread Krzysztof Kozlowski
Prevent possible NULL pointer dereference of pointer returned by of_find_device_by_node(). Handle this by skipping such power domain. Additionally fail the init on kstrdup() failure. Such case is actually not fatal because the name for power domain allocated by kstrdup() is used only in printk.

[RESEND PATCH 1/2] ARM: EXYNOS: Handle of of_iomap() failure

2015-03-27 Thread Krzysztof Kozlowski
Prevent possible NULL pointer dereference if of_iomap() fails. Handle the error by skipping such power domain. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos/pm_domains.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 10/16] iommu/tegra-gart: Make use of domain_alloc and domain_free

2015-03-27 Thread Thierry Reding
On Thu, Mar 26, 2015 at 01:43:13PM +0100, Joerg Roedel wrote: From: Joerg Roedel jroe...@suse.de Implement domain_alloc and domain_free iommu-ops as a replacement for domain_init/domain_destroy. Signed-off-by: Joerg Roedel jroe...@suse.de --- drivers/iommu/tegra-gart.c | 67

Re: [PATCH v2 Resend] pwm: samsung: Fix output race on disabling

2015-03-27 Thread Lukasz Majewski
Hi Sjoerd, When disabling the samsung PWM the output state remains at the level it was in the end of a pwm cycle. In other words, calling pwm_disable when at 100% duty will keep the output active, while at all other setting the output will go/stay inactive. On top of that the samsung PWM

[PATCH v2 1/3] ARM: EXYNOS: Handle of of_iomap() failure

2015-03-27 Thread Krzysztof Kozlowski
Prevent possible NULL pointer dereference if of_iomap() fails. Handle the error by skipping such power domain. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Changes since v1: 1. Add missing kfree() of domain name (allocated with kstrdup()). --- arch/arm/mach-exynos/pm_domains.c

[PATCH v2 2/3] ARM: EXYNOS: Handle of_find_device_by_node and kstrdup failures

2015-03-27 Thread Krzysztof Kozlowski
Prevent possible NULL pointer dereference of pointer returned by of_find_device_by_node(). Handle this by skipping such power domain. Additionally fail the init on kstrdup() failure. Such case is actually not fatal because the name for power domain allocated by kstrdup() is used only in printk.

[PATCH v2 3/3] ARM: EXYNOS: Add missing of_node_put() when parsing power domains

2015-03-27 Thread Krzysztof Kozlowski
Add missing of_node_put() to: 1. Error return path if allocating memory for exynos_pm_domain failed. 2. Second iteration over power domains if a child domain was not present or was incomplete. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reported-by: Karol Wrona

Re: [PATCH 1/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer

2015-03-27 Thread Gustavo Padovan
Hi Tobias, 2015-03-27 Tobias Jakobi tjak...@math.uni-bielefeld.de: Hello! Gustavo Padovan wrote: I would keep calling these two vars x_ratio and y_ratio. I don't see a reason to change the name here. Right, I'm going to change this. Also I was thinking of basing the patch on your

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-27 Thread Javier Martinez Canillas
Hello Abhilash, On 03/20/2015 06:40 PM, Abhilash Kesavan wrote: Regarding the mdma0 disablement, it looks like for the system to suspend properly the mdma0 pclk needs to stay on. I had time today again to work on this issue and the best place I found to enable and disable the mdma0 clock

[RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Javier Martinez Canillas
Commit ae43b3289186 (ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12) added pm support for the pl330 dma driver but it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated during suspend and this clock needs to remain enabled in order to make the system

[RFC PATCH 0/2] ARM: EXYNOS: Fix Suspend-to-RAM on Exynos5420

2015-03-27 Thread Javier Martinez Canillas
Hello, Suspend-to-RAM is currently not working. Abhilash Kesavan traced down to the MDMA0 DMA controller clock to be disabled during suspend and that it must stay enaled during suspend or the system is not able to resume. This series is an attempt to fix the issue and is composed of patches:

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-27 Thread Javier Martinez Canillas
Hello Abhilash, On 03/27/2015 03:06 PM, Abhilash Kesavan wrote: Hello Javier, On Fri, Mar 27, 2015 at 6:59 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Abhilash, On 03/20/2015 06:40 PM, Abhilash Kesavan wrote: Regarding the mdma0 disablement, it looks like

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Krzysztof Kozlowski
2015-03-27 15:21 GMT+01:00 Javier Martinez Canillas javier.marti...@collabora.co.uk: Commit ae43b3289186 (ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12) added pm support for the pl330 dma driver but it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-27 Thread Abhilash Kesavan
Hello Javier, On Fri, Mar 27, 2015 at 6:59 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Abhilash, On 03/20/2015 06:40 PM, Abhilash Kesavan wrote: Regarding the mdma0 disablement, it looks like for the system to suspend properly the mdma0 pclk needs to stay on.

[RFC PATCH 1/2] clk: exynos5420: Add alias for MDMA0 controller clock

2015-03-27 Thread Javier Martinez Canillas
The MDMA0 controller clock needs to be enabled to allow the system to be resumed when entering into a suspend state. The clock is disabled as a part of the runtime pm for the pl330 DMA driver so the system fails to resume. So to allow the system to grab the clock and make sure that it stays

Re: [PATCH 1/1] Revert ARM: dts: add display power domain for exynos5250

2015-03-27 Thread Krzysztof Kozlowski
2015-03-23 11:49 GMT+01:00 Javier Martinez Canillas javier.marti...@collabora.co.uk: This reverts commit 2d2c9a8d0a4f90e298315d2f4a282d8bd5d45e5c (ARM: dts: add display power domain for exynos5250). The mentioned commit added a domain definition for the DISP1 power domain and references to it

Re: [PATCH 1/1] Revert ARM: dts: add display power domain for exynos5250

2015-03-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 03/27/2015 03:29 PM, Krzysztof Kozlowski wrote: 2015-03-23 11:49 GMT+01:00 Javier Martinez Canillas I looked at the DP and FIMD drivers and with great help of Andrzej Hajda found the issue: the FIMD driver does not enable DP clock (DP_MIE_CLKCON register). The process

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Sylwester Nawrocki
Hello Javier, On 27/03/15 15:21, Javier Martinez Canillas wrote: Commit ae43b3289186 (ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12) added pm support for the pl330 dma driver but it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated during suspend

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Javier Martinez Canillas
Hello Sylwester, Thanks a lot for your feedback. On 03/27/2015 03:36 PM, Sylwester Nawrocki wrote: * GIC wake-up support @@ -374,6 +376,16 @@ static void exynos5420_pm_prepare(void) { unsigned int tmp; +/* + * Exynos5420 requires the MDMA0 controller clock to be + *

[RFT PATCHv2] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

2015-03-27 Thread Krzysztof Kozlowski
After adding display power domain for Exynos5250 in commit 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) the display on Chromebook Snow and others stopped working after boot. The reason for this suggested Andrzej Hajda: the DP clock was disabled. This clock is required by

[PATCH] clk: samsung: exynos4: Disable ARMCLK down feature on Exynos4210 SoC

2015-03-27 Thread Bartlomiej Zolnierkiewicz
Commit 42773b28e71d (clk: samsung: exynos4: Enable ARMCLK down feature) enabled ARMCLK down feature on all Exynos4 SoCs. Unfortunately on Exynos4210 SoC ARMCLK down feature causes a lockup when ondemand cpufreq governor is used. Fix it by limiting ARMCLK down feature to Exynos4x12 SoCs. This

[RFT PATCH] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

2015-03-27 Thread Krzysztof Kozlowski
After adding display power domain for Exynos5250 in commit 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) the display on Chromebook Snow and others stopped working after boot. The reason for this suggested Andrzej Hajda: the DP clock was disabled. This clock is required by

Re: [PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

2015-03-27 Thread Inki Dae
Hello Javier, 2015-03-27 20:08 GMT+09:00 Javier Martinez Canillas jav...@dowhile0.org: Hello Inki, On Fri, Mar 27, 2015 at 2:47 AM, Inki Dae inki@samsung.com wrote: Right, this is not documented but if you have ever checked exynos drm driver tree, then I think you could know how we use

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks a lot for your feedback. On 03/27/2015 03:38 PM, Krzysztof Kozlowski wrote: 2015-03-27 15:21 GMT+01:00 Javier Martinez Canillas javier.marti...@collabora.co.uk: Commit ae43b3289186 (ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12) added pm

[PATCH] cpufreq: exynos: remove dead -need_apll_change method

2015-03-27 Thread Bartlomiej Zolnierkiewicz
Commit 26ab1c62b6e1 (cpufreq: exynos5250: Set APLL rate using CCF API) removed the last user of -need_apll_change method. Remove it and then cleanup exynos_cpufreq_scale() accordingly. This patch was tested on Exynos4412 SoC based Trats2 board. There should be no functional changes caused by

[PATCH 00/10] drm/exynos: Add atomic modesetting support

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, Here goes the full support for atomic modesetting on exynos. I've split the patches in the various phases of atomic support. These patches sits on top of the clean up patches I've sent yesterday to this mailing list[1]. Gustavo

[PATCH 03/10] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The new atomic infrastructure needs the .mode_set_nofb() callback to update CRTC timings before setting any plane. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 60

[PATCH 09/10] drm/exynos: remove exported functions from exynos_drm_plane

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that no one is using the functions exported by exynos_drm_plane due to the atomic conversion we can make remove some of the them or make them static. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

[PATCH 04/10] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy()

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Set CRTC, planes and connectors to use the default implementations from the atomic helper library. The helpers will work to keep track of state for each DRM object. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

[PATCH 01/10] drm/exynos: atomic phase 1: use drm_plane_helper_update()

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Rip out the check from exynos_update_plane() and create exynos_check_plane() for the check phase enabling use to use the atomic helpers to call our check and update phases when updating planes. Update all users of exynos_update_plane()

[PATCH 02/10] drm/exynos: atomic phase 1: use drm_plane_helper_disable()

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The atomic helper to disable planes also uses the optional .atomic_disable() helper. The unique operation it does is calling .win_disable() exynos_drm_fb_get_buf_cnt() needs a fb check too to avoid a null pointer. Signed-off-by: Gustavo

[PATCH 08/10] drm/exynos: atomic phase 3: convert page flips

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk PageFlips now use the atomic helper to work through the atomic modesetting API. Async page flips are not supported yet. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 63

[PATCH 05/10] drm/exynos: atomic phase 2: keep track of framebuffer pointer

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Use drm_atomic_set_fb_for_plane() in the legacy page_flip path to keep track of the framebuffer pointer and reference. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 3 +++ 1

[PATCH 06/10] drm/exynos: atomic phase 3: atomic updates of planes

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that phase 1 and 2 are complete we can switch the update/disable_plane callbacks to their atomic version. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_fb.c| 3 +++

[PATCH 07/10] drm/exynos: atomic phase 3: use atomic .set_config helper

2015-03-27 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that phase 1 and 2 are complete switch .set_config helper to use the atomic one. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [RFT PATCHv2] drm/exynos: Enable DP clock to fix display on Exynos5250 and other

2015-03-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 03/27/2015 05:08 PM, Krzysztof Kozlowski wrote: After adding display power domain for Exynos5250 in commit 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) the display on Chromebook Snow and others stopped working after boot. The reason for this suggested

[RFC PATCH v2 1/2] clk: exynos5420: Add alias for MDMA0 controller clock

2015-03-27 Thread Javier Martinez Canillas
The MDMA0 controller clock needs to be enabled to allow the system to be resumed when entering into a suspend state. The clock is disabled as a part of the runtime pm for the pl330 DMA driver so the system fails to resume. So to allow the system to grab the clock and make sure that it stays

[RFC PATCH v2 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Javier Martinez Canillas
Commit ae43b3289186 (ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12) added pm support for the pl330 dma driver but it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated during suspend and this clock needs to remain enabled in order to make the system

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-27 Thread Heiko Stuebner
Am Donnerstag, 26. März 2015, 13:43:03 schrieb Joerg Roedel: Changes v1-v2: * Rebased to v4.0-rc5 * Converted domain-types to a bit-field Hi, here is patch-set to replace the existing domain_init and domain_destroy iommu-ops with the new domain_alloc and domain_free

Re: [PATCH] cpufreq: exynos: remove dead -need_apll_change method

2015-03-27 Thread Viresh Kumar
On 27 March 2015 at 22:02, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Commit 26ab1c62b6e1 (cpufreq: exynos5250: Set APLL rate using CCF API) removed the last user of -need_apll_change method. Remove it and then cleanup exynos_cpufreq_scale() accordingly. This patch was tested

Re: [PATCH 00/16 v2] iommu: Move domain allocation into drivers

2015-03-27 Thread Alex Williamson
On Thu, 2015-03-26 at 13:43 +0100, Joerg Roedel wrote: Changes v1-v2: * Rebased to v4.0-rc5 * Converted domain-types to a bit-field Hi, here is patch-set to replace the existing domain_init and domain_destroy iommu-ops with the new domain_alloc and domain_free callbacks