Re: [PATCH 02/11] clk: samsung: exynos7: Corrects CMU_TOP0 clocks names

On 04.09.2015 20:37, Alim Akhtar wrote: > This patch rename CMU_TOP0 clocks names to match with user manual. s/rename/renames/ I did not check the exact renames but overall the patch makes sense and looks good. Best regards, Krzysztof > > Signed-off-by: Alim Akhtar >

Re: [PATCH 04/11] clk: samsung: exynos7: Corrects CMU_CCORE clocks names

On 04.09.2015 20:37, Alim Akhtar wrote: > This patch rename CMU_CCROE clocks names to match with user manual. s/rename/renames/ (everywhere...) s/CCROE/CCORE/ > And also adds missing gate clock for aclk_ccore_133. > > Signed-off-by: Alim Akhtar > --- >

Re: [PATCH] ARM: exynos_defconfig: Enable USB Video Class support

On 08.09.2015 06:45, Javier Martinez Canillas wrote: > The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in > Silicon Motion USB UVC WebCam. Enable support for the USB Video Class > driver and its needed media Kconfig symbols so the camera is supported. > > Signed-off-by:

Re: [PATCH] ARM: exynos_defconfig: Enable USB Video Class support

[adding Bartlomiej to cc] Hello Krzysztof, On 09/08/2015 10:11 AM, Krzysztof Kozlowski wrote: > On 08.09.2015 06:45, Javier Martinez Canillas wrote: >> The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in >> Silicon Motion USB UVC WebCam. Enable support for the USB Video Class

[PATCH 3/3] ARM: dts: Enable EC vboot context support on Peach boards

The Peach boards use the EC to store the vboot context information, so add the corresponding properties on the EC node to indicate so. Signed-off-by: Emilio López --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 + arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +

[PATCH 0/3] platform/chrome: vboot context support

Hi everyone, This series adds support for reading and writing the verified boot context nvram space on the EC using the cros_ec sysfs interface. The first patch fixes is_visible() functionality, making it work for binary attributes as well as normal ones. This is needed so the sysfs group can be

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

On Tue, Sep 08, 2015 at 12:10:02PM -0700, Greg KH wrote: > On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: > > Emilio, > > > > On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > > > According to the sysfs header file: > > > > > > "The returned value will replace

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: > Emilio, > > On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct

Re: [PATCH] ARM: exynos_defconfig: Enable USB Video Class support

Hello Krzysztof, On 09/08/2015 03:12 PM, Krzysztof Kozlowski wrote: > W dniu 08.09.2015 o 17:40, Javier Martinez Canillas pisze: >> [adding Bartlomiej to cc] >> >> Hello Krzysztof, >> >> On 09/08/2015 10:11 AM, Krzysztof Kozlowski wrote: >>> On 08.09.2015 06:45, Javier Martinez Canillas wrote:

Re: [PATCH 04/11] clk: samsung: exynos7: Corrects CMU_CCORE clocks names

Hello, On 09/08/2015 01:00 PM, Krzysztof Kozlowski wrote: On 04.09.2015 20:37, Alim Akhtar wrote: This patch rename CMU_CCROE clocks names to match with user manual. s/rename/renames/ (everywhere...) s/CCROE/CCORE/ And also adds missing gate clock for aclk_ccore_133. Signed-off-by: Alim

[PATCH v2 4/9] exynos/fimg2d: add g2d_validate_xyz() functions

The G2D headers define a number of modes through enums (like e.g. color, select, repeat, etc.). This introduces g2d_validate_select_mode() and g2d_validate_blending_op() which validate a select mode or blending operation respectively. Use this together with g2d_check_space() in

[PATCH v2 2/9] exynos/fimg2d: simplify base address submission in g2d_scale_and_blend()

Use g2d_add_base_addr() for source and destination base address just like all other calls. Signed-off-by: Tobias Jakobi --- exynos/exynos_fimg2d.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/exynos/exynos_fimg2d.c

[PATCH v2 0/9] drm/exynos: rewrite fimg2d error handling

Hello, during the discussion about the last patchset touching the fimg2d code, it became apparent that the error handling for the command submission is currently unsatisfactory. This series rewrites the handling. All functions that submit command buffers now first check if enough space is

[PATCH v2 3/9] exynos/fimg2d: add g2d_check_space()

This is going to be used to check if the command buffers have enough space left prior to actual submission of the commands. Use this in g2d_{solid_fill,copy,copy_with_scale}(). For this the parameter validation before buffer space checking so that we can exit early if it fails. Also don't reset

[PATCH v2 1/9] exynos/fimg2d: fix empty buffer handling in g2d_flush()

Empty command buffers are no error, we just don't have anything to do for flushing then. Signed-off-by: Tobias Jakobi --- exynos/exynos_fimg2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

Emilio, On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > According to the sysfs header file: > > "The returned value will replace static permissions defined in > struct attribute or struct bin_attribute." > > but this isn't the case, as is_visible is only called on >

Re: [PATCH] cpufreq: s5pv210: remove superfluous CONFIG_PM ifdefs

On Tuesday, September 08, 2015 07:02:12 PM Bartlomiej Zolnierkiewicz wrote: > CONFIG_PM ifdefs are superfluous and can be removed. I guess Kukjin can apply this one? > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

Hi Emilio, On 09/08/2015 05:51 PM, Emilio López wrote: Hi Greg & Guenter, [ ... ] Unless I am missing something, this is not explained anywhere, but it is not entirely trivial to understand. I think it should be documented. I agree. I couldn't find any mention of what this int was

Re: [PATCH] ARM: exynos_defconfig: Enable USB Video Class support

On 08.09.2015 22:32, Javier Martinez Canillas wrote: (...) > >> Let me rephrase my question into: >> 1. What is worth enabling in exynos_defconfig? USB devices? I would >> argue, except they are needed to boot. > > Ok, I understand your concern. The question is where we draw the line. > >>

Re: [PATCH v5 0/4] cpufreq-dt: add suspend frequency support

On Tuesday, September 08, 2015 06:41:00 PM Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series adds suspend frequency support (using opp-v2 > bindings and suspend-opp functionality) to cpufreq-dt driver and > then adds suspend opp for Exynos4412 based boards. > > This patch series fixes

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

Hi Greg & Guenter, On 08/09/15 16:30, Guenter Roeck wrote: On Tue, Sep 08, 2015 at 12:10:02PM -0700, Greg KH wrote: On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: Emilio, On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: According to the sysfs header file:

Re: [PATCH] cpufreq: s5pv210: remove superfluous CONFIG_PM ifdefs

On 08-09-15, 19:02, Bartlomiej Zolnierkiewicz wrote: > CONFIG_PM ifdefs are superfluous and can be removed. > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Signed-off-by: Bartlomiej Zolnierkiewicz > --- >

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: > Hi Emilio, > > On 09/08/2015 05:51 PM, Emilio López wrote: > >Hi Greg & Guenter, > > > [ ... ] > > Unless I am missing something, this is not explained anywhere, but it is > not entirely trivial to understand. I think

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

On 09/08/2015 08:58 PM, Greg KH wrote: On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: Hi Emilio, On 09/08/2015 05:51 PM, Emilio López wrote: Hi Greg & Guenter, [ ... ] Unless I am missing something, this is not explained anywhere, but it is not entirely trivial to

[PATCH v5 0/4] cpufreq-dt: add suspend frequency support

Hi, This patch series adds suspend frequency support (using opp-v2 bindings and suspend-opp functionality) to cpufreq-dt driver and then adds suspend opp for Exynos4412 based boards. This patch series fixes suspend/resume support on Exynos4412 based Trats2 board and reboot hang on Exynos4412

[PATCH v5 4/4] ARM: dts: add suspend opp to exynos4412

Mark 800MHz OPP as a suspend opp for Exynos4412 based boards so effectively cpufreq-dt driver behavior w.r.t. suspend frequency matches what the old exynos-cpufreq driver has been doing. This patch fixes suspend/resume support on Exynos4412 based Trats2 board and reboot hang on Exynos4412 based

[PATCH v5 3/4] cpufreq-dt: add suspend frequency support

Add suspend frequency support and if needed set it to the frequency obtained from the suspend opp (can be defined using opp-v2 bindings and is optional). Cc: Thomas Abraham Cc: Javier Martinez Canillas Cc: Krzysztof Kozlowski

[PATCH v5 1/4] PM / OPP: add dev_pm_opp_get_suspend_opp() helper

Add dev_pm_opp_get_suspend_opp() helper to obtain suspend opp. Cc: Thomas Abraham Cc: Javier Martinez Canillas Cc: Krzysztof Kozlowski Cc: Marek Szyprowski Cc: Tobias Jakobi

[PATCH v2 5/9] exynos/fimg2d: remove default case from g2d_get_blend_op()

We now validate the blending mode via g2d_validate_mode() prior to feeding it to g2d_get_blend_op(). Signed-off-by: Tobias Jakobi --- exynos/exynos_fimg2d.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/exynos/exynos_fimg2d.c

[PATCH v2 6/9] exynos/fimg2d: remove superfluous initialization of g2d_point_val

The g2d_point_val union consists of two coordinates of 16 bits. Whenever this union is used though, both coordinates are explicitly set. Hence prior initialization is unnecessary. Signed-off-by: Tobias Jakobi --- exynos/exynos_fimg2d.c | 19 --- 1

[PATCH v2 7/9] exynos/fimg2d: make g2d_add_cmd() less heavy

The function currently checks for each added command if an overflow of the corresponding command buffers occurs, but none of the callers ever checks the return value. Since all callers are now converted to use g2d_check_space() simplify the function. (1) The overflow checks become asserts, so

[PATCH v2 9/9] exynos/fimg2d: remove g2d_context from public header

All functions from the public API only operation on struct g2d_context*, so this shouldn't break too much. Make the context private since we don't want the user to modify its content directly. Also remove the defines that were only used for fields of g2d_context. Signed-off-by: Tobias Jakobi

[PATCH v2 8/9] exynos/fimg2d: add message prefix

Add a prefix to the messages printed to the console via printf() and fprintf() so that one can easily see where the message comes from. Signed-off-by: Tobias Jakobi --- exynos/exynos_fimg2d.c | 30 -- 1 file changed, 16 insertions(+),

Re: [PATCH] ARM: exynos_defconfig: Enable USB Video Class support

W dniu 08.09.2015 o 17:40, Javier Martinez Canillas pisze: > [adding Bartlomiej to cc] > > Hello Krzysztof, > > On 09/08/2015 10:11 AM, Krzysztof Kozlowski wrote: >> On 08.09.2015 06:45, Javier Martinez Canillas wrote: >>> The Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a built-in

[PATCH v5 2/4] cpufreq: allow cpufreq_generic_suspend() to work without suspend frequency

Some cpufreq drivers may set suspend frequency only for selected setups but still would like to use the generic suspend handler. Thus don't treat !policy->suspend_freq condition as an incorrect one. Cc: Thomas Abraham Cc: Javier Martinez Canillas

[PATCH] cpufreq: s5pv210: remove superfluous CONFIG_PM ifdefs

CONFIG_PM ifdefs are superfluous and can be removed. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/cpufreq/s5pv210-cpufreq.c | 2 -- 1 file changed, 2 deletions(-) diff --git