Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context

Hello Emilio, On Tue, Sep 15, 2015 at 10:24 PM, Emilio López wrote: [snip] > + > + params = (struct ec_params_vbnvcontext *)msg->data; > + params->op = EC_VBNV_CONTEXT_OP_READ; > + > + msg->version = EC_VER_VBNV_CONTEXT; >

Re: [PATCH v3 1/2] ARM: dts: Split audio configuration to separateexynos5422-odroidxu3-audio

On 09/14/15 09:47, Krzysztof Kozlowski wrote: > The Odroid XU4 board does not have audio codec so before adding DTS for > new board split the audio codec to separate DTSI file. Include the audio codec > DTSI in Odroid XU3 and XU3-Lite boards. > > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

On 09/13/15 18:32, Krzysztof Kozlowski wrote: > The LEDs on Odroid XU3 family boards could not properly probe because PWM > outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and > XU3-Lite boards by switching to usage of all 4 outputs (although the PWM > for MIPI probably is

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

On 16.09.2015 08:35, Kukjin Kim wrote: > On 09/13/15 18:32, Krzysztof Kozlowski wrote: >> The LEDs on Odroid XU3 family boards could not properly probe because PWM >> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and >> XU3-Lite boards by switching to usage of all 4 outputs

Re: [PATCH v2 02/12] clk: samsung: exynos7: Adds missing clocks gates of CMU_TOPC

On 10.09.2015 17:44, Alim Akhtar wrote: > This adds some of the missing GATE clocks of CMU_TOPC block. > > Signed-off-by: Alim Akhtar > --- > drivers/clk/samsung/clk-exynos7.c | 27 +++ > include/dt-bindings/clock/exynos7-clk.h | 13

Re: [RFC PATCH v7 01/10] mmc: dw_mmc: Add external dma interface support

Hi, Shawn. Sorry for late review. On 08/24/2015 10:25 AM, Shawn Lin wrote: > DesignWare MMC Controller can supports two types of DMA > mode: external dma and internal dma. We get a RK312x platform > integrated dw_mmc and ARM pl330 dma controller. This patch add > edmac ops to support these

Re: [PATCH v2 5/12] clk: samsung: exynos7: Corrects CMU_CCORE clocks names

On 10.09.2015 17:44, Alim Akhtar wrote: > This patch renames CMU_CCORE clocks names to match with user manual. > > Signed-off-by: Alim Akhtar > --- > drivers/clk/samsung/clk-exynos7.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by:

Re: [PATCH v2 01/12] clk: samsung: exynos7: Change the CMU_TOPC block clock names

On 10.09.2015 17:44, Alim Akhtar wrote: > Corrects the CMU_TOPC block clock names as per user manual. > This does not change any functionalities. > > Signed-off-by: Alim Akhtar > --- > drivers/clk/samsung/clk-exynos7.c | 70 > - >

Re: [PATCH 1/7] [media] dvb: use ktime_t for internal timeout

Hello Arnd, On 15.09.2015 17:49, Arnd Bergmann wrote: > The dvb demuxer code uses a 'struct timespec' to pass a timeout > as absolute time. This will cause problems on 32-bit architectures > in 2038 when time_t overflows, and it is racy with a concurrent > settimeofday() call. > > This patch

Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context

Hi Javier, Thanks for the review. You'll find my answers inline On 15/09/15 10:47, Javier Martinez Canillas wrote: Hello Emilio, Patch looks mostly good to me, I just have a few comments. On Mon, Sep 14, 2015 at 2:34 PM, Emilio López wrote: Some EC

Re: [RFC PATCH] clocksource: exynos_mct: use container_of() instead of this_cpu_ptr()

On 09/04/2015 01:49 AM, Alexey Klimov wrote: Since evt structure is embedded in per-CPU mevt structure it's definitely faster to use container_of() to get access to mevt if we have evt (for example as incoming function argument) instead of more expensive approach with this_cpu_ptr(_mct_tick).

Re: [PATCH v2 0/4] Improvements on exynos7 clock

On 26/08/15 05:30, Alim Akhtar wrote: > This patch series are minor improvement over the current > exynos7 clock file. This fix some bugs and update the clock > bits as per user manual. That one applied as well, thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 00/12] clk: samsung: exynos7: Cleanup of clock file

On 10/09/15 10:44, Alim Akhtar wrote: > Currently there are lots of ambiguity between clock names in clock file > and in user manual, which leads to lots of confusion for the reviewers. > This series attempts to cleanup the exynos7 clock file as per > user manual naming convention. > This also

Re: [PATCH v2 00/12] clk: samsung: exynos7: Cleanup of clock file

Hi Sylwester, On 09/15/2015 02:55 PM, Sylwester Nawrocki wrote: On 10/09/15 10:44, Alim Akhtar wrote: Currently there are lots of ambiguity between clock names in clock file and in user manual, which leads to lots of confusion for the reviewers. This series attempts to cleanup the exynos7

Re: [PATCH v2 0/4] Improvements on exynos7 clock

Hi Sylwester On 09/15/2015 02:57 PM, Sylwester Nawrocki wrote: On 26/08/15 05:30, Alim Akhtar wrote: This patch series are minor improvement over the current exynos7 clock file. This fix some bugs and update the clock bits as per user manual. That one applied as well, thanks. Thanks!! --

Re: [PATCH] ARM: multi_v7_defconfig: enable usb3503

On Tue, 2015-09-15 at 15:50 +0900, Krzysztof Kozlowski wrote: > 2015-09-14 17:35 GMT+09:00 Riku Voipio : > > On 5 June 2015 at 15:45, Arnd Bergmann wrote: > > > On Thursday 04 June 2015 10:47:07 Kevin Hilman wrote: > > > > > > > > > But I wonder why is not

Re: [PATCH] ARM: multi_v7_defconfig: enable usb3503

On 15.09.2015 17:17, Sjoerd Simons wrote: > On Tue, 2015-09-15 at 15:50 +0900, Krzysztof Kozlowski wrote: >> 2015-09-14 17:35 GMT+09:00 Riku Voipio : >>> On 5 June 2015 at 15:45, Arnd Bergmann wrote: On Thursday 04 June 2015 10:47:07 Kevin Hilman wrote:

Re: [RFC PATCH v7 01/10] mmc: dw_mmc: Add external dma interface support

On 2015/9/15 16:08, Jaehoon Chung wrote: Hi, Shawn. [...] -config MMC_DW_IDMAC - bool "Internal DMAC interface" - depends on MMC_DW - help - This selects support for the internal DMAC block within the Synopsys - Designware Mobile Storage IP block. This

[PATCH v3 2/2] [media] media-device: split media initialization and registration

The media device node is registered and so made visible to user-space before entities are registered and links created which means that the media graph obtained by user-space could be only partially enumerated if that happens too early before all the graph has been created. To avoid this race

[PATCH v3 0/2] [media] Fix race between graph enumeration and entities registration

Hello, The Media Controller framework has an issue in which the media device node is registered before all the media entities and pads links are created so if user-space tries to enumerate the graph too early, it may get a partial graph since not everything has been registered yet. This series

Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval

On 09/15/2015 05:49 PM, Arnd Bergmann wrote: > The v4l2 API uses a 'struct timeval' to communicate time stamps to user > space. This is broken on 32-bit architectures as soon as we have a C library > that defines time_t as 64 bit, which then changes the structure layout of > struct v4l2_buffer. >

Re: [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps

On 09/15/2015 05:49 PM, Arnd Bergmann wrote: > The v4l2 event queue uses a 'struct timespec' to pass monotonic > timestamps. This is not a problem by itself, but it breaks when user > space redefines timespec to use 'long long' on 32-bit systems. > > To avoid that problem, we define our own

Re: [PATCH v4 2/2] [media] media-device: split media initialization and registration

Hi Javier, Javier Martinez Canillas wrote: > The media device node is registered and so made visible to user-space > before entities are registered and links created which means that the > media graph obtained by user-space could be only partially enumerated > if that happens too early before all

[PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps

The v4l2 event queue uses a 'struct timespec' to pass monotonic timestamps. This is not a problem by itself, but it breaks when user space redefines timespec to use 'long long' on 32-bit systems. To avoid that problem, we define our own replacement for timespec here, using 'long' tv_sec and

[PATCH 0/7] [media] y2038 conversion for subsystem

Hi everyone, This is a conversion of all subsystem-wide v4l2 code to avoid the use of types based on time_t. The first five patches should all be harmless and obvious, so they can get applied for 4.3 after normal review. The last two patches are marked RFC for now because their possible impact

[PATCH 3/7] [media] dvb: don't use 'time_t' in event ioctl

'struct video_event' is used for the VIDEO_GET_EVENT ioctl, implemented by drivers/media/pci/ivtv/ivtv-ioctl.c and drivers/media/pci/ttpci/av7110_av.c. The structure contains a 'time_t', which will be redefined in the future to be 64-bit wide, causing an incompatible ABI change for this ioctl. As

[PATCH 1/7] [media] dvb: use ktime_t for internal timeout

The dvb demuxer code uses a 'struct timespec' to pass a timeout as absolute time. This will cause problems on 32-bit architectures in 2038 when time_t overflows, and it is racy with a concurrent settimeofday() call. This patch changes the code to use ktime_get() instead, using the monotonic time

[PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval

The v4l2 API uses a 'struct timeval' to communicate time stamps to user space. This is broken on 32-bit architectures as soon as we have a C library that defines time_t as 64 bit, which then changes the structure layout of struct v4l2_buffer. Fortunately, almost all v4l2 drivers use monotonic

[PATCH 2/7] [media] dvb: remove unused systime() function

The systime function uses struct timespec, which we want to stop using in the kernel because it overflows in 2038. Fortunately, this use in dibx000_common is in a function that is never called, so we can just remove it. Signed-off-by: Arnd Bergmann ---

[PATCH 5/7] [media] use v4l2_get_timestamp where possible

This is a preparation for a change to the type of v4l2 timestamps. v4l2_get_timestamp() is a helper function that reads the monotonic time and stores it into a 'struct timeval'. Multiple drivers implement the same thing themselves for historic reasons. Changing them all to use

[PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized

The exynos4 fimc capture driver claims to use monotonic timestamps but calls ktime_get_real_ts(). This is both an incorrect API use, and a bad idea because of the y2038 problem and the fact that the wall clock time is not reliable for timestamps across suspend or settimeofday(). This changes the

Re: [Y2038] [PATCH 1/7] [media] dvb: use ktime_t for internal timeout

On Tuesday 15 September 2015 19:55:35 Andreas Oberritter wrote: > > /* show speed every SPEED_PKTS_INTERVAL packets */ > > if (!(demux->speed_pkts_cnt % SPEED_PKTS_INTERVAL)) { > > - cur_time = current_kernel_time(); > > + cur_time =

Re: [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval

On Tuesday 15 September 2015 18:27:19 Hans Verkuil wrote: > On 09/15/2015 05:49 PM, Arnd Bergmann wrote: > > The v4l2 API uses a 'struct timeval' to communicate time stamps to user > > space. This is broken on 32-bit architectures as soon as we have a C library > > that defines time_t as 64 bit,

Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context

Hi Javier, On 15/09/15 16:43, Javier Martinez Canillas wrote: Hello Emilio, On Tue, Sep 15, 2015 at 9:16 PM, Emilio López wrote: [snip] obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o obj-$(CONFIG_CHROMEOS_PSTORE) += chromeos_pstore.o

Re: [Y2038] [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps

On Tuesday 15 September 2015 18:32:36 Hans Verkuil wrote: > > > > - ktime_get_ts(); > > + ktime_get_ts64(); > > + vts.tv_sec = timestamp.tv_sec; > > + vts.tv_nsec = timestamp.tv_nsec; > > I prefer to take this opportunity to create a v4l2_get_timespec helper > function, just

Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context

On Tue, Sep 15, 2015 at 09:43:35PM +0200, Javier Martinez Canillas wrote: > Hello Emilio, > > On Tue, Sep 15, 2015 at 9:16 PM, Emilio López > wrote: > > [snip] > > >>> > >>> obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o > >>>

Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context

Hello Emilio, On Tue, Sep 15, 2015 at 9:16 PM, Emilio López wrote: [snip] >>> >>> obj-$(CONFIG_CHROMEOS_LAPTOP) += chromeos_laptop.o >>> obj-$(CONFIG_CHROMEOS_PSTORE) += chromeos_pstore.o >>> -cros_ec_devs-objs := cros_ec_dev.o cros_ec_sysfs.o

[PATCH v4 2/2] [media] media-device: split media initialization and registration

The media device node is registered and so made visible to user-space before entities are registered and links created which means that the media graph obtained by user-space could be only partially enumerated if that happens too early before all the graph has been created. To avoid this race

[PATCH v4 0/2] [media] Fix race between graph enumeration and entities registration

Hello, The Media Controller framework has an issue in which the media device node is registered before all the media entities and pads links are created so if user-space tries to enumerate the graph too early, it may get a partial graph since not everything has been registered yet. This series

Re: [PATCH v2 2/3] platform/chrome: Support reading/writing the vboot context

Hello Emilio, Patch looks mostly good to me, I just have a few comments. On Mon, Sep 14, 2015 at 2:34 PM, Emilio López wrote: > Some EC implementations include a small nvram space used to store > verified boot context data. This patch offers a way to expose this >

Re: [PATCH v2 3/3] ARM: dts: Enable EC vboot context support on Peach boards

Hello Emilio, On Mon, Sep 14, 2015 at 2:34 PM, Emilio López wrote: > The Peach boards use the EC to store the vboot context information, > so add the corresponding properties on the EC node to indicate so. > > Signed-off-by: Emilio López

Re: [PATCH v2] clk: samsung: fix cpu clock's flags checking

[ + Stephen on cc: ] On Friday, August 28, 2015 01:49:35 PM Bartlomiej Zolnierkiewicz wrote: > CLK_CPU_HAS_DIV1 and CLK_CPU_NEEDS_DEBUG_ALT_DIV masks were > incorrectly used as a bit numbers. Fix it. > > Tested on Exynos4210 based Origen board and on Exynos5250 based > Arndale board. > > Cc: