Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

2015-11-10 Thread Tobias Jakobi
Hello Marek, this looks very interesting. I'll try to integrate this with my mpv DRM backend once the colorspace conversion bits are implemented. I also wanted to suggest that using the IPP blocks (rotator, FIMC) should be still be possible without any kind of display active. So similar in the

Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

2015-11-10 Thread Krzysztof Kozlowski
On 10.11.2015 19:24, Marek Szyprowski wrote: > FIMD device is not used at all on Exynos5422-based Odroid XU3-lite and > XU4. XU3 board teorethically can support FIMD with DisplayPort s/teorethically/theoretically/ > connector, but due to hw limitation/design it doesn't work in most > cases. It

[PATCH V3 5/5] ARM: dts: exynos4412: Rename OPP nodes as opp@

2015-11-10 Thread Viresh Kumar
OPP bindings got updated to name OPP nodes this way, make changes according to that. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Viresh Kumar --- arch/arm/boot/dts/exynos4412.dtsi | 28 ++-- 1 file changed, 14

[PATCH v4 3/9] ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung"

2015-11-10 Thread Pankaj Dubey
Moving Exynos PMU specific header file into "include/linux/soc/samsung" thus updated affected files under "mach-exynos" to use new location of these header files. Signed-off-by: Amit Daniel Kachhap Signed-off-by: Pankaj Dubey ---

[PATCH v4 1/9] ARM: EXYNOS: removing redundant code from regs-pmu.h

2015-11-10 Thread Pankaj Dubey
commit 6ec4f8d0d91f ("ARM: EXYNOS: add generic function to calculate cpu number") introduced exynos_pmu_cpunr to be used by multi-cluster SoC's e.g Exynos5420, but it's no more used in the codebase and hence removing this part of code. Signed-off-by: Pankaj Dubey

[PATCH v4 7/9] ARM: EXYNOS: split up exynos5420 SoC specific PMU data

2015-11-10 Thread Pankaj Dubey
This patch splits up mach-exynos/pmu.c file, and moves exynos5420, PMU configuration data and functions handing data into exynos5420 SoC specific PMU file mach-exynos/exynos5420-pmu.c. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/Makefile | 2 +-

[PATCH v4 5/9] ARM: EXYNOS: split up exynos4 SoC specific PMU data

2015-11-10 Thread Pankaj Dubey
This patch splits up mach-exynos/pmu.c file, and moves exynos4210, exynos4412 and exynos4212 PMU configuration data and functions handing data into a common exynos4 SoC specific PMU file mach-exynos/exynos4-pmu.c. Signed-off-by: Pankaj Dubey Reviewed-by: Krzysztof

[PATCH v4 6/9] ARM: EXYNOS: split up exynos5250 SoC specific PMU data

2015-11-10 Thread Pankaj Dubey
This patch splits up mach-exynos/pmu.c file, and moves exynos5250, PMU configuration data and functions handing data into exynos5250 SoC specific PMU file mach-exynos/exynos5250-pmu.c. Signed-off-by: Pankaj Dubey Reviewed-by: Krzysztof Kozlowski

[PATCH v4 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver

2015-11-10 Thread Pankaj Dubey
This patch moves exynos_sys_powerdown_conf function above all static functions. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/pmu.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH v4 9/9] drivers: soc: Add support for Exynos PMU driver

2015-11-10 Thread Pankaj Dubey
This patch moves Exynos PMU driver implementation from "arm/mach-exynos" to "drivers/soc/samsung". This driver is mainly used for setting misc bits of register from PMU IP of Exynos SoC which will be required to configure before Suspend/Resume. Currently all these settings are done in

Re: [PATCH v4] tests/exynos: add fimg2d performance analysis

2015-11-10 Thread Hyungwon Hwang
On Tue, 10 Nov 2015 14:23:51 +0100 Tobias Jakobi wrote: > Hello Hyungwon, > > > Hyungwon Hwang wrote: > > Hello Tobias, > > > > On Mon, 09 Nov 2015 10:47:13 +0100 > > Tobias Jakobi wrote: > > > >> Hello Hyungwon, > >> > >> > >>

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

2015-11-10 Thread Hyungwon Hwang
Hello Tobias, On Tue, 10 Nov 2015 14:24:11 +0100 Tobias Jakobi wrote: > Hello Hyungwon, > > > Hyungwon Hwang wrote: > > Hello Tobias, > > > > On Mon, 09 Nov 2015 10:47:02 +0100 > > Tobias Jakobi wrote: > > > >> Hello Hyungwon, >

RE: [PATCH v7 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-10 Thread Pavel Fedin
Hello! > > +- samsung,srom-timing : array of 6 integers, specifying bank timings in the > > +following order: Tacp, Tcah, Tcoh, Tacc, Tcos, > > Tacs. > > +Each value is specified in cycles and has the > > following > > +

Re: [PATCH v7 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-10 Thread Rob Herring
On Fri, Nov 6, 2015 at 4:03 AM, Pavel Fedin wrote: > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot implementation, but heavily reworked. > > Also, fix size of SROMc mapping in the example. > > Signed-off-by: Pavel Fedin

[PATCH 17/25] drm/exynos: fix clipping when scalling is enabled

2015-11-10 Thread Marek Szyprowski
This patch fixes calculation of src x/y offset for negative crtc x/y values when scalling is enabled. This fixes possible IOMMU fault when scalling is enabled. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 13 +++-- 1 file

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

2015-11-10 Thread Tobias Jakobi
Hello Hyungwon, Hyungwon Hwang wrote: > Hello Tobias, > > On Mon, 09 Nov 2015 10:47:02 +0100 > Tobias Jakobi wrote: > >> Hello Hyungwon, >> >> >> Hyungwon Hwang wrote: >>> Hello Tobias, >>> >>> I was in vacation last week, so I could run your code today. I found

[PATCH 21/25] drm/exynos: gem: remove old unused prototypes

2015-11-10 Thread Marek Szyprowski
This patch removes old, unused function prototypes from exynos_drm_gem.h. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_gem.h | 28 1 file changed, 28 deletions(-) diff --git

[PATCH 24/25] drm/exynos: add generic plane rotation property support

2015-11-10 Thread Marek Szyprowski
This patch adds generic plane rotation property for all supported drivers. This has been implemented with additional help from Exynos IPP (Exynos Image Post-Processing subsystem) with temporary framebuffers. Signed-off-by: Marek Szyprowski ---

[PATCH 10/25] drm/exynos: move dma_addr attribute from exynos plane to exynos fb

2015-11-10 Thread Marek Szyprowski
DMA address is a framebuffer attribute and the right place for it is exynos_drm_framebuffer not exynos_drm_plane. This patch also introduces helper function for getting dma address of the given framebuffer. Signed-off-by: Marek Szyprowski ---

[PATCH 05/25] drm/exynos: gsc: add device tree support and remove usage of static mappings

2015-11-10 Thread Marek Szyprowski
This patch adds device tree support for exynos_drm_gsc. This patch also fixed build issue on non-Exynos platforms, thus dependency on !ARCH_MULTIPLATFORM can be now removed. The driver cannot be used simultaneously with V4L2 Mem2Mem GScaller driver thought. Signed-off-by: Seung-Woo Kim

[PATCH 09/25] drm/exynos: exynos7-decon: remove excessive check

2015-11-10 Thread Marek Szyprowski
Display area is already checked by exynos plane core, so there is no need for such check in driver code. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 10 -- 1 file changed, 10 deletions(-) diff --git

[PATCH 03/25] drm/exynos: gsc: prepare and unprepare gsc clock

2015-11-10 Thread Marek Szyprowski
From: Seung-Woo Kim Ths patch changes the clk_enable and clk_disable call in gsc driver into clk_prepare_enable and clk_disable_unprepare. Signed-off-by: Seung-Woo Kim Signed-off-by: Marek Szyprowski ---

[PATCH 02/25] ARM: dts: exynos542x: add rotator node

2015-11-10 Thread Marek Szyprowski
This patch adds device node for Rotator device to Exynos 542x device tree file. Signed-off-by: Marek Szyprowski --- arch/arm/boot/dts/exynos5420.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi

[PATCH 07/25] drm/exynos: fix to calculate offset of each plane for ipp gsc

2015-11-10 Thread Marek Szyprowski
From: Seung-Woo Kim NV12 and YUV420 formats are needed to calculate offset of each plane in a gem buffer for ipp gsc. Without proper offset, only Y plane can be processed, so result shows green frame. This patch fixes to calculate offset for cbcr planes for NV12 and

[PATCH 20/25] drm/exynos: gem: set default alignment for dumb GEM buffers

2015-11-10 Thread Marek Szyprowski
This patch forces all GEM buffers to have pitch aligned at least to 8 pixels. This is a common requirement for various Exynos IPP blocks, which otherwise won't be able to operate on buffers of random size. Signed-off-by: Marek Szyprowski ---

[PATCH 16/25] drm/exynos: mixer: use ratio precalculated in exynos_state

2015-11-10 Thread Marek Szyprowski
Common plane code already calculates and checks for supported scalling modes, so additional code in mixer driver can be now removed. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_mixer.c | 33 +++-- 1 file changed, 3

[PATCH 12/25] drm/exynos: mixer: use crtc->state->adjusted_mode instead of crtc->mode

2015-11-10 Thread Marek Szyprowski
This patch replaces usage of crtc->mode with crtc->state->adjusted_mode like it is already done in common plane code. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_mixer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 19/25] drm/exynos: add fb pointer to exynos_drm_plane_state

2015-11-10 Thread Marek Szyprowski
Add framebuffer pointer to exynos_drm_plane_state and tell drivers to use it. This lets common plane code to set temporary framebuffer in the future and drivers will use it without additional changes. Signed-off-by: Marek Szyprowski ---

[PATCH 14/25] drm/exynos: introduce exynos_drm_plane_config structure

2015-11-10 Thread Marek Szyprowski
This patch adds common structure for keeping plane configuration and capabilities data. This patch is inspired by similar code developed by Tobias Jakobi. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 18 +++---

[PATCH 15/25] drm/exynos: add generic check for plane state

2015-11-10 Thread Marek Szyprowski
This patch adds generic check for plane state: pixel format and display area dimensions, so drivers can always assume that they get valid plane state to set. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 ++

[PATCH 01/25] ARM: dts: exynos4: add rotator nodes

2015-11-10 Thread Marek Szyprowski
This patch adds device node for Rotator device to Exynos 4210 and 4x12 device tree files. Signed-off-by: Marek Szyprowski --- arch/arm/boot/dts/exynos4.dtsi| 10 +- arch/arm/boot/dts/exynos4210.dtsi | 8 arch/arm/boot/dts/exynos4x12.dtsi | 4

[PATCH 11/25] drm/exynos: introduce exynos_drm_plane_state structure

2015-11-10 Thread Marek Szyprowski
This patch introduces exynos_drm_plane_state structure, which subclasses drm_plane_state and holds precalculated data suitable for configuring Exynos hardware. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 21 ++---

Re: [PATCH v4] tests/exynos: add fimg2d performance analysis

2015-11-10 Thread Tobias Jakobi
Hello Hyungwon, Hyungwon Hwang wrote: > Hello Tobias, > > On Mon, 09 Nov 2015 10:47:13 +0100 > Tobias Jakobi wrote: > >> Hello Hyungwon, >> >> >> Hyungwon Hwang wrote: >>> Hello, >>> >>> I think this patch should update .gitignore, not for adding the >>> built

[PATCH 08/25] drm/exynos: rotator: convert to common clock framework

2015-11-10 Thread Marek Szyprowski
This driver was not used after introduction of common clock framework. This patch adds missing prepare/unprepare calls and allows to use it again with current kernel code. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 ++-- 1 file

[PATCH 13/25] drm/exynos: mixer: enable video overlay plane only when VP is available

2015-11-10 Thread Marek Szyprowski
Video overlay plane should be registered only when suitable hardware sub-block (Video Processor) is available. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_mixer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

2015-11-10 Thread Marek Szyprowski
Dear All, This patch series introduces a new life into Exynos IPP (Image Post Processing) subsystem by integrating it (transparently for userspace applications) with Exynos DRM core plane management. This means that all CRTC drivers transparently get support for standard features of IPP subsystem

[PATCH 18/25] drm/exynos: fimd: fix dma burst size setting for small plane size

2015-11-10 Thread Marek Szyprowski
This patch fixes trashed display of buffers cropped to very small width. Even if DMA is unstable and causes tearing when changing the burst size, it is still better than displaying a garbage. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_fimd.c

[PATCH 04/25] drm/exynos: gsc: fix wrong pm_runtime state

2015-11-10 Thread Marek Szyprowski
From: Seung-Woo Kim At probe time, gsc clock is not enabled, so pm_runtime state should be deactive. So this patch removes pm_runtime_set_active() from gsc_probe(). Signed-off-by: Seung-Woo Kim Signed-off-by: Marek Szyprowski

[PATCH 06/25] drm/exynos: fix to calculate offset of each plane for ipp fimc

2015-11-10 Thread Marek Szyprowski
From: Seung-Woo Kim NV12 and YUV420 formats are need to calculate offset of each plane for ipp fimc in a gem buffer. Without proper offset, only Y plane can be processed, so result shows green frame. This patch fixes to calculate offset for cbcr planes for NV12 and YUV420

[PATCH 23/25] drm/exynos: ipp: make framework context global

2015-11-10 Thread Marek Szyprowski
IPP framework stored global context in driver data of its platform device. This patch moves it to global variable to simplify access. There exists only one such framework, so there is no drawback of this change. Signed-off-by: Marek Szyprowski ---

[PATCH 25/25] drm/exynos: add support for plane scaling

2015-11-10 Thread Marek Szyprowski
This patch adds support for plane scaling. Minor changes were needed to use existing Exynos IPP integration code for enabling scaling feature. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 8 +---

[PATCH 22/25] drm/exynos: gem: simplify access to exynos gem object

2015-11-10 Thread Marek Szyprowski
Replace calls to exynos_drm_gem_get_{dma_addr,size}, by a simpler function exynos_drm_gem_get(). This lets the caller to get access to exynos_drm_gem object and extract any information about GEM object without searching object tree for getting each parameter. Signed-off-by: Marek Szyprowski