Re: MFC Encode on S5PV210 hangs

2012-09-11 Thread Andrzej Hajda
On 09.09.2012 21:21, Mike Dyer wrote: Hi All, I'm trying to use the MFC encoder to generate an H264 bitstream using the V4L2 interface. I've tried using my own application, and also the example encode application here: git://git.infradead.org/users/kmpark/public-apps Both exhibit the same

Re: [PATCH RFC 3/3] drm/exynos: use pending_components for components tracking

2014-04-25 Thread Andrzej Hajda
On 04/23/2014 07:13 PM, Russell King - ARM Linux wrote: On Wed, Apr 23, 2014 at 05:43:28PM +0100, Russell King - ARM Linux wrote: So, maybe you would like to finally address *my* point about TDA998x and your solution in a way that provides a satisfactory answer. *Show* how it can be done, or

[RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-04-30 Thread Andrzej Hajda
Andrzej Hajda (4): drivers/base: add interface tracker framework drm/panel: add interface tracker support drm/exynos/dpi: add interface tracker support drm/panel/ld9040: do not power off panel on removal drivers/base/Makefile | 2 +- drivers/base/interface_tracker.c

[RFC PATCH 2/4] drm/panel: add interface tracker support

2014-04-30 Thread Andrzej Hajda
drm_panel framework allows only query for presence of given panel. It also does not protect panel module from unloading and does not provide solution for driver unbinding. interface_tracker should solve both issues. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- --- drivers/gpu/drm

[RFC PATCH 4/4] drm/panel/ld9040: do not power off panel on removal

2014-04-30 Thread Andrzej Hajda
Panel is powered off already by connector during drm_panel_remove call. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/panel/panel-ld9040.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ld9040.c b/drivers/gpu/drm/panel/panel-ld9040.c index

[RFC PATCH 3/4] drm/exynos/dpi: add interface tracker support

2014-04-30 Thread Andrzej Hajda
exynos_dpi uses connector polling for tracking panel presence, this solution introduces unnecessary 10s delay before panel activation. Moreover it is unsafe, module unloading or driver unbinding can cause system crash. interface_tracker support solves both problems. Signed-off-by: Andrzej Hajda

[RFC PATCH 1/4] drivers/base: add interface tracker framework

2014-04-30 Thread Andrzej Hajda
type. Object type depends on interface type, for example interface type drm_panel determines that object is a device_node. Object pointer is used to distinguish different interfaces of the same type and should identify object the interface is bound to. Signed-off-by: Andrzej Hajda a.ha

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-04-30 Thread Andrzej Hajda
Hi Greg, Thanks for comments. I CC Laurent, I hope it could be interesting for him also. Greg Kroah-Hartman wrote, On 30.04.2014 17:49: On Wed, Apr 30, 2014 at 04:02:50PM +0200, Andrzej Hajda wrote: Generic framework for tracking internal interfaces

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-05-01 Thread Andrzej Hajda
Russell King - ARM Linux wrote, On 01.05.2014 00:28: On Wed, Apr 30, 2014 at 11:42:09PM +0200, Andrzej Hajda wrote: The main problem with component framework is that componentization significantly changes every driver and changes it in a way which is not compatible with traditional drivers, so

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-05-05 Thread Andrzej Hajda
On 05/01/2014 11:11 AM, Russell King - ARM Linux wrote: On Thu, May 01, 2014 at 09:04:19AM +0200, Andrzej Hajda wrote: 2. You replace calls of component_add and component_del with calls to interface_tracker_ifup(dev, INTERFACE_TRACKER_TYPE_COMPONENT, specific_component_ops

Re: [RFC v3 PATCH v6 11/16] ARM: dts: s6e3fa0: add DT bindings

2014-05-05 Thread Andrzej Hajda
(commented by Laurent Pinchart) - Adds OLED detection, TE gpio properties Changelog v4: - Moves CPU timings relevant properties from FIMD DT (commeted by Laurent Pinchart, Andrzej Hajda) Changelog v5: - Fixes gpio property names (commented by Andrzej Hajda) Changelog v6: - Renames CPU timings

Re: [RFC v3 PATCH v2 10/16] drm/exynos: dsi: add driver data to support Exynos5420

2014-05-05 Thread Andrzej Hajda
this patch adds driver data to distinguish it. Changelog v2: - Moves exynos_dsi_enable_clocks() after exynos_dsi_reset() (commented by Andrzej Hajda) - Splits D-PHY control setting routines from PLL setting one (commented by Andrzej Hajda) Signed-off-by: YoungJun Cho yj44@samsung.com

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Andrzej Hajda
On 05/05/2014 09:52 PM, Ajay Kumar wrote: This patchset is based on exynos-drm-next-todo branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git I have just put up Rob's and Sean's idea of chaining up the bridges in code, and have implemented basic

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-08 Thread Andrzej Hajda
On 05/08/2014 12:26 PM, Ajay kumar wrote: Hi Andrej, On Thu, May 8, 2014 at 12:11 PM, Andrzej Hajda a.ha...@samsung.com wrote: On 05/05/2014 09:52 PM, Ajay Kumar wrote: This patchset is based on exynos-drm-next-todo branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-09 Thread Andrzej Hajda
On 05/08/2014 08:24 PM, Rob Clark wrote: On Thu, May 8, 2014 at 2:41 AM, Andrzej Hajda a.ha...@samsung.com wrote: On 05/05/2014 09:52 PM, Ajay Kumar wrote: This patchset is based on exynos-drm-next-todo branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-12 Thread Andrzej Hajda
On 05/09/2014 05:05 PM, Ajay kumar wrote: On Fri, May 9, 2014 at 7:29 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, May 9, 2014 at 5:08 AM, Andrzej Hajda a.ha...@samsung.com wrote: On 05/08/2014 08:24 PM, Rob Clark wrote: On Thu, May 8, 2014 at 2:41 AM, Andrzej Hajda a.ha...@samsung.com

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-13 Thread Andrzej Hajda
On 05/12/2014 02:45 PM, Rob Clark wrote: On Mon, May 12, 2014 at 3:06 AM, Andrzej Hajda a.ha...@samsung.com wrote: On 05/09/2014 05:05 PM, Ajay kumar wrote: On Fri, May 9, 2014 at 7:29 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, May 9, 2014 at 5:08 AM, Andrzej Hajda a.ha...@samsung.com

Re: [RFC V2 0/3] drm/bridge: panel and chaining

2014-05-13 Thread Andrzej Hajda
On 05/12/2014 06:00 PM, Sean Paul wrote: On Mon, May 12, 2014 at 3:06 AM, Andrzej Hajda a.ha...@samsung.com wrote: On 05/09/2014 05:05 PM, Ajay kumar wrote: On Fri, May 9, 2014 at 7:29 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, May 9, 2014 at 5:08 AM, Andrzej Hajda a.ha...@samsung.com

[PATCH 8/8] drm/exynos/fimc: simplify and rename fimc_dst_get_buf_seq

2014-05-19 Thread Andrzej Hajda
fimc_dst_get_buf_seq returns number of buffers so the name should be fimc_dst_get_buf_count. Function body has been simplified. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff

[PATCH 5/8] drm/exynos/fimc: simplify irq masking function

2014-05-19 Thread Andrzej Hajda
The name fimc_handle_irq suggests it is irq handler, but the function is for irq mask configuration. The patch renames the function to fimc_mask_irq and removes unused arguments. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 25

[PATCH 2/8] drm/exynos/ipp: correct ipp_id field initialization

2014-05-19 Thread Andrzej Hajda
prop_list.ipp_id field is not initialized properly. The patch fixes it, additionally it removes redundant field from ippdrv. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++ drivers/gpu/drm/exynos/exynos_drm_ipp.h | 1 - 2 files

[PATCH 3/8] drm/exynos/ipp: simplify property list allocation

2014-05-19 Thread Andrzej Hajda
prop_list is always allocated, so instead of allocating it dynamically the pointer can be replaced by the structure itself. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 10 ++ drivers/gpu/drm/exynos/exynos_drm_gsc.c | 10

[PATCH 6/8] drm/exynos/fimc: replace hw access macros with functions

2014-05-19 Thread Andrzej Hajda
HW access macros implicitly depended on presence of ctx local variable. This patch replaces them with C functions. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 311 +++ 1 file changed, 150 insertions(+), 161 deletions

[PATCH 7/8] drm/exynos/fimc: replace mutex by spinlock

2014-05-19 Thread Andrzej Hajda
Function fimc_dst_set_buf_seq is called by irq handler so it should not use mutexes. This patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 4/8] drm/exynos/fimc: simplify pre-scaler ratio calculation

2014-05-19 Thread Andrzej Hajda
The patch replaces dedicated function for scaling ratio calculation by fls calls. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 56 1 file changed, 13 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 1/8] drm/exynos/ipp: fix get_property IOCTL

2014-05-19 Thread Andrzej Hajda
Due to incorrect assignment in EXYNOS_IPP_GET_PROPERTY IOCTL handler this IOCTL did not work at all. The patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 0/8] drm/exynos/ipp: image post processing improvements

2014-05-19 Thread Andrzej Hajda
This set of independent patches contains various improvement and fixes for exynos_drm ipp framework and drivers. The patchset is based on drm-exynos/exynos-drm-next branch. Regards Andrzej Andrzej Hajda (8): drm/exynos/ipp: fix get_property IOCTL drm/exynos/ipp: correct ipp_id field

Re: [PATCH 01/18] drm/exynos: dsi: move the EoT packets configuration point

2014-05-20 Thread Andrzej Hajda
On 05/14/2014 08:26 AM, YoungJun Cho wrote: This configuration could be used in MIPI DSI command mode also. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Andrzej Hajda a.ha

Re: [PATCH 02/18] drm/exynos: use wait_event_timeout() for safety usage

2014-05-20 Thread Andrzej Hajda
. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_crtc.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [PATCH 14/18] drm/panel: add S6E3FA0 driver

2014-05-20 Thread Andrzej Hajda
. Reviewed-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/panel/Kconfig |7 + drivers/gpu/drm/panel/Makefile|1 + drivers/gpu/drm/panel/panel-s6e3fa0.c | 570 + 3 files changed, 578 insertions(+) create mode 100644 drivers/gpu

Re: [PATCH v4] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Andrzej Hajda
Hi Rahul, On 05/23/2014 04:19 AM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime.

[PATCH] drm/exynos: remove redundant mutex_unlock

2014-05-23 Thread Andrzej Hajda
The patch fixes unlocking in exynos_drm_component_del. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- Hi Inki, This patch is based on exynos_drm_next branch. Regards Andrzej --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH] drm/exynos/fimd: allow multiplatform configuration

2014-05-23 Thread Andrzej Hajda
The patch removes dependency on !ARCH_MULTIPLATFORM. This dependency seems to be not longer valid. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu

[PATCH] drm/exynos: add fimd dependency to fimd related encoders

2014-05-23 Thread Andrzej Hajda
DPI, DSI and DP drivers will not work without FIMD. The patch adds appropriate dependencies in Kconfig. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b

[PATCH 0/9] drm/exynos/ipp: image post processing improvements, part deux

2014-05-26 Thread Andrzej Hajda
This is the next part of ipp improvement patches, this time made by YoungJun Cho, I am posting them as he is on leave. The patchset is based on drm-exynos/exynos-drm-next branch. Regards Andrzej Andrzej Hajda (1): drm/exynos: ipp: remove description of non-existing field YoungJun Cho (8

[PATCH 8/9] drm/exynos: ipp: update comment for struct drm_ipp_buf_info

2014-05-26 Thread Andrzej Hajda
...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.h b/drivers/gpu/drm/exynos/exynos_drm_ipp.h index 09cb5a2..e06c41e 100644 --- a/drivers/gpu

[PATCH 6/9] drm/exynos: ipp: rearrange c_node-mem_lock using routines

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com The c_node-mem_list[] should be protected with c_node-mem_lock. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 5/9] drm/exynos: ipp: add ipp_remove_id()

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com This patch adds ipp_remove_id() for idr resource free. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 7/9] drm/exynos: ipp: rearrange c_node-event_lock using routine

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com The c_node-event_list should be protected with c_node-event_lock. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 9/9] drm/exynos: ipp: remove description of non-existing field

2014-05-26 Thread Andrzej Hajda
ipp_id field is removed from exynos_drm_ippdrv struct. The patch removes its description as well. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.h b/drivers/gpu

[PATCH 1/9] drm/exynos: ipp: remove usless list_empty() functions

2014-05-26 Thread Andrzej Hajda
Tested-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 61 + 1 file changed, 9 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index bf71d97..c8cfa24 100644

[PATCH 4/9] drm/exynos: ipp: add cmd_lock for cmd_list

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com This patch adds cmd_lock for cmd_list synchronization. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com

[PATCH 2/9] drm/exynos: ipp: remove duplicated setting

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com This patch removes duplicated setting. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm

[PATCH 3/9] drm/exynos: ipp: rename cmd_lock to lock

2014-05-26 Thread Andrzej Hajda
From: YoungJun Cho yj44@samsung.com The ippdrv-cmd_list requires cmd_lock. So renames cmd_lock to lock for context. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Seong-Woo Kim sw0312@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Andrzej Hajda a.ha

Re: [PATCH v2 13/18] ARM: dts: s6e3fa0: add DT bindings

2014-05-27 Thread Andrzej Hajda
Hi Thierry, On 05/26/2014 03:41 PM, Thierry Reding wrote: On Wed, May 21, 2014 at 01:43:05PM +0900, YoungJun Cho wrote: This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources, display timings and cpu mode timings. Signed-off-by: YoungJun Cho

Re: [PATCH v2 13/18] ARM: dts: s6e3fa0: add DT bindings

2014-05-28 Thread Andrzej Hajda
On 05/28/2014 06:50 AM, Inki Dae wrote: On 2014년 05월 28일 05:21, Thierry Reding wrote: On Tue, May 27, 2014 at 11:24:49PM +0900, Inki Dae wrote: 2014-05-27 16:53 GMT+09:00 Thierry Reding thierry.red...@gmail.com: On Tue, May 27, 2014 at 08:28:52AM +0200, Andrzej Hajda wrote: Hi Thierry

Re: [PATCH 2/2] drm/exynos: mipi-dsi: consider panel driver-deferred probe

2014-05-28 Thread Andrzej Hajda
Hi Inki, There is no problem with the DSI panels, so there is nothing to fix. DSI receives notifications about panel presence via mipi dsi bus, so it can attach/detach it to/from drm using connector's hotplug mechansim. Deferring DSI in unnecessary. Regards Andrzej On 05/27/2014 02:42 PM,

Re: [PATCH 1/2] drm/exynos: consider deferred probe case

2014-05-28 Thread Andrzej Hajda
Hi Inki, On 05/27/2014 02:42 PM, Inki Dae wrote: This patch makes sure that exynos drm framework handles deferred probe case correctly. Sub drivers could be probed before resources, clock, regulator, phy or panel, are ready for them so we should make sure that exynos drm core waits until

[PATCH] drm/panel/s6e8aa0: add backlight support

2014-05-29 Thread Andrzej Hajda
The patch adds backlight support to s6e8aa0 panel. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/panel/Kconfig | 2 ++ drivers/gpu/drm/panel/panel-s6e8aa0.c | 50 +++ 2 files changed, 52 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Andrzej Hajda
Hi Rahul, On 05/28/2014 08:11 AM, Rahul Sharma wrote: System hangs when FIMD registers are accessed to disable hardware overlays. This is because of the clocks which are not enabled before register access. 'Hardware overlay disable' is cleaned from the FIMD probe. Signed-off-by: Rahul

Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Andrzej Hajda
On 06/02/2014 12:11 PM, Tomasz Figa wrote: Hi Rahul, Andrzej, On 02.06.2014 11:42, Rahul Sharma wrote: On 2 June 2014 14:41, Andrzej Hajda a.ha...@samsung.com wrote: Hi Rahul, On 05/28/2014 08:11 AM, Rahul Sharma wrote: System hangs when FIMD registers are accessed to disable hardware

Re: [PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Andrzej Hajda
On 06/02/2014 12:42 PM, Andrzej Hajda wrote: On 06/02/2014 12:11 PM, Tomasz Figa wrote: Hi Rahul, Andrzej, On 02.06.2014 11:42, Rahul Sharma wrote: On 2 June 2014 14:41, Andrzej Hajda a.ha...@samsung.com wrote: Hi Rahul, On 05/28/2014 08:11 AM, Rahul Sharma wrote: System hangs when FIMD

Re: [RFC V3 2/3] drm/bridge: add a dummy panel driver to support lvds bridges

2014-06-03 Thread Andrzej Hajda
On 06/03/2014 11:58 AM, Ajay kumar wrote: On Tue, May 20, 2014 at 1:40 AM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, May 20, 2014 at 12:37:38AM +0530, Ajay kumar wrote: On 5/19/14, Thierry Reding thierry.red...@gmail.com wrote: On Sun, May 18, 2014 at 01:50:36PM +0530, Ajay kumar

Re: [PATCH v2] drm/exynos: consider deferred probe case

2014-06-04 Thread Andrzej Hajda
On 05/29/2014 11:28 AM, Inki Dae wrote: This patch makes sure that exynos drm framework handles deferred probe case correctly. Sub drivers could be probed before resources, clock, regulator, phy or panel, are ready for them so we should make sure that exynos drm core waits until all

Re: [PATCH v2] drm/exynos: consider deferred probe case

2014-06-04 Thread Andrzej Hajda
On 05/29/2014 11:28 AM, Inki Dae wrote: This patch makes sure that exynos drm framework handles deferred probe case correctly. Sub drivers could be probed before resources, clock, regulator, phy or panel, are ready for them so we should make sure that exynos drm core waits until all

Re: [PATCH v2] drm/exynos: consider deferred probe case

2014-06-05 Thread Andrzej Hajda
On 06/05/2014 05:42 AM, Inki Dae wrote: On 2014년 06월 04일 20:24, Andrzej Hajda wrote: On 05/29/2014 11:28 AM, Inki Dae wrote: This patch makes sure that exynos drm framework handles deferred probe case correctly. Sub drivers could be probed before resources, clock, regulator, phy or panel

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-10 Thread Andrzej Hajda
On 06/09/2014 03:43 PM, David Laight wrote: From: Of Andrzej Hajda ... You can't error out on module unload, although that's not really relevant here. gpiochip_remove() is typically called when the device that registered the GPIO chip is unbound. And despite some remove() callbacks having

Re: [PATCH] ARM: dts: remove display power domain for exynos5420

2014-06-18 Thread Andrzej Hajda
On 06/17/2014 07:49 AM, Rahul Sharma wrote: Hi All, Please review this patch. Regards, Rahul Sharma On 9 June 2014 16:58, Rahul Sharma rahul.sha...@samsung.com wrote: Display domain is removed due to instability issues. Explaining the problem below: exynos_init_late triggers the

Re: [PATCH] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-24 Thread Andrzej Hajda
Hi Ajay, On 06/24/2014 01:09 PM, Ajay Kumar wrote: Add the missing setting for DP CLKCON register. This register is present on Exynos5 based FIMD controllers, and needs to be used if we are using DP. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com ---

Re: [PATCH] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-24 Thread Andrzej Hajda
On 06/24/2014 03:14 PM, Ajay kumar wrote: On Tue, Jun 24, 2014 at 9:01 AM, Andrzej Hajda a.ha...@samsung.com wrote: Hi Ajay, On 06/24/2014 01:09 PM, Ajay Kumar wrote: Add the missing setting for DP CLKCON register. This register is present on Exynos5 based FIMD controllers, and needs

Re: [PATCH V3 1/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-27 Thread Andrzej Hajda
Hi Ajay, +CC DT On 06/27/2014 12:12 PM, Ajay Kumar wrote: Add the missing setting for DP CLKCON register. This register is present on Exynos5 based FIMD controllers, and needs to be set if we are using DP. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com ---

Re: [PATCH V3 1/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-27 Thread Andrzej Hajda
On 06/27/2014 01:48 PM, Ajay kumar wrote: Hi Andrej, On Fri, Jun 27, 2014 at 4:52 PM, Andrzej Hajda a.ha...@samsung.com wrote: Hi Ajay, +CC DT On 06/27/2014 12:12 PM, Ajay Kumar wrote: Add the missing setting for DP CLKCON register. This register is present on Exynos5 based FIMD

[PATCH 08/12] ARM: dts: exynos5420: convert magic numbers to macros in clock bindings

2013-09-05 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5420 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5420-clock.txt | 184 + arch/arm

[PATCH 12/12] clk: exynos5440: replace clock ID private enums with IDs from DT header

2013-09-05 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5440.c | 81 +++- 1 file

[PATCH 06/12] clk: exynos5250: replace clock ID private enums with IDs from DT header

2013-09-05 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5250.c | 501 --- 1 file

[PATCH 01/12] ARM: exynos4: create a DT header defining CLK IDs

2013-09-05 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos4.h | 231

[PATCH 09/12] clk: exynos5420: replace clock ID private enums with IDs from DT header

2013-09-05 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5420.c | 648 +-- 1 file

[PATCH 10/12] ARM: exynos5440: create a DT header defining CLK IDs

2013-09-05 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos5440.h | 29

[PATCH 00/12] clk/exynos convert clock IDs to macros

2013-09-05 Thread Andrzej Hajda
Andrzej Hajda (12): ARM: exynos4: create a DT header defining CLK IDs ARM: dts: exynos4: convert magic numbers to macros in clock bindings clk: exynos4: replace clock ID private enums with IDs from DT header ARM: exynos5250: create a DT header defining CLK IDs ARM: dts: exynos5250: convert magic

[PATCH 02/12] ARM: dts: exynos4: convert magic numbers to macros in clock bindings

2013-09-05 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos4 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos4-clock.txt| 259 + arch/arm/boot

[PATCH 04/12] ARM: exynos5250: create a DT header defining CLK IDs

2013-09-05 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos5250.h | 144

[PATCH 05/12] ARM: dts: exynos5250: convert magic numbers to macros in clock bindings

2013-09-05 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5250 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5250-clock.txt | 160 + arch/arm

[PATCH 11/12] ARM: dts: exynos5440: convert magic numbers to macros in clock bindings

2013-09-05 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5440 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5440-clock.txt | 45 +++--- arch/arm

[PATCH v2 11/12] ARM: dts: exynos5440: convert magic numbers to macros in clock bindings

2013-09-06 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5440 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5440-clock.txt | 45 +++--- arch/arm

[PATCH v2 12/12] clk: exynos5440: replace clock ID private enums with IDs from DT header

2013-09-06 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5440.c | 81 +++- 1 file

[PATCH v2 05/12] ARM: dts: exynos5250: convert magic numbers to macros in clock bindings

2013-09-06 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5250 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5250-clock.txt | 160 + arch/arm

[PATCH v2 07/12] ARM: exynos5420: create a DT header defining CLK IDs

2013-09-06 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos5420.h | 188

[PATCH v2 01/12] ARM: exynos4: create a DT header defining CLK IDs

2013-09-06 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos4.h | 244

[PATCH v2 08/12] ARM: dts: exynos5420: convert magic numbers to macros in clock bindings

2013-09-06 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5420 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5420-clock.txt | 184 + arch/arm

[PATCH v2 10/12] ARM: exynos5440: create a DT header defining CLK IDs

2013-09-06 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos5440.h | 42

[PATCH v2 06/12] clk: exynos5250: replace clock ID private enums with IDs from DT header

2013-09-06 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5250.c | 501 --- 1 file

[PATCH v2 02/12] ARM: dts: exynos4: convert magic numbers to macros in clock bindings

2013-09-06 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos4 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos4-clock.txt| 259 + arch/arm/boot

[PATCH v2 09/12] clk: exynos5420: replace clock ID private enums with IDs from DT header

2013-09-06 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5420.c | 648 +-- 1 file

Re: [PATCH v2 00/12] clk/exynos convert clock IDs to macros

2013-09-26 Thread Andrzej Hajda
On 09/16/2013 09:37 PM, Mike Turquette wrote: Quoting Sylwester Nawrocki (2013-09-16 07:33:45) On 09/12/2013 12:50 PM, Kukjin Kim wrote: Well...I'm not sure changing to use macro is better or not at this moment... I think it is. ;) It's really less error prone to have symbolic names instead

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-26 Thread Andrzej Hajda
Hi Mark, Thanks for the review, sorry for late response. On 09/20/2013 07:06 PM, Mark Rutland wrote: On Fri, Sep 06, 2013 at 11:31:06AM +0100, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2

Re: [PATCH v2 00/12] clk/exynos convert clock IDs to macros

2013-10-07 Thread Andrzej Hajda
On 10/06/2013 10:27 PM, Mike Turquette wrote: Quoting Kukjin Kim (2013-10-04 19:16:56) Mike Turquette wrote: Quoting Kukjin Kim (2013-09-30 03:11:41) Mike Turquette wrote: Quoting Sylwester Nawrocki (2013-09-16 07:33:45) On 09/12/2013 12:50 PM, Kukjin Kim wrote: Well...I'm not sure changing

Re: [PATCH v2 00/12] clk/exynos convert clock IDs to macros

2013-10-28 Thread Andrzej Hajda
Ping Regards Andrzej On 10/07/2013 10:46 AM, Andrzej Hajda wrote: On 10/06/2013 10:27 PM, Mike Turquette wrote: Quoting Kukjin Kim (2013-10-04 19:16:56) Mike Turquette wrote: Quoting Kukjin Kim (2013-09-30 03:11:41) Mike Turquette wrote: Quoting Sylwester Nawrocki (2013-09-16 07:33:45

Re: [PATCH V4] spi: s3c64xx: Enable Word transfer

2013-11-13 Thread Andrzej Hajda
On 11/10/2013 06:26 PM, Tomasz Figa wrote: On Friday 08 of November 2013 11:05:17 Mark Brown wrote: On Thu, Nov 07, 2013 at 10:39:37AM +0100, Tomasz Figa wrote: On Thursday 07 of November 2013 14:52:36 Rajeshwari Birje wrote: The reordering of the words is taken care by the Swap configuration

[PATCH v10 2/2] s5k5baf: add DT bindings for camera sensor

2013-12-05 Thread Andrzej Hajda
The patch adds the DT bindings documentation for Samsung S5K5BAF Image Sensor. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Mark Rutland mark.rutl...@arm.com --- v10 - bindings moved to separate patch, - improved clocks

[PATCH v10 0/2] S5K5BAF camera sensor driver

2013-12-05 Thread Andrzej Hajda
Hi, This is the 10th iteration of S5K5BAF camera patch (time for celebration). All changes are described in patches. Regards Andrzej Andrzej Hajda (2): s5k5baf: add camera sensor driver s5k5baf: add DT bindings for camera sensor .../devicetree/bindings/media/samsung-s5k5baf.txt | 58

[PATCH RESEND v2 00/12] clk/exynos convert clock IDs to macros

2014-01-07 Thread Andrzej Hajda
alignement in headers, - added comment to CLK_NR_CLKS, - added copyright headers, - split long lines in dts, - corrected example in bindings/clock/exynos5250-clock.txt, to point appropriate clocks. Regards Andrzej Andrzej Hajda (12): ARM: exynos4: create a DT header defining CLK IDs ARM: dts

[PATCH RESEND v2 04/12] ARM: exynos5250: create a DT header defining CLK IDs

2014-01-07 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos5250.h | 159

[PATCH RESEND v2 05/12] ARM: dts: exynos5250: convert magic numbers to macros in clock bindings

2014-01-07 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5250 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5250-clock.txt | 162 + arch/arm

[PATCH RESEND v2 07/12] ARM: exynos5420: create a DT header defining CLK IDs

2014-01-07 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos5420.h | 188

[PATCH RESEND v2 08/12] ARM: dts: exynos5420: convert magic numbers to macros in clock bindings

2014-01-07 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5420 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5420-clock.txt | 184 + arch/arm

[PATCH RESEND v2 01/12] ARM: exynos4: create a DT header defining CLK IDs

2014-01-07 Thread Andrzej Hajda
The patch adds header file defining clock IDs. This allows to use macros instead of magic numbers in DT bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/dt-bindings/clock/exynos4.h | 244

[PATCH RESEND v2 02/12] ARM: dts: exynos4: convert magic numbers to macros in clock bindings

2014-01-07 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos4 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos4-clock.txt| 259 + arch/arm/boot

[PATCH RESEND v2 06/12] clk: exynos5250: replace clock ID private enums with IDs from DT header

2014-01-07 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5250.c | 559 +-- 1 file

[PATCH RESEND v2 11/12] ARM: dts: exynos5440: convert magic numbers to macros in clock bindings

2014-01-07 Thread Andrzej Hajda
The patch replaces magic numbers with macros defined in DT header in exynos5440 clock bindings. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/clock/exynos5440-clock.txt | 45 +++--- arch/arm

[PATCH RESEND v2 09/12] clk: exynos5420: replace clock ID private enums with IDs from DT header

2014-01-07 Thread Andrzej Hajda
The patch replaces private enum clock IDs in the driver with macros provided by the DT header. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/clk/samsung/clk-exynos5420.c | 648 +-- 1 file

  1   2   3   4   5   6   >