[PATCH 1/2] ARM: exynos4: Fix build error due to 'gic_bank_offset' undeclared

2011-12-01 Thread Axel Lin
only once arch/arm/mach-exynos/cpu.c:245: error: for each function it appears in.) arch/arm/mach-exynos/cpu.c:243: warning: unused variable 'bank_offset' make[1]: *** [arch/arm/mach-exynos/cpu.o] Error 1 make: *** [arch/arm/mach-exynos] Error 2 Signed-off-by: Axel Lin axel@gmail.com --- arch

[PATCH 2/2] ARM: exynos4: Fix build error

2011-12-01 Thread Axel Lin
Trivial fix to fix below build error: CC arch/arm/mach-exynos/mach-universal_c210.o arch/arm/mach-exynos/mach-universal_c210.c:24: error: expected identifier or '(' before '' token Signed-off-by: Axel Lin axel@gmail.com --- arch/arm/mach-exynos/mach-universal_c210.c |2 +- 1

[linux-next] make s5p64x0_defconfig build error

2011-12-13 Thread Axel Lin
Hi, I got below build error on linux-next 20111213. CC arch/arm/kernel/process.o In file included from arch/arm/mach-s5p64x0/include/mach/system.h:16, from arch/arm/kernel/process.c:64: arch/arm/plat-samsung/include/plat/system-reset.h:19:2: error: #error Fix me up

Re: [linux-next] make s5p64x0_defconfig build error

2011-12-14 Thread Axel Lin
Hi Kukjin, Axel and Will, thanks for pointing out. Oops, I couldn't have much time to follow up :( But let me look at that in this weekend and I know, it can be escaped before merge window :) I also found the same build errors by: make s5pc100_defconfig make s5pv210_defconfig make

[PATCH] spi: s3c24xx: Convert to let spi core validate bits_per_word

2014-02-14 Thread Axel Lin
Set bits_per_word_mask so spi core will reject transfers that attempt to use an unsupported bits_per_word value. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/spi-s3c24xx.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/spi/spi-s3c24xx.c b

[RFT][PATCH 1/2] spi: s3c24xx: Add missing spi_master_{resume,suspend} calls to PM callbacks

2014-03-04 Thread Axel Lin
This is required since commit 2025172e3280 spi/bitbang: Use core message pump. spi-bitbang now uses core message pump, so it needs to call spi_master_suspend/ spi_master_resume to start/stop the queue while suspend/resume. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/spi-s3c24xx.c

[PATCH] spi: s3c24xx: Convert to use devm_kzalloc

2014-03-30 Thread Axel Lin
Simplify the cleanup code. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/spi-s3c24xx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index bed2338..6db14e5 100644 --- a/drivers/spi/spi-s3c24xx.c

[PATCH] phy: samsung_usb2: Fixup samsung_usb2_phy_power_on/off paths

2015-03-16 Thread Axel Lin
Ensure we have balanced clk_prepare_enable/clk_disable_unprepare calls if .power_on or .power_off callbacks return error. Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/phy-samsung-usb2.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy

[PATCH] phy: exynos-mipi-video: Fix unbalanced lock on non-regmap path

2015-03-10 Thread Axel Lin
Remove the second lock on non-regmap path. Fixes: 278270e39efa (phy: exynos-mipi-video: Use spin_lock to protct state-regmap rmw operations) Reported-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/phy-exynos-mipi-video.c | 1 - 1 file changed

[PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array

2015-03-02 Thread Axel Lin
Current code uses num_phys settings to tell the number of entries in phys. Thus remove the NULL terminating entry from phys array which is not necessary. Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12-usb2.c | 1 - drivers/phy

[PATCH] phy: exynos5-usbdrd: Fix off-by-one valid value checking for args-args[0]

2015-02-27 Thread Axel Lin
Current code uses args-args[0] as array subscript of phy_drd-phys[]. So the valid value range for args-args[0] is 0 ... EXYNOS5_DRDPHYS_NUM - 1. Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/phy-exynos5-usbdrd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] phy: exynos-mipi-video: Fixup the test for state-regmap

2015-02-25 Thread Axel Lin
syscon_regmap_lookup_by_phandle() returns ERR_PTR on error. Thus don't use null test against state-regmap. Signed-off-by: Axel Lin axel@ingics.com --- drivers/phy/phy-exynos-mipi-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-exynos-mipi-video.c

[PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state-regmap rmw operations

2015-02-26 Thread Axel Lin
The state-regmap is initialized by devm_regmap_init_mmio(). So it's fine to use spin_lock rather than mutex to protct state-regmap rmw operations. Signed-off-by: Axel Lin axel@ingics.com --- Hi Sylwester, I don't have this hardware handy, so can you test if this patch works. This patch

[PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function

2015-02-26 Thread Axel Lin
If IS_ERR(state-regs) the .probe fails. So IS_ERR(state-regs) test in exynos_dp_video_phy_pwr_isol() is not necessary. exynos_dp_video_phy_pwr_isol() simply does a regmap_update_bits() call now, just call regmap_update_bits() instead and return proper return value. Signed-off-by: Axel Lin axel