Re: [oselas] Mini2440 boot failure on kernel 3.7-rc1

On 11/13/2012 01:29 PM, Sylwester Nawrocki wrote: On 11/13/2012 08:54 AM, Brian Norris wrote: On Mon, Nov 12, 2012 at 3:18 PM, Sylwester Nawrocki Can you please list a full 8-byte string of id_data[]? This will be very helpful. I know of at least one solution that will fix your problem

Re: [PATCH] mtd: s3c2410: Move to clk_prepare_enable/clk_disable_unprepare

On Mon, Jun 30, 2014 at 10:12:16PM +0300, Vasily Khoruzhick wrote: Use clk_prepare_enable/clk_disable_unprepare to make the driver work properly with common clock framework. Signed-off-by: Vasily Khoruzhick anars...@gmail.com Pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from this

Re: [PATCH 14/17] mtd: onenand: remove s5pc100 related onenand codes

: Kyungmin Park kyungmin.p...@samsung.com Cc: David Woodhouse dw...@infradead.org Cc: Brian Norris computersforpe...@gmail.com --- drivers/mtd/onenand/Kconfig |4 ++-- drivers/mtd/onenand/samsung.c | 25 + 2 files changed, 3 insertions(+), 26 deletions(-) diff --git

Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string

to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. I'm a little late for this one, but I can apply this instead: From: Brian Norris computersforpe...@gmail.com Date: Fri, 6 Feb 2015 03:25:28 -0800 Subject: [PATCH] mtd: s3c2410: drop useless / misspelled debug

Re: [PATCH 04/11] mtd: ofpart: do not fail probe when no partitions exist

On Wed, Jun 03, 2015 at 09:26:40PM -, Michal Suchanek wrote: On Exynos it is necessary to set SPI controller parameters that apply to a SPI slave in a DT subnode of the slave device. The ofpart code returns an error when there are subnodes of the SPI flash but no partitions are found.

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

On Wed, Jul 29, 2015 at 06:19:24PM +0200, Michal Suchanek wrote: On 29 July 2015 at 16:00, Mark Brown broo...@kernel.org wrote: On Wed, Jul 29, 2015 at 12:19:57PM +0200, Michal Suchanek wrote: Please use subject lines matching the style for the subsytsem so people can spot that the patch

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

On Wed, Jul 15, 2015 at 07:15:50PM +0200, Marek Vasut wrote: On Wednesday, July 15, 2015 at 05:59:46 PM, Brian Norris wrote: 1. Fix up the SPI driver so that it knows how to break large SPI transfers up into smaller segments that its constituent hardware (DMA controllers, fast clocks, etc

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

Hi Michal, On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: The problem is, if you add a new DT binding, you'd have to support it forever, no matter how bad idea that binding turned out to be. Agreed, and a solid NAK to this patch. I could have sworn I gave such a response when

Re: [PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris

Re: [PATCH 18/27] mtd: nand: update mtd_to_nand()

On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote: > Now that all drivers are using the mtd instance embedded in the nand_chip Do you have a script that verifies this? I thought you did at some point, and it'd be nice to note it, so I can also use it to verify things once it gets

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

Hi Yakir, On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > On 11/03/2015 12:38 PM, Brian Norris wrote: > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > >(FYI, I came across this by inspection when comparing Heiko's > >'somewhat-stable' branch

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

Hi Yakir, On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > Add phy driver for the Rockchip DisplayPort PHY module. This > is required to get DisplayPort working in Rockchip SoCs. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang >

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

Hi, A few updates: On Tue, Nov 03, 2015 at 05:13:48PM -0800, Brian Norris wrote: > On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > > On 11/03/2015 12:38 PM, Brian Norris wrote: > > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > &

Re: [PATCH v2 17/25] mtd: nand: remove useless mtd->priv = chip assignments

On Tue, Dec 01, 2015 at 12:03:14PM +0100, Boris Brezillon wrote: > mtd_to_nand() now uses the container_of() approach to transform an > mtd_info pointer into a nand_chip one. Drop useless mtd->priv > assignments from NAND controller drivers. > > Signed-off-by: Boris Brezillon

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris

Re: [PATCH v2 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

On Tue, Dec 01, 2015 at 12:03:09PM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris Brezillon

Re: [PATCH v3 bis 12/25] mtd: nand: use the mtd instance embedded in struct nand_chip

Hi Boris, On Wed, Dec 02, 2015 at 09:50:01AM +0100, Boris Brezillon wrote: > struct nand_chip now embeds an mtd device. Patch all drivers to make use > of this mtd instance instead of using the instance embedded in their > private struct or dynamically allocated. > > Signed-off-by: Boris

Re: [PATCH v2 00/25] mtd: nand: refactor the NAND subsystem (part 1)

Hi, On Tue, Dec 01, 2015 at 12:02:57PM +0100, Boris Brezillon wrote: > Hello, > > This huge series aims at clarifying the relationship between the mtd and > nand_chip structures and hiding NAND framework internals to NAND > controller drivers. > > The first part of the series provide an

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

Hi Boris, On Fri, Dec 11, 2015 at 11:03:05PM +0100, Boris Brezillon wrote: > On Thu, 10 Dec 2015 16:40:08 -0800 > Brian Norris <computersforpe...@gmail.com> wrote: > > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > > Unregister the NAND device f

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > Unregister the NAND device from the NAND subsystem when removing a denali > NAND controller, otherwise the MTD attached to the NAND device is still > exposed by the MTD layer, and accesses to this device will likely crash > the

Re: [PATCH v4 00/58] mtd: nand: refactor the NAND subsystem (part 1)

Hi, On Thu, Dec 10, 2015 at 08:59:44AM +0100, Boris Brezillon wrote: > Hello, > > This huge series aims at clarifying the relationship between the mtd and > nand_chip structures and hiding NAND framework internals to NAND > controller drivers. > > The first part of the series (patch 1 to 4) is

Re: [PATCH v4 55/58] mtd: nand: add helpers to access ->priv

Hi Boris, On Thu, Dec 10, 2015 at 09:00:39AM +0100, Boris Brezillon wrote: > Add two helpers to access the field reserved for private controller data. > This makes it clearer what this field is reserved for and ease future > refactoring. I agree with the refactoring part, but I'm not sure about

Re: [PATCH 01/27] mtd: nand: fix drivers abusing mtd->priv

On Mon, Nov 16, 2015 at 02:37:34PM +0100, Boris Brezillon wrote: > The ->priv field of the mtd_info object attached to a nand_chip device > should point to the nand_chip device. The pxa and cafe drivers are > assigning this field their own private structure, which works fine as long > as the

Re: [PATCH 03/27] mtd: nand: update examples in the documentation to use mtd_to_nand()

On Mon, Nov 16, 2015 at 02:37:36PM +0100, Boris Brezillon wrote: > mtd_to_nand() has been introduced to hide accesses to mtd->priv. > All NAND controller drivers should use it instead of directly accessing > the ->priv field. > > Signed-off-by: Boris Brezillon

Re: [PATCH 02/27] mtd: nand: add an mtd_to_nand() helper

On Mon, Nov 16, 2015 at 02:37:35PM +0100, Boris Brezillon wrote: > Some drivers are retrieving the nand_chip pointer using the container_of > macro on a struct wrapping both the nand_chip and the mtd_info struct while > the standard way of retrieving this pointer is through mtd->priv. > Provide an