[PATCH v2] mmc: dt: Consolidate DT bindings

2012-05-12 Thread Chris Ball
a...@arndb.de [cjb: typo fixes, addition of max-frequency property] Signed-off-by: Chris Ball c...@laptop.org --- Changes since Arnd's v1: * Typo fix from Stephen Warren: s/interrupt/interrupts/ * Typo fix: s/non-removable/ti,non-removable/. This one's being preserved for backwards compatibility

Re: [PATCH v2] mmc: dt: Consolidate DT bindings

2012-05-13 Thread Chris Ball
it to Linus without conflicts. (Alternatively I can take it in mmc-next and Linus can handle the conflicts.) Thanks! - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug

2012-05-17 Thread Chris Ball
time. Signed-off-by: Kyoungil Kim ki0351@samsung.com ---  drivers/mmc/host/dw_mmc.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) Yes, looks correct. Acked-by: Will Newton will.new...@imgtec.com Thanks, pushed to mmc-next for 3.5. - Chris. -- Chris Ball c

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-15 Thread Chris Ball
. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Chris Ball
Hi Thomas, On Thu, Aug 16 2012, Thomas Abraham wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Chris Ball
Hi, On Thu, Aug 16 2012, Thomas Abraham wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- Changes

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Chris Ball
came from, aside from knowing which gpio it is and whether it needs to be inverted (with cd-inverted)? Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
; + return pdata; } #else So, I'd say: - broken-cd: when present, indicates that there is no card-detect line available on the host; polling should be used instead. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
on the host is working and brought out to a GPIO. external-cd-gpios: The CD pin on the host is broken, but there's an independent external GPIO available. (Each host should only have one of these properties.) Thanks, - Chris. -- Chris Ball c...@laptop.org

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
Hi, adding Shawn and Wolfram, On Tue, Aug 21 2012, Arnd Bergmann wrote: On Tuesday 21 August 2012, Chris Ball wrote: How about this? broken-cd: No CD available, use polling. cd-gpios: The CD pin on the host is working and brought out to a GPIO. external-cd-gpios: The CD pin on the host

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-21 Thread Chris Ball
and the controller generates appropriate interrupts to notify changes in card-state. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
- currently samsung,sdhci-cd-none cd-gpios - currently samsung,sdhci-cd-gpios non-removable - currently samsung,sdhci-cd-permanent cd-gpios + samsung,sdhci-cd-external - currently samsung,sdhci-cd-external How does that sound? Thanks, - Chris. -- Chris Ball c...@laptop.org http

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
-by: Chris Ball c...@laptop.org Reverting the commit will get controller mode back to work. Weird; I wonder how that's related to card detection. I'm afraid it's ultimately a driver bug -- esdhc should be able to handle having set_clock called with a value of 0. It seems to have a case

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
) the driver will poll for card-detection as if a broken-cd property was provided. I'll send out the new core bindings doc shortly. Finishing off another thread -- the samsung-sdhci.txt name is okay. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Chris Ball
Hi Stephen, On Wed, Aug 22 2012, Stephen Warren wrote: On 08/22/2012 04:17 AM, Chris Ball wrote: Hi, On Wed, Aug 22 2012, Shawn Guo wrote: The following is what I have on my mind. broken-cd cd-gpiosimplication

[PATCH] mmc: dt: Add card-detection properties to core binding.

2012-08-22 Thread Chris Ball
Signed-off-by: Chris Ball c...@laptop.org --- Documentation/devicetree/bindings/mmc/mmc.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt index 8a6811f..8e2e0ba 100644

Re: [PATCH v5] mmc: sdhci-s3c: Add device tree support

2012-09-17 Thread Chris Ball
Hi, On Mon, Sep 17 2012, Thomas Abraham wrote: On 23 August 2012 22:40, Thomas Abraham thomas.abra...@linaro.org wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c

Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-19 Thread Chris Ball
required bus clock source. 2.Handle the disabling of old bus clock and enables the best clock selected in sdhci_s3c_set_clock(). Signed-off-by: Chander Kashyap chander.kash...@linaro.org Thanks, pushed to mmc-next for 3.7. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One

Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-19 Thread Chris Ball
); clk_disable(sc-clk_bus[sc-cur_clk]); Thanks, pushed to mmc-next for 3.7. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-19 Thread Chris Ball
-cur_clk]); + ret = sdhci_runtime_resume_host(host); + return ret; } #endif Could I get an ACK on this patch from one of you, please? - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-09-19 Thread Chris Ball
of the dw-mmc device tree support patch series. Will Newton has acked this patch series. Can this series be merged for v3.7 ? Yes, looks good; pushed to mmc-next for 3.7. Jaehoon and Seungwon, if you reply soon with your ACK then I'll add it to this patchset. Thanks, - Chris. -- Chris Ball c

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-19 Thread Chris Ball
Hi, On Wed, Sep 19 2012, Jaehoon Chung wrote: Looks good to me. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Thanks, pushed to mmc-next for 3.7. (The patch didn't merge cleanly so I applied it by hand; let me know if anything looks wrong.) - Chris. -- Chris Ball c...@laptop.org http

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Chris Ball
Hi Tomasz, On Wed, Sep 19 2012, Tomasz Figa wrote: Hi Chris, On Wednesday 19 of September 2012 01:42:01 Chris Ball wrote: On Tue, Sep 04 2012, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Chris Ball
, */ voltage = regulator_get_voltage(supply); - if (mmc-caps2 MMC_CAP2_BROKEN_VOLTAGE) + if (regulator_count_voltages(supply) == 1) min_uV = max_uV = voltage; if (voltage 0) -- Chris Ball c

Re: [PATCH v2 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-21 Thread Chris Ball
: - Wrapped clk_disable in probe and clk_enable in remove with #ifdef CONFIG_PM_RUNTIME conditional check. Thanks, pushed to mmc-next for 3.7. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung

Re: [PATCH v6 8/9] mmc: dw_mmc: add support for implementation specific callbacks

2012-09-23 Thread Chris Ball
patch but Stephen Rothwell's asked for people to hold off rebasing now that -rc7 is out, which is reasonable.) Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH] mmc: sdhci-s3c: use clk_prepare_enable and clk_disable_unprepare

2012-10-23 Thread Chris Ball
Hi, On Tue, Oct 02 2012, Thomas Abraham wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Thanks, pushed to mmc-next for 3.8. - Chris. -- Chris Ball c

Re: [PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-10-23 Thread Chris Ball
, MMC_DEBUG [=n]. Hence this patch enables the dw_mmc controller interrupt before mmc_start_host. Signed-off-by: Yuvaraj CD yuvaraj...@samsung.com Is Yuvaraj CD your legal name? We should use your full name so that we can track copyright attribution properly. Thanks! - Chris. -- Chris Ball

Re: [PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-10-25 Thread Chris Ball
Hi, On Thu, Oct 25 2012, Yuvaraj CD wrote: Yes,its legal name.Yuvaraj C D. Thanks for letting me know; pushed to mmc-next for 3.7. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl

2012-11-25 Thread Chris Ball
Hi, On Wed, Nov 21 2012, Thomas Abraham wrote: nit: there could have been one example each for gpio and pinctrl variant instead of putting both into one example node. Tomasz, do you want to reply to this review comment? Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net

Re: [PATCH 3/5] sdhci-s3c: increase the timeout value

2010-08-27 Thread Chris Ball
using SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK instead, so this wasn't merged. Would you like to resubmit with that change? -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge

2010-09-20 Thread Chris Ball
to solve it is to use spin_lock_irqsave/irqrestore() calls. Thanks, applied to mmc-next with: Signed-off-by: Chris Ball c...@laptop.org Andrew, not sure how best to get this upstream -- do you want to send this up to Linus (for -rc5) via your queue in -mm? -- Chris Ball c...@laptop.org http

Re: [PATCH] sdhci-s3c: fix NULL ptr access in sdhci_s3c_remove

2010-09-23 Thread Chris Ball
]); + if (sc-clk_bus[ptr]) { + clk_disable(sc-clk_bus[ptr]); + clk_put(sc-clk_bus[ptr]); + } } clk_disable(sc-clk_io); clk_put(sc-clk_io); I'll send this to Linus for .36 after you reply with an ACK. Thanks, -- Chris Ball c

Re: [PATCH] sdhci-s3c: fix NULL ptr access in sdhci_s3c_remove

2010-09-26 Thread Chris Ball
Hi Kyungmin, On Sun, Sep 26, 2010 at 07:53:48PM +0900, Kyungmin Park wrote: On Sun, Sep 26, 2010 at 7:53 AM, Chris Ball c...@laptop.org wrote: On Thu, Sep 23, 2010 at 12:08:03PM -0700, Andrew Morton wrote: The patch applies OK to 2.6.35.  Is the bug present there as well?  If so, should we

[GIT PULL] MMC fixes for .36-rc6

2010-09-26 Thread Chris Ball
in -next. Thanks. The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786: Al Viro (1): alpha: fix usp value in multithreaded coredumps are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git for-linus Chris Ball (1

Re: [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-29 Thread Chris Ball
Hi Kyungmin, Ben, On Thu, Sep 30, 2010 at 10:18:12AM +0900, Kyungmin Park wrote: On Sat, Sep 18, 2010 at 12:59 AM, Chris Ball c...@laptop.org wrote: Hi, On Thu, Sep 16, 2010 at 06:08:28PM +0900, Kyungmin Park wrote: Well there are two implementations. and no conclusion yet. as s5pc210

Re: [PATCH] mmc: sdhci-s3c: let device core setup the default pin configuration

2013-03-22 Thread Chris Ball
on the deprecated Samsung specific gpio bindings is also removed. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, pushed to mmc-next for 3.10. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child

Re: [PATCH 09/30] mmc: sdhci-s3c: remove platform dependencies

2013-04-10 Thread Chris Ball
structure not needed by the driver, so we can split out the platform_data definition instead and leave the rest to platform code. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: linux-...@vger.kernel.org Cc: Chris Ball c...@laptop.org Acked-by: Chris Ball c...@laptop.org - Chris. -- Chris Ball

Re: [PATCH v5] mmc: dw_mmc: let device core setup the default pin configuration

2013-04-12 Thread Chris Ball
, pushed to mmc-next for 3.10. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH V6 RESEND 2/2] mmc: core: Add Poweroff Notify handling eMMC 4.5

2011-10-10 Thread Chris Ball
mmc-next, fix, and resend? - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH V6 RESEND 2/2] mmc: core: Add Poweroff Notify handling eMMC 4.5

2011-10-11 Thread Chris Ball
branch that the pull request is for: http://git.infradead.org/users/kmpark/linux-2.6-samsung/commitdiff/dac139c9591545a40ea0058d9305514130762682 and it has the same problems I'm replying to here. Maybe the wrong version got merged? Thanks, - Chris. -- Chris Ball c...@laptop.org http

Re: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-13 Thread Chris Ball
will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). For suspend mode short timeout is used, whereas for the normal poweroff long timeout is used. cc: Chris Ball c...@laptop.org Signed-off-by: Girish K S girish.shivananja

Re: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Chris Ball
Hi, On Mon, Oct 17 2011, Girish K S wrote: After fetching your mmc-next branch. i can see that this patch is already applied. How about the changes that have been pointed here? Thanks, it's in mmc-next for testing -- please do resend the patch and I'll fold in your changes. - Chris. -- Chris

Re: [PATCH] mmc: core: Modify the timeout value for writing power class

2011-10-17 Thread Chris Ball
Hi, On Tue, Oct 18 2011, Seungwon Jeon wrote: This patch will apply the generic CMD6 timeout to switch command for power class. Signed-off-by: Seungwon Jeon tgih@samsung.com Thanks, applied to mmc-next for 3.2. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Chris Ball
instead of the power class patch. Would be great if you can double-check that the merge all looks okay to you. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-18 Thread Chris Ball
Hi, On Tue, Oct 18 2011, Girish K S wrote: missing one thing.unsigned intpower_notify_type; in include/linux/mmc/host.h is not alligned to the above member, which was done in my latest patch Fixed. Thanks! - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One

Re: [PATCH] mmc: core: Assemble the codes of related to eMMC4.5

2011-10-24 Thread Chris Ball
: return err; The rest looks good, thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RESEND] mmc: core: Assemble the codes of related to eMMC4.5

2011-10-25 Thread Chris Ball
members of card structure are already set to zero at card-init. Signed-off-by: Seungwon Jeon tgih@samsung.com Thanks, pushed to mmc-next for 3.2. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH RESEND V4] mmc: core: HS200 mode support for eMMC 4.5

2011-10-26 Thread Chris Ball
type in the sdhci.c file to add support for eMMC tuning function. So card.h file is included to import the card data structure. cc: Chris Ball c...@laptop.org Signed-off-by: Girish K S girish.shivananja...@linaro.org The long case statements and conditionals in this patch make it pretty dense

Re: [PATCH V5 1/3] SDHCI: S3C: Use generic clock names for sdhci bus clock options

2011-10-26 Thread Chris Ball
); continue; } Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mmc: core: Fix setting power notify state variable for non eMMC

2011-11-11 Thread Chris Ball
Hi, On Fri, Nov 11 2011, Ulf Hansson wrote: Girish K S wrote: This patch skips the setting of the power notify state variable for non eMMC 4.5 devices. Also fixes the problem of omap_hsmmc noisy/broken for suspend resume reported by kevin Hilman. cc: Chris Ball c...@laptop.org Signed-off

Re: [PATCH] mmc: core: Fix power_off_notify during suspend

2011-11-15 Thread Chris Ball
girish.shivananja...@linaro.org Thanks, pushed to mmc-next for 3.2. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] mmc: dw_mmc: Add more capabilities field

2011-12-24 Thread Chris Ball
-caps = 0; + if (host-pdata-caps2) + mmc-caps2 = host-pdata-caps2; + else + mmc-caps2 = 0; + + I think the else clause is unnecessary here (and above), so I'll suggest merging this patch to mmc-next for 3.3 and also adding: From: Chris Ball c...@laptop.org

Re: [PATCH RESEND] mmc: dw_mmc: Support predefined mutiple block transfers

2011-12-24 Thread Chris Ball
-by: Will Newton will.new...@imgtec.com Thanks, pushed to mmc-next for 3.3 with Will's ACK and suggested change. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH] mmc: core: Fix voltage select in DDR mode

2011-12-24 Thread Chris Ball
the extended csd value if (ddr == EXT_CSD_CARD_TYPE_DDR_1_2V) cc: Philip Rakity prak...@marvell.com cc: Arindam Nath arindam.n...@amd.com cc: Chris Ball c...@laptop.org Signed-off-by: Girish K S girish.shivananja...@linaro.org Pushed to mmc-next for 3.3 with ACKs from Philip and Subhash

Re: [PATCH v2] mmc: dw_mmc: Add second capability field

2011-12-24 Thread Chris Ball
-caps; + mmc-caps2 |= host-pdata-caps2; Ah, I replied earlier without having seen this patch. I still prefer the version I proposed, which doesn't dereference host-pdata-caps{,2} without testing it first. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child

Re: [PATCH V9 0/2] HS200 Mode support for device and host

2012-01-08 Thread Chris Ball
SDHCI_CTRL_DRV_TYPE_B0x -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V9 2/2] mmc: host: Adds support for eMMC 4.5 HS200 mode

2012-01-08 Thread Chris Ball
) == SDHCI_CTRL_UHS_SDR104) || + requires_tuning_nonuhs) ctrl |= SDHCI_CTRL_EXEC_TUNING; else { spin_unlock(host-lock); -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3 2/2] mmc: sdhci-s3c: add platform data for the second capability

2012-02-06 Thread Chris Ball
-host_caps; + if (pdata-host_caps2) + host-mmc-caps2 |= pdata-host_caps2; + ret = sdhci_add_host(host); if (ret) { dev_err(dev, sdhci_add_host() failed\n); In case you'd rather merge both of these via the samsung-soc tree: Acked-by: Chris Ball c

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-02-11 Thread Chris Ball
a very strong opinion, but I think it's probably better to go via the mmc tree since the patch is so large and hence the chance of conflict before merging is high. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-02-21 Thread Chris Ball
that you'll do the merge to Linus.) - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-03-02 Thread Chris Ball
Hi, On Wed, Feb 22 2012, Mark Brown wrote: On Tue, Feb 21, 2012 at 08:17:41AM -0500, Chris Ball wrote: Pushed to mmc-next, thanks. (I'm expecting that you'll do the merge to Linus.) I've been sending patches adding runtime PM support to this driver for a while with no response

Re: [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend

2012-03-08 Thread Chris Ball
, - .resume = sdhci_s3c_resume, + SET_SYSTEM_SLEEP_PM_OPS(sdhci_s3c_suspend, sdhci_s3c_resume) }; #define SDHCI_S3C_PMOPS (sdhci_s3c_pmops) Thanks, pushed to mmc-next for 3.4 with Jaehoon's ACK. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child

Re: [PATCH 2/2] mmc: sdhci-s3c: Enable runtime power management

2012-03-08 Thread Chris Ball
that runtime PM is enabled for this device. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Chris Ball c...@laptop.org --- drivers/mmc/host/sdhci-s3c.c | 28 1 files changed, 28 insertions

Re: [PATCH] drivers: mmc: sdhci-s3c: fix broken compilation for non-Exynos SoCs

2012-03-15 Thread Chris Ball
, - .data = exynos4_sdhci_drv_data }, + .data = EXYNOS4_SDHCI_DRV_DATA }, {}, }; MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); Thanks, pushed to mmc-next for 3.4 with Jaehoon's ACK. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-03-27 Thread Chris Ball
Hi Kukjin, On Tue, Feb 21 2012, Chris Ball wrote: On Tue, Feb 21 2012, Kukjin Kim wrote: I created topic branch for this we talked. You can pull that following: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.4-for-cjb If any problems, please kindly let me know

Re: [PATCH v3 0/6] mmc: sdhci-s3c: Rework platform data and add device tree support

2012-03-31 Thread Chris Ball
, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-04-09 Thread Chris Ball
in mmc-next once you get time to post a v2 covering Stephen Warren's review comments (and adding max-frequency to the document, I guess). - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-04-10 Thread Chris Ball
of that document, or in the code or shipped .dts files. (Presumably you decided to preserve it for backwards compatibility, so the bindings documentation shouldn't be changed.) Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list

Re: [PATCH v4 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-12-19 Thread Chris Ball
an ACK from Ben, but I will accept it into mmc-next for the .38 merge window, and Ben can yell sometime before the merge if he doesn't agree. Does that work okay for you? Thanks, -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line

Re: [PATCH] mmc: dw_mmc: set the card_width bit per card.

2011-06-20 Thread Chris Ball
] and CTYPE[0] correspond respectively to card[15] and CTYPE[0] for 1-bit or 4-bit mode. Signed-off-by: Seungwon Jeon tgih@samsung.com Acked-by: Will Newton will.new...@imgtec.com Pushed to mmc-next for 3.1, thanks. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop

Re: [PATCH] mmc: dw_mmc: protect a sequence of request and request-done.

2011-06-20 Thread Chris Ball
. And Data error interrupt(DRTO, DCRC, SBE, EBE) and data transfer over(DTO) are same reanson. Signed-off-by: Seungwon Jeon tgih@samsung.com Acked-by: Will Newton will.new...@imgtec.com Pushed to mmc-next for 3.1, thanks. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One

Re: [PATCH] mmc: sdhci-s3c: Fix return value in sdhci_s3c_suspend/resume()

2011-07-09 Thread Chris Ball
= platform_get_drvdata(dev); - sdhci_resume_host(host); - return 0; + return sdhci_resume_host(host); } #else Thanks, pushed to mmc-next for 3.1. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line

Re: [PATCH] mmc: sdhci-s3c: Fix mmc card I/O problem

2011-08-28 Thread Chris Ball
the previous bus mode and apply the new mode setting. Signed-off-by: Girish K S girish.shivananja...@linaro.org Thanks, pushed to mmc-next for 3.1 with a stable@ tag. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line

Re: [PATCH] mmc: core: Fix the incorrect calculation for erase unit size.

2011-09-08 Thread Chris Ball
to stable@, etc. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] mmc: core: Fix the incorrect calculation for erase unit size.

2011-09-13 Thread Chris Ball
this was a problem, should this patch be applied to stable@, etc. It is mentioned from eMMC Spec. Erase unit size is defined in 512Kbyte * HC_ERASE_GRP_SIZE(EXT_CSD[224]). You haven't answered any of the other questions I asked, though. Thanks, - Chris. -- Chris Ball c...@laptop.org http

Re: [PATCH v2 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-21 Thread Chris Ball
any conflicts. Thanks, pushed to mmc-next for 3.2. I've been waiting for kernel.org to come back up, but I think later today I'll just move mmc-next to git://dev.laptop.org/users/cjb/mmc, so this will be available in linux-next soon. - Chris. -- Chris Ball c...@laptop.org http://printf.net

Re: [PATCH v3] mmc: core: Add default timeout value for CMD6.

2011-09-21 Thread Chris Ball
at this point: patching file drivers/mmc/core/mmc.c patch: malformed patch at line 39: @@ -668,7 +677,8 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line

Re: [PATCH] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-21 Thread Chris Ball
value here so that we can investigate. Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mmc: core: HS200 mode support for eMMC 4.5

2011-09-21 Thread Chris Ball
. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: card: modify mmc_getgeo function

2011-09-21 Thread Chris Ball
constants Reuse heads/sectors instead of duplicating them in the cylinders calculation. Signed-off-by: Girish K S girish.shivananja...@linaro.org Signed-off-by: Chris Ball c...@laptop.org - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop

Re: [PATCH V3] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-22 Thread Chris Ball
: This patch version removes some checkpatch error v3: updated with review comments made by chris ball. patch generated by rebasing to chris balls mmc-next branch. The mmc.h patch doesn't apply against today's mmc-next branch -- maybe due to a patch I pushed yesterday, also make sure that you're

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
, EXT_CSD_CMD_SET_NORMAL, + EXT_CSD_POWER_CLASS, + pwrclass_val, + 0); + } + + return err; +} Thanks, - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child

Re: [PATCH V4] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
. - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V5] mmc: core: eMMC 4.5 Power Class Selection Feature

2011-09-23 Thread Chris Ball
class is available then switch to the power class and use the higher data bus. If power class is not supported then switch to the lower data bus in a worst case. Signed-off-by: Girish K S girish.shivananja...@linaro.org Thanks, pushed to mmc-next for 3.2 now. - Chris. -- Chris Ball c

Re: [PATCH] mmc: card: modify mmc_getgeo function

2011-09-26 Thread Chris Ball
] Error 2 Interesting, thanks. It builds fine here on my (gcc-4.6) ARM toolchains. Looking online, I think you're hitting an old gcc-4.3 bug? - Chris. -- Chris Ball c...@laptop.org http://printf.net/ One Laptop Per Child -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 0/6] mmc: sdhci-s3c: Fix base clock source management

2014-03-03 Thread Chris Ball
Hi, On Mon, Mar 03 2014, Tomasz Figa wrote: It's been almost two months since I posted this series, it's been already ACKed and it would be nice to have it applied for upcoming release. Sorry about this, Tomasz -- now pushed to mmc-next for 3.15, thanks. - Chris. -- Chris Ball ch