On 05/09/2012 01:53 PM, Kukjin Kim wrote:
amit kachhap wrote:
Hi Mr Kukjin,
Any comment or update about this patch?
I'm not sure we don't need to check the idle_time?
Others, looks ok to me.
Hi,
may be I misunderstood your question but the behavior is not changed
here, just the code is
On 05/14/2012 10:57 AM, Mark Brown wrote:
On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
Are these patches ok for inclusion ?
you might want to include the maintainer
On 05/14/2012 10:57 AM, Mark Brown wrote:
On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
Are these patches ok for inclusion ?
you might want to include the maintainer
On 05/14/2012 03:51 PM, Kukjin Kim wrote:
On 05/14/12 18:22, Daniel Lezcano wrote:
On 05/14/2012 10:57 AM, Mark Brown wrote:
On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
On 05/09/2012 04:08 PM, Daniel Lezcano wrote
to test these patches.
Daniel Lezcano (2):
ARM: s3c64xx: cpuidle - declare the states with the new api
ARM: s3c64xx: cpuidle - use timekeeping wrapper
arch/arm/mach-s3c64xx/cpuidle.c | 45 +--
1 files changed, 15 insertions(+), 30 deletions(-)
--
1.7.5.4
The states are now part of the cpuidle_driver structure, so we can
declare the states in this structure directly. That saves us an extra
variable declaration and a memcpy.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-s3c64xx/cpuidle.c | 33
The timekeeping is computed from the cpuidle core if we set
the .en_core_tk_irqen flag. Let's use it and remove the duplicated
code.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-s3c64xx/cpuidle.c | 12 +---
1 files changed, 1 insertions(+), 11 deletions
A trivial patch to replace for_each_cpu(cpu_id, cpu_online_mask) by
the corresponding macro.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm
We register the device for cpu1 but with only one state which
is actually WFI. This one is already the default idle function
when no cpuidle device is set for the cpu.
We can remove the cpuidle device for this cpu as it is the same
code path than the pm_idle callback.
Signed-off-by: Daniel
fails.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
index f8dd1cd..a5fe194 100644
--- a/arch/arm/mach
The states are defined in the driver. We can get rid of the
intermediate cpuidle states initialization and the memcpy by
directly initializing the driver states.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 45
or unplugged. That clarifies the code and
make it simpler.
Signed-off: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 117 +++-
1 file changed, 69 insertions(+), 48 deletions(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm
On 01/10/2013 11:33 PM, amit daniel kachhap wrote:
On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano daniel.lezc...@free.fr
wrote:
On 01/10/2013 09:07 PM, amit daniel kachhap wrote:
Hi Daniel,
Hi Amit Daniel,
This hotplug noifiers looks fine. I suppose it should add extra state
C1 in cpu0
On 01/18/2013 04:51 AM, Kukjin Kim wrote:
Daniel Lezcano wrote:
On 01/10/2013 11:33 PM, amit daniel kachhap wrote:
On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano daniel.lezc...@free.fr
wrote:
On 01/10/2013 09:07 PM, amit daniel kachhap wrote:
Hi Daniel,
Hi Amit Daniel,
This hotplug
Hi all,
why is the exynos not using the TWD as local timers ?
Probably already asked, but I was not able to find an detailed answer
for that [1]
Thanks
-- Daniel
[1] http://www.spinics.net/lists/arm-kernel/msg218906.html
--
http://www.linaro.org/ Linaro.org │ Open source software for ARM
Using the exynos4_defconfig and compiling the kernel from the samsung
git tree at 3.9-rc1, I am stuck.
Does anyone have any idea ?
Thanks !
-- Daniel
U-Boot 2013.01.-rc1 (Dec 08 2012 - 12:15:17) for ORIGEN
CPU:Exynos4210@1000MHz
On 03/29/2013 10:24 AM, ning.n.ji...@gmail.com wrote:
From: Ning Jiang ning.n.ji...@gmail.com
Currently there are two problems when we try to stop local timer.
First, it calls set_mode function directly so mode state is not
updated for the clock event device. Second, it makes the device
On 03/29/2013 10:24 AM, ning.n.ji...@gmail.com wrote:
From: Ning Jiang ning.n.ji...@gmail.com
Currently there are two problems when we try to stop local timer.
First, it calls set_mode function directly so mode state is not
updated for the clock event device. Second, it makes the device
On 04/23/2013 04:41 PM, Daniel Lezcano wrote:
Remove the duplicated code and use the cpuidle common code for initialization.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
Hi Kim and Ben,
It is the last patch in the series which was not acked-by.
Rafael is willing to take
, Daniel Lezcano wrote:
The following driver is for exynos4210. I did not yet finished the
other boards, so
I created a specific driver for 4210 which could be merged later.
The driver is based on Colin Cross's driver found at:
https://android.googlesource.com/kernel/exynos
On 04/24/2014 11:21 AM, Vincent Guittot wrote:
Use the clocksource mct-frc for sched_clock
Signed-off-by: Vincent Guittot vincent.guit...@linaro.org
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
[ ... ]
--
http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs
Follow
On 05/09/2014 02:02 PM, Tomasz Figa wrote:
Hi Arnd,
On 09.05.2014 12:56, Arnd Bergmann wrote:
On Friday 11 April 2014, Daniel Lezcano wrote:
No more dependency on the arch code. The platform_data field is used to set the
PM callback as the other cpuidle drivers.
Signed-off-by: Daniel Lezcano
On 05/14/2014 10:03 AM, Chander Kashyap wrote:
Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7 cores.
This patchset adds cpuidle support for Exynos5420 SoC based on
generic big.little cpuidle driver.
Hi Chander,
just a side question. I am not succeeding to have both
b.zolnier...@samsung.com
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
--
http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro Facebook |
http://twitter.com/#!/linaroorg Twitter |
http://www.linaro.org/linaro-blog/ Blog
On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote:
Add S5P_CENTRAL_SEQ_OPTION register setup for EXYNOS4x12 to AFTR
mode code. Without this setup AFTR mode doesn't show any benefit
over WFI one. When this setup is applied AFTR mode reduces power
consumption by ~12% (as measured on Trats2
On 05/15/2014 10:40 PM, Kukjin Kim wrote:
[ ... ]
Exynos cpuidle is not a device on the SoC, so I don't think there is
any
way to represent it in DT. The only thing I could see this is matching
root node with a central SoC driver that instantiates specific
subdevices, such as cpufreq and
On 05/21/2014 10:10 AM, Arnd Bergmann wrote:
On Wednesday 21 May 2014 09:15:34 Daniel Lezcano wrote:
On 05/15/2014 10:40 PM, Kukjin Kim wrote:
[ ... ]
Exynos cpuidle is not a device on the SoC, so I don't think there is
any
way to represent it in DT. The only thing I could see
On 05/22/2014 08:35 PM, Kukjin Kim wrote:
On 04/26/14 20:05, Kukjin Kim wrote:
Tomasz Figa wrote:
On 14.04.2014 11:01, Daniel Lezcano wrote:
Hi Kukjin,
I believe I addressed all the comments. Is it possible to take this
patchset for next ?
Sure ;-)
+1.
Also when applying you might
On 05/22/2014 08:35 PM, Kukjin Kim wrote:
On 04/26/14 20:05, Kukjin Kim wrote:
Tomasz Figa wrote:
On 14.04.2014 11:01, Daniel Lezcano wrote:
Hi Kukjin,
I believe I addressed all the comments. Is it possible to take this
patchset for next ?
Sure ;-)
+1.
Also when applying you might
sysram_base_addr non-static, declared it in common.h and used
in pm.c instead of S5P_VA_SYSRAM.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Suggested-by: Tomasz Figa t.f...@samsung.com
---
arch/arm/mach-exynos/common.h |1 +
arch/arm/mach-exynos/platsmp.c |2 +-
arch/arm/mach-exynos/pm.c
On 05/24/2014 07:24 PM, Daniel Lezcano wrote:
A look at the code reveals use of S5P_VA_SYSRAM macro, in case of certain SoC
revisions, which is not valid any longer, after SYSRAM started to be mapped
dynamically. The new dynamic mapping is stored in sysram_base_addr variable,
which is declared
the compatible strings of
SoC's using this driver.
Signed-off-by: Chander Kashyap chander.kash...@linaro.org
Signed-off-by: Chander Kashyap k.chan...@samsung.com
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
---
drivers/cpuidle/cpuidle-big_little.c | 11 ++-
1 file changed
On 05/28/2014 06:35 AM, Kukjin Kim wrote:
Chander Kashyap wrote:
On 26 May 2014 15:59, Tomasz Figa tomasz.f...@gmail.com wrote:
Hi Chander,
On 16.05.2014 10:03, Chander Kashyap wrote:
Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7
cores.
This patchset adds cpuidle
...@samsung.com
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
---
Changes in v4:
1. Typo fixed from SOC_EXYNOS5420 to ARCH_EXYNOS
2. Commit message updated
Changes in v3: None
Changes in v2:
1. Changed config macro from SOC_EXYNOS5420 to ARCH_EXYNOS
drivers/cpuidle
Hi all,
I am trying an upstream kernel + some patches to enable ethernet on
arndale octa.
Unfortunately, only 4 cores boot up. The other ones fail to boot.
[12.179453] CPU6: failed to come online
[13.189479] CPU7: failed to come online
[14.199479] CPU4: failed to come online
[15.209743]
On 04/24/2014 07:42 PM, Tomasz Figa wrote:
Hi Daniel,
Please see my comments inline.
Btw. Please fix your e-mail composer to properly wrap your messages
around 7xth column, as otherwise they're hard to read.
On 04.04.2014 11:48, Daniel Lezcano wrote:
The following driver is for exynos4210. I
On 05/30/2014 03:33 PM, Andreas Färber wrote:
Hi,
Am 30.05.2014 11:25, schrieb Daniel Lezcano:
I am trying an upstream kernel + some patches to enable ethernet on
arndale octa.
Unfortunately, only 4 cores boot up. The other ones fail to boot.
[12.179453] CPU6: failed to come online
On 06/02/2014 02:08 PM, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Friday, May 16, 2014 11:03:11 AM Daniel Lezcano wrote:
On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote:
Add S5P_CENTRAL_SEQ_OPTION register setup for EXYNOS4x12 to AFTR
mode code. Without this setup AFTR mode doesn't
b.zolnier...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm
On 06/02/2014 02:35 PM, Bartlomiej Zolnierkiewicz wrote:
* Use do_idle firmware method instead of cpu_do_idle() on boards with
secure firmware enabled.
* Use sysram_ns_base_addr + 0x24 address for exynos_boot_vector_addr()
and sysram_ns_base_addr + 0x20 one for exynos_boot_vector_flag()
On 06/11/2014 10:50 AM, Krzysztof Kozlowski wrote:
On pią, 2014-04-04 at 11:48 +0200, Daniel Lezcano wrote:
The following driver is for exynos4210. I did not yet finished the other
boards, so
I created a specific driver for 4210 which could be merged later.
The driver is based on Colin
On 06/04/2014 07:30 PM, Doug Anderson wrote:
In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we
supported using the MCT as a scheduler clock. We properly marked
exynos4_read_sched_clock() as notrace. However, we then went and
called another function that _wasn't_ notrace.
On 06/16/2014 06:40 AM, Doug Anderson wrote:
Daniel,
On Sun, Jun 15, 2014 at 2:18 PM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
On 06/04/2014 07:30 PM, Doug Anderson wrote:
In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we
supported using the MCT as a scheduler
On 06/04/2014 07:30 PM, Doug Anderson wrote:
In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we
supported using the MCT as a scheduler clock. We properly marked
exynos4_read_sched_clock() as notrace. However, we then went and
called another function that _wasn't_ notrace.
On 06/19/2014 01:17 AM, Doug Anderson wrote:
Amit,
Thanks for posting!
On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap
amit.dan...@samsung.com wrote:
This patch register the exynos mct clocksource as the current timer
as it has constant clock rate. This will generate correct udelay for
On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote:
This patch register the exynos mct clocksource as the current timer
as it has constant clock rate. This will generate correct udelay for the
exynos platform and avoid using unnecessary calibrated jiffies. This change
has been tested on
On 06/19/2014 12:21 PM, amit daniel kachhap wrote:
On Thu, Jun 19, 2014 at 2:41 PM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote:
This patch register the exynos mct clocksource as the current timer
as it has constant clock rate
On 06/19/2014 05:49 PM, Doug Anderson wrote:
Daniel,
On Thu, Jun 19, 2014 at 2:07 AM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
On 06/19/2014 01:17 AM, Doug Anderson wrote:
Amit,
Thanks for posting!
On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap
amit.dan...@samsung.com wrote
On 06/19/2014 07:08 PM, Doug Anderson wrote:
In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we
supported using the MCT as a scheduler clock.
Hi Thomas,
is it possible you update the tip/timers/core so I can get visibility on
the above patch to apply this one ?
Thanks
Is there something I missed ?
Thanks !
-- Daniel
On Mon, Jun 23, 2014 at 2:32 AM, Andreas Färber afaer...@suse.de wrote:
Am 30.05.2014 11:25, schrieb Daniel Lezcano:
Hi all,
I am trying an upstream kernel + some patches to enable ethernet on
arndale octa.
Unfortunately, only 4 cores boot up. The other
exynos4_enter_idle(dev, drv, new_index);
+ return arm_cpuidle_simple_enter(dev, drv, new_index);
else
return exynos4_enter_core0_aftr(dev, drv, new_index);
}
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
--
http://www.linaro.org/ Linaro.org │ Open source software
-by: Daniel Lezcano daniel.lezc...@linaro.org
--
http://www.linaro.org/ Linaro.org │ Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro Facebook |
http://twitter.com/#!/linaroorg Twitter |
http://www.linaro.org/linaro-blog/ Blog
--
To unsubscribe from this list
On 09/02/2013 11:41 AM, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 02, 2013 10:54:17 AM Daniel Lezcano wrote:
On 08/30/2013 12:21 PM, Bartlomiej Zolnierkiewicz wrote:
Add cpuidle-exynos.max_states= parameter to allow user to specify
the maximum of allowed CPU idle states for ARM
On 09/02/2013 03:48 PM, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 02, 2013 03:18:51 PM Daniel Lezcano wrote:
On 09/02/2013 11:41 AM, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 02, 2013 10:54:17 AM Daniel Lezcano wrote:
On 08/30/2013 12:21 PM, Bartlomiej Zolnierkiewicz
On 09/02/2013 04:43 PM, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 02, 2013 04:24:23 PM Daniel Lezcano wrote:
On 09/02/2013 03:48 PM, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 02, 2013 03:18:51 PM Daniel Lezcano wrote:
On 09/02/2013 11:41 AM, Bartlomiej Zolnierkiewicz
)
[0.249748] [c00143cc] (secondary_start_kernel+0xec/0x138) from
[40008664] (0x40008664)
[0.249767] ---[ end trace 3406ff24bd97382e ]---
Cc: Daniel Lezcano daniel.lezc...@linaro.org
Cc: Thomas Gleixner t...@linutronix.de
Cc: Kukjin Kim kgene@samsung.com
Cc: linux-arm-ker
On 09/26/2013 12:32 PM, Tomasz Figa wrote:
Hi Daniel,
On Thursday 26 of September 2013 02:39:25 Daniel Lezcano wrote:
On 09/25/2013 04:49 PM, Ming Lei wrote:
This patch moves request_irq() out of cpu notifier callback
to fix below lockdep warning:
[0.249513] [ cut here
On 09/27/2013 03:09 PM, Ming Lei wrote:
On Thu, Sep 26, 2013 at 6:32 PM, Tomasz Figa t.f...@samsung.com wrote:
This is a fix that we may want to have, but it must be modified to take
my regression fix[1] into account.
[1] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online
On 10/14/2013 05:08 PM, Vyacheslav Tyrtov wrote:
From: Tarek Dakhran t.dakh...@samsung.com
Add EDCS(Exynos Dual Cluster Support) for Samsung Exynos5410 SoC.
This enables all 8 cores, 4 x A7 and 4 x A15 run at the same time.
IIUC, the 5410 has a CCI-400 bug preventing to use the two clusters
On 10/17/2013 04:32 PM, Dave Martin wrote:
On Thu, Oct 17, 2013 at 12:45:29PM +0200, Daniel Lezcano wrote:
On 10/14/2013 05:08 PM, Vyacheslav Tyrtov wrote:
From: Tarek Dakhran t.dakh...@samsung.com
Add EDCS(Exynos Dual Cluster Support) for Samsung Exynos5410 SoC.
This enables all 8 cores, 4 x
.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-s3c64xx/cpuidle.c | 38 --
arch/arm/mach-s3c64xx/pm.c | 33 ++---
2 files changed, 42 insertions(+), 29 deletions(-)
diff --git a/arch/arm/mach
There is no more dependency with the arch dependant code, thanks to the platform
driver conversion.
Move the driver to the drivers/cpuidle like the other drivers.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-s3c64xx/Makefile |1 -
drivers
On 10/25/2013 12:39 PM, Tomasz Figa wrote:
Hi Daniel,
[Sending again, without HTML part. Sorry for the noise.]
On Friday 25 of October 2013 09:11:13 Daniel Lezcano wrote:
The driver is tied with the pm low level code making difficult to split
the driver into a more arch independent code
On 10/25/2013 10:52 PM, Tomasz Figa wrote:
On Friday 25 of October 2013 21:13:35 Daniel Lezcano wrote:
On 10/25/2013 12:39 PM, Tomasz Figa wrote:
Hi Daniel,
[Sending again, without HTML part. Sorry for the noise.]
On Friday 25 of October 2013 09:11:13 Daniel Lezcano wrote:
The driver
On 10/25/2013 03:23 PM, Daniel Lezcano wrote:
[ ... ]
Won't it be worth to add a new WFI_SLEEP state to the cpuidle driver ?
I don't think so. How a suspend-to-RAM specific thing like WFI_SLEEP
could
be relevant to a cpuidle driver? (Unless there are some plans to
consolidate STR
On 10/30/2013 03:40 PM, Tomasz Figa wrote:
Hi Daniel,
On Wednesday 30 of October 2013 14:43:51 Daniel Lezcano wrote:
On 10/25/2013 03:23 PM, Daniel Lezcano wrote:
[ ... ]
Won't it be worth to add a new WFI_SLEEP state to the cpuidle driver
?
I don't think so. How a suspend-to-RAM specific
-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Daniel Lezcano daniel.lezc...@linaro.org
Cc: Kukjin Kim kgene@samsung.com
---
arch/arm/mach-exynos/cpuidle.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions
On 12/20/2013 07:47 PM, Bartlomiej Zolnierkiewicz wrote:
dev-state_count is now always equal to drv-state_count so
it can be removed.
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Daniel Lezcano daniel.lezc
systems can hotplug a cpu
at runtime after the kernel has booted case.
Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Len Brown l...@kernel.org
---
drivers/idle
b.zolnier...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Len Brown l...@kernel.org
Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org
---
drivers/idle/intel_idle.c | 29 -
1 file changed, 29 deletions(-)
diff --git a/drivers/idle
to intel_idle_cpu_init() (which is also called during CPU_ONLINE
operation).
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Cc: Len Brown l...@kernel.org
Reviewed-by: Daniel Lezcano daniel.lezc...@linaro.org
---
drivers/idle
On 01/22/2014 09:08 AM, Jingoo Han wrote:
On Tuesday, January 21, 2014 6:03 PM, Jingoo Han wrote:
According to the datasheet of Exynos SoCs, the counter bit
of CPU local timers is 31-bit, not 32-bit; thus, it should
be fixed.
Please, ignore this patch.
There is a 31-bit counter in CPU local
Hi all,
I tried the v3.14 kernel and unplugged the cpu1. That leads to a kernel
hang without any trace.
If I disable the cpuidle AFTR state through sysfs before unplugging
cpu1, it works well.
I reproduced the issue on v3.14, v3.13, v3.12, v3.11
v3.10 works fine.
I tried to git bisect
On 04/01/2014 01:04 PM, Krzysztof Kozlowski wrote:
On Tue, 2014-04-01 at 12:43 +0200, Daniel Lezcano wrote:
Hi all,
I tried the v3.14 kernel and unplugged the cpu1. That leads to a kernel
hang without any trace.
If I disable the cpuidle AFTR state through sysfs before unplugging
cpu1
On 04/01/2014 01:22 PM, Tomasz Figa wrote:
Hi Daniel,
On 01.04.2014 12:43, Daniel Lezcano wrote:
Hi all,
I tried the v3.14 kernel and unplugged the cpu1. That leads to a kernel
hang without any trace.
If I disable the cpuidle AFTR state through sysfs before unplugging
cpu1, it works well
On 04/01/2014 02:29 PM, Tomasz Figa wrote:
On 01.04.2014 14:16, Daniel Lezcano wrote:
On 04/01/2014 01:22 PM, Tomasz Figa wrote:
Hi Daniel,
On 01.04.2014 12:43, Daniel Lezcano wrote:
Hi all,
I tried the v3.14 kernel and unplugged the cpu1. That leads to a kernel
hang without any trace
Move the structure below the 'exynos4_enter_lowpower' function so no more
need of forward declaration.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 40 ++--
1 file changed, 18 insertions(+), 22 deletions
The driver was initially written for exynos4 but the driver is used also for
exynos5.
Change the function prefix name exynos4 - exynos
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 20 ++--
1 file changed, 10 insertions(+), 10
This function should be called only when the powerdown sequence fails.
Even if the current code does not hurt, by moving this line, we have the same
code than the one in pm.c.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |5 ++---
1 file changed
Use the cpu_pm_enter/exit notifier to group some pm code inside the pm file.
The save and restore code is duplicated across pm.c and cpuidle.c. By using
the cpu_pm notifier, we can factor out the routine.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |6 --
arch/arm/mach-exynos/pm.c |3 +++
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch
That makes the code cleaner and encapsulted. The function will be reused in the
next patch.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c | 65 -
1 file changed, 41 insertions(+), 24 deletions(-)
diff --git
The scu_enable function is already a noop in the scu's header file is
CONFIG_SMP=n, so no need to use these macros in the code.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/pm.c |5 -
1 file changed, 5 deletions(-)
diff --git a/arch/arm/mach-exynos
Move the S5P_CHECK_AFTR definition to the header it belongs to.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |2 --
arch/arm/mach-exynos/regs-pmu.h |1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-exynos
Let's encapsulate more the PM code inside the PM file by moving the
'exynos_set_wakeupmask' function inside the pm.c and the call in the cpu_pm
notifier.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |7 ---
arch/arm/mach-exynos/pm.c
Move the code around to differentiate different section of code and prepare it
to be factored out in the next patches.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git
Tested on exynos5: 5250
Daniel Lezcano (17):
ARM: exynos: cpuidle: Prevent forward declaration
ARM: exynos: cpuidle: use cpuidle_register
ARM: exynos: cpuidle: change function name prefix
ARM: exynos: cpuidle: encapsulate register access inside a function
ARM: exynos: cpuidle: Move some
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/Makefile |1 -
drivers/cpuidle/Kconfig.arm|7 +++
drivers/cpuidle/Makefile |1 +
.../cpuidle.c = drivers/cpuidle/cpuidle-exynos.c
The code to initiate and exit the powerdown sequence is the same in pm.c and
cpuidle.c.
Let's split the common part in the pm.c and reuse it from the cpu_pm notifier.
That is one more step forward to make the cpuidle driver arch indenpendant.
Signed-off-by: Daniel Lezcano daniel.lezc
The cpuidle driver is broken since v3.11 and now we are at v3.14.
Default the cpuidle driver to favorize a better detection next time.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/configs/exynos_defconfig |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm
divider is set in the pm's
init routine, so it will also operate when the cpuidle driver is not set, which
is good.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 54 ---
arch/arm/mach-exynos/pm.c | 55
No more dependency on the arch code. The platform_data field is used to set the
PM callback as the other cpuidle driver.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/common.c |5 +++--
arch/arm/mach-exynos/common.h |1 +
arch/arm/mach-exynos
As usual, move the boot vector setting in the pm.c file and use the cpu_pm
notifier to set it up.
Remove the unused headers.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 22 --
arch/arm/mach-exynos/pm.c | 15
On 04/04/2014 10:57 AM, Viresh Kumar wrote:
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
We make the cpuidle code less arch dependent.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c |6 --
arch/arm/mach-exynos
On 04/04/2014 11:10 AM, Viresh Kumar wrote:
On 4 April 2014 13:18, Daniel Lezcano daniel.lezc...@linaro.org wrote:
The cpuidle driver is broken since v3.11 and now we are at v3.14.
Default the cpuidle driver to favorize a better detection next time.
Signed-off-by: Daniel Lezcano daniel.lezc
time than the one when we have to unplug CPU1 in order to let CPU0 to reach
the AFTR state.
This patch is a RFC because, we have to find a way to remove the macros
definitions and cpu powerdown function without pulling the arch dependent
headers.
Signed-off-by: Daniel Lezcano daniel.lezc
On 04/04/2014 11:00 AM, Sachin Kamat wrote:
Hi Daniel,
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote:
This patchset relies on the cpm_pm notifier to initiate the powerdown sequence
operations from pm.c instead cpuidle.c. Thus the cpuidle driver is no longer
dependent
Hi,
I tried to make the idle AFTR state working on arndale 5250 but that
leads to a kernel reboot and crash.
How to reproduce ?
echo 0 /sys/devices/system/cpu/cpu1/online
Reproductible on v3.14 and samsung/for-next
Any ideas ?
Thanks
-- Daniel
--
http://www.linaro.org/ Linaro.org │
That makes the code cleaner and encapsulted. The function will be reused in the
next patch.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-exynos/pm.c | 65 -
1 file changed
divider is set in the pm's
init routine, so it will also operate when the cpuidle driver is not set, which
is good.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/mach-exynos/cpuidle.c | 54
1 - 100 of 241 matches
Mail list logo
