Re: [PATCH 3/4] misc: exynos-chipid: Add Exynos Chipid driver support

2014-05-05 Thread Krzysztof Kozlowski
On sob, 2014-05-03 at 15:11 +0900, Pankaj Dubey wrote: diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 7eb4b69..48c8fb5 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -55,3 +55,4 @@ obj-$(CONFIG_SRAM) += sram.o obj-y

[PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-13 Thread Krzysztof Kozlowski
. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos/hotplug.c | 28 +--- arch/arm/mach-exynos/regs-pmu.h | 2 ++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c

[PATCH on kgene/for-next] ARM: EXYNOS: Do not calculate boot address twice

2014-05-15 Thread Krzysztof Kozlowski
Commit b3205dea8fbf (ARM: EXYNOS: Map SYSRAM through generic DT bindings) introduced local variable boot_reg where boot address from cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() again. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos

[PATCH] ARM: EXYNOS: SWRESET is needed to boot secondary CPU on Exynos3250

2014-05-15 Thread Krzysztof Kozlowski
mode. When booting the secondary CPU on Exynos3250 execute also software reset for core 1. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 22 ++ arch/arm/mach-exynos/regs-pmu.h | 3 +++ 2 files changed, 25 insertions(+) diff

[PATCH v4 3/3] clk: s2mps11: Add support for S2MPS14 clocks

2014-05-21 Thread Krzysztof Kozlowski
This patch adds support for S2MPS14 PMIC clocks (BT and AP) to the s2mps11 clock driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com Acked

[PATCH v4 0/3] clk: s2mps11: Fixes and add support for S2MPS14 clocks

2014-05-21 Thread Krzysztof Kozlowski
: Update driver description in Kconfig. 2. Patch 2/3: Add of_compatible to all MFD cells. 3. Add Yadwinder's Review-by. Best regards, Krzysztof Krzysztof Kozlowski (3): clk: s2mps11: Add missing of_node_put and of_clk_del_provider clk: s2mps11: Remove useless check for clk_table clk: s2mps11

[PATCH v4 2/3] clk: s2mps11: Remove useless check for clk_table

2014-05-21 Thread Krzysztof Kozlowski
There is no need for checking if 'clk_table' is not NULL twice (first after allocation and second at the end of probe()). Also move allocation of this 'clk_table' to probe from s2mps11_clk_parse_dt as this is logical place for it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com

[PATCH v4 1/3] clk: s2mps11: Add missing of_node_put and of_clk_del_provider

2014-05-21 Thread Krzysztof Kozlowski
Add of_clk_del_provider to remove previously registered clock provider. Add of_node_put to decrement the ref count of clock nodes. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-s2mps11.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions

[PATCH] clk: samsung: Make of_device_id array const

2014-05-23 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field and of_find_matching_node_and_match() function. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/samsung/clk-exynos4.c| 2 +- drivers/clk/samsung/clk-exynos5250.c | 2 +- drivers/clk

[PATCH 1/3] regulator: s2mps11: Refactor setting ramp delay

2014-05-26 Thread Krzysztof Kozlowski
not change as this patch only prepares for supporting S2MPA01 device. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/s2mps11.c | 210 ++-- 1 file changed, 144 insertions(+), 66 deletions(-) diff --git a/drivers/regulator

[PATCH 3/3] regulator: s2mpa01: Remove driver because it was merged into s2mps11

2014-05-26 Thread Krzysztof Kozlowski
The s2mpa01 regulator driver can be safely removed since it was merged into s2mps11 driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 drivers/regulator/Kconfig | 7 - drivers/regulator

[PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

2014-05-26 Thread Krzysztof Kozlowski
Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes the s2mpa01 regulator driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 106 drivers/regulator/Kconfig | 4 +- drivers

Re: [PATCH 1/3] regulator: s2mps11: Refactor setting ramp delay

2014-05-27 Thread Krzysztof Kozlowski
On wto, 2014-05-27 at 11:56 +0530, Yadwinder Singh Brar wrote: Hi Krzysztof, On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Prepare for merging the s2mpa01 regulator driver into s2mps11 by: 1. Adding common id for buck regulators. 2. Splitting

Re: [PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

2014-05-27 Thread Krzysztof Kozlowski
On wto, 2014-05-27 at 12:00 +0530, Yadwinder Singh Brar wrote: On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes the s2mpa01 regulator driver. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH] ARM: multi_v7_defconfig: Enable clock and RTC driver for S2M and S5M

2014-05-28 Thread Krzysztof Kozlowski
The config enables already Samsung's PMIC-s MFD driver and regulators (S2MPS11 and S5M8767). Enable also drivers for rest of these PMIC-s features: clock and RTC. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2

[PATCH] ARM: exynos_defconfig: Enable clock and RTC driver for S2M and S5M

2014-05-28 Thread Krzysztof Kozlowski
The config enables already Samsung's PMIC-s MFD driver and regulators (S2MPS11 and S5M8767). Enable also drivers for rest of these PMIC-s features: clock and RTC. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions

Re: [PATCH] ARM: EXYNOS: SWRESET is needed to boot secondary CPU on Exynos3250

2014-05-30 Thread Krzysztof Kozlowski
On czw, 2014-05-15 at 13:18 +0200, Krzysztof Kozlowski wrote: Without software reset the secondary CPU does not power up and exynos_boot_secondary() ends with pen_release equal to 1. This can be observed in dmesg: CPU1: failed to come online Brought up 1 CPUs SMP: Total

Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-30 Thread Krzysztof Kozlowski
On wto, 2014-05-13 at 16:12 +0200, Krzysztof Kozlowski wrote: On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set in ARM_CORE1_OPTION register during CPU power down. This is the proper way of powering down CPU. Additionally without this the CPU clock down won't work after powering down CPU1

Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-30 Thread Krzysztof Kozlowski
On pią, 2014-05-30 at 13:50 +0200, Tomasz Figa wrote: Hi Krzysztof, On 13.05.2014 16:12, Krzysztof Kozlowski wrote: On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set in ARM_CORE1_OPTION register during CPU power down. This is the proper way of powering down CPU. Additionally without

Re: [PATCH] ARM: exynos4212: hotplug: Fix CPU idle clock down after CPU1 off

2014-05-30 Thread Krzysztof Kozlowski
On pią, 2014-05-30 at 14:56 +0200, Tomasz Figa wrote: On 30.05.2014 14:46, Krzysztof Kozlowski wrote: On pią, 2014-05-30 at 13:50 +0200, Tomasz Figa wrote: Hi Krzysztof, On 13.05.2014 16:12, Krzysztof Kozlowski wrote: On Exynos4212 USE_DELAYED_RESET_ASSERTION must be set

[PATCH v2] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off

2014-06-02 Thread Krzysztof Kozlowski
by CPUfreq governor. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Changes since v1: 1. Use delayed reset assertion on all Exynos4 family and all cores, not only on core 1 of Exynos4212. 2. Rebase on Tomasz Figa's patch: ARM: EXYNOS: Fix core ID used by platsmp and hotplug code

[PATCH v2] ARM: EXYNOS: SWRESET is needed to boot secondary CPU on Exynos3250

2014-06-06 Thread Krzysztof Kozlowski
mode. When booting the secondary CPU on Exynos3250 execute also software reset for core 1. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- Changes since v1: 1. Removed inline keyword and change if statement to early return as Tomasz

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-09 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs, a Real-Time-Clock (RTC) and a I2C interface to program the individual regulators, clocks

Re: [PATCH 1/5] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-09 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: Maxim MAX77802 is a power management chip that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators used to power up application processors and peripherals, a 2-channel 32kHz clock outputs, a

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Krzysztof Kozlowski
On pon, 2014-06-09 at 09:04 -0700, Doug Anderson wrote: Krzystof, On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On pon, 2014-06-09 at 11:37 +0200, Javier Martinez Canillas wrote: MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, 32

Re: [PATCH 0/5] Add Maxim 77802 PMIC support

2014-06-10 Thread Krzysztof Kozlowski
On wto, 2014-06-10 at 00:55 +0200, Javier Martinez Canillas wrote: Hello Krzystof, Thanks a lot for your feedback. On 06/09/2014 06:04 PM, Doug Anderson wrote: Krzystof, On Mon, Jun 9, 2014 at 3:16 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On pon, 2014-06-09 at 11:37

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-06-11 Thread Krzysztof Kozlowski
On pią, 2014-04-04 at 11:48 +0200, Daniel Lezcano wrote: The following driver is for exynos4210. I did not yet finished the other boards, so I created a specific driver for 4210 which could be merged later. The driver is based on Colin Cross's driver found at:

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-06-25 Thread Krzysztof Kozlowski
On sob, 2014-06-14 at 00:43 +0200, Daniel Lezcano wrote: On 06/11/2014 10:50 AM, Krzysztof Kozlowski wrote: (...) Hi, Shouldn't the exynos_idle_barrier be initialized here? As it is a static data it will be initialized to zero. I know you sent the patch almost 2 months ago but I

Re: [PATCH v3 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-25 Thread Krzysztof Kozlowski
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote: From: Doug Anderson diand...@chromium.org The max77686 includes an RTC that keeps power during suspend. It's convenient to be able to use it as a wakeup source. Signed-off-by: Doug Anderson diand...@chromium.org ---

Re: [PATCH v3 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-25 Thread Krzysztof Kozlowski
...@collabora.co.uk --- drivers/clk/clk-max77686.c | 7 +-- include/dt-bindings/clock/maxim,max77686.h | 23 +++ 2 files changed, 24 insertions(+), 6 deletions(-) create mode 100644 include/dt-bindings/clock/maxim,max77686.h Reviewed-by: Krzysztof Kozlowski

Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-25 Thread Krzysztof Kozlowski
...@collabora.co.uk --- .../devicetree/bindings/clock/maxim,max77686.txt | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof diff --git a/Documentation/devicetree/bindings/clock/maxim

Re: [PATCH v3 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-25 Thread Krzysztof Kozlowski
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote: Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these chips are duplicating code and are simpler enough that can be converted to use a generic driver to

Re: [PATCH v3 06/14] clk: max77686: Convert to the generic max clock driver

2014-06-25 Thread Krzysztof Kozlowski
-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/clk/Kconfig| 1 + drivers/clk/clk-max77686.c | 176 +++-- 2 files changed, 9 insertions(+), 168 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com

Re: [PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-26 Thread Krzysztof Kozlowski
to consolidate code and avoid duplication. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v3: - Add current copyright information. Suggested by Krzysztof Kozlowski - Do a single allocation for struct max_gen_clk. Suggested by Krzysztof Kozlowski

Re: [PATCH v4 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-26 Thread Krzysztof Kozlowski
that this patch needs another change due wakeup ordering problems. drivers/rtc/rtc-max77686.c | 28 1 file changed, 28 insertions(+) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof diff --git a/drivers/rtc/rtc-max77686.c b/drivers

Re: [PATCH v4 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-26 Thread Krzysztof Kozlowski
Hi, Just a few nit-picks below but overall everything looks fine: Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote: Maxim MAX77802 is a power management chip that contains 10 high efficiency Buck regulators, 32 Low

Re: [PATCH v4 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-26 Thread Krzysztof Kozlowski
On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote: The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS

Re: [PATCH v4 11/14] clk: Add driver for Maxim 77802 PMIC clocks

2014-06-26 Thread Krzysztof Kozlowski
100644 include/dt-bindings/clock/maxim,max77802.h Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index 3fd4270..221260b 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -42,6 +42,13

[PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice

2014-06-26 Thread Krzysztof Kozlowski
Commit b3205dea8fbf (ARM: EXYNOS: Map SYSRAM through generic DT bindings) introduced local variable boot_reg where boot address from cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() again. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/mach-exynos

[PATCH RESEND] clk: samsung: Make of_device_id array const

2014-06-26 Thread Krzysztof Kozlowski
Array of struct of_device_id may be be const as expected by of_match_table field and of_find_matching_node_and_match() function. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/samsung/clk-exynos4.c| 2 +- drivers/clk/samsung/clk-exynos5250.c | 2 +- drivers/clk

[PATCH RESEND 1/2] ARM: multi_v7_defconfig: Enable clock and RTC driver for S2M and S5M

2014-06-26 Thread Krzysztof Kozlowski
The config enables already Samsung's PMIC-s MFD and regulator (S2MPS11 and S5M8767) drivers. Enable also drivers for the rest of these PMIC-s features: clock and RTC. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2

[PATCH RESEND 2/2] ARM: exynos_defconfig: Enable clock and RTC driver for S2M and S5M

2014-06-26 Thread Krzysztof Kozlowski
The config enables already Samsung's PMIC-s MFD and regulator (S2MPS11 and S5M8767) drivers. Enable also drivers for the rest of these PMIC-s features: clock and RTC. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2

[PATCH] spi: spi-s3c64xx: Add missing pm_runtime_put on setup fail

2013-10-17 Thread Krzysztof Kozlowski
pm_runtime_put() wasn't called if clock rate could not be set up in s3c64xx_spi_setup() leading to invalid count of device pm_runtime usage. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/spi/spi-s3c64xx.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi

[PATCH] spi/s3c64xx: Add missing pm_runtime_set_active() call in probe()

2013-10-17 Thread Krzysztof Kozlowski
Mark device as PM runtime active during initialization to reflect actual device power/clocks state. This reduces the enable count for SPI bus controller gate clock so it can be disabled when the bus controller is not used. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off

[PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
sleep for the time of s3c64xx_spi_hwinit(). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/spi/spi-s3c64xx.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c

Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote: pm_runtime_{get,put}* must not be called from drivers's system suspend/resume callbacks. Please use pm_runtime_suspended() to check device runtime PM status in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks

[PATCH 1/2] spi/s3c64xx: Do not ignore return value of spi_master_resume/suspend

2013-10-21 Thread Krzysztof Kozlowski
During PM resume and suspend do not ignore the return value of spi_master_suspend() or spi_master_resume(). Instead pass it further. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/spi/spi-s3c64xx.c |8 1

[PATCH 2/2] mfd: max77693: reorder params in API for regmap consistency

2013-11-08 Thread Krzysztof Kozlowski
, - max77693_update_reg() reorder val and mask. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/extcon/extcon-max77693.c | 14 +++--- drivers/mfd/max77693-irq.c |2 +- drivers/mfd/max77693.c

[PATCH] clk: exynos: File scope reg_save array should depend on PM_SLEEP

2013-12-17 Thread Krzysztof Kozlowski
Move reg_save[] into CONFIG_PM_SLEEP dependency block as it is used only by suspend and resume functions. This fixes the warning on CONFIG_PM_SLEEP=n: drivers/clk/samsung/clk-exynos-audss.c:29:22: warning: ‘reg_save’ defined but not used [-Wunused-variable] Signed-off-by: Krzysztof Kozlowski

[PATCH] ARM: EXYNOS: cpuidle: Fix build error of no type of module_init

2014-01-22 Thread Krzysztof Kozlowski
warnings being treated as errors make[1]: *** [arch/arm/mach-exynos/cpuidle.o] Error 1 Build error happens on gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) and was introduced by commit 35baa3369d1c (ARM: EXYNOS: convert cpuidle driver to be a platform driver). Signed-off-by: Krzysztof Kozlowski

[PATCH RESEND] cpufreq: exynos: Fix build error of no type of module_init

2014-01-22 Thread Krzysztof Kozlowski
to platform driver). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Tomasz Figa t.f...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com --- drivers/cpufreq/exynos-cpufreq.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH RESEND] cpufreq: exynos: Fix build error of no type of module_init

2014-01-22 Thread Krzysztof Kozlowski
On Wed, 2014-01-22 at 20:12 +0530, Viresh Kumar wrote: On 22 January 2014 19:51, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add missing include to fix build error: drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default

Re: [PATCH RESEND] cpufreq: exynos: Fix build error of no type of module_init

2014-01-22 Thread Krzysztof Kozlowski
On Wed, 2014-01-22 at 20:12 +0530, Viresh Kumar wrote: On 22 January 2014 19:51, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add missing include to fix build error: drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled

[PATCH v2 1/2] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC

2014-01-22 Thread Krzysztof Kozlowski
. - It allows disabling the regulator during suspend to RAM; The AP will enable it during resume; Without the patch the regulator supplying eMMC must be defined as fixed-regulator. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek

[PATCH v2 2/2] regulator: s5m8767: Document new bindings for Buck9 GPIO control

2014-01-22 Thread Krzysztof Kozlowski
Add documentation for new bindings for controlling (enable/disable) the Buck9 Converter by GPIO (BUCK9EN). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Bartlomiej Zolnierkiewicz b.zolnier

[PATCH v2 0/2] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC

2014-01-22 Thread Krzysztof Kozlowski
. This patchset is based on next tree: next-20140122. Best regards, Krzysztof Krzysztof Kozlowski (2): regulator: s5m8767: Use GPIO for controlling Buck9/eMMC regulator: s5m8767: Document new bindings for Buck9 GPIO control .../bindings/regulator/s5m8767-regulator.txt | 16 +++- drivers

Re: [PATCH v2 2/2] regulator: s5m8767: Document new bindings for Buck9 GPIO control

2014-01-22 Thread Krzysztof Kozlowski
On Wed, 2014-01-22 at 19:49 +, Mark Brown wrote: On Wed, Jan 22, 2014 at 05:07:28PM +0100, Krzysztof Kozlowski wrote: Add documentation for new bindings for controlling (enable/disable) the Buck9 Converter by GPIO (BUCK9EN). Your CC list for this is *very* large... Hmmm

[PATCH v3 1/2] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC

2014-01-24 Thread Krzysztof Kozlowski
. - It allows disabling the regulator during suspend to RAM; The AP will enable it during resume; Without the patch the regulator supplying eMMC must be defined as fixed-regulator. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek

[PATCH v3 0/2] regulator: s5m8767: Use GPIO for controlling Buck9/eMMC

2014-01-24 Thread Krzysztof Kozlowski
by Mark Brown. Changes since v1: 1. Use ena_gpio of regulator core, as suggested by Mark Brown. This patchset is based on next tree: next-20140122. Best regards, Krzysztof Krzysztof Kozlowski (2): regulator: s5m8767: Use GPIO for controlling Buck9/eMMC regulator: s5m8767: Document new binding

[PATCH v3 2/2] regulator: s5m8767: Document new binding for Buck9 GPIO control

2014-01-24 Thread Krzysztof Kozlowski
Add documentation for new binding for controlling (enable/disable) the Buck9 Converter by GPIO (BUCK9EN). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Bartlomiej Zolnierkiewicz b.zolnier

Re: [PATCH RESEND 1/4] clk: clk-s2mps11: Refactor for including support for other MFD clocks

2014-01-29 Thread Krzysztof Kozlowski
Hi, Quoting Mark Brown (2013-12-31 08:09:16) On Mon, Dec 30, 2013 at 09:33:50AM +0530, Tushar Behera wrote: Commit 1b1ccee1e821 mfd: s2mps11: Fix build after regmap field rename in sec-core.c is also touching this file, which is in Mark's tree right now. If I rebase It's

[PATCH] mfd: sec-core: Fix possible NULL pointer dereference when i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
() or i2c_unregister_device(). If i2c_new_dummy() fails for RTC device, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/sec-core.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/sec-core.c b

[PATCH 1/7] mfd: 88pm860x: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
by regmap_init_i2c(). If i2c_new_dummy() fails for companion device, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/88pm860x-core.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mfd/88pm860x

[PATCH 3/7] mfd: max77686: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
(). If i2c_new_dummy() fails for RTC device, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/max77686.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/max77686.c b/drivers/mfd

[PATCH 2/7] mfd: 88pm860x: Fix I2C device resource leak on regmap init fail

2014-02-11 Thread Krzysztof Kozlowski
During probe the driver allocates dummy I2C device for companion chip and then allocates a regmap for it. If regmap_init_i2c() fails then the I2C driver (allocated with i2c_new_dummy()) is not freed and this resource leaks. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta

[PATCH 7/7] mfd: max8998: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
by i2c_unregister_device(). If i2c_new_dummy() fails for RTC device, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/max8998.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/max8998.c b/drivers/mfd

[PATCH 4/7] mfd: max77693: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
by devm_regmap_init_i2c() and i2c_unregister_device(). If i2c_new_dummy() fails for MUIC or haptic devices, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/max77693.c | 12 +++- 1 file changed, 11

[PATCH 6/7] mfd: max8997: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
by i2c_unregister_device(). If i2c_new_dummy() fails for RTC, haptic or MUIC devices, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/max8997.c | 18 ++ 1 file changed, 18 insertions

[PATCH 5/7] mfd: max8925: Fix possible NULL pointer dereference on i2c_new_dummy error

2014-02-11 Thread Krzysztof Kozlowski
by i2c_unregister_device(). If i2c_new_dummy() fails for RTC or ADC devices, fail also the probe for main MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/mfd/max8925-i2c.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mfd

[PATCH 04/14] rtc: s5m: Remove undocumented time init on first boot

2014-02-11 Thread Krzysztof Kozlowski
will be initialized with reset value (2000-01-01 00:00:00). The code might work on S5M8763 but still this does not look like a task for RTC driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Alessandro Zummo a.zu...@towertech.it Cc: rtc-li...@googlegroups.com --- drivers/rtc

[PATCH 00/14] mfd/regulator/rtc: sec: Add support for S2MPS14

2014-02-11 Thread Krzysztof Kozlowski
/gmane.linux.kernel/1587881/focus=1587882 which didn't get their way into clk-next. I will wait for them. Krzysztof Kozlowski (14): mfd: sec: Add maximum RTC register for regmap config mfd: sec: Select different RTC regmaps for devices mfd/rtc: sec/sec: Rename SEC* symbols to S5M rtc: s5m

[PATCH 10/14] Documentation: mfd: s2mps11: Document support for S2MPS14

2014-02-11 Thread Krzysztof Kozlowski
Add bindings documentation for S2MPS14 device to the s2mps11 driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com Cc: Tomasz Figa t.f...@samsung.com Cc: devicet...@vger.kernel.org Cc: Rob Herring robh

[PATCH 07/14] regulator: s2mps11: Choose number of supported regulators during probe

2014-02-11 Thread Krzysztof Kozlowski
the regulator driver for supporting the S2MPS14 device. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com --- drivers/regulator/s2mps11.c | 46

[PATCH 08/14] mfd: sec: Add support for S2MPS14

2014-02-11 Thread Krzysztof Kozlowski
Add support for S2MPS14 PMIC device to the MFD sec-core driver. The S2MPS14 is similar to S2MPS11 but it has fewer regulators, two clocks instead of three and a little different registers layout. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c

[PATCH 09/14] regulator: s2mps11: Add support for S2MPS14 regulators

2014-02-11 Thread Krzysztof Kozlowski
Add support for S2MPS14 PMIC regulators to s2mps11 driver. The S2MPS14 has fewer BUCK-s and LDO-s than S2MPS11. It also does not support controlling the BUCK ramp delay. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw

[PATCH 02/14] mfd: sec: Select different RTC regmaps for devices

2014-02-11 Thread Krzysztof Kozlowski
This patch prepares for adding support for S2MPS14 RTC driver by selecting different regmaps for S2MPS1X/S5M876X RTC devices. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-11 Thread Krzysztof Kozlowski
the operation mode from DTS by reading a op_mode property from regulator child node. The op_mode is then used for enabling the S2MPS14 regulators. On S2MPS11 the DTS op_mode property is parsed but not used for enabling, as this was not tested. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH 13/14] rtc: s5m: Support different register layout

2014-02-11 Thread Krzysztof Kozlowski
This patch prepares for adding support for S2MPS14 RTC device to the rtc-s5m driver: 1. Adds a map of registers used by the driver which differ between the chipsets (S5M876X and S2MPS14). 2. Moves code of checking for alarm pending to separate function. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH 12/14] Documentation: mfd/regulator: s2mps11: Document the op_mode bindings

2014-02-11 Thread Krzysztof Kozlowski
(although S5M8767 have also low-power mode). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com Cc: Tomasz Figa t.f...@samsung.com Cc: devicet...@vger.kernel.org Cc: Rob

[PATCH 14/14] rtc: s5m: Add support for S2MPS14 RTC

2014-02-11 Thread Krzysztof Kozlowski
time; - RTC interrupts are reported in main PMIC I2C device; This patch also adds missing mfd_cell for RTC in the MFD core driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Alessandro Zummo a.zu...@towertech.it Cc: rtc-li...@googlegroups.com --- drivers/rtc/rtc-s5m.c | 89

[PATCH 05/14] mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes

2014-02-11 Thread Krzysztof Kozlowski
The S2MPS11 RTC has two alarms: alarm0 and alarm1 (corresponding interrupts are named similarly). Use consistent names for interrupts to limit possible errors. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-irq.c |8 include/linux/mfd

[PATCH 01/14] mfd: sec: Add maximum RTC register for regmap config

2014-02-11 Thread Krzysztof Kozlowski
Add maximum register to the regmap used by rtc-s5m driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c |2 ++ include/linux/mfd/samsung/rtc.h |2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec

[PATCH 03/14] mfd/rtc: sec/sec: Rename SEC* symbols to S5M

2014-02-11 Thread Krzysztof Kozlowski
This patch prepares for adding support for S2MPS14 RTC device to the rtc-s5m driver: 1. Renames SEC* symbols to S5M. 2. Adds S5M prefix to some of defines which are different between S5M876X and S2MPS14. This is only a rename-like patch, new code is not added. Signed-off-by: Krzysztof Kozlowski

[PATCH 06/14] regulator: s2mps11: Constify regulator_desc array

2014-02-11 Thread Krzysztof Kozlowski
Constify the regulator_desc 'regulators' array. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com --- drivers/regulator/s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 01/14] mfd: sec: Add maximum RTC register for regmap config

2014-02-12 Thread Krzysztof Kozlowski
On Wed, 2014-02-12 at 08:48 +, Lee Jones wrote: Add maximum register to the regmap used by rtc-s5m driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/sec-core.c |2 ++ include/linux/mfd/samsung/rtc.h |2 ++ 2 files changed, 4

Re: [PATCH 05/14] mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes

2014-02-12 Thread Krzysztof Kozlowski
On Wed, 2014-02-12 at 09:07 +, Lee Jones wrote: The S2MPS11 RTC has two alarms: alarm0 and alarm1 (corresponding interrupts are named similarly). Use consistent names for interrupts to limit possible errors. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers

Re: [PATCH 08/14] mfd: sec: Add support for S2MPS14

2014-02-12 Thread Krzysztof Kozlowski
On Wed, 2014-02-12 at 09:17 +, Lee Jones wrote: Add support for S2MPS14 PMIC device to the MFD sec-core driver. The S2MPS14 is similar to S2MPS11 but it has fewer regulators, two clocks instead of three and a little different registers layout. Signed-off-by: Krzysztof Kozlowski

Re: [PATCH 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-12 Thread Krzysztof Kozlowski
, as this was not tested. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com --- drivers/regulator/s2mps11.c | 98

Re: [PATCH 05/14] mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes

2014-02-12 Thread Krzysztof Kozlowski
On Wed, 2014-02-12 at 10:02 +, Lee Jones wrote: On Wed, 12 Feb 2014, Krzysztof Kozlowski wrote: On Wed, 2014-02-12 at 09:07 +, Lee Jones wrote: The S2MPS11 RTC has two alarms: alarm0 and alarm1 (corresponding interrupts are named similarly). Use consistent names

Re: [PATCH 07/14] regulator: s2mps11: Choose number of supported regulators during probe

2014-02-12 Thread Krzysztof Kozlowski
On Wed, 2014-02-12 at 15:31 +0530, Yadwinder Singh Brar wrote: Hi, + dev_type = platform_get_device_id(pdev)-driver_data; + switch (dev_type) { + case S2MPS11X: + s2mps11-rdev_num = ARRAY_SIZE(s2mps11_regulators); + regulators =

[PATCH v2 10/14] Documentation: mfd: s2mps11: Document support for S2MPS14

2014-02-13 Thread Krzysztof Kozlowski
Add bindings documentation for S2MPS14 device to the s2mps11 driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com Cc: Tomasz Figa t.f...@samsung.com Cc: devicet...@vger.kernel.org Cc: Rob Herring robh

[PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

2014-02-13 Thread Krzysztof Kozlowski
the operation mode from DTS by reading a op_mode property from regulator child node. The op_mode is then used for enabling the S2MPS14 regulators. On S2MPS11 the DTS op_mode property is parsed but not used for enabling, as this was not tested. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH v2 14/14] rtc: s5m: Add support for S2MPS14 RTC

2014-02-13 Thread Krzysztof Kozlowski
time; - RTC interrupts are reported in main PMIC I2C device; This patch also adds missing mfd_cell for RTC in the MFD core driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Alessandro Zummo a.zu...@towertech.it Cc: rtc-li...@googlegroups.com --- drivers/rtc/rtc-s5m.c | 89

[PATCH v2 07/14] regulator: s2mps11: Copy supported regulators from initconst

2014-02-13 Thread Krzysztof Kozlowski
of 'regulator_desc' (also marked as __initconst). This way memory footprint of the driver will be reduced (approximately 'regulators_desc' array for S2MPS11 occupies 5 kB on 32-bit ARM, for S2MPS14 will occupy 3 kB). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Chanwoo Choi

[PATCH v2 06/14] regulator: s2mps11: Constify regulator_desc array

2014-02-13 Thread Krzysztof Kozlowski
Constify the regulator_desc 'regulators' array. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com --- drivers/regulator/s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 13/14] rtc: s5m: Support different register layout

2014-02-13 Thread Krzysztof Kozlowski
This patch prepares for adding support for S2MPS14 RTC device to the rtc-s5m driver: 1. Adds a map of registers used by the driver which differ between the chipsets (S5M876X and S2MPS14). 2. Moves code of checking for alarm pending to separate function. Signed-off-by: Krzysztof Kozlowski k.kozlow

[PATCH v2 09/14] regulator: s2mps11: Add support for S2MPS14 regulators

2014-02-13 Thread Krzysztof Kozlowski
Add support for S2MPS14 PMIC regulators to s2mps11 driver. The S2MPS14 has fewer BUCK-s and LDO-s than S2MPS11. It also does not support controlling the BUCK ramp delay. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw

[PATCH v2 01/14] mfd: sec: Add maximum RTC register for regmap config

2014-02-13 Thread Krzysztof Kozlowski
Add maximum register to the regmap used by rtc-s5m driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/sec-core.c |2 ++ include/linux/mfd/samsung/rtc.h |2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCH v2 00/14] mfd/regulator/rtc: sec: Add support for S2MPS14

2014-02-13 Thread Krzysztof Kozlowski
. The patch is actually ready but it is based on the Add support for clocks in S5M8767 http://thread.gmane.org/gmane.linux.kernel/1587881/focus=1587882 which didn't get their way into clk-next. I will wait for them. Krzysztof Kozlowski (15): mfd: sec: Add maximum RTC register for regmap config

[PATCH v2 05/14] mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes

2014-02-13 Thread Krzysztof Kozlowski
The S2MPS11 RTC has two alarms: alarm0 and alarm1 (corresponding interrupts are named similarly). Use consistent names for interrupts to limit possible errors. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/sec-irq.c

  1   2   3   4   5   6   7   8   9   10   >