Re: [PATCH V2 0/1] dmaengine/amba-pl08x: Add support for s3c64xx DMAC

2012-05-27 Thread Linus Walleij
on this, is there something in specific that you need help on here? We really need to get rid of this forked code, and it should be beneficial to S3C because we have fixed a lot of bugs in the PL08x driver now, plus it'll likely be a prerequisite to DT support for S3C. Yours, Linus Walleij

Re: [PATCH 1/3] pinctrl: add samsung pinctrl and gpiolib driver

2012-05-31 Thread Linus Walleij
}, +#endif /* CONFIG_CPU_EXYNOS4210 */ +       {}, +}; +MODULE_DEVICE_TABLE(of, samsung_pinctrl_dt_match); +#endif /* CONFIG_OF */ So delete the closing #endif too. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH 2/3] pinctrl: add exynos4210 specific driver data for samsung pinctrl driver

2012-05-31 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Overall this patch set is looking really good, just the final touches on the main driver needed from my point of view, would be nice to have some DT review though. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung

Re: [PATCH 0/3] pinctrl: add support for samsung pinctrl driver

2012-05-31 Thread Linus Walleij
the pinctrl api should ensure that support for legacy platforms is maintained. Is the plan to move also the older platforms over to the DT-based model? It'd be really nice to be able to just delete the old drivers at some point... Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 3/3] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-06-05 Thread Linus Walleij
On Thu, May 24, 2012 at 1:47 AM, Thomas Abraham thomas.abra...@linaro.org wrote: Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-06-28 Thread Linus Walleij
On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Elegant, monsieur. Acked-by: Linus Walleij linus.wall...@linaro.org I'm starting

Re: [PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE,}ACT macros at call sites

2012-06-28 Thread Linus Walleij
directly. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Much clearer. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [GIT PULL] Samsung devel-dma ops for v3.6

2012-07-23 Thread Linus Walleij
to be rebased onto that, but it should be pretty straight-forward. Can we please have something moving the S3C over to dmaengine *early* next kernel cycle? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-21 Thread Linus Walleij
pinctrl_gpio_range grange; +}; This is looking really good. No further comments! (Atleast not this time, since it's a big driver I have probably missed something...) Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-08-21 Thread Linus Walleij
is passed to the main driver, it seems to be through some DT node but I cannot figure this out. Can you explain this? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used

2012-08-21 Thread Linus Walleij
Kim kgene@samsung.com Signed-off-by: Thomas Abraham thomas.abra...@linaro.org +#ifdef CONFIG_OF Don't you actually want to use: #fidef CONFIG_PINCTRL_SAMSUNG here? CONFIG_OF is a bit vague. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-08-21 Thread Linus Walleij
On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Linus Walleij

Re: [PATCH 2/2] ARM: EXYNOS: Enable PINCTRL config option for Exynos4 device tree enabled platform

2012-08-21 Thread Linus Walleij
driver, as is already done for some GPIO controllers for example: select PINCTRL select PINCTRL_SAMSUNG Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/2] ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC

2012-08-21 Thread Linus Walleij
-pud = 0; + samsung,pin-drv = 0; + }; Apart from the pin-pud and pin-drv stuff this patch looks fine. These two things I want to discuss in the other mail thread (controller core) first. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 0/3] Removal of obsolete s3c2410_* GPIO API

2012-08-27 Thread Linus Walleij
with this as long as the Samsung maintainer is, so Acked-by: Linus Walleij linus.wall...@linaro.org But I suspect this will be merged through the Samsung SoC tree? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 0/3] Removal of obsolete s3c2410_* GPIO API

2012-08-27 Thread Linus Walleij
big Samsung patches in my tree, just fixes that will go into the -rc:s anyway. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] ARM: EXYNOS: Add support for GPIO on Exynos4x12

2012-08-31 Thread Linus Walleij
for Exynos4412 soon and then switch over to using pinctrl driver. That can simplfy the gpio/pinmux support for Exynos4 SoC's. This sounds like a NACK. I will not merge these patches until Ben or Kukjin (the Samsung maintainers listed in MAINTAINERS) ACK it. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH v2] gpio: samsung: add devicetree init for s3c24xx arches

2012-08-31 Thread Linus Walleij
... Acked-by: Kukjin Kim kgene@samsung.com OK are you taking this into the Samsung tree or shall I take care of it? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-03 Thread Linus Walleij
subsystem and gpiolib interface registers gpio chips with the gpiolib subsystem. The information about the pins, pin groups, pin functions and gpio chips, which are SoC specific, are parsed from device tree node. Cc: Linus Walleij linus.wall...@linaro.org Cc: Kukjin Kim kgene@samsung.com Signed

Re: [PATCH v3 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-09-03 Thread Linus Walleij
with the Samsung pinctrl driver. Cc: Linus Walleij linus.wall...@linaro.org Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH v3 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used

2012-09-03 Thread Linus Walleij
Kim kgene@samsung.com Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 1/2] ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC

2012-09-03 Thread Linus Walleij
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 2/2] ARM: EXYNOS: Enable pinctrl driver support for Exynos4 device tree enabled platform

2012-09-03 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gpio: samsung: Update documentation

2012-09-04 Thread Linus Walleij
just in case there is any out of tree code that still needs to be converted. Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com Acked-by: Linus Walleij linus.wall...@linaro.org Get the Samsung maintainers to apply this patch since they carry the API changes. Yours, Linus Walleij

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Linus Walleij
) return 0; If we just add pinctrl_select_state_force() excluding that clause we can force re-poking of the state at any time. Compare regulator_force_disable() and similar. Maybe this is actually more helpful? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Linus Walleij
devm_pinctrl_get_select_default() and be done with it. In any case do not open code the string default, use PINCTRL_STATE_DEFAULT which defines to that string. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 0/6] pinctrl: samsung: Various fixes

2012-09-20 Thread Linus Walleij
this into the pinctrl tree or will it go through Samsung ARM SoC (Kyungmin)? In the latter case, Acked-by: Linus Walleij linus.wall...@linaro.org for all, else poke me and I'll apply them. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-20 Thread Linus Walleij
- devicetree better than anyone else. (I'll look and see if I can see something that sticks out...) Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC PATCH 0/6] pinctrl: samsung: Convert the driver to use per-bank GPIO and interrupt specifiers

2012-09-24 Thread Linus Walleij
On Fri, Sep 21, 2012 at 4:22 PM, Tomasz Figa t.f...@samsung.com wrote: This is a continuation of work focused on improving the pinctrl-samsung driver. All look good to me, I guess these will go through the Samsung tree? Acked-by: Linus Walleij linus.wall...@linaro.org for all. Yours, Linus

Re: [PATCH 7/6] pinctrl: exynos: Fix wakeup IRQ domain registration check

2012-09-24 Thread Linus Walleij
On Thu, Sep 20, 2012 at 4:53 PM, Tomasz Figa t.f...@samsung.com wrote: Because of a typo, incorrect field of a structure was being checked. This patch fixes the check to use correct field. Signed-off-by: Tomasz Figa t.f...@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org I

Re: [RFC PATCH 0/6] pinctrl: samsung: Convert the driver to use per-bank GPIO and interrupt specifiers

2012-09-24 Thread Linus Walleij
On Mon, Sep 24, 2012 at 12:45 PM, Kyungmin Park kyungmin.p...@samsung.com wrote: On 9/24/12, Linus Walleij linus.wall...@linaro.org wrote: On Fri, Sep 21, 2012 at 4:22 PM, Tomasz Figa t.f...@samsung.com wrote: This is a continuation of work focused on improving the pinctrl-samsung driver

Re: [PATCH 2/2] gpio: samsung: Fix input mode setting function for GPIO int

2012-09-26 Thread Linus Walleij
in the samsung_gpiolib_4bit_input function. Signed-off-by: Eunki Kim eunki_...@samsung.com Cc: Kukjin Kim kgene@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org Are you taking this into the Samsung tree or shall I merge it into my GPIO tree? In the latter case I need an ACK from some Samsung maintainer

Re: [RFC PATCH 00/16] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-01 Thread Linus Walleij
and one IRQ domain per pin bank - introducing generic wake-up interrupt capability description Overall this looks good to me. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 02/16] pinctrl: exynos: Parse wakeup-eint parameters from DT

2012-10-10 Thread Linus Walleij
? Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/16] ARM: dts: exynos4210: Replace legacy GPIO bank nodes with pinctrl bank nodes

2012-10-10 Thread Linus Walleij
be #defined. + #interrupt-cells = 2; + }; Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/16] pinctrl: samsung: Parse pin banks from DT

2012-10-10 Thread Linus Walleij
, it's better to keep the old driver. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/16] pinctrl: samsung: Detect and handle unsupported configuration types

2012-10-10 Thread Linus Walleij
? Thomas A: can you ACK this so I can apply it in that case? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/16] pinctrl: exynos: Use one IRQ domain per pin bank

2012-10-10 Thread Linus Walleij
-by: Tomasz Figa t.f...@samsung.com This looks like a very good patch! Can it be applied in isolation from the other patches? Thomas A: can you ACK this? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org

Re: [PATCH 10/16] pinctrl: samsung: Do not pass gpio_chip to pin_to_reg_bank

2012-10-10 Thread Linus Walleij
separately? Thomas A: is this ACK:able? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/16] pinctrl: samsung: Use one GPIO chip per pin bank

2012-10-10 Thread Linus Walleij
discussed before) so needs to be applied in isolation from the regs-to-DT stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/16] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-10 Thread Linus Walleij
that these two things are mingled together like this in an all-or-nothing manner. So I'm OK with a patch series for bulle (2) and (3) but not (1). And I'd like to have Thomas A:s ACK on the series too. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung

Re: [PATCH 00/16] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-11 Thread Linus Walleij
to device tree is not as important, so it might be discussed later. Thanks! :-D I'll look at it now... I still would really like to see Mr. Abraham's ACK on this before I merge any of it. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH 04/16] pinctrl: samsung: Parse pin banks from DT

2012-10-11 Thread Linus Walleij
On Wed, Oct 10, 2012 at 10:39 AM, Tomasz Figa t.f...@samsung.com wrote: On Wednesday 10 of October 2012 09:34:05 Linus Walleij wrote: If you will end up with a hybrid approach with some stuff in the device tree and some stuff in the code, it's better to keep the old driver. This will allow

Re: [PATCH 01/15] pinctrl: samsung: Detect and handle unsupported configuration types

2012-10-11 Thread Linus Walleij
register. Signed-off-by: Tomasz Figa t.f...@samsung.com I'm quite happy with these 17 patches, but I'd like to have Thomas Abraham's definitive ACK before I merge anything. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH v2 00/15] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-11 Thread Linus Walleij
to one GPIO chip and IRQ domain per pin bank - improving wake-up IRQ setup and handling Oh I see Thomas and Kyungmin has ACKed this on patch 0, sorry for being so confused :-/ Looking into applying this using a separate samsung branch now... Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 01/15] pinctrl: samsung: Detect and handle unsupported configuration types

2012-10-11 Thread Linus Walleij
On Thu, Oct 11, 2012 at 4:00 PM, Kyungmin Park kmp...@infradead.org wrote: On Thu, Oct 11, 2012 at 10:57 PM, Linus Walleij linus.wall...@linaro.org wrote: I'm quite happy with these 17 patches, but I'd like to have Thomas Abraham's definitive ACK before I merge anything. Thomas did ACK

Re: [PATCH v2 00/15] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-11 Thread Linus Walleij
. Thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

2012-10-16 Thread Linus Walleij
use: dev_dbg(chip-dev, %s: %p: CON now %08lx\n, __func__, base, con); In that case use the dev_* print macros everywhere instead. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH V3] gpio: samsung: use pr_* instead of printk

2012-10-19 Thread Linus Walleij
On Wed, Oct 17, 2012 at 3:52 AM, Jingoo Han jg1@samsung.com wrote: This patch uses pr_* instead of printk. Also, gpio_dbg is replaced with pr_debug. Signed-off-by: Jingoo Han jg1@samsung.com Reviewed-by: Linus Walleij linus.wall...@linaro.org - NAK Please consult Documentation

Re: [PATCH V3] gpio: samsung: use pr_* instead of printk

2012-10-22 Thread Linus Walleij
On Mon, Oct 22, 2012 at 3:02 AM, Jingoo Han jg1@samsung.com wrote: On Friday, October 19, 2012 7:09 PM Linus Walleij wrote On Wed, Oct 17, 2012 at 3:52 AM, Jingoo Han jg1@samsung.com wrote: This patch uses pr_* instead of printk. Also, gpio_dbg is replaced with pr_debug. Signed

Re: [PATCH V3] gpio: samsung: use pr_* instead of printk

2012-10-24 Thread Linus Walleij
On Tue, Oct 23, 2012 at 4:10 PM, Kukjin Kim kgene@samsung.com wrote: Linus Walleij wrote: On Mon, Oct 22, 2012 at 3:02 AM, Jingoo Han jg1@samsung.com wrote: On Friday, October 19, 2012 7:09 PM Linus Walleij wrote On Wed, Oct 17, 2012 at 3:52 AM, Jingoo Han jg1@samsung.com

Re: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12

2012-10-28 Thread Linus Walleij
of Exynos4x12, which is not supported by this driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org Tell me if there is something you want merged through the GPIO or pinctrl tree. I have

Re: [PATCH 3/4] pinctrl: samsung: Add support for Exynos4x12

2012-10-28 Thread Linus Walleij
Walleij linus.wall...@linaro.org I guess you need all of this to go into my Samsung branch? I need and ACK from the Samsung maintainer and preferably Thomas A as well. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH 4/4] ARM: dts: exynos4x12: Add nodes for pin controllers

2012-10-28 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] pinctrl: samsung: Add support for Exynos4x12

2012-10-30 Thread Linus Walleij
well, just one minor conflict in -next so let's go for this... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/7] pinctrl: exynos5440: add pinctrl driver for Samsung EXYNOS5440 SoC

2012-11-05 Thread Linus Walleij
controller driver for EXYNOS5440 SoC is independent of the Samsung pinctrl framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Kukjin Kim kgene@samsung.com If I haven't ACK:ed this before here's an Acked-by: Linus

Re: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12

2012-11-08 Thread Linus Walleij
. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12

2012-11-11 Thread Linus Walleij
have removed the samsung branch from my for-next to avoid clashes. So please bring the samsung branch into you tree and fix everything up there. Axel Lin has sent some tree-wide cleanups but let's hope they don't hit samsung so much, or they will need to be postponed/dropped. Yours, Linus

Re: Build failure: OMAP4430 failed due to exynos4 pinctrl

2012-11-15 Thread Linus Walleij
-by: Arnd Bergmann a...@arndb.de Cc: Tomasz Figa t.f...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org Cc: Kukjin Kim kgene@samsung.com Acked-by: Kukjin Kim kgene@samsung.com Linus, can you pick this up in your pinctrl/fixes ree? OK

Re: [PATCH 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2012-12-14 Thread Linus Walleij
On Thu, Dec 13, 2012 at 12:54 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Add Samsung Exynos5250 SoC specific data to enable pinctrl support for all platforms based on Exynos5250. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org

Re: [PATCH] ARM: dts: add pinctrl nodes for Exynos5250 SoC

2012-12-14 Thread Linus Walleij
On Thu, Dec 13, 2012 at 2:06 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Add pinctrl device nodes for Exynos5250 SoC. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org - The individual device nodes which are using the old style

Re: [PATCH 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-01-06 Thread Linus Walleij
: change PINCTRL_EXYNOS option Since pinctrl-exynos can support exynos4 and exynos5 so changed the option name to PINCTRL_EXYNOS for more clarity. Cc: Thomas Abraham thomas.abra...@linaro.org Cc: Linus Walleij linus.wall...@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Signed-off

Re: [PATCH 01/26] gpio: samsung: remove inclusion mach/regs-clock.h

2013-01-10 Thread Linus Walleij
On Wed, Jan 2, 2013 at 11:23 PM, Kukjin Kim kgene@samsung.com wrote: The mach/regs-clock.h is not needed for gpio-samsung. Cc: Linus Walleij linus.wall...@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Kukjin Kim kgene@samsung.com Applied to fixes, thanks

Re: [PATCH 09/26] ARM: SAMSUNG: cleanup mach/gpio-fns.h gpio-track.h and gpio-nrs.h

2013-01-10 Thread Linus Walleij
On Wed, Jan 2, 2013 at 11:23 PM, Kukjin Kim kgene@samsung.com wrote: remove mach/gpio-fns.h, mach/gpio-track.h and plat/gpio-fns.h Cc: Linus Walleij linus.wall...@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Kukjin Kim kgene@samsung.com This really needs

Re: [PATCH v4 19/19] irqchip: Move ARM vic.h to include/linux/irqchip/arm-vic.h

2013-01-10 Thread Linus Walleij
on fixes merged for -rc3. Apart from that, Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v4 14/19] ARM: remove unneeded vic.h includes

2013-01-10 Thread Linus Walleij
On Thu, Jan 3, 2013 at 6:54 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com Numerous includes of asm/hardware/vic.h aren't needed, so remove them. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH] gpio: samsung: add GPIO interrupt registration for exynos5

2013-01-17 Thread Linus Walleij
support GPIO interrupt, so their struct samsung_gpio_cfg should be initialized to samsung_gpio_cfgs[8] in declaration ahead. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com This patch has been floating for a while, Kyungmin, Kukjin, Thomas: shall it be applied? Yours, Linus Walleij

Re: [PATCH] gpio: samsung: fix pinctrl condition for exynos and exynos5440

2013-01-17 Thread Linus Walleij
EXYNOS5440 so PINCTRL_EXYNOS5440 has been implemented separated. Cc: Thomas Abraham thomas...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Patch applied, thanks. Sorry for taking an eternity for getting to these patches :-( Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH] gpio: samsung: silent build warning for EXYNOS5 SoCs

2013-01-17 Thread Linus Walleij
: 'exynos5_gpios_4' defined but not used [-Wunused-variable] Because current gpio-samsung is valid only on EXYNOS5250. Cc: Thomas Abraham thomas...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Patch applied, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Linus Walleij
this patch just to annoy people with obsessive-compulsive disorder (but that's a bit mean). Reference: http://izismile.com/2011/08/16/obnoxious_ways_to_drive_people_with_ocd_nuts_16_pics.html But I'd like a word from Rob, Grant or Stephen so I have some guidance here. Yours, Linus Walleij

Re: [PATCH 01/26] gpio: samsung: remove inclusion mach/regs-clock.h

2013-01-17 Thread Linus Walleij
missed it. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gpio: samsung: skip gpio lib registration for EXYNOS5440

2013-01-17 Thread Linus Walleij
, no GPIOs added Acked-by: Thomas Abraham thomas...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Appled to fixes. Thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-17 Thread Linus Walleij
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim kgene@samsung.com wrote: Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. Cc: Thomas Abraham thomas...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org Cc: Grant Likely grant.lik...@secretlab.ca Signed-off

Re: [PATCH] pinctrl: samsung: removing duplicated condition for PINCTRL_SAMSUNG

2013-01-18 Thread Linus Walleij
@samsung.com Patch applied to pinctrl fixes, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-01-18 Thread Linus Walleij
On Thu, Jan 10, 2013 at 2:29 AM, Kukjin Kim kgene@samsung.com wrote: Linus Walleij wrote: On Thu, Dec 27, 2012 at 5:58 PM, Kukjin Kim kgene@samsung.com wrote: And I think, would be clear if the config could be changed like following. 8

Re: Failure due to missing (Exynos related) pinctrl patch

2013-01-29 Thread Linus Walleij
based board: Hm I didn't realize there was a dependency between these patches, oh well, better get the pull for the pinctrl tree finished off then... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: Failure due to missing (Exynos related) pinctrl patch

2013-01-30 Thread Linus Walleij
squashed together. Err, Sachin, what are you talking about? As you said, one patch has been merged into the mainline, so how does it can be squashed? In this case, just applying the other patch into pinctrl-fixes is enough. Torvalds has already pulled it in - problem solved. :-) Yours, Linus

Re: Failure due to missing (Exynos related) pinctrl patch

2013-01-31 Thread Linus Walleij
On Wed, Jan 30, 2013 at 11:15 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 30 January 2013 15:18, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Jan 30, 2013 at 5:08 AM, Kukjin Kim kgene@samsung.com wrote: Sachin Kamat wrote: This patch is required along with the patch

Re: [PATCH] pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()

2013-02-10 Thread Linus Walleij
from the maintainers. Thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] ARM: S3C24XX: handle s3c2412 eints using new infrastructure

2013-02-15 Thread Linus Walleij
definately need an ACK from some Samsung maintainer for this patch... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Linus Walleij
core The right solution is to simply revert commit 2693ac69880a33d4d9df6f128415b65e745f00ba i2c: s3c2410: Add support for pinctrl Tomasz are you OK with this, or will you add more fine-grained pinctrl (like runtime PM etc) to this driver? Yours, Linus Walleij -- To unsubscribe from this list

Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-23 Thread Linus Walleij
now? Plus, I think that now that the device core is handling pin control you should be able to just remove all this default-enabling from your drivers. *NO* using of pinctrl to check if do we need to do it some other way. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Linus Walleij
{ bool use_that_old_gpio_interface; (...) }; Instead of trying to semi-guess if the pinctrl framework is there? Surely you know this when setting up the pdata from your machine? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Linus Walleij
a temporary solution. The legacy DT- based pin configuration will go away after all the DT-enabled platforms using this driver get migrated to pin control and so will the need to check if pin control is available. So use AUXDATA, and you get a pdata for that driver? Yours, Linus Walleij

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Linus Walleij
the platforms relying on the legacy DT GPIO support should have been already migrated to pin control, so ideally instead of fixing the drivers to continue supporting the deprecated method, such platforms should be fixed. I agree. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-24 Thread Linus Walleij
come across as too harsh and then I feel bad about that :-( I really want spare-time contributors, they are often more valueable in addition to the corporate ones since they provide an outside view of things. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] i2c: s3c24xx: allow device core to setup default pin configuration

2013-03-06 Thread Linus Walleij
is also removed. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-03-07 Thread Linus Walleij
Acked-by: Linus Walleij linus.wall...@linaro.org So shall I merge these three patches to the pinctrl tree or not? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mmc: sdhci-s3c: let device core setup the default pin configuration

2013-03-07 Thread Linus Walleij
is also removed. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] spi: s3c64xx: let device core setup the default pin configuration

2013-03-07 Thread Linus Walleij
...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: samsung-keypad: let device core setup the default pin configuration

2013-03-07 Thread Linus Walleij
...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-03-07 Thread Linus Walleij
...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ASoC: samsung: let device core setup the default pin configuration

2013-03-07 Thread Linus Walleij
thomas.abra...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ARM: dts: Add default pin states for client nodes on Exynos4/5 platforms

2013-03-07 Thread Linus Walleij
in the client nodes allows the device core to setup the default pin configuration for all the controllers. The series: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: State of pinctrl and exynos5250?

2013-03-07 Thread Linus Walleij
, Stephen's point to have one single pinctrl set-up for the entire device seems perfectly valid, why do you need to specify it per-slot at all? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-03-07 Thread Linus Walleij
On Thu, Mar 7, 2013 at 12:09 PM, Kukjin Kim kgene@samsung.com wrote: [Me] So shall I merge these three patches to the pinctrl tree or not? Hi Linus, this series is already in Samsung tree with your ack. OK good, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH 3/6] pinctrl: samsung: Split pin bank description into two structures

2013-04-03 Thread Linus Walleij
Abraham on this patch. Thanks, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] pinctrl: samsung: Protect bank registers with a spinlock

2013-04-09 Thread Linus Walleij
a per bank spinlock as it was done in the old Samsung GPIO driver. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com OK no reaction from the other Samsung maintainers so now I start applying these... Patch applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/6] pinctrl: samsung: Include pinctrl-exynos driver data conditionally

2013-04-09 Thread Linus Walleij
applying? Fixed and applied. Thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/6] pinctrl: samsung: Split pin bank description into two structures

2013-04-09 Thread Linus Walleij
a pointer to a bank type struct. It is a prerequisite for further patch removing the statically hardcoded register offsets, making it impossible to support SoCs with different set and order of pin control registers. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Patch applied. Yours, Linus

  1   2   3   >