Re: [PATCH v2 5/5] input: samsung-keypad - Add samsung keypad driver

2010-05-29 Thread Marek Vasut
Dne Ne 30. května 2010 05:06:24 Joonyoung Shim napsal(a): This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

2010-05-29 Thread Marek Vasut
Dne Ne 30. května 2010 05:06:20 Joonyoung Shim napsal(a): This patch adds samsung keypad device definition for samsung cpus. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/plat-samsung/Kconfig|

Re: [PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

2010-05-30 Thread Marek Vasut
Dne Po 31. května 2010 02:06:48 Kukjin Kim napsal(a): Joonyoung Shim wrote: This patch adds samsung keypad device definition for samsung cpus. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v4] libata: pata_samsung_cf: Add Samsung PATA controller driver

2010-06-24 Thread Marek Vasut
Dne Pá 25. června 2010 05:38:19 Kukjin Kim napsal(a): Jeff Garzik wrote: On 06/14/2010 03:07 AM, Kukjin Kim wrote: From: Abhilash Kesavana.kesa...@samsung.com Adds support for the Samsung PATA controller. This driver is based on the Libata subsystem and references the earlier

Re: [PATCH 1/3] h1940: use gpiolib for latch access

2010-08-24 Thread Marek Vasut
Dne Čt 19. srpna 2010 17:00:01 Vasily Khoruzhick napsal(a): This patch adds gpiolib support for h1940 latch. With this patch it's possible to use leds-gpio and uda1380 drivers (they require gpiolib support for appropriate pins). And now it's possible to drop leds-h1940 driver.

Re: [PATCH 2/3] h1940: fix h1940-bluetooth compilation

2010-08-24 Thread Marek Vasut
Dne Čt 19. srpna 2010 17:00:02 Vasily Khoruzhick napsal(a): Signed-off-by: Vasily Khoruzhick anars...@gmail.com Errr ... fix ... in what way? What was broken? I don't understand, please add more explanatory text. Thanks Cheers --- arch/arm/mach-s3c2410/h1940-bluetooth.c |8 1

Re: [PATCH 3/3] h1940: implement mmc_power function

2010-08-24 Thread Marek Vasut
Dne Čt 19. srpna 2010 17:00:03 Vasily Khoruzhick napsal(a): Signed-off-by: Vasily Khoruzhick anars...@gmail.com --- arch/arm/mach-s3c2410/include/mach/h1940-latch.h |2 +- arch/arm/mach-s3c2410/mach-h1940.c | 23 +++-- 2 files changed, 21 insertions(+), 4

Re: [PATCH 2/3] h1940: fix h1940-bluetooth compilation

2010-08-24 Thread Marek Vasut
Dne Út 24. srpna 2010 15:57:07 Vasily Khoruzhick napsal(a): В сообщении от 24 августа 2010 16:50:46 автор Marek Vasut написал: Dne Čt 19. srpna 2010 17:00:02 Vasily Khoruzhick napsal(a): Signed-off-by: Vasily Khoruzhick anars...@gmail.com Errr ... fix ... in what way? What was broken? I

Re: [PATCH 1/3] h1940: use gpiolib for latch access

2010-08-24 Thread Marek Vasut
Dne Út 24. srpna 2010 16:50:36 Vasily Khoruzhick napsal(a): В сообщении от 24 августа 2010 17:40:21 автор Marek Vasut написал: Defining S3C2410_GPH_GPIONAME for each bit might be better then. Well, that requires massive refactoring of h1940 (and rx1950) support. And btw, that's common

Re: [PATCH 3/4] ARM: S5PC110: add common FIMC setup code

2010-09-05 Thread Marek Vasut
Dne Po 6. září 2010 06:34:28 Marek Szyprowski napsal(a): Hello, On 2010-09-06 13:16 Marek Vasut wrote: Dne Po 6. září 2010 05:50:43 Marek Szyprowski napsal(a): Add common clocks setup code for FIMC devices on S5PV210 SoCs. Signed-off-by: Marek Szyprowskim.szyprow...@samsung.com

Re: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight

2013-03-19 Thread Marek Vasut
regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight

2013-03-20 Thread Marek Vasut
Hi Mark, On Tue, Mar 19, 2013 at 04:10:26PM -0600, Stephen Warren wrote: On 03/19/2013 03:27 PM, Marek Vasut wrote: Do we really need a mandatory regulator? Why can't it be optional? IIRC, the previous advice I've seen is that if a device (driver) uses a regulator, it must /require

Re: [PATCH V5 3/9] ARM: pxa: Provide regulator to pwm-backlight

2013-03-28 Thread Marek Vasut
Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] S3C2443: Move i2s clock definitions to common code

2011-08-21 Thread Marek Vasut
On Sunday, August 21, 2011 07:25:04 PM Heiko Stübner wrote: Am Sonntag 21 August 2011, 19:13:32 schrieb Russell King - ARM Linux: On Sat, Aug 20, 2011 at 06:01:29PM +0200, Heiko Stübner wrote: +/* i2s-ref + * + * i2s bus reference clock, selectable from external, esysclk or epllref

Re: [PATCH] spi: Make core DMA mapping functions generate scatterlists

2014-02-04 Thread Marek Vasut
On Sunday, February 02, 2014 at 02:52:52 PM, Mark Brown wrote: Hi, thanks for preparing this patch! I have just a few very minor nitpicks, ignore if you please. [...] +static int spi_map_buf(struct spi_master *master, struct device *dev, +struct sg_table *sgt, void *buf,

Re: [PATCH] spi: Make core DMA mapping functions generate scatterlists

2014-02-05 Thread Marek Vasut
On Wednesday, February 05, 2014 at 01:00:02 PM, Mark Brown wrote: On Wed, Feb 05, 2014 at 07:30:57AM +0100, Marek Vasut wrote: On Sunday, February 02, 2014 at 02:52:52 PM, Mark Brown wrote: +static int spi_map_buf(struct spi_master *master, struct device *dev, +struct

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-06 Thread Marek Vasut
Acked-by: Arnd Bergmann a...@arndb.de (+cc Mohit KUMAR, Richard Zhu, Pratyush Anand, Marek Vasut, Kishon Vijay Abraham I) Acked-by: Jingoo Han jg1@samsung.com It works properly on Exynos platform. Thank you. Looks reasonable, Reviewed-by: Marek Vasut ma...@denx.de +CC Troy

Re: [PATCH 0/8] i.MX6 PCIe binding change and MSI support

2014-03-30 Thread Marek Vasut
of the old binding (most of the optional properties in the binding aren't even implemented). Looking forward to your feedback. Other but 2/8, which needs further discussion, Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/8] ARM: imx6q-clk: parent lvds_gate from lvds_sel

2014-03-30 Thread Marek Vasut
On Friday, March 28, 2014 at 05:52:52 PM, Lucas Stach wrote: Allows fror proper refcounting of the parent clocks when enabling the clock output on CLK1/2 pads. Signed-off-by: Lucas Stach l.st...@pengutronix.de Looks OK: Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut

Re: [PATCH 2/8] PCI: designware: split Exynos and i.MX bindings

2014-03-30 Thread Marek Vasut
it cannot enable the regulator which will power up the slot the device is sitting in. [...] btw. am I blind or do I just not see devicetree-discuss on CC ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 2/8] PCI: designware: split Exynos and i.MX bindings

2014-03-31 Thread Marek Vasut
On Monday, March 31, 2014 at 11:28:29 AM, Lucas Stach wrote: Am Sonntag, den 30.03.2014, 19:36 +0200 schrieb Marek Vasut: On Friday, March 28, 2014 at 05:52:53 PM, Lucas Stach wrote: The glue around the core designware IP is significantly different between the Exynos and i.MX

Re: [PATCH 2/8] PCI: designware: split Exynos and i.MX bindings

2014-03-31 Thread Marek Vasut
On Monday, March 31, 2014 at 12:38:01 PM, Lucas Stach wrote: Am Montag, den 31.03.2014, 11:36 +0200 schrieb Marek Vasut: On Monday, March 31, 2014 at 11:28:29 AM, Lucas Stach wrote: Am Sonntag, den 30.03.2014, 19:36 +0200 schrieb Marek Vasut: On Friday, March 28, 2014 at 05:52:53 PM

Re: [PATCH 10/11] spi: add more debug prints in s3c64xx

2015-06-03 Thread Marek Vasut
On Wednesday, June 03, 2015 at 11:26:42 PM, Michal Suchanek wrote: The SPI NOR transfers mysteriously fail so add more debug prints about SPI transactions. Signed-off-by: Michal Suchanek hramr...@gmail.com dev_dbg() and friends would certainly be nicer here. Best regards, Marek Vasut

Re: [PATCH 04/11] mtd: ofpart: do not fail probe when no partitions exist

2015-06-03 Thread Marek Vasut
. Change this condition to a warning so that flash without partitions can be accessed on Exynos. I have to admit the rationale for this patch is not very clear to me, sorry. Can you please explain this a bit more ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 00/11] Enable access to SPI NOR flash on Samsung Snow board

2015-06-03 Thread Marek Vasut
data transfers are less likely to be affected. Sounds like the DMA engine driver should be fixed. Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-03 Thread Marek Vasut
. + Using this option may severely degrade performance and + possibly flash memory life when max_tx_len is smaller than + flash page size (typically 256 bytes) Will we need similar patch for all other SPI slave drivers, like SPI NAND ? Best regards, Marek Vasut

Re: [PATCH 04/11] mtd: ofpart: do not fail probe when no partitions exist

2015-06-05 Thread Marek Vasut
On Thursday, June 04, 2015 at 05:40:58 PM, Michal Suchanek wrote: On 4 June 2015 at 17:28, Marek Vasut ma...@denx.de wrote: On Thursday, June 04, 2015 at 06:54:00 AM, Michal Suchanek wrote: On 4 June 2015 at 00:58, Marek Vasut ma...@denx.de wrote: On Wednesday, June 03, 2015 at 11:26:40 PM

Re: [PATCH 00/11] Enable access to SPI NOR flash on Samsung Snow board

2015-06-04 Thread Marek Vasut
On Thursday, June 04, 2015 at 06:21:32 AM, Michal Suchanek wrote: On 4 June 2015 at 00:53, Marek Vasut ma...@denx.de wrote: On Wednesday, June 03, 2015 at 11:26:39 PM, Michal Suchanek wrote: Hello, Hi, this patch series makes it possible to access the SPI NOR flash in the Samsung

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-04 Thread Marek Vasut
On Thursday, June 04, 2015 at 06:31:45 AM, Michal Suchanek wrote: On 4 June 2015 at 01:03, Marek Vasut ma...@denx.de wrote: On Wednesday, June 03, 2015 at 11:26:41 PM, Michal Suchanek wrote: On sunxi the SPI controller currently does not have DMA support and fails any transfer larger than

Re: [PATCH 04/11] mtd: ofpart: do not fail probe when no partitions exist

2015-06-04 Thread Marek Vasut
On Thursday, June 04, 2015 at 06:54:00 AM, Michal Suchanek wrote: On 4 June 2015 at 00:58, Marek Vasut ma...@denx.de wrote: On Wednesday, June 03, 2015 at 11:26:40 PM, Michal Suchanek wrote: On Exynos it is necessary to set SPI controller parameters that apply to a SPI slave in a DT subnode

Re: [PATCH 11/11] dt: Exynos: add Snow SPI NOR node.

2015-06-04 Thread Marek Vasut
nonsense. Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-30 Thread Marek Vasut
On Thursday, July 30, 2015 at 02:18:09 PM, Michal Suchanek wrote: On 30 July 2015 at 13:24, Marek Vasut ma...@denx.de wrote: On Monday, July 27, 2015 at 10:43:05 PM, Michal Suchanek wrote: On 27 July 2015 at 19:43, Marek Vasut ma...@denx.de wrote: On Monday, July 27, 2015 at 11:46:25 AM

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-30 Thread Marek Vasut
On Monday, July 27, 2015 at 10:43:05 PM, Michal Suchanek wrote: On 27 July 2015 at 19:43, Marek Vasut ma...@denx.de wrote: On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: On 24 July 2015 at 10:34, Marek Vasut ma...@denx.de wrote: On Thursday, July 23, 2015 at 07:03:47 PM

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-27 Thread Marek Vasut
On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: On 24 July 2015 at 10:34, Marek Vasut ma...@denx.de wrote: On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: Hi! [...] It's probably slower to set up DMA for 2-byte commands but it might work

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-24 Thread Marek Vasut
On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: Hi! [...] It's probably slower to set up DMA for 2-byte commands but it might work nonetheless. It is, the overhead will be considerable. It might help the stability though. I'm really looking forward to the results!

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
a formula would be needed that translates arbitrary client settings to transfer size limit and there would be need to somehow get the client settings to the formula in the dmaengine driver. Thanks Michal Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 10:38:14 AM, Michal Suchanek wrote: On 22 July 2015 at 10:24, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: On 22 July 2015 at 09:58, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:45

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: On 22 July 2015 at 09:33, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: On 22 July 2015 at 06:49, Vinod Koul vinod.k...@intel.com wrote: On Tue, Jul 21, 2015 at 10:14

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: On 22 July 2015 at 09:58, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: On 22 July 2015 at 09:33, Marek Vasut ma...@denx.de wrote: On Wednesday, July 22, 2015 at 09:30

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Marek Vasut
On Thursday, July 16, 2015 at 03:19:35 AM, Brian Norris wrote: On Wed, Jul 15, 2015 at 07:15:50PM +0200, Marek Vasut wrote: On Wednesday, July 15, 2015 at 05:59:46 PM, Brian Norris wrote: 1. Fix up the SPI driver so that it knows how to break large SPI transfers up into smaller segments

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Marek Vasut
On Wednesday, July 15, 2015 at 05:59:46 PM, Brian Norris wrote: Hi Michal, Hi all, On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: The problem is, if you add a new DT binding, you'd have to support it forever, no matter how bad idea that binding turned out to be. Agreed

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Marek Vasut
with a suggested value which can be tuned depending on the system seems more viable. The problem is, if you add a new DT binding, you'd have to support it forever, no matter how bad idea that binding turned out to be. Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe