Hi Thomas Abraham,
How about separating the variant for Samsung Exynos.
Like dw_mmc-exynos.c
Thanks,
Seungwon Jeon.
Thomas Abraham wrote:
The instantiation of the Synopsis Designware controller on Exynos5250
include extension for SDR and DDR specific tx/rx phase shift timing
and CIU internal
SDMMC_CLKSEL_GET_DIVRATIO(x) x) 24) 0x7) + 1)
+#define SDMMC_CLKSEL_GET_SELCLK_DRV(x) (((x) 16) 0x7)
+
Is this patch considered only for exynos5250?
In case of exynos4210, the number of bits is different.
If upper macros is backward-compatible, it would be better.
Best regards,
Seungwon Jeon
input rate for cclk_in of mshc.
Host of samsung soc doesn't use input clock from system directly.
As you have introduced CLKSEL in your another patch, input clock can be changed
prior to cclk_in.
For non-samsung host, we don't need to consider this with generic way?
Thanks,
Seungwon Jeon
July 23, 2012, Thomas Abraham thomas.abra...@linaro.org wrote:
On 20 July 2012 16:08, Seungwon Jeon tgih@samsung.com wrote:
July 20, 2012, Thomas Abraham thomas.abra...@linaro.org wrote:
On 19 July 2012 09:21, Seungwon Jeon tgih@samsung.com wrote:
[...]
+static unsigned long
are board-specific timing
values.
So, these values can't be used commonly. It has been already discussed.
If this property is empty, returning error with message will be fine.
Currently just 0 is always returned.
Thanks,
Seungwon Jeon
+}
+
+static int dw_mci_exynos_setup_bus(struct dw_mci *host
: dw_mmc: lookup for optional biu and
ciu clocks
Could I get your opinion?
Thanks,
Seungwon Jeon
+
+ if (!host-bus_hz) {
dev_err(host-dev,
Platform data must supply bus speed\n);
- return -ENODEV;
+ ret = -ENODEV;
+ goto
On Tuesday, August 28, 2012 Thomas Abraham thomas.abra...@linaro.org wrote:
Hi Seungwon,
On 28 August 2012 12:36, Seungwon Jeon tgih@samsung.com wrote:
Hi Thomas,
Thank you for your effort.
Some reviews seems like to be omitted. Please check more.
On Sunday, August 26, 2012
)
+{
+ struct dw_mci_exynos_priv_data *priv = host-priv;
+ struct device_node *np = host-dev-of_node;
+ u32 timing[3];
u32 timing[2] is enough.
Thanks,
Seungwon Jeon
+ u32 div = 0;
+ int ret;
+
+ of_property_read_u32(np, samsung,dw-mshc-ciu-div, div);
+ priv-ciu_div
;
As adding dw-mshc-ciu-div, third field of dw-mshc-ddr-timing can be removed.
Thanks,
Seungwon Jeon
+
+ slot@0 {
+ reg = 0;
+ bus-width = 8;
+ gpios = gpc0 0 2 0 3, gpc0 1 2 0 3,
+ gpc1 0 2 3 3, gpc1
On Friday, September 07, 2012, Thomas Abraham thomas.abra...@linaro.org wrote:
Hi Seungwon,
Thanks for reviewing the patch.
On 5 September 2012 16:13, Seungwon Jeon tgih@samsung.com wrote:
On Wednesday, September 05, 2012, Thomas Abraham
thomas.abra...@linaro.org wrote:
Version 6
On Thursday, September 20, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
On 19 September 2012 19:12, Seungwon Jeon tgih@samsung.com wrote:
On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
+int dw_mci_exynos_probe(struct platform_device *pdev
On Thursday, September 20, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
On 19 September 2012 19:09, Seungwon Jeon tgih@samsung.com wrote:
On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
+#ifdef CONFIG_OF
+/* given a slot id, find out
patch would be good, please.
(I'd normally take an updated patch but Stephen Rothwell's asked for
people to hold off rebasing now that -rc7 is out, which is reasonable.)
Thomas,
Is there any work for fix?
Thanks,
Seungwon Jeon
Thanks,
- Chris.
--
Chris Ball c...@laptop.org http
.
As there also could be other Samsung platforms affected that use the ext-gpio
code, it's probably right to revert it for now. Or you see a easy fix :-) .
Hi,
I think clock is disabled during bus transaction.
I'll send a patch. Could you test it?
Thanks.
Seungwon Jeon
Heiko
Best
Hi,
wp-gpios has been implemented in dw_mmc-exynos.c
It can be reused for EXYNOS platform? We need to modify some though.
Thanks,
Seungwon Jeon
On Thursday, November 22, 2012, Doug Anderson diand...@chromium.org wrote:
On some SoCs (like exynos5250) you need to use an external GPIO for
write
On Thursday, November 22, 2012, Doug Anderson diand...@chromium.org wrote:
On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon tgih@samsung.com wrote:
Hi,
wp-gpios has been implemented in dw_mmc-exynos.c
It can be reused for EXYNOS platform? We need to modify some though.
Yup, I've seen
/mach-exynos/include/mach/dwmci.h
Hi Thomas,
The following parts are remained. Also, no used code.
Could you check it?
./plat-samsung/include/plat/devs.h:126:extern struct platform_device
exynos4_device_dwmci;
./Kconfig:111:config EXYNOS4_DEV_DWMCI
Thanks,
Seungwon Jeon
diff --git a/arch/arm
.
Thanks,
Seungwon Jeon
--
1.7.7.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Doug,
On Thursday, November 29, 2012, Doug Anderson wrote:
Seungwon,
Thanks for the review. See below for comments. If you'd like me to
respin then please let me know. Otherwise I look forward to your ack.
On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon tgih@samsung.com wrote
Doug, Thanks to work.
Looks good to me with other patches.
Acked-by: Seungwon Jeon tgih@samsung.com
On Friday, November 30, 2012, Doug Anderson wrote:
The disable-wp property is used to specify that a given SD card slot
doesn't have a concept of write protect. This eliminates the need
the purpose, it would be good to remove.
And, could you change commit prefix for consistency?
dwmmc - dw_mmc
Thanks,
Seungwon Jeon
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
drivers/mmc/host/dw_mmc-exynos.c | 38
--
1 files changed, 0
: dw_mmc: Add MSHC compatible for Exynos4412
...just to avoid the simple merge conflict when applying?
Otherwise everything here looks great...
-Doug
Thomas,
It's a conflict to merge. Please do rebase the patch.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe
On Friday, April 05, 2013, Thomas Abraham wrote:
With device core now able to setup the default pin configuration,
the pin configuration code based on the deprecated Samsung specific
gpio bindings is removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Seungwon Jeon
on mmc_alloc_host.
mmc_alloc_host is called prior to regulator_enable.
So, if regulator_enable is failed, call of mmc_free_host makes sense.
Thanks,
Seungwon Jeon
-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More
Hi Sonny,
Can you separate procedure?
Reset all are handled in fifo-reset.
And ciu reset is always needed for error handling?
Thanks,
Seungwon Jeon
On Sat, May 10, 2014, Sonny Rao wrote:
On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi, Sonny.
You can
)) {
+ dw_mci_request_end(host, mrq);
+ goto unlock;
+ }
Can you explain what happens above?
What is it for?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
Seungwon,
On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon tgih@samsung.com wrote:
On Fri, May 09, 2014, Sonny Rao wrote:
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote:
Any comments on this patch
is needed?
Thanks,
Seungwon Jeon
+ return false;
+ }
+
+#ifdef CONFIG_MMC_DW_IDMAC
+ /* It is also recommended that we reset and reprogram idmac */
+ dw_mci_idmac_reset(host);
+#endif
+
+ /* After a CTRL reset we need to have CIU set clock registers
On Tuesday, May 13, Sonny Rao wrote:
On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com wrote:
As I mentioned in previous version, you put all reset stuff in existing
fifo_reset function.
Although databook mentions ciu_reset case for SBE error, it's not obvious
when
On Wed, May 14, 2014, Doug Anderson wrote:
Seungwon,
On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon tgih@samsung.com wrote:
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
Seungwon,
On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon tgih@samsung.com
wrote:
On Fri, May
On Sat, May 17, 2014, Doug Anderson wrote:
Seungwon,
On Thu, May 15, 2014 at 6:46 PM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, May 14, 2014, Doug Anderson wrote:
Seungwon,
On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon tgih@samsung.com
wrote:
Hi Doug,
On Tue
On Sat, May 17, 2014, Sonny Rao wrote:
On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon tgih@samsung.com wrote:
On Tuesday, May 13, Sonny Rao wrote:
On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com
wrote:
As I mentioned in previous version, you put all reset stuff
On Tue, May 13, 2014, Seungwon Jeon wrote:
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
Seungwon,
On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon tgih@samsung.com wrote:
On Fri, May 09, 2014, Sonny Rao wrote:
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar yuvaraj
On Wed, May 21, 2014, Doug Anderson wrote:
Seungwon,
On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon tgih@samsung.com wrote:
+ } else {
+ /*
+* If we don't have a command
complete now
procedure
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changes in v2:
- Removed TODO
- Set cmd to NULL before calling dw_mci_request_end()
drivers/mmc/host/dw_mmc.c | 46 ++
1 file changed, 46 insertions(+)
diff --git
instead of the
device node.
Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changelog V2:
- Fix the typo.
drivers/mmc/core/host.c | 13
].quirk, NULL))
- pdata-quirks |= of_quirks[idx].id;
-
Same as above.
Thanks,
Seungwon Jeon
if (of_property_read_u32(np, fifo-depth, pdata-fifo_depth))
dev_info(dev, fifo-depth property not found, using
value of FIFOTH
Can this be merged with your another patch, [PATCH 2/5] mmc: dw_mmc: remove
the supports-highspeed property.?
On Mon, May 26, 2014, Jaehoon Chung wrote:
dw-mmc controller can be support the multiple slot.
can support, it would be better to correct the above message.
Thanks,
Seungwon Jeon
So
mmc bindings instead of driver-specific,
host driver shall not need old one.
I think we can remove it.
Thanks,
Seungwon Jeon
If i'm wrong, let me know, plz.
Thank you for sharing the information.
Best Regards,
Jaehoon Chung
Kind regards
Ulf Hansson
--
To unsubscribe from
On Wed, May 28, 2014, Jaehoon Chung wrote:
dw-mmc controller has the multiple slot.
Then it needs to parse the property for each slot.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changelog V3:
- Fix
On Wed, May 28, 2014, Jaehoon Chung wrote:
Removed the parser for supports-highspeed.
It can be parsed with cap-mmc-highsped or cap-sd-highspeed at
mmc_of_parse().
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Tahnks,
Seungwon Jeon
be replaced to cap-sd/mmc-highspeed.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Looks good to me.
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changelog V3:
- Merge [PATCH 2/5] mmc: dw_mmc: rmove the supports-highspeed
property
Changelog V2
-vmmc);
-
Just to check: have you tested suspend/resume with the various
combinations of keep-power-in-suspend and non-removable with your
patch. I remember some of the logic being a bit complicated...
Please check it and give some updates/result in next version.
Thanks,
Seungwon Jeon
= ~SDMMC_INT_VOLT_SWITCH;
+ dw_mci_cmd_interrupt(host,
+ pending | SDMMC_INT_CMD_DONE);
Artificially adding SDMMC_INT_CMD_DONE to pending is needed to complete cmd
handling?
Is there any reason?
Thanks,
Seungwon Jeon
Hi Doug,
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com wrote:
+ case MMC_POWER_ON:
+ if (!IS_ERR(mmc-supply.vqmmc)
+ !test_bit(DW_MMC_IO_POWERED,
slot
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed, Jun 25, 2014 at 6:08 AM, Seungwon Jeon tgih@samsung.com wrote:
On Mon, June 23, 2014, Yuvaraj Kumar C D wrote:
Subject: [PATCH 3/3] mmc: dw_mmc: Support voltage changes
From: Doug Anderson diand...@chromium.org
Hi Yuvaraj,
On Fri, June 27, 2014, Yuvaraj Kumar wrote:
On Thu, Jun 26, 2014 at 10:20 PM, Doug Anderson diand...@chromium.org wrote:
Seungwon,
On Thu, Jun 26, 2014 at 3:41 AM, Seungwon Jeon tgih@samsung.com wrote:
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed
On Fri, June 27, 2014, Doug Anderson wrote:
Seungwon,
On Thu, Jun 26, 2014 at 3:30 AM, Seungwon Jeon tgih@samsung.com wrote:
Hi Doug,
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com
wrote
= dw_mci_prepare_command(slot-mmc, mrq-stop);
If i misunderstood something, plz let me know...Thanks.
Yes, predefined transfer doesn't send stop command normally.
But if transfer error is occurred, stop command is required.
Thank you for test.
Best regards,
Seungwon Jeon.
Tested-by: Jaehoon Chung jh80.ch
Adrian Hunter wrote:
On 22/09/11 05:12, Seungwon Jeon wrote:
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation
Adrian Hunter wrote:
On 08/09/11 10:29, Seungwon Jeon wrote:
This patch adds cache feature of eMMC4.5 Spec.
If device supports cache capability, host can utilize some specific
operations.
Signed-off-by: Seungwon Jeontgih@samsung.com
---
This patch is base on [PATCH v3] mmc: core
Andrei E. Warkentin wrote:
Hi Seungwon,
2011/10/6 Seungwon Jeon tgih@samsung.com:
Adrian Hunter wrote:
On 08/09/11 10:29, Seungwon Jeon wrote:
This patch adds cache feature of eMMC4.5 Spec.
If device supports cache capability, host can utilize some specific
operations
Adrian Hunter wrote:
On 06/10/11 07:38, Seungwon Jeon wrote:
Adrian Hunter wrote:
On 08/09/11 10:29, Seungwon Jeon wrote:
This patch adds cache feature of eMMC4.5 Spec.
If device supports cache capability, host can utilize some specific
operations.
Signed-off-by: Seungwon Jeontgih
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used for default
timeout except for some operations which don't define the timeout(i.e.
background operation, sanitize, flush cache) in eMMC4.5 Spec.
Signed-off-by: Seungwon Jeon tgih
This mail is a duplicate from our security machine.
V5 of related patch has already submitted.
Please ignore this resending.
I think that it was unfortunate.
Seungwon Jeon.
EXT_CSD[248] includes the default maximum timeout for CMD6.
This field is added at eMMC4.5 Spec. And it can be used
Base code of V8 may be mixed.
Please check below for next resending. It seems like unrelated.
#define MMC_CAP2_CACHE_CTRL (1 1)
#define EXT_CSD_FLUSH_CACHE 32
Best regards,
Seungwon Jeon.
Girish K S wrote:
This patch adds the support for power off notify feature, available
This patch will apply the generic CMD6 timeout to switch command
for power class.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index f8ea938
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message is
added for checking failure case of cache-on.
Signed-off-by: Seungwon Jeon tgih@samsung.com
Girish K S wrote:
On 24 October 2011 15:40, Seungwon Jeon tgih@samsung.com wrote:
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message
Chris Ball wrote:
Hi Seungwon,
On Mon, Oct 24 2011, Seungwon Jeon wrote:
Code cleanup. The codes of related to eMMC4.5 are scattered.
This patch removes a duplicate if-statement and assembles all.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c | 20
at card-init.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/mmc.c | 20 +---
1 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 6354eb3..6354bac 100644
--- a/drivers/mmc/core/mmc.c
+++ b
S, Venkatraman svenk...@ti.com wrote:
On Thu, Oct 27, 2011 at 4:24 PM, Seungwon Jeon tgih@samsung.com wrote:
This patch supports packed command feature of eMMC4.5 Spec.
Several reads(or writes) can be grouped in packed command
and all data of the individual commands can be sent in one
This patch-set adds support of packed command feature
for eMMC4.5 devices.
Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device
drivers/mmc/card/block.c | 355
This patch adds packed command feature of eMMC4.5.
The maximum number for packing read(or write) is offered
and exception event relevant to packed command which is
used for error handling is enabled. If host wants to use
this feature, MMC_CAP2_PACKED_CMD should be set.
Signed-off-by: Seungwon
S, Venkatraman svenk...@ti.com wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote:
This patch supports packed command of eMMC4.5 device.
Several reads(or writes) can be grouped in packed command
and all data of the individual commands can be sent in a
single
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com wrote:
S, Venkatraman svenk...@ti.com wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com wrote:
This patch supports packed command of eMMC4.5 device.
Several
Maya Erez wrote:
On Thu, Nov 10, 2011 Maya Erez wrote:
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com
wrote:
+static u8 mmc_blk_chk_packable(struct mmc_queue *mq, struct
request *req)
The function prepares the checkable list
S, Venkatraman svenk...@ti.com wrote:
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com wrote:
Maya Erez wrote:
On Thu, Nov 10, 2011 Maya Erez wrote:
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com
wrote
Maya Erez wrote:
On Fri, Nov 11, 2011 at 12:56 PM, Seungwon Jeon tgih@samsung.com
wrote:
Maya Erez wrote:
On Thu, Nov 10, 2011 Maya Erez wrote:
S, Venkatraman svenk...@ti.com wrote:
On Thu, Nov 3, 2011 at 7:23 AM, Seungwon Jeon tgih@samsung.com
wrote:
+static u8
will be
deferred next time.
If request can't be packed, it'd rather be sent at once than delayed
by returning a BLKPREP_DEFER for better responsiveness.
Thanks.
Seungwon Jeon.
The decision whether a request is packable or not should not be made per
request, therefore I don't see the need
Maya Erez wrote:
+ if (reqs = 2) {
+ mmc_blk_packed_hdr_wrq_prep(mq-mqrq_cur, card,
mq, reqs);
+ if (rq_data_dir(rqc) == READ) {
+ areq = mq-mqrq_cur-mmc_active;
+
Sahitya Tummala wrote:
Hi,
On 10/27/2011 4:24 PM, Seungwon Jeon wrote:
+static int mmc_blk_packed_err_check(struct mmc_card *card,
+struct mmc_async_req *areq)
+{
+ struct mmc_queue_req *mq_mrq = container_of(areq, struct mmc_queue_req
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message is
added for checking failure case of cache-on.
Signed-off-by: Seungwon Jeon tgih@samsung.com
While calling mmc_cache_ctrl() a host is not claimed. This patch
adds the mmc_try_claim_host() for quick response in suspend.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/core.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc
Maya Erez wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon tgih@samsung.com
wrote:
@@ -943,7 +950,8 @@ static int mmc_blk_err_check(struct mmc_card
*card,
* kind. If it was a write, we may have transitioned to
* program mode, which we have to wait
Maya Erez wrote:
Maya Erez wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon
tgih@samsung.com
wrote:
@@ -980,12 +988,67 @@ static int mmc_blk_err_check(struct
mmc_card
*card,
if (!brq-data.bytes_xfered)
return MMC_BLK_RETRY
preparing the packed list with the comment from Maya Erez and
Venkatraman.
Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device
drivers/mmc/card/block.c | 454 ++--
drivers/mmc
This patch supports packed command of eMMC4.5 device.
Several reads(or writes) can be grouped in packed command
and all data of the individual commands can be sent in a
single transfer on the bus.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/card/block.c | 454
This patch adds packed command feature of eMMC4.5.
The maximum number for packing read(or write) is offered
and exception event relevant to packed command which is
used for error handling is enabled. If host wants to use
this feature, MMC_CAP2_PACKED_CMD should be set.
Signed-off-by: Seungwon
This patch-set fixed the cache control for eMMC4.5
Changes in v2:
- clear the cache_ctrl flag for a failure(enabling cache)
Seungwon Jeon (2):
mmc: core: Separate the timeout value for cache-ctrl
mmc: core: Add claiming a host during mmc_cache_ctrl
drivers/mmc/core/core.c
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message is
added for checking failure case of cache-on.
Signed-off-by: Seungwon Jeon tgih@samsung.com
While calling mmc_cache_ctrl() a host is not claimed. This patch
adds the mmc_try_claim_host() for quick response in suspend.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/core.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc
to
SDHCI_QUIRK_NONSTANDARD_CLOCK.
mmc: sdhci-s3c: Support controllers with no internal clock
divider(253e0a7c3dc4b)
mmc: sdhci-s3c: Remove usage of clk_type member in platform
data(b77d777eeb0a086)
Thanks,
Seungwon Jeon.
+ sc-cur_clk = ptr;
clk_enable(clk);
@@ -627,63
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 02/29/2012 03:33 PM, Seungwon Jeon wrote:
Hi Jaehoon,
Thank you for the patch.
Could you check comments below?
Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch is change to use the sdhci-pltfm.c
Signed-off-by: Jaehoon Chung
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 03/02/2012 11:15 AM, Seungwon Jeon wrote:
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 02/29/2012 03:33 PM, Seungwon Jeon wrote:
Hi Jaehoon,
Thank you for the patch.
Could you check comments below?
Jaehoon Chung jh80.ch
, this series looks good to me.
But direct access for SMU concerning (4/4, exynos: configure SMU in
exynos5420')
will be removed in driver before long.
I will sort your patches with the pending others.
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
Best Regards.
Jaehoon
|
+ DWMCI_MPSCTRL_NON_SECURE_WRITE_BIT);
Yuvaraj,
Just one thing to check.
ch#0 and #1 of three hosts are only valid for SMU control.
Did you consider #2 host?
It seems not.
Thanks,
Seungwon Jeon
+ }
+
return 0;
}
@@ -107,6 +135,7 @@ static int dw_mci_exynos_resume(struct device *dev
On Thu, August 29, 2013, Alim Akhtar wrote:
Hi Seungwon,
On Thu, Aug 29, 2013 at 1:53 PM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, August 28, 2013, Yuvaraj Kumar C D wrote:
Exynos5420 Mobile Storage Host controller has Security Management Unit
(SMU) for channel 0 and channel 1
Yuvaraj Kumar wrote:
On Thu, Aug 29, 2013 at 3:14 PM, Seungwon Jeon tgih@samsung.com wrote:
On Thu, August 29, 2013, Alim Akhtar wrote:
Hi Seungwon,
On Thu, Aug 29, 2013 at 1:53 PM, Seungwon Jeon tgih@samsung.com
wrote:
On Wed, August 28, 2013, Yuvaraj Kumar C D wrote
code to dw_mci_socfpga_parse_dt.
We can use the dw_mci_socfpga_priv_init to do some actual platform
specific initialisation.
This patch is compile tested only.
CC'ed Dinh Nguyen
Thanks,
Seungwon Jeon
changes since V2: none
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
On Thu, August 29, 2013, Tomasz Figa wrote:
Hi Seungwon,
On Thursday 29 of August 2013 19:36:28 Seungwon Jeon wrote:
Yuvaraj Kumar wrote:
On Thu, Aug 29, 2013 at 3:14 PM, Seungwon Jeon tgih@samsung.com
wrote:
On Thu, August 29, 2013, Alim Akhtar wrote:
Hi Seungwon
On Mon, November 25, 2013, Olof Johansson wrote:
Hi,
On Sun, Nov 24, 2013 at 4:07 AM, randy lxr1...@hotmail.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
After pull the merge of 3.13-rc1, the dw_mmc-exynos will make the boot
stock.In 3.13, it is just stocked udev in 3.13
-name = biu, ciu;
Thanks,
Seungwon Jeon
于 2013年11月26日 12:32, Jaehoon Chung 写道:
Hi, Randy,
It seems a problem that controller didn't find the clock source.
Also you can see the below message. Did you check the clock
source?
[1.125000] s3c-sdhci 1255.sdhci: failed to get io
Clock lookup information is required as driver can manipulate
clock rate properly.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/boot/dts/exynos4412.dtsi |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi
b/arch/arm/boot
before command done is occured, next request can be
sent, but CD of current request is not finished. This can bring about
a broken sequence of request and request-done.
And Data error interrupt(DRTO, DCRC, SBE, EBE) and data transfer
over(DTO) are same reanson.
Signed-off-by: Seungwon Jeon tgih
This patch sets the card_width bit of CTYPE for the corresponding card.
CTYPE[31] and CTYPE[16] correspond respectively to card[15] and card[0]
for 8-bit mode. And CTYPE[15] and CTYPE[0] correspond respectively to
card[15] and CTYPE[0] for 1-bit or 4-bit mode.
Signed-off-by: Seungwon Jeon tgih
Hi,
Kyungmin Park wrote:
On Wed, Jul 13, 2011 at 4:17 PM, Seungwon Jeon tgih@samsung.com
wrote:
This patch add platform devices for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig
This patch add platform devices for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig | 12
arch/arm/mach-exynos4/Makefile|1 +
arch/arm/mach-exynos4/dev-dwmci.c
Hi,
Kyungmin Park wrote:
On Thu, Jul 14, 2011 at 6:53 PM, Seungwon Jeon tgih@samsung.com
wrote:
This patch add platform devices for Synopsys DesignWare Multimedia Card
Interface driver.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/mach-exynos4/Kconfig
Hi
Kyungmin Park wrote:
On Fri, Jul 15, 2011 at 3:58 PM, Seungwon Jeon tgih@samsung.com
wrote:
Hi,
Kyungmin Park wrote:
On Thu, Jul 14, 2011 at 6:53 PM, Seungwon Jeon tgih@samsung.com
wrote:
This patch add platform devices for Synopsys DesignWare Multimedia
Card
1 - 100 of 154 matches
Mail list logo
