Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-21 Thread Stephen Warren
On 08/21/2012 05:25 AM, Linus Walleij wrote: On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Add a new device tree enabled pinctrl and gpiolib driver for Samsung SoC's. ... + The child node can also optionally specify one or more of the pin +

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Stephen Warren
On 08/22/2012 04:17 AM, Chris Ball wrote: Hi, On Wed, Aug 22 2012, Shawn Guo wrote: The following is what I have on my mind. broken-cdcd-gpiosimplication --- no no SDHCI CD no yes GPIO CD

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-23 Thread Stephen Warren
. Irrespective of whether you choose to keep the binding as-is, or change it, please consider it: Acked-by: Stephen Warren swar...@wwwdotorg.org + The values specified by these config properties should be dervied from the s/dervied/derived/ +External GPIO and Wakeup Interrupts

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-06 Thread Stephen Warren
...@linaro.org Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Stephen Warren
On 09/06/2012 05:06 AM, Thomas Abraham wrote: On 6 September 2012 15:04, Tomasz Figa t.f...@samsung.com wrote: Hi, This patch shows the problem of the need to explicitly migrate all drivers to pinctrl. Maybe we should consider extending the pinctrl subsystem to set the default state

Re: [PATCH 2/2] ARM: dts: exynos4: allow i2c0 bus to be configured using pinctrl interface

2012-09-10 Thread Stephen Warren
On 09/06/2012 05:14 AM, Thomas Abraham wrote: On 6 September 2012 15:43, Tomasz Figa t.f...@samsung.com wrote: Hi Thomas, On Thursday 06 of September 2012 14:53:01 Thomas Abraham wrote: compatible = samsung,s3c2440-i2c; reg = 0x1386 0x100;

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-20 Thread Stephen Warren
On 09/21/2012 05:22 AM, Leela Krishna Amudala wrote: This patch adds device tree based discovery support for exynos DRM-FIMD driver which includes driver modification to handle platform data in both the cases with DT and non-DT, Also adds the documentation for bindings. diff --git

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-21 Thread Stephen Warren
On 09/21/2012 01:22 AM, Inki Dae wrote: 2012/9/21 Stephen Warren swar...@wwwdotorg.org: On 09/21/2012 05:22 AM, Leela Krishna Amudala wrote: This patch adds device tree based discovery support for exynos DRM-FIMD driver which includes driver modification to handle platform data in both

Re: [RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-21 Thread Stephen Warren
On 09/20/2012 02:53 AM, Tomasz Figa wrote: This RFC series is a work on replacing static platform-specific data in pinctrl-samsung driver with data dynamically parsed from device tree. Hmm. I tend to think this is exactly the opposite of the correct direction; you end up wasting a whole ton of

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-21 Thread Stephen Warren
On 09/20/2012 02:53 AM, Tomasz Figa wrote: The patch pinctrl: samsung: Parse pin banks from DT introduced platform-specific data parsing from DT. This patch adds all necessary nodes and properties to exynos4210 device tree sources. +++ b/arch/arm/boot/dts/exynos4210-pinctrl-banks.dtsi +/

Re: [RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-24 Thread Stephen Warren
On 09/21/2012 01:31 PM, Tomasz Figa wrote: On Friday 21 of September 2012 12:40:35 Stephen Warren wrote: On 09/20/2012 02:53 AM, Tomasz Figa wrote: This RFC series is a work on replacing static platform-specific data in pinctrl-samsung driver with data dynamically parsed from device tree

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-24 Thread Stephen Warren
On 09/21/2012 01:54 PM, Tomasz Figa wrote: On Friday 21 of September 2012 12:56:41 Stephen Warren wrote: On 09/20/2012 02:53 AM, Tomasz Figa wrote: The patch pinctrl: samsung: Parse pin banks from DT introduced platform-specific data parsing from DT. This patch adds all necessary nodes

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 03:37 AM, Tomasz Figa wrote: Hi Stephen, On Monday 24 of September 2012 17:14:38 Stephen Warren wrote: On 09/24/2012 03:31 PM, Tomasz Figa wrote: On Monday 24 of September 2012 11:42:15 Stephen Warren wrote: On 09/21/2012 01:54 PM, Tomasz Figa wrote: On Friday 21 of September

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 11:41 AM, Tomasz Figa wrote: On Tuesday 25 of September 2012 10:49:11 Stephen Warren wrote: On 09/25/2012 03:37 AM, Tomasz Figa wrote: Hi Stephen, On Monday 24 of September 2012 17:14:38 Stephen Warren wrote: On 09/24/2012 03:31 PM, Tomasz Figa wrote: On Monday 24 of September

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 12:35 PM, Tomasz Figa wrote: On Tuesday 25 of September 2012 12:22:03 Stephen Warren wrote: ... BTW, how does the driver know what register addresses to use; I can see the base for each pin controller bank is in samsung,pctl-offset, but what describes the offset for each

Re: [PATCH V2] ASoC: SAMSUNG: Add DT support for i2s

2012-09-27 Thread Stephen Warren
On 09/27/2012 04:25 AM, Padmavathi Venna wrote: Add support for device based discovery. +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt +i2s@0383 { + compatible = samsung,samsung-i2s; + reg = 0x0383 0x100; + tx-dma-channel-secondary = pdma0 8; +

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-10-01 Thread Stephen Warren
On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote: Hello Stephen Warren, The binding names that I use in my dts file should match with the names given in http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html right? I don't think so; the binding in that link

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-10-03 Thread Stephen Warren
On 10/02/2012 10:06 PM, Leela Krishna Amudala wrote: On Mon, Oct 1, 2012 at 9:50 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote: Hello Stephen Warren, The binding names that I use in my dts file should match with the names given in http

Re: [PATCH 01/16] ARM: dts: exynos4210: Replace legacy GPIO bank nodes with pinctrl bank nodes

2012-10-10 Thread Stephen Warren
On 10/10/2012 01:26 AM, Linus Walleij wrote: On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa t.f...@samsung.com wrote: Seuqential patches from this series introduce SoC-specific data parsing from device tree. This patch removes legacy GPIO bank nodes from exynos4210.dtsi and replaces them

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-14 Thread Stephen Warren
On 12/13/2012 10:50 PM, Naveen Krishna Chatradhi wrote: The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus. diff --git a/Documentation/devicetree/bindings/i2c/arbitrator-i2c.txt

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Stephen Warren
On 01/17/2013 01:34 AM, Linus Walleij wrote: On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Fix the incorrect compatible property value of pin-controller module EXYNOS5440 SoC. (...) pinctrl { -

Re: [PATCH v4 4/7] ARM: Exynos: allow dt based discovery of mct controller using clocksource_of_init

2013-01-28 Thread Stephen Warren
On 01/21/2013 03:02 AM, Thomas Abraham wrote: Add entries to __clksrc_of_table so that Exynos MCT controller is discoverable using call to clocksource_of_init. With this change, it would be appropriate to rename the function 'exynos4_timer_init' as 'mct_init' since it aptly describes this

Re: [PATCH v4 3/7] ARM: Exynos: add device tree support for MCT controller driver

2013-01-28 Thread Stephen Warren
in this series, fairly quickly, Reviewed-by: Stephen Warren swar...@nvidia.com Sorry for the slow review. I'm not 100% sure if I like Mark's #global-interrupts suggestion or not, but I'd be fine with the binding either way, so choose as you see fit. -- To unsubscribe from this list: send the line

Re: [PATCH v4 4/7] ARM: Exynos: allow dt based discovery of mct controller using clocksource_of_init

2013-01-30 Thread Stephen Warren
On 01/28/2013 01:57 PM, Stephen Warren wrote: On 01/21/2013 03:02 AM, Thomas Abraham wrote: Add entries to __clksrc_of_table so that Exynos MCT controller is discoverable using call to clocksource_of_init. With this change, it would be appropriate to rename the function 'exynos4_timer_init

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
n 02/05/2013 04:42 PM, Sean Paul wrote: Use the compatible string in the device tree to determine which registers/functions to use in the HDMI driver. Also changes the references from v13 to 4210 and v14 to 4212 to reflect the IP block version instead of the HDMI version. diff --git

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
On 02/05/2013 05:37 PM, Sean Paul wrote: On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren swar...@wwwdotorg.org wrote: n 02/05/2013 04:42 PM, Sean Paul wrote: Use the compatible string in the device tree to determine which registers/functions to use in the HDMI driver. Also changes

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
On 02/05/2013 05:56 PM, Sean Paul wrote: On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 02/05/2013 05:37 PM, Sean Paul wrote: On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren swar...@wwwdotorg.org wrote: n 02/05/2013 04:42 PM, Sean Paul wrote: Use

Re: [PATCH v4 01/10] s5p-csis: Add device tree support

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and for parsing all SoC and board specific properties. diff --git

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: This patch adds support for FIMC devices instantiated from devicetree for S5PV210 and Exynos4 SoCs. The FIMC IP features include colorspace conversion and scaling (mem-to-mem) and parallel/MIPI CSI2 bus video capture interface. Multiple SoC

Re: [PATCH v4 05/10] s5p-fimc: Add device tree based sensors registration

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: The sensor (I2C and/or SPI client) devices are instantiated by their corresponding control bus drivers. Since the I2C client's master clock is often provided by a video bus receiver (host interface) or other than I2C/SPI controller device, the

Re: [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: Before the camera ports can be used the pinmux needs to be configured properly. This patch adds a function to set the camera ports pinctrl to a default state within the media driver's probe(). The camera port(s) are then configured for the

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-08 Thread Stephen Warren
On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt +Samsung S5P/EXYNOS SoC Camera Subsystem (FIMC

Re: [PATCH v4 01/10] s5p-csis: Add device tree support

2013-02-08 Thread Stephen Warren
On 02/08/2013 03:29 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:36 AM, Stephen Warren wrote: On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-08 Thread Stephen Warren
On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote: On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-11 Thread Stephen Warren
On 02/09/2013 03:29 PM, Sylwester Nawrocki wrote: On 02/09/2013 01:32 AM, Stephen Warren wrote: On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote: On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-13 Thread Stephen Warren
On 02/12/2013 03:39 PM, Sylwester Nawrocki wrote: On 02/11/2013 10:50 PM, Stephen Warren wrote: On 02/09/2013 03:29 PM, Sylwester Nawrocki wrote: On 02/09/2013 01:32 AM, Stephen Warren wrote: On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote

Re: State of pinctrl and exynos5250?

2013-03-07 Thread Stephen Warren
On 03/07/2013 09:27 AM, Doug Anderson wrote: +the proper address for Will. Sorry... On Thu, Mar 7, 2013 at 8:13 AM, Doug Anderson diand...@chromium.org mailto:diand...@chromium.org wrote: Linus, +dw_mmc folks and Stephen Warren : for context here, we are discussing

Re: [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name

2013-03-18 Thread Stephen Warren
On 03/18/2013 09:50 AM, Rob Herring wrote: On 03/13/2013 05:42 PM, Sylwester Nawrocki wrote: Rob, On 03/13/2013 03:39 PM, Rob Herring wrote: I fail to see what the hack is. The order of interrupt properties must be defined by the binding. interrupt-names is auxiliary data and must not be

Re: [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name

2013-03-18 Thread Stephen Warren
On 03/18/2013 04:27 PM, Rob Herring wrote: On 03/18/2013 01:11 PM, Stephen Warren wrote: On 03/18/2013 09:50 AM, Rob Herring wrote: On 03/13/2013 05:42 PM, Sylwester Nawrocki wrote: Rob, On 03/13/2013 03:39 PM, Rob Herring wrote: I fail to see what the hack is. The order of interrupt

Re: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight

2013-03-19 Thread Stephen Warren
On 03/19/2013 03:27 PM, Marek Vasut wrote: Dear Andrew Chew, The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. Signed-off-by: Andrew Chew ac...@nvidia.com Do we really need a mandatory

Re: [PATCH V4 9/9] pwm_bl: Add mandatory backlight enable regulator

2013-03-20 Thread Stephen Warren
On 03/19/2013 12:59 PM, Andrew Chew wrote: Many backlights need to be explicitly enabled. Typically, this is done with a GPIO. For flexibility, we generalize the enable mechanism to a regulator. If an enable regulator is not needed, then a dummy regulator can be given to the backlight

Re: [PATCH V4 8/9] ARM: tegra: Provide regulator to pwm-backlight

2013-03-21 Thread Stephen Warren
On 03/19/2013 12:59 PM, Andrew Chew wrote: The pwm-backlight driver now takes a mandatory regulator that is gotten during driver probe. Initialize a dummy regulator to satisfy this requirement. I assume these patches will get merged through the PWM tree? If so, Acked-by: Stephen Warren swar

Re: GENERIC_GPIO considered deprecated

2013-04-08 Thread Stephen Warren
On 04/08/2013 01:31 AM, Kukjin Kim wrote: Alexandre Courbot wrote: On Wed, Apr 3, 2013 at 5:35 PM, Kukjin Kim kgene@samsung.com wrote: could you amend the patches that adds them such as they get changed into select ARCH_REQUIRE_GPIOLIB instead? You can grep for select I can do it for my

Re: [RFC 23/42] drivers/spi: don't check resource with devm_ioremap_resource

2013-05-10 Thread Stephen Warren
On 05/10/2013 02:17 AM, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) {

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-28 Thread Stephen Warren
On 04/28/2014 05:18 AM, Thierry Reding wrote: On Mon, Apr 28, 2014 at 12:56:03PM +0200, Arnd Bergmann wrote: ... A lot of drivers probably only support one master, so they can just set #iommu-cells=0, others might require IDs that do not fit into one cell. You mean #iommu-cells = 1 for

Re: [PATCH v3 1/3] base: power: Add generic OF-based power domain look-up

2014-04-28 Thread Stephen Warren
On 04/23/2014 10:46 AM, Tomasz Figa wrote: This patch introduces generic code to perform power domain look-up using device tree and automatically bind devices to their power domains. Generic device tree binding is introduced to specify power domains of devices in their device tree nodes.

Re: [PATCH 00/16] Another 16 L2C patches

2014-04-28 Thread Stephen Warren
On 04/28/2014 11:12 AM, Stephen Warren wrote: On 04/28/2014 10:56 AM, Russell King - ARM Linux wrote: So, in response to Matt Porter's complaint about breaking prima2, here's another 16 patches which changes the way the L2 cache is initialised on many platforms. This series moves towards

Re: [PATCH 51/97] ARM: l2c: remove platforms/SoCs setting early BRESP

2014-04-28 Thread Stephen Warren
. Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 49/97] ARM: l2c: fix register naming

2014-04-28 Thread Stephen Warren
control register definitions. Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 51/97] ARM: l2c: remove platforms/SoCs setting early BRESP

2014-04-29 Thread Stephen Warren
On 04/28/2014 06:02 PM, Simon Horman wrote: On Mon, Apr 28, 2014 at 08:30:32PM +0100, Russell King wrote: Since we now automatically enable early BRESP in core L2C-310 code when we detect a Cortex-A9, we don't need platforms/SoCs to set this bit explicitly. Instead, they should seek to

Re: [PATCH v3 6/7] i2c: ChromeOS EC tunnel driver

2014-05-01 Thread Stephen Warren
a special driver, but I haven't researched that enough). The binding looks reasonable to me, so that part, Acked-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-05-01 Thread Stephen Warren
On 04/30/2014 11:44 AM, Doug Anderson wrote: This adds the EC i2c tunnel (and devices under it) to the tegra124-venice2 device tree. I'll happily take this into the Tegra tree once the patch containing the binding it uses is applied. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap

2014-05-12 Thread Stephen Warren
On 05/10/2014 06:00 AM, Vivek Gautam wrote: Using devm_ioremap_resource() API should actually be preferred over devm_ioremap(), since the former request the mem region first and then gives back the ioremap'ed memory pointer. devm_ioremap_resource() calls request_mem_region(), therby preventing

Re: [PATCH 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-05-15 Thread Stephen Warren
On 04/17/2014 11:59 AM, Doug Anderson wrote: This adds the EC i2c tunnel (and devices under it) to the tegra124-venice2 device tree. Did the MFD patches at the start of this series get applied yet? I was hoping to apply this one patch to the Tegra tree for 3.16, and that needs to happen by

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-29 Thread Stephen Warren
On 05/23/2014 02:36 PM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough to cover the requirements of both the Exynos System MMU and Tegra SMMU

[PATCH] ASoC: free jack GPIOs before the sound card is freed

2014-05-30 Thread Stephen Warren
From: Stephen Warren swar...@nvidia.com This is the same change as commit fb6b8e71448a ASoC: tegra: free jack GPIOs before the sound card is freed, but applied to all other ASoC machine drivers where code inspection indicates the same problem exists. That commit's description

Re: [PATCH v3 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-06-16 Thread Stephen Warren
On 04/30/2014 11:44 AM, Doug Anderson wrote: This adds the EC i2c tunnel (and devices under it) to the tegra124-venice2 device tree. I've applied this to Tegra's for-3.17/dt branch. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to

Re: [PATCH v3 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources

2014-06-17 Thread Stephen Warren
On 06/17/2014 02:53 AM, Paul Bolle wrote: Doug, On Fri, 2014-06-13 at 08:22 -0700, Doug Anderson wrote: On Fri, Jun 13, 2014 at 1:08 AM, Paul Bolle pebo...@tiscali.nl wrote: On Wed, 2014-06-11 at 08:11 -0700, Doug Anderson wrote: This is a config option on the ChromeOS EC

RE: [PATCH 2/3] mmc: Add OF bindings support for mmc host controller capabilities

2011-10-11 Thread Stephen Warren
Thomas Abraham wrote at Sunday, October 09, 2011 12:58 AM: On 5 October 2011 21:25, Stephen Warren swar...@nvidia.com wrote: Thomas Abraham wrote at Wednesday, October 05, 2011 8:28 AM: On 5 October 2011 18:59, Rob Herring robherri...@gmail.com wrote: On 10/05/2011 05:13 AM, Thomas Abraham

RE: [PATCH] ARM: SAMSUNG: Save/restore GPIO drive strength across suspend/resume

2011-11-14 Thread Stephen Warren
Thomas Abraham wrote at Monday, November 14, 2011 6:57 AM: On 12 November 2011 16:30, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Nov 12, 2011 at 6:01 AM, Inderpal Singh inderpal.si...@linaro.org wrote: GPIO driver strength settings are not preserved across suspend/resume for

RE: [PATCH] ARM: SAMSUNG: Save/restore GPIO drive strength across suspend/resume

2011-11-15 Thread Stephen Warren
Thomas Abraham wrote at Monday, November 14, 2011 12:37 PM: ... I am not sure how this works, but with dynamic transitioning, will it be possible to program the pinmux registers dynamically when a driver/controller decides to idle for sometime and come back up again (not a system wide

RE: [RFC 1/3] pinctrl: add a driver for the OMAP pinmux

2011-11-22 Thread Stephen Warren
Tony Lindgren wrote at Tuesday, November 22, 2011 10:54 AM: * Linus Walleij linus.wall...@linaro.org [22 03:30]: On Tue, Nov 22, 2011 at 12:09 PM, Thomas Abraham thomas.abra...@linaro.org wrote: On 17 November 2011 19:27, Linus Walleij linus.wall...@linaro.org wrote: Maybe I'm

RE: [PATCH] ARM: move CP15 definitions to separate header file

2012-01-20 Thread Stephen Warren
Russell King wrote at Friday, January 20, 2012 3:04 AM: Avoid namespace conflicts with drivers over the CP15 definitions by moving CP15 related prototypes and definitions to a private header file. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk For Tegra, Acked-by: Stephen Warren

Re: [PATCH 1/5] pinctrl: add samsung pinctrl and gpiolib driver

2012-03-19 Thread Stephen Warren
On 03/11/2012 06:46 AM, Thomas Abraham wrote: Add a new pinctrl and gpiolib driver for Samsung SoC's. This driver provides a common framework for all Samsung SoC's to interface with the pinctrl and gpiolib subsystems. This driver is split into two parts: the pinctrl interface and the gpiolib

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-19 Thread Stephen Warren
On 03/11/2012 06:46 AM, Thomas Abraham wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. @@ -643,8 +649,13 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-03-30 Thread Stephen Warren
On 03/30/2012 05:36 AM, Arnd Bergmann wrote: On Friday 30 March 2012, Viresh Kumar wrote: On 3/27/2012 9:49 PM, Arnd Bergmann wrote: These bindings came up in a discussion IRC today. I think it's rather bad that we can't agree on a common way to name the properties for mmc. We have bindings

Re: [PATCH 3/3] ARM: dts: Disable I2C controllers by default on Exynos5250

2013-09-12 Thread Stephen Warren
On 09/12/2013 06:58 AM, Tomasz Figa wrote: Hi Mark, On Thursday 12 of September 2013 11:40:27 Mark Brown wrote: From: Mark Brown broo...@linaro.org Ensure that unused I2C controllers are not activated, causing problems due to inappropriate pinmuxing or similar, by marking the controllers

Re: [PATCH v8 12/12] V4L: Add driver for s5k4e5 image sensor

2013-09-13 Thread Stephen Warren
On 09/13/2013 06:55 AM, Philipp Zabel wrote: Hi Arun, Am Donnerstag, den 12.09.2013, 17:37 +0530 schrieb Arun Kumar K: This patch adds subdev driver for Samsung S5K4E5 raw image sensor. Like s5k6a3, it is also another fimc-is firmware controlled sensor. This minimal sensor driver doesn't do

Re: [PATCH 00/26] ARM: provide common arch init for DT clocks

2013-09-18 Thread Stephen Warren
On 09/18/2013 01:52 PM, Sebastian Hesselbarth wrote: On 09/18/2013 09:47 PM, Jason Cooper wrote: On Wed, Sep 18, 2013 at 07:53:33PM +0200, Sebastian Hesselbarth wrote: ... Sebastian Hesselbarth (26): ARM: nomadik: move mtu setup to clocksource init ... How would you like to handle this

Re: [PATCH 01/10] pwm-backlight: Refactor backlight power on/off

2013-10-01 Thread Stephen Warren
On 09/23/2013 03:40 PM, Thierry Reding wrote: In preparation for adding an optional regulator and enable GPIO to the driver, split the power on and power off sequences into separate functions to reduce code duplication at the multiple call sites. diff --git a/drivers/video/backlight/pwm_bl.c

Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field

2013-10-01 Thread Stephen Warren
On 09/23/2013 03:41 PM, Thierry Reding wrote: The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. static void __init smdkv210_map_io(void) @@ -70,6 +70,7 @@ static struct samsung_bl_drvdata samsung_dfl_bl_data __initdata = {

Re: [PATCH 08/10] pwm-backlight: Use new enable_gpio field

2013-10-01 Thread Stephen Warren
On 09/23/2013 03:41 PM, Thierry Reding wrote: Make use of the new enable_gpio field and allow it to be set from DT as well. Now that all legacy users of platform data have been converted to initialize this field to an invalid value, it is safe to use the field from the driver. diff --git

Re: [PATCH 09/10] pwm-backlight: Use an optional power supply

2013-10-01 Thread Stephen Warren
On 09/23/2013 03:41 PM, Thierry Reding wrote: Many backlights require a power supply to work properly. This commit uses a power-supply regulator, if available, to power up and power down the panel. I think that all backlights require a power supply, albeit the supply may not be

Re: [PATCH 10/10] pwm-backlight: Allow backlight to remain disabled on boot

2013-10-01 Thread Stephen Warren
On 09/23/2013 03:41 PM, Thierry Reding wrote: The default for backlight devices is to be enabled immediately when registering with the backlight core. This can be useful for setups that use a simple framebuffer device and where the backlight cannot otherwise be hooked up to the panel.

Re: [PATCH 05/10] ARM: SAMSUNG: Initialize PWM backlight enable_gpio field

2013-10-01 Thread Stephen Warren
On 10/01/2013 02:43 PM, Thierry Reding wrote: On Tue, Oct 01, 2013 at 12:31:04PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: The GPIO API defines 0 as being a valid GPIO number, so this field needs to be initialized explicitly. static void __init

Re: [PATCH 09/10] pwm-backlight: Use an optional power supply

2013-10-01 Thread Stephen Warren
On 10/01/2013 02:53 PM, Thierry Reding wrote: On Tue, Oct 01, 2013 at 12:43:57PM -0600, Stephen Warren wrote: On 09/23/2013 03:41 PM, Thierry Reding wrote: Many backlights require a power supply to work properly. This commit uses a power-supply regulator, if available, to power up and power

Re: [PATCH 2/6] clk: exynos5410: register clocks using common clock framework

2013-10-01 Thread Stephen Warren
On 10/01/2013 10:17 AM, Vyacheslav Tyrtov wrote: From: Tarek Dakhran t.dakh...@samsung.com The EXYNOS5410 clocks are statically listed and registered using the Samsung specific common clock helper functions. diff --git a/Documentation/devicetree/bindings/clock/exynos5410-clock.txt

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/17/2013 08:59 AM, Catalin Marinas wrote: On 17 November 2013 08:49, Alexandre Courbot acour...@nvidia.com wrote: The ARM tree includes a firmware_ops interface that is designed to implement support for simple, TrustZone-based firmwares but could also cover other use-cases. It has been

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/18/2013 04:58 AM, Catalin Marinas wrote: ... Of course, trusted foundations interface could be plugged into cpu_ops on arm64 but I will NAK it on the grounds of not using the PSCI API, nor the SMC calling convention (and it's easy to fix when porting to ARMv8). If a supported standard

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/18/2013 10:10 AM, Russell King - ARM Linux wrote: On Mon, Nov 18, 2013 at 10:03:37AM -0700, Stephen Warren wrote: On 11/18/2013 04:58 AM, Catalin Marinas wrote: ... Of course, trusted foundations interface could be plugged into cpu_ops on arm64 but I will NAK it on the grounds

Re: [PATCH] ARM: move firmware_ops to drivers/firmware

2013-11-18 Thread Stephen Warren
On 11/18/2013 10:30 AM, Catalin Marinas wrote: On Mon, Nov 18, 2013 at 05:03:37PM +, Stephen Warren wrote: On 11/18/2013 04:58 AM, Catalin Marinas wrote: ... Of course, trusted foundations interface could be plugged into cpu_ops on arm64 but I will NAK it on the grounds of not using

Re: [PATCH] pinctrl: samsung: Allow pin value to be initialized using pinfunc.

2013-11-19 Thread Stephen Warren
On 11/19/2013 10:15 AM, Tomasz Figa wrote: This patch extends the range of settings configurable via pinfunc API to cover pin value as well. This allows configuration of default values of pins. Shouldn't there be a driver that acquires the GPIO that's output to the pin, and configures the

Re: [PATCH] pinctrl: samsung: Allow grouping multiple pinmux/pinconf nodes

2013-11-19 Thread Stephen Warren
a little briefly, Reviewed-by: Stephen Warren swar...@nvidia.com Just a minor comment below, diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c +static int samsung_pinctrl_create_function(struct device *dev, + struct

Re: [PATCH] pinctrl: samsung: Allow pin value to be initialized using pinfunc.

2013-11-19 Thread Stephen Warren
On 11/19/2013 11:59 AM, Doug Anderson wrote: On Tue, Nov 19, 2013 at 10:46 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/19/2013 10:15 AM, Tomasz Figa wrote: This patch extends the range of settings configurable via pinfunc API to cover pin value as well. This allows configuration

Re: [PATCH] pinctrl: samsung: Allow pin value to be initialized using pinfunc.

2013-11-19 Thread Stephen Warren
On 11/19/2013 05:02 PM, Kyungmin Park wrote: On Wed, Nov 20, 2013 at 4:16 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/19/2013 11:59 AM, Doug Anderson wrote: On Tue, Nov 19, 2013 at 10:46 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/19/2013 10:15 AM, Tomasz Figa wrote

Re: [PATCH] pinctrl: samsung: Allow pin value to be initialized using pinfunc.

2013-12-05 Thread Stephen Warren
On 12/03/2013 02:29 AM, Linus Walleij wrote: ... So I guess what you're after is a kind of hog that will be pushed aside and ignored if a struct device with an associated state appears that will use the same pin? That probably would be useful. Perhaps we should just make all hogs not

Re: [PATCH V2] regulator: fixed: update to devm_* API

2014-01-28 Thread Stephen Warren
On 01/27/2014 08:12 PM, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. I'm not sure why this patch is sent to linux-te...@vger.kernel.org; it seems nothing to do with Tegra (or Samsung or OMAP for that matter). -- To unsubscribe from this

Re: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-11 Thread Stephen Warren
On 02/04/2014 02:45 PM, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com This means that the driver can be in host or peripheral mode when the appropriate connector is used. When an A-cable is plugged in, the driver behaves in host mode, and when a B-cable is used, the

Re: [PATCH 1/7] ARM: dts: tegra: add PCIe interrupt mapping properties

2014-02-28 Thread Stephen Warren
On 02/28/2014 10:28 AM, Lucas Stach wrote: Those are defined by the common PCI binding. I have no reason to object to the two Tegra patches, but I'll wait for Thierry to take a closer look. I expect once he does, I would apply patch 1/7 through the Tegra tree, and Bjorn would take patch 2/7

Re: [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties

2014-03-05 Thread Stephen Warren
On 03/05/2014 06:25 AM, Lucas Stach wrote: Those are defined by the common PCI binding. It sounds like there's no dependency between pathces 1/6 and 2/6, so I should apply 1/6 to the Tegra tree, and Bjorn apply 2/6 to the PCI tree? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible

2014-03-06 Thread Stephen Warren
On 03/05/2014 06:25 AM, Lucas Stach wrote: This is the recommended method of doing the IRQ mapping. For old devicetrees we fall back to the previous practice. Tested-by: Stephen Warren swar...@nvidia.com I tested both with and without patch 1/6, and the PCIe-based NIC on Beaver worked fine

Re: [PATCH v2 1/6] ARM: dts: tegra: add PCIe interrupt mapping properties

2014-03-06 Thread Stephen Warren
On 03/05/2014 06:25 AM, Lucas Stach wrote: Those are defined by the common PCI binding. I've applied this to Tegra's for-3.15/dt branch. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

2014-03-13 Thread Stephen Warren
On 03/13/2014 11:40 AM, Tim Harvey wrote: When using interrupt-maps, the size of a map entry is #address-cells + #interrupt-cells for the parent interrupt controller. For the ARM GIC address-cells should be 0 as this is not used. This patch fixes the example by correctly specifying

Re: [RESEND PATCH 6/7] i2c: ChromeOS EC tunnel driver

2014-04-21 Thread Stephen Warren
On 04/17/2014 12:36 PM, Doug Anderson wrote: On ARM Chromebooks we have a few devices that are accessed by both the AP (the main Application Processor) and the EC (the Embedded Controller). These are: * The battery (sbs-battery). * The power management unit tps65090. ... On the Samsung ARM

Re: [PATCH 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-04-21 Thread Stephen Warren
On 04/17/2014 11:59 AM, Doug Anderson wrote: This adds the EC i2c tunnel (and devices under it) to the tegra124-venice2 device tree. The series, Tested-by: Stephen Warren swar...@nvidia.com I can apply this one patch once the other patches in the series are acked or applied (in order to make

Re: [PATCH 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-04-21 Thread Stephen Warren
On 04/21/2014 01:35 PM, Doug Anderson wrote: Stephen, On Mon, Apr 21, 2014 at 11:18 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 04/17/2014 11:59 AM, Doug Anderson wrote: This adds the EC i2c tunnel (and devices under it) to the tegra124-venice2 device tree. diff --git a/arch/arm

Re: [PATCH v2 0/7] Add cros_ec changes for newer boards

2014-04-23 Thread Stephen Warren
On 04/23/2014 06:32 AM, Lee Jones wrote: On Tue, 22 Apr 2014, Doug Anderson wrote: This series adds the most critical cros_ec changes for newer boards using cros_ec. Specifically: * Fixes timing/locking issues with the previously upstreamed (but never used upstream) cros_ec_spi driver.

Re: [PATCH] ARM: dts: Add mask-tpm-reset to the device tree

2014-06-27 Thread Stephen Warren
On 06/27/2014 06:17 AM, Tomasz Figa wrote: Hi Doug, On 26.06.2014 17:25, Doug Anderson wrote: Tomasz, On Thu, Jun 26, 2014 at 2:52 AM, Tomasz Figa t.f...@samsung.com wrote: Hi Vikas, Doug, On 26.06.2014 11:15, Vikas Sajjan wrote: From: Doug Anderson diand...@chromium.org The

Re: [PATCH] ARM: dts: Add mask-tpm-reset to the device tree

2014-06-27 Thread Stephen Warren
On 06/27/2014 10:45 AM, Doug Anderson wrote: Stephen, On Fri, Jun 27, 2014 at 9:10 AM, Stephen Warren swar...@wwwdotorg.org wrote: Surely there's a driver (or could be a driver) for the TPM chip, and that driver should have a reset-mask-gpios property, so the driver can call gpio_get

Re: [PATCH] ARM: dts: Add mask-tpm-reset to the device tree

2014-06-27 Thread Stephen Warren
On 06/27/2014 12:30 PM, Doug Anderson wrote: Stephen, On Fri, Jun 27, 2014 at 11:20 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 06/27/2014 10:45 AM, Doug Anderson wrote: Stephen, On Fri, Jun 27, 2014 at 9:10 AM, Stephen Warren swar...@wwwdotorg.org wrote: Surely there's

  1   2   >