Re: [PATCH v3 2/6] thermal: Add generic cpufreq cooling implementation

2012-05-09 Thread Amit Kachhap
On 9 May 2012 01:46, Andrew Morton a...@linux-foundation.org wrote: On Tue,  8 May 2012 21:48:14 +0530 Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patch adds support for generic cpu thermal cooling low level implementations using frequency scaling up/down based on the registration

Re: [PATCH v3 5/6] thermal: exynos: Register the tmu sensor with the kernel thermal layer

2012-05-09 Thread Amit Kachhap
On 9 May 2012 01:46, Andrew Morton a...@linux-foundation.org wrote: On Tue,  8 May 2012 21:48:17 +0530 Amit Daniel Kachhap amit.kach...@linaro.org wrote: This code added creates a link between temperature sensors, linux thermal framework and cooling devices for samsung exynos platform. This

Re: [PATCH v3 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-05-09 Thread Amit Kachhap
On 9 May 2012 01:36, Zhang, Rui rui.zh...@intel.com wrote: Hi, Amit, Sorry for the late response as I'm in a travel recently. I think the generic cpufreq cooling patches are good. But about the THERMAL_TRIP_STATE_INSTANCE patch, what I'd like to see is that 1. from thermal zone point of

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-09 Thread amit kachhap
Hi Rob/Eduardo, As these patches have still not made into mainline. I will rebase the whole set along with your suggestion and send them shortly. Sorry for late reply. Thanks, Amit Daniel On Tue, Jun 26, 2012 at 1:12 PM, Valentin, Eduardo eduardo.valen...@ti.com wrote: Hey Rob and Amit, On

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-11 Thread amit kachhap
On Tue, Jul 10, 2012 at 12:31 PM, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 12 May 2012 17:40, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patch adds support for generic cpu thermal cooling low level implementations using frequency scaling up/down based on the registration

Re: [linux-pm] [RESEND PATCH v4 1/5] thermal: add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Thu, Jul 12, 2012 at 8:40 PM, Valentin, Eduardo eduardo.valen...@ti.com wrote: Amit, On Thu, Jul 12, 2012 at 4:41 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patchset introduces a new generic cooling device based on cpufreq that can be used on non-ACPI platforms. As a

Re: [linux-pm] [RESEND PATCH v4 1/5] thermal: add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Fri, Jul 13, 2012 at 4:34 AM, Andrew Morton a...@linux-foundation.org wrote: On Thu, 12 Jul 2012 19:11:04 +0530 Amit Daniel Kachhap amit.kach...@linaro.org wrote: [a...@linux-foundation.org: fix comment layout] Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org Cc: Donggeun Kim

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Fri, Jul 13, 2012 at 3:39 PM, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 12 May 2012 17:40, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patch adds support for generic cpu thermal cooling low level implementations using frequency scaling up/down based on the registration

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

2012-07-14 Thread amit kachhap
On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim kgene@samsung.com wrote: Amit Daniel Kachhap wrote: These TMU enablement patches are needed for exynos4 and exynos5 TMU driver patches sent earlier. The link for those are http://www.spinics.net/lists/lm-sensors/msg35858.html. How was going on

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

2012-07-14 Thread amit kachhap
On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck li...@roeck-us.net wrote: On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote: Amit Daniel Kachhap wrote: These TMU enablement patches are needed for exynos4 and exynos5 TMU driver patches sent earlier. The link for those are

Re: [linux-pm] [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-16 Thread Amit Kachhap
On 16 August 2012 20:22, Valentin, Eduardo eduardo.valen...@ti.com wrote: Amit, Thanks again for keeping this up. On Thu, Aug 16, 2012 at 2:41 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patchset introduces a new generic cooling device based on cpufreq that can be used

Re: [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-17 Thread Amit Kachhap
On 17 August 2012 12:54, Zhang Rui rui.zh...@intel.com wrote: On 四, 2012-08-16 at 17:11 +0530, Amit Daniel Kachhap wrote: This patchset introduces a new generic cooling device based on cpufreq that can be used on non-ACPI platforms. As a proof of concept, we have drivers for the following

Re: [RESEND PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-17 Thread Amit Kachhap
This is repost containing the changes suggested by Zhang Rui. Now the cpufreq current state will be calculated each time instead of earlier way of returning the cached value. Thanks, Amit Daniel On 17 August 2012 18:59, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patchset introduces

Re: [linux-pm] [PATCH RESEND] thermal: add generic cpufreq cooling implementation

2012-09-11 Thread amit kachhap
On Mon, Sep 10, 2012 at 3:25 PM, Zhang Rui rui.zh...@intel.com wrote: Refreshed to remove the notifier mechanism as we do not have a real user of it. if there is no problem, I'll apply the whole patch set to thermal next tree. The removal of notification API looks fine. Thanks for refreshing

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-07 Thread Amit Kachhap
On 8 November 2012 11:31, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly jump to the upper or

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread Amit Kachhap
On 9 November 2012 09:21, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-08 at 11:56 +0530, Amit Kachhap wrote: On 8 November 2012 11:31, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: This modification adds 2 new thermal trend type

Re: [PATCH-Resend] thermal: Exynos: Add missing dependency

2012-11-14 Thread Amit Kachhap
On 15 November 2012 12:09, Sachin Kamat sachin.ka...@linaro.org wrote: CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking for dependencies gives the following compilation warnings: warning: (ARCH_TEGRA_2x_SOC ARCH_TEGRA_3x_SOC UX500_SOC_DB8500 CPU_THERMAL

Re: [PATCH-Resend] thermal: Exynos: Add missing dependency

2012-11-14 Thread Amit Kachhap
On 15 November 2012 12:34, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-15 at 12:31 +0530, Amit Kachhap wrote: On 15 November 2012 12:09, Sachin Kamat sachin.ka...@linaro.org wrote: CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking for dependencies

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Amit Kachhap
On 22 November 2012 06:52, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly jump to the upper or

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Amit Kachhap
On 22 November 2012 13:42, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-22 at 10:11 +0530, Amit Kachhap wrote: On 22 November 2012 06:52, Zhang Rui rui.zh...@intel.com wrote: On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: This modification adds 2 new thermal trend type

Re: [PATCH 2/5 RESEND] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

2013-01-08 Thread amit kachhap
Hi Joe, Thanks for the review. Will re-post with your suggestion, On Sun, Jan 6, 2013 at 3:55 PM, Joe Perches j...@perches.com wrote: On Sun, 2013-01-06 at 15:50 -0800, Amit Daniel Kachhap wrote: Below fixes are done to support falling threshold interrupt, * Falling interrupt status macro

Re: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies

2013-01-08 Thread amit kachhap
On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Add freq_attr attribute to show list of available frequencies. Signed-off-by: Donggeun Kim dg77@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: KyungMin Park

Re: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-16 Thread amit kachhap
Hi Rui, Thanks for the review comments, On Tue, Jan 15, 2013 at 11:33 PM, Zhang Rui rui.zh...@intel.com wrote: Hi, Amit, On Sun, 2013-01-06 at 16:08 -0800, Amit Daniel Kachhap wrote: This patch adds support to set the emulated temperature method in thermal zone (sensor). After setting this

Re: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-27 Thread amit kachhap
On Mon, Jan 21, 2013 at 7:20 PM, Zhang Rui rui.zh...@intel.com wrote: On Wed, 2013-01-16 at 11:30 -0800, amit kachhap wrote: Hi Rui, Thanks for the review comments, On Tue, Jan 15, 2013 at 11:33 PM, Zhang Rui rui.zh...@intel.com wrote: Hi, Amit, On Sun, 2013-01-06 at 16:08 -0800, Amit

Re: [PATCH V2 1/2] thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation

2013-02-03 Thread amit kachhap
On Fri, Feb 1, 2013 at 12:27 AM, Zhang Rui rui.zh...@intel.com wrote: On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: This patch adds support to set the emulated temperature method in thermal zone (sensor). After setting this feature thermal zone may report this temperature and

Re: [PATCH 3/3] dts: Add cpufreq controller node for Exynos5440 SoC

2013-02-07 Thread amit kachhap
On Wed, Feb 6, 2013 at 8:49 PM, Inderpal Singh inderpal.si...@linaro.org wrote: On 7 February 2013 01:09, Amit Daniel Kachhap amit.dan...@samsung.com wrote: Add cpufreq controller device node for Exynos5440 SoC for passing parameters like controller base address, interrupt and cpufreq table.

Re: [PATCH 2/3] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-02-07 Thread amit kachhap
Hi Viresh, Thanks for the detailed review. Will try to handle them in the next version, On Thu, Feb 7, 2013 at 3:17 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On Thu, Feb 7, 2013 at 1:09 AM, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch adds dvfs support for exynos5440

Re: [PATCH V2 2/2] thermal: exynos: Use the framework for temperature emulation support

2013-02-07 Thread amit kachhap
Hi Rui, Please merge this patch also. The 1st series of this patchset is already accepted by you. This is just a adaptation of the earlier one and does code cleanup. Thanks, Amit Daniel On Sun, Feb 3, 2013 at 6:14 PM, Zhang Rui rui.zh...@intel.com wrote: On Sun, 2013-01-27 at 19:28 -0800, Amit

Re: [PATCH 2/3] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-02-07 Thread amit kachhap
On Thu, Feb 7, 2013 at 6:42 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 8 February 2013 00:38, amit kachhap amit.kach...@gmail.com wrote: Hi Viresh, Thanks for the detailed review. Will try to handle them in the next version, np. I haven't seen reply to few questions, you missed them

Re: [PATCH V2 2/2] thermal: exynos: Use the framework for temperature emulation support

2013-02-07 Thread amit kachhap
On Thu, Feb 7, 2013 at 7:04 PM, Zhang Rui rui.zh...@intel.com wrote: On Mon, 2013-02-04 at 10:14 +0800, Zhang Rui wrote: On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: This removes the driver specific sysfs support of the temperature emulation and uses the newly added core

Re: [PATCH 3/3] dts: Add cpufreq controller node for Exynos5440 SoC

2013-02-11 Thread amit kachhap
On Fri, Feb 8, 2013 at 8:49 AM, Inderpal Singh inderpal.si...@linaro.org wrote: On 8 February 2013 00:03, amit kachhap amit.kach...@gmail.com wrote: On Wed, Feb 6, 2013 at 8:49 PM, Inderpal Singh inderpal.si...@linaro.org wrote: On 7 February 2013 01:09, Amit Daniel Kachhap amit.dan

Re: [PATCH V2 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-05 Thread amit kachhap
Hi Viresh, Again thanks for your review comments. On Tue, Mar 5, 2013 at 6:48 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On 2 March 2013 15:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch adds dvfs support for exynos5440 SOC. This soc has 4 cores and they run at same

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Sylwester, Thanks for the review. Will update with your suggestion in the next version, Thanks, Amit D On Thu, Mar 7, 2013 at 8:58 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: +/* Register definations */ s/definations/definitions

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Russell, On Thu, Mar 7, 2013 at 9:07 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 07, 2013 at 04:28:00PM +0100, Sylwester Nawrocki wrote: On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: + dvfs_info-cpu_clk = devm_clk_get(dvfs_info-dev, armclk); + if

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Viresh, On Sat, Mar 9, 2013 at 4:17 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 7 March 2013 12:13, Amit Daniel Kachhap amit.dan...@samsung.com wrote: diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c +struct exynos_dvfs_data { + void

Re: [PATCH V4 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-18 Thread amit kachhap
Hi Viresh, On Tue, Mar 12, 2013 at 4:19 PM, Viresh Kumar viresh.ku...@linaro.org wrote: This is what Russell told me a long time back: Don't use Adding, Fixing, etc words as this work is not something, which is already done. So your subject should have been: cpufreq: exynos: Add cpufreq

Re: [1/9] thermal: exynos: Adapt to temperature emulation core thermal framework

2013-04-12 Thread amit kachhap
Hi Eduardo, Thanks for your review comments. On Fri, Apr 12, 2013 at 1:03 AM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hello Amit, Couple of comments inline. On 26-03-2013 07:33, Amit Daniel Kachhap wrote: This removes the driver specific sysfs support of the temperature

Re: [2/9] thermal: exynos: Add support for instance based register/unregister

2013-04-12 Thread amit kachhap
Hi Eduardo, On Fri, Apr 12, 2013 at 1:39 AM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hey Amit, On 26-03-2013 07:33, Amit Daniel Kachhap wrote: This code modifies the thermal driver to have multiple thermal zone support by replacing the global thermal zone varibale with device data

Re: [PATCH 5/6] thermal:exynos4: Enable support for Exynos4412 SoCs

2013-04-22 Thread amit kachhap
Hi, I have one suggestion, On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski l.majew...@samsung.com wrote: Enable TMU support for Exynos4412 based target with device tree. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH 01/10] thermal: exynos: remove unused struct exynos_tmu_registers entries

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/thermal/samsung/exynos_tmu.h | 40

Re: [PATCH 02/10] thermal: exynos: remove unused defines

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/thermal/samsung/exynos_tmu_data.h | 27 +--

Re: [PATCH 03/10] thermal: exynos: remove dead code for HW_MODE calibration

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 33

Re: [PATCH 04/10] thermal: exynos: remove dead code for TYPE_TWO_POINT_TRIMMING calibration

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Only TYPE_ONE_POINT_TRIMMING calibration is used so remove the dead code for TYPE_TWO_POINT_TRIMMING calibration. I prefer to retain this feature as it is provided by the TMU controller. This will avoid unnecessary churning of

Re: [PATCH 05/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_initialize()

2014-05-18 Thread Amit Kachhap
On 5/15/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: On Thursday, May 15, 2014 10:47:40 AM Eduardo Valentin wrote: Hello Bartlomiej, Hi, On Mon, May 05, 2014 at 01:15:34PM +0200, Bartlomiej Zolnierkiewicz wrote: Remove runtime checks for pdata sanity from

Re: [PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Remove runtime checks for negative return values of temp_to_code() from exynos_tmu_initialize(). The current level temperature data hardcoded in pdata will never cause a negative temp_to_code() return values and for the new

Re: [PATCH 07/10] thermal: exynos: simplify temp_to_code() and code_to_temp()

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: * Remove dead temp check from temp_to_code() (this function users in exynos_tmu_initialize() always pass correct temperatures and exynos_tmu_set_emulation() returns early for EXYNOS4210 because TMU_SUPPORT_EMULATION

Re: [PATCH 08/10] thermal: exynos: cache non_hw_trigger_levels in pdata

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Cache number of non-hardware trigger levels in a new pdata field (non_hw_trigger_levels) and convert code in exynos_tmu_initialize() accordingly. Changes looks fine, Reviewed-by: Amit Daniel Kachhapamit.dan...@samsung.com

Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-05-19 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: pdata-reference_voltage and pdata-gain are always defined to non-zero values so remove the redundant checks from exynos_tmu_control(). I prefer to have these checks for the same reason that new soc support

Re: [PATCH 10/10] thermal: exynos: remove identical values from exynos*_tmu_registers structures

2014-05-19 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: There is no need for abstracting configuration for registers that are identical on all SoC types. Changes look fine and also that shift and masks may not change in future socs also. Reviewed-by: Amit Daniel

Re: [PATCH 00/10] thermal: exynos: various cleanups

2014-05-19 Thread Amit Kachhap
On 5/15/14, Zhang Rui rui.zh...@intel.com wrote: On 一, 2014-05-05 at 13:15 +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series contains various cleanups for EXYNOS thermal driver. Overall it decreases driver's LOC by 13%. It is based on next-20140428 kernel. It should not cause

[PATCH 0/4]ARM: exynos4: Add l2 retention mode cpuidle state

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap amit.kach...@linaro.org This Patch series adds support for AFTR mode cpuidle state based on patch (http://www.spinics.net/lists/arm-kernel/msg132243.html) earlier submitted by Jaecheol Lee jc@samsung.com. This patch uses CPU PM notifiers , common l2 save/restore

[PATCH 1/4] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap amit.kach...@linaro.org This patch adds support for AFTR(ARM OFF TOP RUNNING) mode in cpuidle driver for EXYNOS4210. L2 cache keeps their data in this mode. This patch ports the code to the latest interfaces to save/restore CPU state inclusive of CPU PM notifiers, l2

[PATCH 2/4] ARM: exynos4: remove useless churn in sleep.S

2011-11-04 Thread amit . kachhap
From: Lorenzo Pieralisi lorenzo.pieral...@arm.com This patch cleans up sleep code in preparation for L2 resume code and hotplug functions Signed-off-by: Lorenzo Pieralisi lorenzo.pieral...@arm.com --- arch/arm/mach-exynos4/sleep.S |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)

[PATCH 3/4] ARM: exynos4: add L2 early resume code

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap amit.kach...@linaro.org This patch adds code to save L2 register configuration at boot, and to resume L2 before MMU is enabled in suspend and cpuidle resume paths. Signed-off-by: Lorenzo Pieralisi lorenzo.pieral...@arm.com Signed-off-by: Amit Daniel Kachhap

[PATCH 4/4] ARM: exynos4: remove useless code to save/restore L2 and GIC state

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap amit.kach...@linaro.org Following the merge of CPU PM notifiers and L2 resume code, this patch removes useless code to save and restore L2 and GIC registers. This is now automatically covered by suspend calls which integrated CPU PM notifiers and new sleep code that

Re: [PATCH V2 1/5] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-11 Thread Amit Kachhap
On 11 November 2011 15:47, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: Hi Amit, On Fri, Nov 11, 2011 at 06:29:33AM +, Amit Daniel Kachhap wrote: This patch adds support for AFTR(ARM OFF TOP RUNNING) mode in cpuidle driver for EXYNOS4210. L2 cache keeps their data in this mode.

Re: [PATCH 1/4] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-17 Thread Amit Kachhap
On 11 November 2011 13:03, MyungJoo Ham myungjoo@gmail.com wrote: On Sat, Nov 5, 2011 at 2:03 AM,  amit.kach...@linaro.org wrote: From: Amit Daniel Kachhap amit.kach...@linaro.org This patch adds support for AFTR(ARM OFF TOP RUNNING) mode in cpuidle driver for EXYNOS4210. L2 cache keeps

Re: [PATCH V3 3/6] ARM: exynos: save L2 settings during bootup

2011-11-22 Thread amit kachhap
On Tue, Nov 22, 2011 at 3:19 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 22, 2011 at 03:05:29PM +0530, Amit Daniel Kachhap wrote: This patch adds code to save L2 register configuration at boot, and later used to resume L2 before MMU is enabled in suspend and cpuidle

Re: [PATCH V3 2/6] ARM: s5p: remove useless churn in sleep.S

2011-11-23 Thread amit kachhap
On Tue, Nov 22, 2011 at 3:18 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 22, 2011 at 03:05:28PM +0530, Amit Daniel Kachhap wrote: This patch cleans up sleep code in preparation for L2 resume code and hotplug functions I wonder whether anyone read the comments in

Re: [PATCH V3 1/6] ARM: exynos: Add AFTR mode cpuidle state on EXYNOS4210

2011-11-24 Thread amit kachhap
On Thu, Nov 24, 2011 at 9:37 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Hi Amit, On 22 November 2011 15:05, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patch adds support AFTR(ARM OFF TOP RUNNING) mode in cpuidle driver. L2 cache keeps their data in this mode. This

Re: [PATCH V3 0/6] ARM: exynos: Add l2 retention mode cpuidle state

2011-11-24 Thread amit kachhap
Dear Kukjin Kim, Any comments or feedback on this patchset from your side. I am preparing another version with fixes/issues suggested by Russell and Inder. Thanks, Amit Daniel On Tue, Nov 22, 2011 at 3:05 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: Changes since V2: *Implemented

Re: [PATCH] ARM: exynos4: Fix for stall in case of cpu hotplug or sleep

2011-12-01 Thread amit kachhap
On Thu, Dec 1, 2011 at 4:05 PM, Kukjin Kim kgene@samsung.com wrote: Amit Daniel Kachhap wrote: This patch adds remove_irq in place of disable_irq which is correct equivalent function for setup_irq used in exynos4_mct_tick_init. Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org

Re: [lm-sensors] [RFC PATCH 2/3] thermal: exynos4: Register the tmu sensor with the thermal interface layer

2012-01-04 Thread Amit Kachhap
Hi Guenter, The main idea of this work is to leave the current userspace based notification scheme and add the kernel based cooling scheme on top of it. Anyway, It is a good idea to move the file hwmon/exynos4_tmu.c as this creates 2 hwmon entries. Adding CC: Donggeun Kim to know his opinion.

Re: [PATCH V4 0/5] ARM: exynos: Add l2 retention mode cpuidle state

2012-01-04 Thread Amit Kachhap
On 3 January 2012 18:52, Kukjin Kim kgene@samsung.com wrote: amit kachhap wrote: Hi Mr kim, All the comments have been addressed for the Exynos cpu idle patchset. The updated patchset was posted about one month back and there have been no further comments on the patchset since

Re: [PATCH V5 5/5] ARM: exynos: Enable l2 configuration through device tree

2012-01-04 Thread Amit Kachhap
On 5 January 2012 10:06, Olof Johansson o...@lixom.net wrote: On Wed, Jan 4, 2012 at 8:25 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patch enables calling generic l2 setup functions if device tree is used. Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org ---  

Re: [PATCH V6 1/5] ARM: exynos: Add support AFTR mode on EXYNOS4210

2012-02-23 Thread Amit Kachhap
On 23 February 2012 11:54, Rob Lee rob@linaro.org wrote:  static struct cpuidle_state exynos4_cpuidle_set[] = {        [0] = { @@ -27,9 +47,17 @@ static struct cpuidle_state exynos4_cpuidle_set[] = {                .exit_latency           = 1,                .target_residency       =

Re: [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory

2012-03-05 Thread Amit Kachhap
On 3 March 2012 17:51, Sylwester Nawrocki snj...@gmail.com wrote: On 03/03/2012 12:06 PM, Amit Daniel Kachhap wrote: This movement is needed because the hwmon entries and corresponding sysfs interface is a duplicate of utilities already provided by driver/thermal/thermal_sys.c. The goal is to

Re: [lm-sensors] [linux-pm] [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory

2012-03-05 Thread Amit Kachhap
On 3 March 2012 23:34, Guenter Roeck guenter.ro...@ericsson.com wrote: On Sat, Mar 03, 2012 at 11:44:10AM -0500, Mark Brown wrote: On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote: This movement is needed because the hwmon entries and corresponding sysfs interface is a

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Amit Kachhap
Hi Durgadoss, Thanks for the detailed review. On 12 March 2012 16:21, R, Durgadoss durgados...@intel.com wrote: Hi Amit, Thanks for keeping this up. And Sorry for late reply. -Original Message- From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel Kachhap

Re: [PATCH V2 3/6] thermal: Add generic cpuhotplug cooling implementation

2012-03-20 Thread Amit Kachhap
On 19 March 2012 17:15, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On 03/19/2012 11:47 AM, Amit Daniel Kachhap wrote: This patch adds support for generic cpu thermal cooling low level implementations using cpuhotplug based on the thermal level requested from user. Different cpu

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-03 Thread Amit Kachhap
Hi Len/Rui, Any comment or feedback from your side about the status of this patch? Is it merge-able or major re-work is needed? I have fixed most of the comments in this patchset and currently working on some of the minor comments received and will submit them shortly. Regards, Amit Daniel On

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-24 Thread Amit Kachhap
On 16 April 2012 07:37, Zhang Rui rui.zh...@intel.com wrote: On 三, 2012-04-11 at 18:17 +0530, Amit Kachhap wrote: Hi Rui, Thanks for looking into the patches. On 10 April 2012 06:28, Zhang Rui rui.zh...@intel.com wrote: Hi, Amit, On 三, 2012-04-04 at 10:02 +0530, Amit Kachhap wrote

Re: [PATCH] ARM: exynos: Adapt to cpuidle core time keeping and irq enable

2012-05-07 Thread amit kachhap
Hi Mr Kukjin, Any comment or update about this patch? Regards, Amit Daniel On Mon, Apr 30, 2012 at 10:13 PM, Rob Lee rob@linaro.org wrote: On Wed, Apr 25, 2012 at 9:44 AM, Daniel Lezcano daniel.lezc...@linaro.org wrote: On 04/25/2012 02:11 PM, Amit Daniel Kachhap wrote: This patch

Re: [RESEND PATCH 1/3] ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

2013-10-10 Thread Amit Kachhap
Hi Bartlomeij, Yes these patches have missed 2 merge windows and still not merged. Mike: I am re-basing these patches on linux-next. Please merge them. Regards, Amit On Wed, Oct 9, 2013 at 3:18 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, Mike: Could you please apply

Re: [PATCH] thermal: offer Samsung thermal support only when ARCH_EXYNOS is defined

2013-11-25 Thread Amit Kachhap
On 10/4/13, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Menu for Samsung thermal support is visible on all Samsung platforms while thermal drivers are currently available only for EXYNOS SoCs. Fix it by replacing PLAT_SAMSUNG dependency with ARCH_EXYNOS one. Signed-off-by:

Re: [PATCH] thermal: EXYNOS: always register TMU driver with core thermal framework

2013-11-25 Thread Amit Kachhap
On 11/25/13, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, Could you please also apply this patch? Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics On Friday, October 04, 2013 02:38:25 PM Bartlomiej Zolnierkiewicz wrote: There

Re: [PATCH] I2C: Samsung: Add support for PM_runtime in the I2C driver.

2011-07-21 Thread amit kachhap
On Mon, Mar 28, 2011 at 4:41 AM, Ben Dooks ben-li...@fluff.org wrote: On Sun, Mar 27, 2011 at 04:32:43PM -0400, Amit Daniel Kachhap wrote: This patch adds PM runtime management support in the I2C driver. The functionality of the driver is not modified much but some extra I2C states are added

Re: [RFC PATCH 3/4] ARM: EXYNOS4: Add support AFTR mode cpuidle state on EXYNOS4210

2011-08-22 Thread Amit Kachhap
On 21 August 2011 22:48, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Aug 19, 2011 at 06:39:59PM +0530, Amit Daniel Kachhap wrote: +ENTRY(exynos4_enter_lp) +     stmfd   sp!, { r3 - r12, lr } + +     adr     r0, sleep_save_misc + +     mrc     p15, 0, r2, c15, c0, 0  @

Re: [RFC PATCH 2/4] ARM: EXYNOS4: Fix to work with origen boards.

2011-08-22 Thread Amit Kachhap
On 19 August 2011 19:29, Kyungmin Park kmp...@infradead.org wrote: On Fri, Aug 19, 2011 at 10:09 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This adds a function to get the revision id. Signed-off-by: Jaecheol Lee jc@samsung.com Signed-off-by: Changhwan Youn

Re: [PATCH] thermal: samsung: Add TMU support for Exynos3250 SoC

2014-07-09 Thread Amit Kachhap
On Wed, Jul 9, 2014 at 8:30 AM, Chanwoo Choi cw00.c...@samsung.com wrote: On 07/01/2014 09:33 AM, Chanwoo Choi wrote: This patch add registers, bit fields and compatible strings for Exynos3250 TMU (Thermal Management Unit). Exynos3250 uses the Cortex-A7 dual cores and has a target speed of