Re: [PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-14 Thread Sylwester Nawrocki
On 11/07/14 14:00, Tushar Behera wrote:
 @@ -103,17 +140,11 @@ static int exynos_audss_clk_probe(struct 
 platform_device *pdev)
   return PTR_ERR(reg_base);
   }
  
 - clk_table = devm_kzalloc(pdev-dev,
 - sizeof(struct clk *) * EXYNOS_AUDSS_MAX_CLKS,
 - GFP_KERNEL);
 - if (!clk_table)
 + ctx = samsung_clk_init(pdev-dev.of_node, reg_base, nr_clks);

There is an issue here that this registers the clk provider before all
its clocks are registered with the clk core. Therefore it introduces
a race condition.

Please have a look at patch [1], you may want to rebase this series
onto that patch.

 + samsung_clk_register_div(ctx, exynos_audss_div_clks,
 + ARRAY_SIZE(exynos_audss_div_clks));
[...]
 + samsung_clk_register_gate(ctx, exynos_audss_gate_clks,
 + ARRAY_SIZE(exynos_audss_gate_clks));
[...]
 - ret = of_clk_add_provider(pdev-dev.of_node, of_clk_src_onecell_get,
 - clk_data);
 - if (ret) {
 - dev_err(pdev-dev, failed to add clock provider\n);
 - goto unregister;
 + samsung_clk_register_gate(ctx, exynos5420_audss_gate_clks,
 + ARRAY_SIZE(exynos5420_audss_gate_clks));
   }

[1]
https://git.kernel.org/cgit/linux/kernel/git/tfiga/samsung-clk.git/commit/?h=samsung-clk-nextid=d5e136a21b2028fb1f45143ea7112d5869bfc6c7

--
Regards,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-14 Thread Tushar Behera
On Mon, Jul 14, 2014 at 9:04 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
 On 11/07/14 14:00, Tushar Behera wrote:
 @@ -103,17 +140,11 @@ static int exynos_audss_clk_probe(struct 
 platform_device *pdev)
   return PTR_ERR(reg_base);
   }

 - clk_table = devm_kzalloc(pdev-dev,
 - sizeof(struct clk *) * EXYNOS_AUDSS_MAX_CLKS,
 - GFP_KERNEL);
 - if (!clk_table)
 + ctx = samsung_clk_init(pdev-dev.of_node, reg_base, nr_clks);

 There is an issue here that this registers the clk provider before all
 its clocks are registered with the clk core. Therefore it introduces
 a race condition.

 Please have a look at patch [1], you may want to rebase this series
 onto that patch.


Thanks for the pointer. I will re-post.

 + samsung_clk_register_div(ctx, exynos_audss_div_clks,
 + ARRAY_SIZE(exynos_audss_div_clks));
 [...]
 + samsung_clk_register_gate(ctx, exynos_audss_gate_clks,
 + ARRAY_SIZE(exynos_audss_gate_clks));
 [...]
 - ret = of_clk_add_provider(pdev-dev.of_node, of_clk_src_onecell_get,
 - clk_data);
 - if (ret) {
 - dev_err(pdev-dev, failed to add clock provider\n);
 - goto unregister;
 + samsung_clk_register_gate(ctx, exynos5420_audss_gate_clks,
 + 
 ARRAY_SIZE(exynos5420_audss_gate_clks));
   }

 [1]
 https://git.kernel.org/cgit/linux/kernel/git/tfiga/samsung-clk.git/commit/?h=samsung-clk-nextid=d5e136a21b2028fb1f45143ea7112d5869bfc6c7

 --
 Regards,
 Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH V2 3/3] clk: exynos-audss: Use samsung clock APIs to register/unregister clocks

2014-07-11 Thread Tushar Behera
Using samsung clock APIs to register/unregister clocks will save some
lines of code.

Signed-off-by: Tushar Behera tusha...@samsung.com
---
Changes of v2:
* Retain platform driver structure.

 drivers/clk/samsung/clk-exynos-audss.c |  146 
 1 file changed, 56 insertions(+), 90 deletions(-)

diff --git a/drivers/clk/samsung/clk-exynos-audss.c 
b/drivers/clk/samsung/clk-exynos-audss.c
index 1a5294c..2b90967 100644
--- a/drivers/clk/samsung/clk-exynos-audss.c
+++ b/drivers/clk/samsung/clk-exynos-audss.c
@@ -19,16 +19,16 @@
 
 #include dt-bindings/clock/exynos-audss-clk.h
 
+#include clk.h
+
 enum exynos_audss_clk_type {
TYPE_EXYNOS4210,
TYPE_EXYNOS5250,
TYPE_EXYNOS5420,
 };
 
-static DEFINE_SPINLOCK(lock);
-static struct clk **clk_table;
+static struct samsung_clk_provider *ctx;
 static void __iomem *reg_base;
-static struct clk_onecell_data clk_data;
 
 #define ASS_CLK_SRC 0x0
 #define ASS_CLK_DIV 0x4
@@ -78,7 +78,7 @@ static const struct of_device_id exynos_audss_clk_of_match[] 
= {
 /* register exynos_audss clocks */
 static int exynos_audss_clk_probe(struct platform_device *pdev)
 {
-   int i, ret = 0;
+   int i;
struct resource *res;
struct clk *tmp;
const char *clk_name_ref[] = {
@@ -87,14 +87,51 @@ static int exynos_audss_clk_probe(struct platform_device 
*pdev)
fin_pll, fout_epll, cdclk0, sclk_audio0, sclk_pcm0};
const char *mout_audss_p[] = {fin_pll, fout_epll};
const char *mout_i2s_p[] = {mout_audss, cdclk0, sclk_audio0};
-   const char *sclk_pcm_p = sclk_pcm0;
+   char sclk_pcm_p[32];
const struct of_device_id *match;
enum exynos_audss_clk_type variant;
 
+   struct samsung_mux_clock exynos_audss_mux_clks[] = {
+   MUX(EXYNOS_MOUT_AUDSS, mout_audss, mout_audss_p,
+   ASS_CLK_SRC, 0, 1),
+   MUX(EXYNOS_MOUT_I2S, mout_i2s, mout_i2s_p,
+   ASS_CLK_SRC, 2, 2),
+   };
+
+   struct samsung_div_clock exynos_audss_div_clks[] = {
+   DIV(EXYNOS_DOUT_SRP, dout_srp, mout_audss,
+   ASS_CLK_DIV, 0, 4),
+   DIV(EXYNOS_DOUT_AUD_BUS, dout_aud_bus, dout_srp,
+   ASS_CLK_DIV, 4, 4),
+   DIV(EXYNOS_DOUT_I2S, dout_i2s, mout_i2s, ASS_CLK_DIV, 8, 4),
+   };
+
+   struct samsung_gate_clock exynos_audss_gate_clks[] = {
+   GATE(EXYNOS_SRP_CLK, srp_clk, dout_srp,
+   ASS_CLK_GATE, 0, CLK_SET_RATE_PARENT, 0),
+   GATE(EXYNOS_I2S_BUS, i2s_bus, dout_aud_bus,
+   ASS_CLK_GATE, 2, CLK_SET_RATE_PARENT, 0),
+   GATE(EXYNOS_SCLK_I2S, sclk_i2s, dout_i2s,
+   ASS_CLK_GATE, 3, CLK_SET_RATE_PARENT, 0),
+   GATE(EXYNOS_PCM_BUS, pcm_bus, sclk_pcm,
+   ASS_CLK_GATE, 4, CLK_SET_RATE_PARENT, 0),
+   GATE(EXYNOS_SCLK_PCM, sclk_pcm, sclk_pcm_p,
+   ASS_CLK_GATE, 5, CLK_SET_RATE_PARENT, 0),
+   };
+
+   struct samsung_gate_clock exynos5420_audss_gate_clks[] = {
+   GATE(EXYNOS_ADMA, adma, dout_srp,
+   ASS_CLK_GATE, 9, CLK_SET_RATE_PARENT, 0),
+   };
+
+   int nr_clks = EXYNOS_AUDSS_MAX_CLKS;
+
match = of_match_node(exynos_audss_clk_of_match, pdev-dev.of_node);
if (!match)
return -EINVAL;
variant = (enum exynos_audss_clk_type)match-data;
+   if (variant != TYPE_EXYNOS5420)
+   nr_clks--;
 
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
reg_base = devm_ioremap_resource(pdev-dev, res);
@@ -103,17 +140,11 @@ static int exynos_audss_clk_probe(struct platform_device 
*pdev)
return PTR_ERR(reg_base);
}
 
-   clk_table = devm_kzalloc(pdev-dev,
-   sizeof(struct clk *) * EXYNOS_AUDSS_MAX_CLKS,
-   GFP_KERNEL);
-   if (!clk_table)
+   ctx = samsung_clk_init(pdev-dev.of_node, reg_base, nr_clks);
+   if (!ctx) {
+   dev_err(pdev-dev, failed to get clock provier context\n);
return -ENOMEM;
-
-   clk_data.clks = clk_table;
-   if (variant == TYPE_EXYNOS5420)
-   clk_data.clk_num = EXYNOS_AUDSS_MAX_CLKS;
-   else
-   clk_data.clk_num = EXYNOS_AUDSS_MAX_CLKS - 1;
+   }
 
for (i = 0; i  ARRAY_SIZE(clk_name_ref); i++) {
tmp = clk_get(pdev-dev, clk_name_ref[i]);
@@ -127,69 +158,20 @@ static int exynos_audss_clk_probe(struct platform_device 
*pdev)
mout_audss_p[1] = clk_name_actual[1];
mout_i2s_p[1] = clk_name_actual[2];
mout_i2s_p[2] = clk_name_actual[3];
-   sclk_pcm_p = clk_name_actual[4];
-
-   clk_table[EXYNOS_MOUT_AUDSS] = clk_register_mux(NULL, mout_audss,
-